[PATCH 1/2] scsi: mpt3sas: make driver options visible in sys

2019-06-14 Thread Tomas Henzl
Support is easier with all driver parameters visible in sysfs. Also I've replaced a constant with an octal permission. Signed-off-by: Tomas Henzl --- drivers/scsi/mpt3sas/mpt3sas_base.c | 14 +++--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 +++--- 2 files change

[PATCH 0/2] mpt3sas

2019-06-14 Thread Tomas Henzl
Just few small changes, octal numbers instead of constants etc. Tomas Henzl (2): scsi: mpt3sas: make driver options visible in sys scsi: mpt3sass: use DEVICE_ATTR_{RO, RW} drivers/scsi/mpt3sas/mpt3sas_base.c | 14 +- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 210

[PATCH 2/2] scsi: mpt3sass: use DEVICE_ATTR_{RO, RW}

2019-06-14 Thread Tomas Henzl
Use existing macros. No functional change. Signed-off-by: Tomas Henzl --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 210 + 1 file changed, 97 insertions(+), 113 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c index

[PATCH 2/3] megaraid_sas: use octal permissions instead of constants

2019-05-29 Thread Tomas Henzl
Checkpatch emits a warning when using symbolic permissions. Use octal permissions instead. No functional change. Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 20 ++-- drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +- 2 files changed, 11 insertions

[PATCH 3/3] megaraid_sas: use DEVICE_ATTR_{RO, RW}

2019-05-29 Thread Tomas Henzl
Use existing macros. No functional change. Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 44 ++- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid

[PATCH 0/3] megaraid_sas:

2019-05-29 Thread Tomas Henzl
Just few small changes, octal numbers instead of constants etc.

[PATCH 1/3] megaraid_sas: make max_sectors visible in sys

2019-05-29 Thread Tomas Henzl
Support is easier with all driver parameters visible in sysfs. Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 1/1] megaraid_sas: correct an info message

2019-01-02 Thread Tomas Henzl
This was apparently forgotten in 894169db1 ("scsi: megaraid_sas: Use 63-bit DMA addressing"). Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/dr

Re: [PATCH] mpt3sas: correct reset of smid while clearing scsi tracker

2018-07-18 Thread Tomas Henzl
value before decrementing the chain_offset counter. which we are correcting > with this patch. > > Signed-off-by: Sreekanth Reddy Fixes: 2b548dd3790f95c2e174d51c2c8ada71b6505b4e scsi: mpt3sas: Fix calltrace observed while running IO & reset Maybe both patches could be merged. Reviewe

Re: [PATCH] mpt3sas: Add an i/o barrier

2018-05-24 Thread Tomas Henzl
On 05/24/2018 05:33 PM, James Bottomley wrote: > On Thu, 2018-05-24 at 17:31 +0200, Tomas Henzl wrote: >> On 05/24/2018 05:19 PM, James Bottomley wrote: >>> On Thu, 2018-05-24 at 17:12 +0200, Tomas Henzl wrote: >>>> A barrier should be added to ensure proper

Re: [PATCH] mpt3sas: Add an i/o barrier

2018-05-24 Thread Tomas Henzl
On 05/24/2018 05:19 PM, James Bottomley wrote: > On Thu, 2018-05-24 at 17:12 +0200, Tomas Henzl wrote: >> A barrier should be added to ensure proper ordering of memory mapped >> writes. >> >> Signed-off-by: Tomas Henzl >> --- >>  drivers/scsi/mpt3sas/mpt

[PATCH] mpt3sas: Add an i/o barrier

2018-05-24 Thread Tomas Henzl
A barrier should be added to ensure proper ordering of memory mapped writes. Signed-off-by: Tomas Henzl --- drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index bf04fa90f

Re: [V1] mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

2018-02-14 Thread Tomas Henzl
ux-scsi/msg117405.html > "Adding MPI Endpoint device support" patches. > > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH] megaraid_sas: Do not use 32-bit atomic request descriptor for Ventura controllers

2018-02-13 Thread Tomas Henzl
; } > > - /* For Ventura also IOC INIT required 64 bit Descriptor write. */ > - spin_lock_irqsave(&instance->hba_lock, flags); > - writel(le32_to_cpu(req_desc.u.low), > -&instance->reg_set->inbound_low_queue_port); > - writel(le32

Re: [PATCH] qla4xxx: skip error recovery in case of register disconnect.

2018-02-13 Thread Tomas Henzl
On 02/12/2018 07:48 AM, Manish Rangankar wrote: > A system crashes when continuously removing/re-adding > the storage controller. > > Signed-off-by: Manish Rangankar Reviewed-by: Tomas Henzl

Re: [PATCH 5/6] mpt3sas: Introduce function to clone mpi request.

2018-01-22 Thread Tomas Henzl
On 01/19/2018 01:37 PM, Suganath Prabu S wrote: > 1) Added function _base_clone_mpi_to_sys_mem to clone > MPI request into system BAR0 mapped region. > > 2) Seperate out MPI Endpoint IO submissions to function > _base_put_smid_mpi_ep_scsi_io. > > 3) MPI EP requests are submitted in two 32 bit MMIO

[PATCH] mpt3sas: fix an out of bound write

2018-01-19 Thread Tomas Henzl
ge in cpu_online_mask. Fixes: 1d55abc0e98a0bf35f3af80665aac564e3b30572 scsi: mpt3sas: switch to pci_alloc_irq_vectors Signed-off-by: Tomas Henzl --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/dr

Re: [PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Bump mpt3sas driver version to v16.100.00.00 > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Adding PNP ID of Mercator i.e. SAS3616 HBA device. > Its device ID is 0xD1 and vendor ID is 0x1000. > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
On 10/11/2017 05:56 PM, James Bottomley wrote: > On Wed, 2017-10-11 at 17:35 +0200, Tomas Henzl wrote: >> On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: >>> For Dev Handles who value is less than hba's phys count number >>>  driver will return HBA sas address va

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
> > Modified the driver to update devices enclosure handles after > host reset to current value, by referring the enclosure handles > from corresponding device pages > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
ce_pg0, struct _sas_device *sas_device) > +{ > + Mpi2ConfigReply_t mpi_reply; > + Mpi2SasEnclosurePage0_t enclosure_pg0; > + > + if (!sas_device_pg0 || !sas_device) > + return; This test^ implies that sas_device_pg0 or sas_device can be null, is that true? Signed-off-by: Tomas Henzl

Re: [PATCH 07/10] mpt3sas: Display chassis slot information of the drive

2017-10-11 Thread Tomas Henzl
Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Updated MPI headers to v2.00.48 > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

2017-10-11 Thread Tomas Henzl
quot;DID_RESET" > (i.e. retry the IO infinite times) host bytes. > > Earlier driver is returning the IO with "DID_SOFT_ERROR" > that reties the IO quickly for five times but still > firmware needed some more time and hence IOs were failing. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
s. So now updated the driver to return > Virtual SES's sas address for Virtual SES device instead of > HBA's sas address. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl

Re: [PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

2017-10-11 Thread Tomas Henzl
ult. > 4) Set SCSI IO Queue depth to 200. > > Signed-off-by: Sreekanth Reddy I think that preferred is (though not much used yet) instead of 'reset_devices' to use a 'is_kdump_kernel()' function. Signed-off-by: Tomas Henzl

Re: [PATCH 02/10] mpt3sas: Fixed memory leaks in driver

2017-10-11 Thread Tomas Henzl
vice > node as NULL and so we are not freeing the child device's > allocated data structures. > Updated the driver to remove the expander device from the list > only after freeing all its child devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 01/10] mpt3sas: Processing of Cable Exception events

2017-10-11 Thread Tomas Henzl
added Cable Exception Event even for SAS3008 & SAS3108 HBAs > (i.e. MPI 2.5 spec supporting HBAs) earlier this event was > enabled only for MPI 2.6 spec supporting HBA devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 3/3] smartpqi: update driver version to 1.1.2-126

2017-09-29 Thread Tomas Henzl
On 27.9.2017 23:30, Don Brace wrote: > Reviewed-by: Gerry Morong > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl

Re: [PATCH 2/3] smartpqi: cleanup raid map warning message

2017-09-29 Thread Tomas Henzl
On 27.9.2017 23:30, Don Brace wrote: > From: Kevin Barnett > > Fix a small cosmetic bug in a very rarely encountered > error message that can occur when a LD has a corrupted > raid map. > > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don

Re: [PATCH 1/3] smartpqi: update controller ids

2017-09-29 Thread Tomas Henzl
On 27.9.2017 23:29, Don Brace wrote: > From: Kevin Barnett > > Update the driver’s PCI IDs > > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl

Re: [PATCH 3/6] hpsa: disable volume status check for older controller

2017-08-11 Thread Tomas Henzl
On 8.8.2017 10:35, Hannes Reinecke wrote: > Older Controller might not support volume status, so assume > the volume is online here. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/hpsa.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/scsi/hpsa.c b/drivers/s

Re: [PATCH] megaraid_sas: move command counter to correct place

2017-08-09 Thread Tomas Henzl
On 8.8.2017 09:37, Sumit Saxena wrote: >> -Original Message- >> From: Martin K. Petersen [mailto:martin.peter...@oracle.com] >> Sent: Monday, August 07, 2017 11:07 PM >> To: Tomas Henzl >> Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com; >> k

[PATCH] megaraid_sas: move command counter to correct place

2017-07-28 Thread Tomas Henzl
the eh reset function returns success when fw_outstanding equals zero, that means that the counter shouldn't be decremented when the driver still owns the command Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v2 08/15] megaraid_sas: Use SMID for Task abort case only

2017-07-18 Thread Tomas Henzl
*fusion; > + struct fusion_context *fusion = NULL; This^ change seems to be needless, but not important. Reviewed-by: Tomas Henzl tomash > struct megasas_cmd_fusion *scsi_lookup; > int rc; > struct MPI2_SCSI_TASK_MANAGE_REPLY *mpi_reply; > @@ -3781,8 +378

Re: [PATCH v2 15/15] megaraid_sas: driver version upgrade

2017-07-11 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 14/15] megaraid_sas: call megasas_dump_frame with correct IO frame size

2017-07-11 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 13/15] megaraid_sas: modified few prints in OCR and IOC INIT path

2017-07-11 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 12/15] megaraid_sas: replace internal FALSE/TRUE definitions with false/true

2017-07-11 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 11/15] megaraid_sas: Set device queue_depth same as HBA can_queue value in scsi-mq mode

2017-07-11 Thread Tomas Henzl
setting QD same as HBA queue_depth. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 10/15] megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE in case adapter is dead

2017-07-11 Thread Tomas Henzl
> Signed-off-by: Shivasharan S > Cc: sta...@vger.kernel.org > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 09/15] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

2017-07-11 Thread Tomas Henzl
On 11.7.2017 12:49, Shivasharan Srikanteshwara wrote: >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Monday, July 10, 2017 7:15 PM >> To: Shivasharan S; linux-scsi@vger.kernel.org >> Cc: martin.peter...@oracle.com; j...@lin

Re: [PATCH v2 07/15] megaraid_sas: Check valid aen class range to avoid kernel panic

2017-07-10 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 06/15] megaraid_sas: Fix endianness issues in DCMD handling

2017-07-10 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 05/15] megaraid_sas: Do not re-fire shutdown DCMD after OCR

2017-07-10 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 04/15] megaraid_sas: Call megasas_complete_cmd_dpc_fusion every 1 second while there are pending commands

2017-07-10 Thread Tomas Henzl
conds before driver will process completion for these commands. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 03/15] megaraid_sas: Use synchronize_irq in target reset case

2017-07-10 Thread Tomas Henzl
ff-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 02/15] megaraid_sas: set minimum value of resetwaittime to be 1 secs

2017-07-10 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Setting resetwaittime to 0 during a FW fault will result in driver > not calling the OCR. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 01/15] megaraid_sas: mismatch of allocated MFI frame size and length exposed in MFI MPT pass through command

2017-07-10 Thread Tomas Henzl
ed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_

Re: [PATCH v2 09/15] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

2017-07-10 Thread Tomas Henzl
On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke > --- > drivers/scsi/megaraid/megaraid_sas.h| 1 - > drivers/scsi/megaraid/megaraid_sas_base.c | 12 ++- > drivers/scsi/megaraid/megaraid_sas_fusion.

Re: [PATCH 09/15] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

2017-06-30 Thread Tomas Henzl
On 30.6.2017 10:30, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h| 1 - > drivers/scsi/megaraid/megaraid_sas_base.c | 12 ++- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 113 > +---

Re: [PATCH V4 07/12] hpsa: cleanup reset handler

2017-05-05 Thread Tomas Henzl
On 5.5.2017 00:51, Don Brace wrote: > - mark device state sooner. > > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/hpsa.c | 59 > +++ > drivers/scsi/hpsa.h |

Re: [PATCH V2 07/12] hpsa: cleanup reset handler

2017-05-04 Thread Tomas Henzl
On 28.4.2017 20:20, Don Brace wrote: > - mark device state sooner. > > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/hpsa.c | 59 > +++ > drivers/scsi/hpsa.h |

Re: [PATCH 1/2] hpsa: update pci ids

2017-03-29 Thread Tomas Henzl
On 28.3.2017 23:40, Don Brace wrote: > Reviewed-by: Gerry Morong > Reviewed-by: Scott Teel > Signed-off-by: Don Brace Hi Don has a gen9 device with id=0x334D ever been released? https://lkml.org/lkml/2013/9/4/499 seems to be still missing in the current table. tomash > --- > drivers/scsi/hp

Re: [PATCH v3 10/10] be2iscsi: Update driver version

2017-03-24 Thread Tomas Henzl
On 24.3.2017 09:41, Jitendra Bhivare wrote: > Version 11.4.0.0 > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 05/10] be2iscsi: Increase HDQ default queue size

2017-03-24 Thread Tomas Henzl
On 24.3.2017 09:41, Jitendra Bhivare wrote: > Currently, ASYNC PDU default queue size is set to max connections. > This leaves only one buffer per connection for any ASYNC PDUs from > targets. > > Double the size of the default queue. > > Signed-off-by: Jitendra Bhivare Rev

Re: [PATCH v3 04/10] scsi_transport_iscsi: Use flush_work in iscsi_remove_session

2017-03-24 Thread Tomas Henzl
Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 08/10] be2iscsi: Check size before copying ASYNC handle

2017-03-24 Thread Tomas Henzl
: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 07/10] be2iscsi: Remove free_list for ASYNC handles

2017-03-24 Thread Tomas Henzl
ion if found so. > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 06/10] be2iscsi: Use num_cons field in Rx CQE

2017-03-24 Thread Tomas Henzl
: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 02/10] be2iscsi: Fix closing of connection

2017-03-24 Thread Tomas Henzl
tion with reset instead of > gracefully closing it. > > Set save_cfg to 0 - session not to be saved on flash. > > Add delay and process CQ before uploading connection. > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 03/10] be2iscsi: Replace spin_unlock_bh with spin_lock

2017-03-23 Thread Tomas Henzl
On 16.3.2017 04:24, Jitendra Bhivare wrote: > spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of > spin_lock. > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 01/10] be2iscsi: Check tag in beiscsi_mccq_compl_wait

2017-03-23 Thread Tomas Henzl
0x31e/0x690 > [] ? netlink_rcv_wake+0x44/0x60 > [] ? netlink_recvmsg+0x1e3/0x450 > > beiscsi_mccq_compl_wait gets called even when MCC tag allocation failed > for mgmt_invalidate_connection. > mcc_wait is not initialized for tag 0 so causes crash in prepare_to_wait. > > Signed-off-by: Jitendra Bhivare Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 02/10] be2iscsi: Fix closing of connection

2017-03-23 Thread Tomas Henzl
On 16.3.2017 04:24, Jitendra Bhivare wrote: > CID needs to be freed even when invalidate or upload connection fails. > Attempt to close connection 3 times before freeing CID. > > Set cleanup_type to INVALIDATE instead of force TCP_RST. > This unnecessarily is terminating connection with reset inste

[PATCH] hpsa: fix volume offline state

2017-03-20 Thread Tomas Henzl
In a previous patch a hpsa_scsi_dev_t.volume_offline update line has been removed, so let us put it back.. Fixes: 85b29008d8 (hpsa: update check for logical volume status) Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/hpsa.c

Re: [PATCH 4/4] megaraid_sas: Driver version upgrade

2017-03-10 Thread Tomas Henzl
On 10.3.2017 12:22, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl tomash

Re: [PATCH 3/4] megaraid_sas: raid6 also require cpuSel check same as raid5

2017-03-10 Thread Tomas Henzl
On 10.3.2017 12:22, Shivasharan S wrote: > Without this fix, raid6 performance will not be an optimal. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl tomash

Re: [PATCH 1/4] megaraid_sas: enable intx only if msix request fails

2017-03-10 Thread Tomas Henzl
NT |grep Control > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- > Stepping- SERR+ FastB2B- DisINTx+ > > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl tomash

Re: [PATCH 2/4] megaraid_sas: add correct return type check for ldio hint logic for raid1

2017-03-10 Thread Tomas Henzl
ve r1_ldio_hint as default value in sdev > private. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl tomash

Re: [PATCH 3/3] hpsa: do not timeout reset operations

2017-03-10 Thread Tomas Henzl
On 6.3.2017 22:24, Don Brace wrote: > resets can take longer than DEFAULT_TIMEOUT > > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl tomash

Re: [PATCH 2/3] hpsa: limit outstanding rescans

2017-03-10 Thread Tomas Henzl
rogress is finished. */ > while (1) { > spin_lock_irqsave(&h->scan_lock, flags); Placing the test to this place would save few lines + if (h->scan_waiting) { + spin_unlock_irqrestore(&h->scan_lock, flags); + return but I agree with your version too. Reviewed-by: Tomas Henzl tomash

Re: [PATCH 1/3] hpsa: update check for logical volume status

2017-03-10 Thread Tomas Henzl
On 6.3.2017 22:24, Don Brace wrote: > - Add in a new case for volume offline. Resolves internal >testing bug for multilun array management. > - Return correct status for failed TURs. > > Reviewed-by: Scott Benesh > Reviewed-by: Scott Teel > Signed-off-by: Don Brace > --- > drivers/scsi/hp

Re: [PATCH v3 19/39] megaraid_sas: MR_TargetIdToLdGet u8 to u16 and avoid invalid raid-map access

2017-02-10 Thread Tomas Henzl
gt; > ld target id issue occurs mainly whenever driver loops to populate raid map > (ea. MR_ValidateMapInfo). > These are the only two places where we may see out of range target ids and > wants to > protect raid map access based on range provided by Firmware API. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
On 8.2.2017 19:51, Kashyap Desai wrote: >>> +static inline void >>> +megasas_complete_r1_command(struct megasas_instance *instance, >>> + struct megasas_cmd_fusion *cmd) { >>> + u8 *sense, status, ex_status; >>> + u32 data_length; >>> + u16 peer_smid; >>> + struct fusi

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-09 Thread Tomas Henzl
using r1_alt_dev_handle only. > Move resetting megasas_cmd_fusion fields at common function > megasas_return_cmd_fusion. > > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-08 Thread Tomas Henzl
_descriptor we can remove the error handling > which is not required. > With fusion controllers, if there is a valid message frame available, > we are guaranteed to get a corresponding request descriptor. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 10/39] megaraid_sas: NVME Interface detection and prop settings

2017-02-08 Thread Tomas Henzl
> PD INFO DCMD provide new interface type NVME_PD. Driver set property of NVME > device. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 09/39] megaraid_sas: change issue_dcmd to return void from int

2017-02-08 Thread Tomas Henzl
uest descriptor, > issue_dcmd will now always return DCMD_SUCCESS. This patch changes > return type of issue_dcmd to void and change all callers > appropriately. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 06/39] megaraid_sas: RAID map is accessed for SYS PDs when use_seqnum_jbod_fp is not set

2017-02-08 Thread Tomas Henzl
On 8.2.2017 10:29, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-08 Thread Tomas Henzl
On 8.2.2017 10:28, Shivasharan S wrote: > fix in v2 - ex_status and status was wrongly re-used in > megasas_complete_r1_command. > discussed below - > http://marc.info/?l=linux-scsi&m=148638763409385&w=2 > > > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never

Re: [PATCH 39/39] megaraid_sas: driver version upgrade

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 38/39] megaraid_sas: Change RAID_1_10_RMW_CMDS to RAID_1_PEER_CMDS and set value to 2

2017-02-06 Thread Tomas Henzl
ssary. > Set RAID_1_10_RMW_CMDS to 2 and also change macro name to > RAID_1_PEER_CMDS. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 37/39] megaraid_sas: Indentation and smatch warning fixes

2017-02-06 Thread Tomas Henzl
-by: Dan Carpenter > Signed-off-by: Kashyap Desai > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 36/39] megaraid_sas: Cleanup VD_EXT_DEBUG and SPAN_DEBUG related debug prints

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 35/39] megaraid_sas: Increase internal command pool

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Fix - increase internal command pool to 8. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > FIX - Do not use random delay to synchronize with IRQ. Use kernel API. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > b/drivers/scsi/megaraid/megaraid_sas_bas

Re: [PATCH 32/39] megaraid_sas: Bail out the driver load if ld_list_query fails

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Error handling: Bail out the driver load if > key FW cmds (LD_LIST) are not return successful. > Clean up error handling in megasas_init_fw. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 31/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Code refactoring to build_mpt_mfi_pass_thru to return void. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 30/39] megaraid_sas: During OCR, if get_ctrl_info fails do not continue with OCR

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Error handling: If controller reset is not able to > recover, kill HBA and quit immediately. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 28/39] megaraid_sas: Remove unused pd_index from megasas_build_ld_nonrw_fusion

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 29/39] megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for > better tracking and other functionalities if the device > is task management capable. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 27/39] megaraid_sas: megasas_return_cmd does not memset IO frame to zero

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Memset the IO frame to zero after release. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 26/39] megaraid_sas: max_fw_cmds are decremented twice, remove duplicate

2017-02-06 Thread Tomas Henzl
> > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 24/39] megaraid_sas: Change max_cmd from u32 to u16 in all functions

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Since maximum supported FW commands are all defined as u16, change > all local variables referring to max_cmd from u32 to u16. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 25/39] megaraid_sas: update can_queue only if the new value is less

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Minor Optimization: No need to update HBA can_queue value > if the current max FW commands is equal to earlier value. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 23/39] megaraid_sas: set pd_after_lb from MR_BuildRaidContext and initialize pDevHandle to MR_DEVHANDLE_INVALID

2017-02-06 Thread Tomas Henzl
i > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 22/39] megaraid_sas: latest controller OCR capability from FW before sending shutdown DCMD

2017-02-06 Thread Tomas Henzl
ure that driver always has latest OCR capability > of controller before sending the DCMD. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 21/39] megaraid_sas: avoid unaligned access in ioctl path

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Fix kernel warning for accessing unaligned memory access in driver. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

  1   2   3   4   5   6   7   8   >