On 01/31/2017 01:19 PM, Russell King wrote:
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing
pointer to incomplete type 'struct phy_device'
Add linux/phy.h to emac-sgmii.c
Signed-off-by: Russell King
---
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 +
The v
On 11/10/2015 03:54 PM, Arnd Bergmann wrote:
In our drivers for 32-bit devices, we have to explicitly set the DMA
mask to 32-bits in order to get any DMA working.
Do you mean PCI devices or platform devices?
Platform.
Maybe the parent bus is lacking a dma-ranges property?
All of this app
On 11/10/2015 01:13 PM, Arnd Bergmann wrote:
If the mask is 64-bit by default on ARM64, that is a bug that we need
to fix urgently. Can you verify this?
I think the mask is 0 by default, because there's no code in ARM64 that
actually sets the mask.
Take a look at arch_setup_pdev_archdata() i
On 11/10/2015 10:47 AM, Arnd Bergmann wrote:
What BenH was worried about here is that the driver sets different masks
for streaming and coherent mappings, which is indeed a worry that
could hit us on ARM as well, but I suppose we'll have to deal with
that in platform code.
Setting both masks to
Sinan Kaya wrote:
The code says it is using these macros for small integers only which
can't overflow. I was trying to get rid of compiler warning and it seems
to have disappeared.
I would double-check the assembly code, if I were you. I don't like it
when warnings just go away like that.
Sinan Kaya wrote:
I created this patch back in March with an older version of the compiler
and older kernel (3.19). I'm no longer able to reproduce this with this
compiler and linux-next.
Thread model: posix
gcc version 4.8.3 20140401 (prerelease) (crosstool-NG
linaro-1.13.1-4.8-2014.04 - Linar
On 11/09/2015 05:22 PM, Sinan Kaya wrote:
if (ioc->dma_mask)
consistent_dma_mask = DMA_BIT_MASK(64);
else
consistent_dma_mask = DMA_BIT_MASK(32); <-- why here?
So this change is from this patch:
http://permalink.gmane.org/gmane.linux.kernel/1759343
Note that this was di
Sinan Kaya wrote:
>
>
> #define MULDIV(X,MUL,DIV)mult_frac64(X, MUL, DIV)
Why bother with the macro at all? Just change the code to use do_div()
directly. It's possible that the original code was written before
do_div() became standard, or the developer didn't know about, which is
why we h
8 matches
Mail list logo
