Re: [PATCH 2/2] scsi: mpt3sass: use DEVICE_ATTR_{RO, RW}

Acked-by: Suganath Prabu On Fri, Jun 14, 2019 at 8:12 PM Tomas Henzl wrote: > > Use existing macros. No functional change. > > Signed-off-by: Tomas Henzl > --- > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 210 + > 1 file changed, 97 insertions(+), 113 deletions(-) > > di

Re: [PATCH 1/2] scsi: mpt3sas: make driver options visible in sys

Acked-by: Suganath Prabu On Fri, Jun 14, 2019 at 8:12 PM Tomas Henzl wrote: > > Support is easier with all driver parameters visible in sysfs. > Also I've replaced a constant with an octal permission. > > Signed-off-by: Tomas Henzl > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 14 +++-

Re: [PATCH 0/2] mpt3sas

Acked-by: Suganath Prabu On Wed, Jun 19, 2019 at 6:34 AM Martin K. Petersen wrote: > > > > Just few small changes, octal numbers instead of constants etc. > > Broadcom folks: Please review! > > -- > Martin K. Petersen Oracle Linux Engineering

Re: [v1 0/7] Irq poll to address cpu lockup.

Thanks Martin. -Suganath On Tue, Mar 19, 2019 at 2:47 AM Martin K. Petersen wrote: > > > Suganath, > > > We have seen cpu lock up issue from fields if system has greater (more > > than 96) logical cpu count. SAS3.0 controller (Invader series) > > supports at max 96 msix vector and SAS3.5 produc

Re: [v1 0/7] Irq poll to address cpu lockup.

Hi Martin, Any update on these patches. Thanks, Suganath On Fri, Feb 15, 2019 at 1:10 PM Suganath Prabu wrote: > > We have seen cpu lock up issue from fields if > system has greater (more than 96) logical cpu count. > SAS3.0 controller (Invader series) supports at > max 96 msix vector and SAS3

Re: Re: How to disable NCQ with mpt3sas ?

Hi Vaughan, NCQ feature is only for SATA. Enabling / Disabling NCQ through mpt3sas/lsiutil support is only for SATA drives. Thanks, Suganath On Mon, Feb 25, 2019 at 8:12 AM ca...@uit.com.cn wrote: > > Hi Suganath, > >[448435.392210] scsi 4:0:0:0: atapi(n), ncq(n), asyn_notify(n),smart(y),

Re: [PATCH 31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through

Hi Gustavo, This patch may not apply smoothly over 4.21/scsi-queue. Our previous patch for Aero had some changes in this switch case. Can you resend this patch with latest code base ? Thanks, Suganath prabu On Thu, Dec 20, 2018 at 5:37 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly ping: >

Re: [v6 0/4] mpt3sas: Hot-Plug Surprise removal support on IOC.

Any update on this ? In V6, I have posted has only defect fixes (Other than HBA Hot-Plug Surprise remove support). We are reworking and incorporating the suggestions from Bjorn. And after covering tests, we ll post Hot-Plug Surprise removal patches. Thanks, Suganath Prabu On Tue, Oct 23, 2018 at

Re: [v5 3/4] mpt3sas:Fix driver modifying persistent data.

On Wed, Oct 17, 2018 at 1:54 PM Andy Shevchenko wrote: > > On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu > wrote: > > > > * If EEDPTagMode field in manufacturing page11 is set, > > unset it. This is needed to fix a hardware bug > > in SAS3/SAS2 cards, So, skipping EEDPTagMode changes > > in Manu

Re: [PATCH] scsi/mpt3sas: Use dma_pool_zalloc

Looks good, Please consider this patch as Acked-by: Suganath Prabu Thanks On Tue, Oct 2, 2018 at 11:14 AM Souptick Joarder wrote: > > Replaced dma_pool_alloc + memset with dma_pool_zalloc. > > Signed-off-by: Brajeswar Ghosh > Signed-off-by: Souptick Joarder > --- > drivers/scsi/mpt3sas/mpt3s

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

as this only adds sanity check. We are also okay, if you suggest us to completely remove this patch. Thanks, Suganath Prabu On Mon, Oct 1, 2018 at 7:11 PM Bjorn Helgaas wrote: > > [+cc LKML] > > On Mon, Oct 01, 2018 at 12:57:01PM +0530, Suganath Prabu Subramani wrote: > > On Th

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

On Tue, Oct 2, 2018 at 7:34 PM Bjorn Helgaas wrote: > > On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote: > > I think the names "pci_device_is_present()" and > > "mpt3sas_base_pci_device_is_available()" contribute to the problem > > because they make promises that can't be kept -- all

Re: [PATCH 7/7] mpt3sas: Remove unused macro MPT3SAS_FMT

Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:33 PM Joe Perches wrote: > > All the uses have been removed, delete the macro. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.h | 2 -- > 1 file changed, 2 deletions(-) > > di

Re: [PATCH 6/7] mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels

Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:33 PM Joe Perches wrote: > > Convert these uses to ioc_ where appropriate. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 41 > +++- > dr

Re: [PATCH 5/7] mpt3sas: Remove KERN_WARNING from panic uses

Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Remove the logging level as panic calls stop the machine and should > always be emitted regardless of requested logging level. > > These existing panic uses are perhaps inappropr

Re: [PATCH 4/7] mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:

Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Convert the existing 2 uses to make the format and arguments > matching more obvious. > > Miscellanea: > > o Move the word "enabled" into the format to trivially reduce object si

Re: [PATCH 3/7] mpt3sas: Convert mlsleading uses of pr_ with MPT3SAS_FMT

Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > These have misordered uses of __func__ and ioc->name that could > mismatch MPT3SAS_FMT and "%s: ". > > Convert them to ioc_. > > Signed-off-by: Joe Perches > --- > drivers/

Re: [PATCH 2/7] mpt3sas: Convert uses of pr_ with MPT3SAS_FMT to ioc_

Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Use a more common logging style. > > Done using the perl script below and some typing > > $ git grep --name-only -w MPT3SAS_FMT -- "*.c" | \ > xargs perl -i -e 'local $/; w

Re: [PATCH 1/7] mpt3sas: Add ioc_ logging macros

Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > These macros can help identify specific logging uses and eventually > perhaps reduce object sizes. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > The code for getting shost and IOC is redundant so > > moved that to function "scsih_get_shost_and_ioc". > > Also checks for NULL are added to IOC and shost. > > > > Signe

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

Hi Lucas and Bjorn, Thanks for reviewing and providing useful comments. On Fri, Sep 28, 2018 at 12:40 AM Lukas Wunner wrote: > > On Thu, Sep 27, 2018 at 01:47:46PM -0500, Bjorn Helgaas wrote: > > mpt3sas_wait_for_commands_to_complete(...) > > { > > ... > > + if (!mpt3sas_base_pci_device

Re: [PATCH v4 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

Hi Bjorn, Thanks for reviewing. On Thu, Sep 27, 2018 at 2:33 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote: > > Introduce mpt3sas_wait_for_ioc_to_operational. > > > > This section of code "wait for IOC to be operational" > > is used in many places a

Re: [PATCH v3 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

On Tue, Sep 25, 2018 at 3:22 PM Andy Shevchenko wrote: > > On Tue, Sep 25, 2018 at 12:46 PM Suganath Prabu Subramani > wrote: > > > > > + pr_err(MPT3SAS_FMT > > > > + "%s: pci error recovery reset or" > > &g

Re: [PATCH v3 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

Hi Andy, I forgot to add Lukas in last patch CC list, But i have sent a note regarding the updated patch to him. Also added linux-pci On Tue, Sep 25, 2018 at 2:10 PM Andy Shevchenko wrote: > > On Mon, Sep 24, 2018 at 9:36 AM Suganath Prabu S > wrote: > > > > * Driver uses "pci_device_is_presen

Re: mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

t3sas: Fix for Asynchronous completion of timedout IO and task abort of timedout IO. Track msix of each IO and use the same msix for issuing abort to timed out IO. With this driver will process IO's reply first followed by TM. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B

Re: mpt3sas: sleeping function called from invalid context

Hi Bart, We have root caused the issue and it is same as you mentioned. "_scsih_get_enclosure_logicalid_chassis_slot()" is called with interrupts disabled and this function "_scsih_get_enclosure_logicalid_chassis_slot" again calls _config_request(), with mutex_lock(). We have patch ready along wi

Re: [PATCH 5/6] mpt3sas: Introduce function to clone mpi request.

Hi tomas, We have sent V1 version of patches on 7th of Feb. Please review. Thanks, Suganath Prabu S On Mon, Jan 22, 2018 at 8:08 PM, Tomas Henzl wrote: > On 01/19/2018 01:37 PM, Suganath Prabu S wrote: >> 1) Added function _base_clone_mpi_to_sys_mem to clone >> MPI request into system BAR0 mappe

Re: [V1 0/6] mpt3sas: Adding MPI Endpoint device support.

Gentle Reminder, Any update on this ? Thanks, Suganath Prabu S On Wed, Feb 7, 2018 at 4:21 PM, Suganath Prabu S wrote: > V1 Change info: > > * Few sparse warning fixes over initial patch set. > * For 32 bit Arch,_base_writeq function is identical > to _base_mpi_ep_writeq, Removed duplicate code

Re: [PATCH] mpt3sas: fix an out of bound write

Hi, Please consider this patch as Ack-by: Suganath Prabu S Thanks. On Fri, Jan 19, 2018 at 8:52 PM, Tomas Henzl wrote: > cpu_msix_table is allocated to store online cpus, but pci_irq_get_affinity > may return cpu_possible_mask which is then used to access cpu_msix_table. > That causes bad user

Re: [PATCH 4/6] mpt3sas: Introduce Base function for cloning.

Hi All, We tried to reproduce below error "drivers/scsi/mpt3sas/mpt3sas_base.c:315:10: error: implicit declaration of function 'mpt3sas_scsih_scsi_lookup_get'; did you mean scmd = mpt3sas_scsih_scsi_lookup_get(ioc, smid);" with base code and Make file flags (sparse) as mentioned under reprodu

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 15, 2017 at 6:37 AM, Martin K. Petersen wrote: > > Suganath, > >> Is there any update on the submitted mpt3sas patches. > > We are waiting for you to report back your findings on PRP vs. SGL. We are working on this, since there is h/w dependent, we are in discussion with H

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Is there any update on the submitted mpt3sas patches. Thanks, Suganath Prabu S On Fri, Sep 1, 2017 at 2:09 PM, Suganath Prabu Subramani wrote: > Hi Martin, > > On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen > wrote: >> >> Hi Suganath, >> >>

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, On Fri, Sep 1, 2017 at 8:52 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Let me explain - NVME device fast path is possible in two ways. IEEE >> SGL and PRP SGL. Due to h/w constraint we choose IEEE SGL only for >> smaller IO size. Both above is true h/w Fast Path and no firmw

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied inline. Thanks, Suganath Prabu S On Thu, Aug 31, 2017 at 8:35 AM, Martin K. Petersen wrote: > > Hi Suganath, > >> Theoretically we want to use h/w capability (to translate IEEE to PRP) >> for smaller IO size to leverage h/w capability. > > Nobody says we have to use the capabi

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

Hi Martin, Replied in line. - I don't understand why you go through all these hoops to decide whether to use PRPs or IEEE scatterlists. If the firmware translation is slow, why even bother with the SG format in the first place? Set the max I/O size to match MDTS and you're done. => We wil

Re: [PATCH v3 01/13] mpt3sas: Update MPI Header

Hi James, we have fixed the sparse warnings associated with this patch set and posting V4 of mpt3sas patches soon. We are also working on sparse error/warnings that existed before this patch set and we ll be posting it separately. Thanks, Suganath Prabu S On Wed, Aug 9, 2017 at 2:48 AM, J Freyens

Re: [PATCH v3 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Martin, This code was added to detect holes, when we started testing with 4.9 kernel. when we disabled "use_blk_mq" and no merges, we are hitting issues with holes. Anyhow In latest upstream, it got fixed with this commit 5a8d75a1b8c99bdc926ba69b7b7dbe4fae81a5af So we are removing the code rela

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

Is there any update on these patches ? Thanks, Suganath Prabu S On Fri, Jul 14, 2017 at 6:52 PM, Suganath Prabu S wrote: > Ventura Series controller are Tri-mode. The controller and > firmware are capable of supporting NVMe devices and > PCIe switches to be connected with the controller. This >

Re: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

Hi Elliott, We are maintaining NVMe drives as scsi device in mpt3sas driver. There are lot of firmware/hardware level dependencies and after lot of discussions we arrived this value (128). So, we prefer not to provide module parameter to change this at least for now. Thanks, Suganath Prabu S On T

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Keith, We have made change and submitted V2 of patch set. Thanks, Suganath Prabu S On Wed, Jul 12, 2017 at 5:34 AM, Keith Busch wrote: > On Tue, Jul 11, 2017 at 01:55:02AM -0700, Suganath Prabu S wrote: >> +/** >> + * _base_check_pcie_native_sgl - This function is called for PCIe end >> devi

Re: [PATCH 00/13]mpt3sas driver NVMe support:

Is there any update on this ? Will include linux-n...@lists.infradead.org in next version of this patch submission, if there is any change suggestion. Thanks, Suganath Prabu S On Thu, Jun 29, 2017 at 8:01 PM, Johannes Thumshirn wrote: > On Thu, Jun 29, 2017 at 07:49:01PM +0530, Suganath Prabu S

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

max devices it can support. So, there is No possibility that driver can add more devices than bitmap. Thanks, Suganath Prabu S On Tue, Oct 25, 2016 at 3:21 PM, Hannes Reinecke wrote: > On 10/25/2016 11:19 AM, Suganath Prabu Subramani wrote: >> Hi Hannes, >> >> Please give us littl

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

Hi Hannes, Please give us little more info on the third comment. It ll help us to understand better and incorporate required changes. Comment is "Why don't you need to check for the size of the bitmap here?" i have taken care of other two comments in this patch. > /* check if device is p

[PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

From: Suganath prabu Subramani Deallocate resources before reallocating of the same in retry_allocation path of _base_allocate_memory_pools() Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 2/2] Updating maintainers list for MPT FUSION DRIVERS.

From: Suganath prabu Subramani Updating maintainers list for MPT FUSION DRIVERS, broadcom support link and email id. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- MAINTAINERS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS

[PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q

From: Suganath prabu Subramani Removed cpumask_clear as it is not required for zalloc_cpumask_var and free free_cpumask_var before freeing reply_q. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- 1 file changed, 1 insertion

[mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

Module parameter to enable/disable configuring affinity hint for msix vector. SMP affinity feature can be enabled/disabled by setting module parameter "smp_affinity_enable" to 1/0. By default this feature is enabled. (smp_affinity_enable = 1 enabled). Signed-off-by: Suganath prabu

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

er review comments for freeing reply_q and cpumask_var in this patch and sending it soon. Thanks, Suganath prabu S On Thu, Feb 4, 2016 at 8:31 PM, Tomas Henzl wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani >> >> Module parameter