On Wed, 5 Jun 2019 12:26:47 -0700
Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 12:10:20PM -0700, Stephen Hemminger wrote:
> > > Sure. But they should not get a way out for just one specific driver.
> >
> > There are people running new kernels on 6 year old dist
On Wed, 5 Jun 2019 12:26:47 -0700
Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 12:10:20PM -0700, Stephen Hemminger wrote:
> > > Sure. But they should not get a way out for just one specific driver.
> >
> > There are people running new kernels on 6 year old dist
On Wed, 5 Jun 2019 12:07:23 -0700
Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 12:06:40PM -0700, Stephen Hemminger wrote:
> > > Which is true for every device, and why we use UUIDs or label for
> > > mounts that are supposed to be stable.
> >
> > Not ev
On Wed, 5 Jun 2019 11:56:37 -0700
Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 11:52:05AM -0700, Stephen Hemminger wrote:
> > Doing asynchronous probing can lead to reordered device names
> > which is leads to failed mounts.
>
> Which is true for every device, an
Doing asynchronous probing can lead to reordered device names
which is leads to failed mounts.
Fixes: af0a5646cb8d ("use the new async probing feature for the hyperv drivers")
Signed-off-by: Stephen Hemminger
---
drivers/scsi/storvsc_drv.c | 3 ---
1 file changed, 3 deletions(-)
di
> Signed-off-by: Michael Kelley
Acked-by: Stephen Hemminger
t use kernel stack for it by pre-allocating
> them using kmalloc when channels are first initialized.
>
> Signed-off-by: Long Li
Reviewed-by: Stephen Hemminger
ch 28, 2018 3:43 PM
To: Martin K. Petersen ; Long Li
Cc: KY Srinivasan ; Haiyang Zhang ;
Stephen Hemminger ; James E . J . Bottomley
; de...@linuxdriverproject.org;
linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; net...@vger.kernel.org
Subject: RE: [Resend Patch 1/3] Vmbus: Add functi
On Thu, 15 Mar 2018 16:52:23 -0700
Long Li wrote:
> From: Long Li
>
> Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth
> correctly for IDE.
>
> Also set the correct cmd_per_lun for all devices.
>
> Signed-off-by: Long Li
Loo
before a failover can occur.
>
> Signed-off-by: Cathy Avery
> Signed-off-by: Long Li
When working on the DVD probe issue I saw that error handling was
problematic. Thanks for fixing.
Reviewed-by: Stephen Hemminger
On Tue, 29 Aug 2017 21:31:11 -0400
"Martin K. Petersen" wrote:
> Long,
>
> > When storvsc is sending I/O to Hyper-v, it may allocate a bigger
> > buffer descriptor for large data payload that can't fit into a
> > pre-allocated buffer descriptor. This bigger buffer is freed on return
> > path.
>
These are refactoring changes to the Hyper-V scsi driver.
Stephen Hemminger (2):
storvsc: use in place iterator function
storvsc: remove unnecessary channel inbound lock
drivers/hv/channel_mgmt.c | 1 -
drivers/scsi/storvsc_drv.c | 52
In 4.12-rc1, new functions were added to support iterating
over elements in the vmbus event ring. This patch uses them to
simplify the ring buffer handling in virtual SCSI driver as well.
Signed-off-by: Stephen Hemminger
---
drivers/scsi/storvsc_drv.c | 44
In storvsc driver, inbound messages do not go through inbound lock.
The only effect of this lock was is to provide a barrier for
connect and remove logic.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel_mgmt.c | 1 -
drivers/scsi/storvsc_drv.c | 8 +++-
include/linux/hyperv.h
I decided not to send it to stable since problem was only observed on 4.11 but
it is probably endemic to all GEN2 VM's
-Original Message-
From: Joseph Salisbury [mailto:joseph.salisb...@canonical.com]
Sent: Tuesday, March 28, 2017 7:29 AM
To: Stephen Hemminger ; Long Li
C
Are you sure the real problem is not the one fixed by this commit?
commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f
Author: Stephen Hemminger
Date: Tue Mar 7 09:15:53 2017 -0800
scsi: storvsc: Workaround for virtual DVD SCSI version
Hyper-V host emulation of SCSI for virtual DVD
On Tue, 14 Mar 2017 12:01:03 -0400
Cathy Avery wrote:
> #if IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
> if (host->transportt == fc_transport_template) {
> + struct fc_rport_identifiers ids;
> +
> + ids.node_name = 0;
> + ids.port_name = 0;
> + ids.por
nto a death spiral doing
block reads on the non-existent LUNs.
By setting the correct blacklist flags, the target with the
DVD device is scanned with REPORTLUN and that works correctly.
Patch needs to go in current 4.11, it is safe but not necessary
in older kernels.
Signed-off-by: Stephen Hemm
> > I will try it, but it can't work for two reasons.
> > First, the INVALID_LUN error is masked off on INQUIRY in current code.
> > Second, the scsi_device is instantiated already as part of scan probe
> > process
> > before it gets here.
>
> Was the invalid LUN in the LUN0 position. Inquiry
On Sat, 4 Mar 2017 21:03:41 +
KY Srinivasan wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Friday, March 3, 2017 4:50 PM
> > To: James Bottomley
> > Cc: Hannes Reinecke ; Christoph Hellwig ;
&g
Needs more testing but this does fix the observed problem.
From: Stephen Hemminger
Subject: [PATCH] hv_storvsc: fix error handling
The Hyper-V storvsc SCSI driver was hiding all errors in INQUIRY and
MODE_SENSE commands. This caused the scan process to incorrectly think
devices were present
On Thu, 02 Mar 2017 11:18:23 -0800
James Bottomley wrote:
> On March 2, 2017 11:05:05 AM PST, Stephen Hemminger
> wrote:
> >On Thu, 02 Mar 2017 10:36:17 -0800
> >James Bottomley wrote:
> >
> >> On March 2, 2017 10:23:24 AM PST, Stephen Hemminger
> >
On Thu, 02 Mar 2017 10:36:17 -0800
James Bottomley wrote:
> On March 2, 2017 10:23:24 AM PST, Stephen Hemminger
> wrote:
> >On Thu, 2 Mar 2017 14:25:14 +0100
> >Hannes Reinecke wrote:
> >
> >> On 03/02/2017 02:40 AM, Stephen Hemminger wrote:
> &g
On Thu, 2 Mar 2017 14:25:14 +0100
Hannes Reinecke wrote:
> On 03/02/2017 02:40 AM, Stephen Hemminger wrote:
> > On Thu, 2 Mar 2017 01:56:15 +0100
> > Christoph Hellwig wrote:
> >
> >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote:
> >&
On Thu, 2 Mar 2017 14:25:14 +0100
Hannes Reinecke wrote:
> On 03/02/2017 02:40 AM, Stephen Hemminger wrote:
> > On Thu, 2 Mar 2017 01:56:15 +0100
> > Christoph Hellwig wrote:
> >
> >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote:
> >&
On Thu, 2 Mar 2017 01:56:15 +0100
Christoph Hellwig wrote:
> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote:
> > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote:
> > > >
> > > > http://git.infradead.o
On Thu, 2 Mar 2017 01:01:35 +0100
Christoph Hellwig wrote:
> On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote:
> > >
> > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e2229c076c0ea418712654be77e4
> > >
> >
> &
On Wed, 01 Mar 2017 15:09:44 -0800
James Bottomley wrote:
> On Wed, 2017-03-01 at 13:27 -0800, Stephen Hemminger wrote:
> > Ok here is much better data, wasn't accounting for the offset in the
> > payload
>
> But now both responses are the same:
>
> > Worki
Ok here is much better data, wasn't accounting for the offset in the payload
Working 4.10
[1.020041] scsi host0: storvsc_host_t
[1.024998] hv_storvsc: INQUIRY cmd 0x12 0x0 0x0 scsi status 0x0 srb status
0x1 length 36
[1.027452] hv_storvsc: payload size 288 count 1 offset 3072 len 36
On Wed, 01 Mar 2017 11:20:22 -0800
James Bottomley wrote:
> On Wed, 2017-03-01 at 10:57 -0800, James Bottomley wrote:
> > On Wed, 2017-03-01 at 10:48 -0800, Stephen Hemminger wrote:
> > > On Tue, 28 Feb 2017 22:20:58 -0800
> > > James Bottomley wrote:
> > >
On Tue, 28 Feb 2017 22:20:58 -0800
James Bottomley wrote:
> On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote:
> > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb
> > status 0x20 length 36
> > [1.352913] inquiry data: : 00 aa be
Dexuan has reproduced the same problem and discovered that is related to
whether virtual DVD is
attached to the VM. My VM had empty virtual DVD (offline) from the
installation of the ISO.
If the DVD device is removed then the VM boots.
This makes the problem less of a catastrophic but we still
On Wed, 1 Mar 2017 16:50:57 +0100
Christoph Hellwig wrote:
> On Tue, Feb 28, 2017 at 10:48:45PM -0800, Stephen Hemminger wrote:
> > Let me know, I can run another test and dump more data.
>
> Could it be that we keep the old sense buffer values around because
> my commit
On Tue, 28 Feb 2017 22:20:58 -0800
James Bottomley wrote:
> On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote:
> > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb
> > status 0x20 length 36
> > [1.352913] inquiry data: : 00 aa be
> Let's concentrate on INQUIRY since that's the first command in the
> probe sequence. I think it's completing successfully because your
> hyperv layer says it has 36 bytes of transfer and that's the size of a
> successful initial INQUIRY, so the fact that the code above would break
> stuff if th
On Tue, 28 Feb 2017 09:06:13 -0800
James Bottomley wrote:
> On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote:
> > On 02/28/2017 07:08 AM, Christoph Hellwig wrote:
> > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote:
> > > > Fixes: ee5
On Tue, 28 Feb 2017 09:06:13 -0800
James Bottomley wrote:
> On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote:
> > On 02/28/2017 07:08 AM, Christoph Hellwig wrote:
> > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote:
> > > > Fixes: ee5
On Tue, 28 Feb 2017 09:06:13 -0800
James Bottomley wrote:
> On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote:
> > On 02/28/2017 07:08 AM, Christoph Hellwig wrote:
> > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote:
> > > > Fixes: ee5
On Tue, 28 Feb 2017 15:08:12 +0100
Christoph Hellwig wrote:
> On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote:
> > Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each I/O")
> >
> > but that is already in linux-next.
> >
>
On Mon, 27 Feb 2017 15:30:30 -0800
Stephen Hemminger wrote:
> Something in SCSI in 4.11 broke booting on Hyper-V Generation 2 VM with 8
> VCPU and 4G of memory.
> Both Linus's current tree (4.11 pre-rc1) and linux-next fail in a similar
> manner. It looks like some error
; net/hsr/hsr_slave.c | 3 ++-
> 14 files changed, 31 insertions(+), 35 deletions(-)
Looks good thanks.
Acked-by: Stephen Hemminger
On Sun, 29 Jan 2017 01:12:18 -0800
"Christoph Hellwig" wrote:
> Remove a piece of code in storvsc_queuecommand that tries to pass the
> physical address of the kernel struct scatterlist pointer to the host.
>
> Fortunately the code can't ever be reached anyway.
>
> Signed-off-by: Christoph Hell
Signed-off-by: Stephen Hemminger
---
Depends on first patch that changes PCI core.
drivers/scsi/ipr.c |2 +-
drivers/scsi/lpfc/lpfc_init.c|2 +-
drivers/scsi/mpt2sas/mpt2sas_scsih.c |2 +-
drivers/scsi/qla2xxx/qla_os.c|2 +-
drivers/scsi
On Wed, 5 Sep 2012 23:13:46 +0530
Naresh Kumar Inna wrote:
> On 9/5/2012 9:59 PM, Stephen Hemminger wrote:
> > On Wed, 5 Sep 2012 18:03:55 +0530
> > Naresh Kumar Inna wrote:
> >
> >> This patch contains code for driver initialization, driver resource
> &
On Wed, 5 Sep 2012 18:03:59 +0530
Naresh Kumar Inna wrote:
> +
> +#define CSIO_ASSERT(cond)
> \
> +do { \
> + if (unlikely(!((cond\
On Wed, 5 Sep 2012 18:03:59 +0530
Naresh Kumar Inna wrote:
> +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r))
This is similar to existing round_up() in kernel.h could you use that?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
On Wed, 5 Sep 2012 18:03:55 +0530
Naresh Kumar Inna wrote:
> This patch contains code for driver initialization, driver resource
> allocation and the Work Request module functionality. Driver initialization
> includes module entry/exit points, registration with PCI, FC transport and
> SCSI mid l
On Wed, 5 Sep 2012 18:03:54 +0530
Naresh Kumar Inna wrote:
> +
> +/* FCoE Adapter types & its description */
> +static struct csio_adap_desc csio_fcoe_adapters[] = {
Tables like this should be const.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a messa
dev_err() call into a device driver if all the other
error printout's use a different interface.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(Found out not to put aic7xxx in subject line because of spam filter...)
Running with latest 2.6.11 bk tree, one of my machines takes for ever to boot.
The driver is builtin (not a module). It worked fine until today, and works
fine with 2.6.11 or earlier. Looks like it is going into some probin
On Tue, 25 Jan 2005 16:19:12 + (GMT)
S Iremonger <[EMAIL PROTECTED]> wrote:
>
> For some purposes at the moment, working IP-over-SCSI could be rather
> handy... ;-).
You probably are looking for:
http://linux-iscsi.sourceforge.net/
--
Stephen Hemminger &l
51 matches
Mail list logo
