#define driver_byte(result) (((result) >> 24) & 0xff)
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Ges
DITION;
+ scsi_build_sense(scmd, 1, ILLEGAL_REQUEST, 0x10, ascq);
set_host_byte(scmd, DID_SOFT_ERROR);
}
looks like a non-functional change for zfcp, so for this part:
Acked-by: Steffen Maier # for zfcp
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index a0db8d8766a8..2babf6df8066
if (q->mq_ops == &scsi_mq_ops)
+ if (q->mq_ops == &scsi_mq_ops ||
+ q->mq_ops == &scsi_mq_ops_no_commit)
sdev = q->queuedata;
if (!sdev || !get_device(&sdev->sdev_gendev))
sdev = NULL;
--
Mit freundlichen
Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On 10/1/19 4:14 PM, Greg KH wrote:
On Tue, Oct 01, 2019 at 12:49:49PM +0200, Steffen Maier wrote:
On excessive bit errors for the FCP channel ingress fibre path, the channel
notifies us. Previously, we only emitted a kernel message and a trace record.
Since performance can become suboptimal
plugged.
* After the repair action, you can manually recover the FCP device by
* writing "0" into its "failed" sysfs attribute.
* If recovery through sysfs is not possible, set the CHPID of the device
* offline and back online on the service element.
Signed-off-by:
I don't expect all stable or longterm kernels to get the fix.
If I happen to find out we need the fix in a kernel where it does not apply,
I'll send a backport to stable when the time is right.
Showing the possible dependencies is awesome!
--
Mit freundlichen Gruessen / Kind regard
sfs attribute.
* If recovery through sysfs is not possible, set the CHPID of the device
* offline and back online on the service element.
Signed-off-by: Steffen Maier
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: #2.6.30+
Reviewed-by: Jens Remus
Reviewed-by: Benjamin Block
---
Martin, Jam
:0: multipath: error attaching hardware handler
device-mapper: ioctl: error adding target to table
Signed-off-by: Steffen Maier
Fixes: 8930a6c20791 ("scsi: core: add support for request batching")
Cc: Paolo Bonzini
---
drivers/scsi/scsi_lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
its own
new copy scsi_mq_ops_batching instead of changing the use case and
semantics of the existing scsi_mq_ops, because this would likely
cause less regressions for all the other users not using the new feature.
Steffen Maier (2):
scsi: core: fix missing .cleanup_rq for SCSI hosts without
om block/for-next.
Signed-off-by: Steffen Maier
Fixes: 8930a6c20791 ("scsi: core: add support for request batching")
Cc: Paolo Bonzini
Cc: Ming Lei
---
drivers/scsi/scsi_lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index
42] [<3a990226>] __tiqdio_inbound_processing+0x106/0xbf0
[ 499.575551] [<3a1e4eea>] tasklet_action_common.isra.0+0x72/0xf0
[ 499.575559] [<3aba5442>] __do_softirq+0x102/0x368
[ 499.575560] [<3a1e4ab6>] irq_exit+0x9e/0xb8
[ 499.5
Hi Ming,
On 6/26/19 5:07 AM, Ming Lei wrote:
On Tue, Jun 25, 2019 at 12:51:04PM +0200, Steffen Maier wrote:
I don't mind doing this change for zfcp. However, I'm having doubts
regarding the rationale in the commit description.
However, I still suggest to do it because it will
required for this SCSI MQ change regarding scatterlist allocation,
change all other scatterlist iterators in zfcp to the safe sg_next() even if
not necessary as these changed zfcp-internal scatterlists are linear and
unchained. This may avoid confusion about a potential need for conversions in
th
r the whole request.
Cc: Steffen Maier
Cc: Benjamin Block
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Cc: linux-s...@vger.kernel.org
Acked-by: Benjamin Block
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Ming Lei
---
drivers/s390/scsi/zfcp_fc.c | 4 ++--
1 file ch
from v3.7
commit d99b601b6338 ("[SCSI] zfcp: restore refcount check on port_remove").
However, we have to give up zfcp_sysfs_port_units_mutex earlier in unit_add
to prevent a deadlock with scsi_host scan taking shost->scan_mutex first
and then zfcp_sysfs_port_units_mutex now in our zfcp_
With this early return due to zfcp_unit child(ren), we don't use the
zfcp_port reference from the earlier zfcp_get_port_by_wwpn()any more
and need to put it.
Signed-off-by: Steffen Maier
Fixes: d99b601b6338 ("[SCSI] zfcp: restore refcount check on port_remove")
Cc: #3.7+
Reviewed
Martin, James,
here are 2 zfcp bugfixes for v5.2-rcX.
The patches apply to Martin's 5.2/scsi-fixes
and to James' fixes branch.
Steffen Maier (2):
zfcp: fix missing zfcp_port reference put on -EBUSY from port_remove
zfcp: fix to prevent port_remove with pure auto scan LUNs (
this code change:
Tag: fcrscn1
WWPN : 0x500507630310d327
ERP want : 0x02
ERP need : 0x02
Tag: fcrscn1
WWPN : 0x500507630310d327
ERP want : 0x02
ERP need : 0x00 NOP => superfluous trace record
The last tr
James, Martin,
here are 3 zfcp bug fixes for v5.1-rcX (or the next merge window).
The patches apply to Martin's 5.1/scsi-fixes
and to James' fixes branch.
Steffen Maier (3):
zfcp: fix rport unblock if deleted SCSI devices on Scsi_Host
zfcp: fix scsi_eh host reset with port_forced E
ID : 0x
ERP status : 0x0180
ERP step : 0x1000
ERP action : 0x01
ERP count : 0x00
NOT followed by a trace record with tag "scpaddy"
for WWPN 0x50050763031bd327.
Signed-off-by: Steffen Maier
Fixes: 6f2ce1c6af37 ("scsi: zfcp: fix rport unbloc
the above described escalation
and eventually all ports would be forced reopen to resolve any
continuing FCP request timeouts due to earlier bit errors.
Signed-off-by: Steffen Maier
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: #3.0+
Reviewed-by: Jens Remus
Reviewed-by: Benjamin Block
--
t_device(&sdkp->dev);
}
/**
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
of a8cf59a6692c.
Devices on our bus ccw support DMA but no DMA mapping. Of multiple device
types on the ccw bus, only zfcp needs dma_parms for SCSI limits.
So, leave dma_parms setup in zfcp and do not move it to the bus.
Signed-off-by: Steffen Maier
Fixes: 50c2e9107f ("scsi: introduce a max_
quick attempt to adapt zfcp to your patch would be to set
scsi_host_template.max_segment_size = ZFCP_QDIO_SBALE_LEN.
Ideas?
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender
mempool")
v3.10 commit 9edf7d75ee5f
("[SCSI] zfcp: status read buffers on first adapter open with link down")
Signed-off-by: Steffen Maier
Reviewed-by: Jens Remus
---
drivers/s390/scsi/zfcp_aux.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/
the accounting of missing SRBs atomic for parallel
execution in both the ERP thread and adapter->stat_work.
Signed-off-by: Steffen Maier
Fixes: d26ab06ede83 ("[SCSI] zfcp: receiving an unsolicted status can lead to
I/O stall")
Cc: #2.6.27+
Reviewed-by: Jens Remus
---
drivers/s390/s
eue
and to James' misc branch.
Steffen Maier (2):
zfcp: fix posting too many status read buffers leading to adapter
shutdown
zfcp: improve kdoc for return of zfcp_status_read_refill()
drivers/s390/scsi/zfcp_aux.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
--
2.16.4
request size as there is no protection data for zfcp.
Signed-off-by: Steffen Maier
Co-developed-by: Fedor Loshakov
Signed-off-by: Fedor Loshakov
Reviewed-by: Jens Remus
---
Changes in description since v1:
Don't erroneously blame non-zfcp code for DIX issues.
Explain technical reasons why DIF
On 11/16/2018 12:22 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
would now
suppress helpful -Wswitch compiler warnings when building with W=1
But then again, only with W=1 we would notice unhandled enum cases.
that's the only caveat
Without the default cases
And if there are unaddressed issues in the I/O stack that prevents you
from having integrity enabled, I'd prefer to know about them so they can
be fixed rather than circumventing them through driver module parameter.
Sure.
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux o
On 11/21/2018 12:02 PM, Steffen Maier wrote:
On 11/20/2018 03:59 PM, John Garry wrote:
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->sg_table one more time in the dr
PTT_CNT;
shost->cmd_per_lun = hisi_hba->hw->max_command_entries -
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On 11/16/2018 12:13 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
On 11/16/2018 12:17 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
Use the already defined enum for this purpose to get at least some build
checking (even though an enum is type equivalent to an int in C).
v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup co
t freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Also clarify namespace prefix for the timeout used for FSF requests
on behalf of SCSI error recovery: It is zfcp_fsf_ not zfcp_scsi_.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 6 --
drivers/s390/scsi/zfcp_fsf.c | 9 +++--
2 files
1):
zfcp: make DIX experimental, disabled, and independent of DIF
Steffen Maier (21):
zfcp: move SG table helper from aux to fc and make them static
zfcp: drop unnecessary forward prototype for struct zfcp_reqlist
zfcp: move scsi_eh & non-ERP timeout defines owned by and local to
v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements")
extended this mask by one nibble with the introduction of
ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x0080 for ACT
(access control table).
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers
Improve whatever the following simple invocation reported:
$ ./scripts/kernel-doc -none drivers/s390/scsi/*.h
While at it, improve some related kdoc,
including struct zfcp_fsf_ct_els in zfcp_fsf.h.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.h
.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_fsf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index 0bdbc596da97..b83d249d07dc 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
s) to handle new functionality.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c
index b2845c5b8106..9345fed3bb37 100644
--- a/drivers/s390
code
might perform unforeseen things we might not want...
As of today, we never run through the removed default case,
so removing it is no functional change.
In the future, we never should run through a default case but
introduce the necessary specific case(s) to handle new functionality.
Signed-o
While at it also improve some copy&paste kdoc mistakes.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 13 -
drivers/s390/scsi/zfcp_erp.c | 6 +++---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/s390/scsi/zfcp_fsf.c
ues after the switch case body.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 16 +++-
drivers/s390/scsi/zfcp_erp.c | 35 +--
2 files changed, 40 insertions(+), 11 deletions(-)
--- a/drivers/s390/scsi/zfcp
065:6: warning: this statement may fall through
[-Wimplicit-fallthrough=]
if (atomic_read(&zfcp_sdev->status) & ZFCP_STATUS_COMMON_OPEN)
^
drivers/s390/scsi/zfcp_erp.c:1068:2: note: here
case ZFCP_ERP_STEP_LUN_CLOSING:
^~~~
Signed-off-by: Steffen Maier
Reviewed-by: Benjami
zfcp_erp_thread_setup() update complements v2.6.32 commit 347c6a965dc1
("[SCSI] zfcp: Use kthread API for zfcp erp thread").
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
" in
zfcp_erp_strategy() to "result". This avoids confusion with other
compile unit variables "retval" having different semantics and type.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 124 +--
nce the remainder of zfcp does use the term
"trace tag". Also "id" is quite generic and it's not obvious for what.
Just unify it consistently and use the "dbf" prefix to relate the arguments
to the code in zfcp_dbf.*.
Signed-off-by
.h, we have to move enum zfcp_erp_act_type from
its private definition in zfcp_erp.c to the zfcp-global zfcp_def.h.
Silence one false -Wswitch compiler warning case: LUNs as the leaves in our
object tree do not have any follow-up success recovery.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 31b3e2bb3b42..572debf2f528 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers
While struct zfcp_adapter contains a pointer to zfcp_reqlist,
the pointer field does not need to know the structure or even a prototype.
The prototype was introduced with v2.6.34 commit b6bd2fb92a7b ("[SCSI]
zfcp: Move FSF request tracking code to new file").
Signed-off-by: Ste
4 bytes hole, try to pack */
struct fsf_qtcb * qtcb; /* 144 8 */
...
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 8
drivers/s390/scsi/zfcp_dbf.h | 4 ++--
drivers/s390/scsi/zfcp_def
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_fsf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions
* qtcb; /* 144 8 */
void * data; /* 152 8 */
...
/* size: 288, cachelines: 2, members: 13 */
/* sum members: 284, holes: 1, sum holes: 4 */
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
c.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_aux.c | 44 +-
drivers/s390/scsi/zfcp_fc.c | 46 ++--
2 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/drivers
Have structures just before the structures that use them
(without disrupting sequences of using structures such as
zfcp_unit and zfcp_scsi_dev):
- zfcp_adapter_mempool embedded in zfcp_adapter,
- zfcp_latenc... embedded in zfcp_scsi_dev.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
In contrast to struct fsf_qual_latency_info, the ones here are not FSF
but software defined zfcp-internal.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 14 +++---
drivers/s390/scsi/zfcp_fsf.c | 4 ++--
2 files changed, 9 insertions(+), 9
]
Signed-off-by: Steffen Maier
---
drivers/s390/scsi/zfcp_aux.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
index 08cdc00e8299..8818a3a290f6 100644
--- a/drivers/s390/scsi/zfcp_aux.c
+++ b/dr
.
Signed-off-by: Steffen Maier
Co-developed-by: Fedor Loshakov
Signed-off-by: Fedor Loshakov
Reviewed-by: Jens Remus
---
drivers/s390/scsi/zfcp_aux.c | 3 +++
drivers/s390/scsi/zfcp_ext.h | 1 +
drivers/s390/scsi/zfcp_scsi.c | 10 +++---
3 files changed, 11 insertions(+), 3 deletions
IU
FCP rsp IU len : 32 FCP_RSP IU length
Payload time : ...
FCP rsp IU all : 0100 full FCP_RSP IU
0008 full FCP_RSP IU
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
are meanwhile
more speeds.
Clarify comment on fsf_qtcb_bottom_port.supported_speed and add a comment
to fsf_qtcb_bottom_config.fc_link_speed.
Signed-off-by: Jens Remus
Reviewed-by: Steffen Maier
Reviewed-by: Fedor Loshakov
Acked-by: Benjamin Block
Acked-by: Hendrik Brueckner
Signed-off-by
;82af1024>]
process_one_work+0x1dc/0x6f8
Last Breaking-Event-Address:
[<009d0ade>] zfcp_dbf_rec_trig+0x16e/0x188
---[ end trace b2f4020572e2c124 ]---
Suggested-by: Steffen Maier
Signed-off-by: Jens Remus
Reviewed-by: Benjamin Block
Reviewed-by: Steffen Maier
Signed-off-by: Steffen
1e547f7523 ("[SCSI] zfcp: Post
events through FC transport class").
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_fc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.
nvalid value, common code returns EINVAL without invoking
our callback:
$ echo foo > /sys/class/scsi_host/host/host_reset
-bash: echo: write error: Invalid argument
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 11 +++
drivers/s390/sc
From: Jens Remus
Add port speed capabilities as defined in FC-LS RPSC ELS that have a
counterpart FC_PORTSPEED_* defined in scsi/scsi_transport_fc.h.
Suggested-by: Steffen Maier
Signed-off-by: Jens Remus
Reviewed-by: Steffen Maier
Reviewed-by: Fedor Loshakov
Acked-by: Hendrik Brueckner
Simplify its signature to return boolean and rename it to
zfcp_erp_action_is_running() to indicate its actual unmodified semantics.
It has always been used like this since v2.6.0 history commit ea127f975424
("[PATCH] s390 (7/7): zfcp host adapter.").
Signed-off-by: Steffen Maier
R
r and use the more
direct req->adapter as elsewhere in this function already.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
Notes:
Changes since RFC:
Since the FCP channel always requires a valid LUN handle,
we now use scsi_device as context data with any
bute to sysfs").
SCSI rport setter for dev_loss_tmo was introduced with v2.6.18
commit 338151e06608 ("[SCSI] zfcp: make use of fc_remote_port_delete when
target port is unavailable").
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c
0x...
ERP want : 0x03 ZFCP_ERP_ACTION_REOPEN_PORT_FORCED
ERP need : 0xe0 ZFCP_ERP_ACTION_FAILED
Signed-off-by: Steffen Maier
Cc: #2.6.38+
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 13 +++--
1 file changed, 11 insertions(+
, we only need to delete
a local auto variable which is now the intended argument.
Suggested-by: Hannes Reinecke
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
Notes:
Changes since RFC:
Since the FCP channel always requires a valid LUN handle,
we now use scsi_devic
ed the function return type from int to "enum zfcp_erp_act_state".
ZFCP_ERP_ACTION_READY was never used outside of zfcp_erp_action_exists().
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/dr
Since v2.6.27 commit 553448f6c483 ("[SCSI] zfcp: Message cleanup"),
none of the callers has been interested any more.
Values were not returned consistently in all ERP trigger functions.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_
supported_mode default to initiator.").
The feature flag was introduced with v2.6.24 commit 5dc2b89e1242
("[SCSI] add supported_mode and active_mode attributes to the host").
So there was no release where zfcp would have shown "unknown".
Signed-off-by: Steffen Maier
Rev
the work item, we can simply use
the other way to get an rport pointer.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
Notes:
Changes since RFC:
For consistency renamed from "zfcp: use fc_block_rport for TMFs and
host reset to decouple from scsi_cmnd"
...
Ready count: 0x...
Running count : 0x...
ERP want : 0x0. ZFCP_ERP_ACTION_REOPEN_...
ERP need : 0xe0 ZFCP_ERP_ACTION_FAILED
Signed-off-by: Steffen Maier
Cc: #2.6.38+
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 79
as argument and field from the trace.
This patch here is for tracing. A fix to allow LUN recovery in the case at
hand is a topic for a separate patch.
See also commit fdbd1c5e27da ("[SCSI] zfcp: Allow running unit/LUN shutdown
without acquiring reference") for a similar case and back
ZFCP_ERP_ACTION_NONE
Signed-off-by: Steffen Maier
Cc: #2.6.38+
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c
index 20fe59300d0e..69dfb328dba4 100644
--- a/drivers
s=0-255 flags=0x4 nice=0 active=1/1
in-flight: 2193:zfcp_scsi_rport_work [zfcp]
pool 512: cpus=0-255 flags=0x4 nice=0 hung=0s workers=4 idle: 5 2354 2311
Work items with adapter scope are already identified by the workqueue name
"zfcp_q_" and the work item function name.
Signed-of
on a scsi_device and derived objects.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
Notes:
Changes since RFC:
Since the FCP channel always requires a valid LUN handle,
we now use scsi_device as context data with any TMF instead of
zfcp_port for FCP_TMF_TGT_RESE
In zfcp_fsf_fcp_task_mgmt() resolve the still old argument scsi_cmnd
into scsi_device very early and only depend on scsi_device and derived
objects in the function body.
This prepares to later change the function signature replacing the
scsi_cmnd argument with scsi_device.
Signed-off-by: Steffen
This reverts commit 2443c8b23aea ("[SCSI] zfcp: Merge FCP task management
setup with regular FCP command setup"), because this introduced a
dependency on the unsuitable SCSI command for scsi_eh / TMF.
Signed-off-by: Steffen Maier
Reviewed-by: Hannes Reinecke
Reviewed-by: Benj
lated
FCP rsp inf cod: 0x.. none (invalid)
FCP rsp IU : ...none (invalid)
Signed-off-by: Steffen Maier
Fixes: 63caf367e1c9 ("[SCSI] zfcp: Improve reliability of SCSI eh handlers in
zfcp")
Fixes: af4de36d911a ("[SCSI] zfcp: Block scsi
OPEN_PORT_FORCED
ERP need : 0xc0 ZFCP_ERP_ACTION_NONE
Signed-off-by: Steffen Maier
Fixes: 70932935b61e ("[SCSI] zfcp: Fix oops when port disappears")
Cc: #2.6.38+
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 20
drivers/s390/scsi
ded single SUCCESS return path.
Signed-off-by: Steffen Maier
Fixes: a1dbfddd02d2 ("[SCSI] zfcp: Pass return code from fc_block_scsi_eh to
scsi eh")
Cc: #2.6.38+
Reviewed-by: Jens Remus
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 40 ++
5-25 are small cleanups / updates.
Jens Remus (3):
zfcp: assert that the ERP lock is held when tracing a recovery trigger
zfcp: add port speed capabilities
zfcp: enhance comments on fc_link_speed and supported_speed
Steffen Maier (22):
zfcp: fix missing SCSI trace for result of eh_host_reset
://www.ibm.com/support/knowledgecenter/ST3FR7_8.1.2/com.ibm.storwize.v7000.812.doc/svc_zs_statechange_3fgeri.html
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koede
d rport during rport
gone")
Cc: # 2.6.32+
Reviewed-by: Benjamin Block
Signed-off-by: Steffen Maier
---
James, Martin,
this is an important zfcp regression fix.
It would be nice if it could make it into 4.17-rcX.
The patch applies to James' fixes branch or Martin
l cause problems if the secure erase takes
longer than max_retries * scmd_tmo. I.e. the command timing out by
default after 180 seconds as in
https://www.spinics.net/lists/linux-block/msg24837.html ?
The fix approach here seems to also handle this gracefully.
--
Mit freundlichen Grüßen / Kind reg
d format'')
v2.6.31 commit f3948f8857ef (``blktrace: fix context-info when
mixed-using blk tracer and trace events'')
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufs
msg24691.html
("[PATCH v2 1/2] tracing/events: block: track and print if unplug was
explicit or schedule")
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederi
so I added another sleep hack:
# dd closing SCSI disk causes implicit TUR also being delayed once
+# sleep over time window where READ was done and TUR not yet queued
+sleep 2
while grep -q -F "in_use_bm BUSY:"
"/proc/scsi/scsi_debug/${SCSI_DEB
Signed-off-by: Steffen Maier
---
tests/scsi/004 | 59
tests/scsi/004.out |3 ++
2 files changed, 62 insertions(+), 0 deletions(-)
create mode 100755 tests/scsi/004
create mode 100644 tests/scsi/004.out
diff --git a/tests/scsi/004
On 03/08/2018 12:07 PM, Menion wrote:
Unfortunately the Ubuntu kernel is not configured for ftrace or
kprobe, and I am operating this server so I am not sure if I will
eventually find the time and the risk to install a self-compiled
kernel
systemtap?
to use READ
CAPACITY(16).
[ 348.134002] sd 0:0:0:0: [sda] Very big device. Trying to use READ
CAPACITY(16).
[ 657.963478] sd 0:0:0:0: [sda] Very big device. Trying to use READ
CAPACITY(16).
2018-03-07 18:14 GMT+01:00 Douglas Gilbert :
On 2018-03-07 09:02 AM, Menion wrote:
2018-03-07 14:51
just
guessing as I'm not familiar with USB
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On 02/02/2018 05:00 PM, Hannes Reinecke wrote:
On 01/26/2018 05:54 PM, Steffen Maier wrote:
On 12/18/2017 09:31 AM, Hannes Reinecke wrote:
On 12/15/2017 07:08 PM, Steffen Maier wrote:
On 12/14/2017 11:11 AM, Hannes Reinecke wrote:
To me, this raises the question which properties of the
tch set?
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttga
On 01/26/2018 03:15 PM, Steffen Maier wrote:
On 12/18/2017 08:48 AM, Hannes Reinecke wrote:
On 12/15/2017 07:17 PM, Steffen Maier wrote:
On 12/14/2017 11:11 AM, Hannes Reinecke wrote:
@@ -524,10 +532,16 @@ static void virtio_scsi_init_hdr(struct
virtio_device *vdev,
int
On 12/18/2017 09:31 AM, Hannes Reinecke wrote:
On 12/15/2017 07:08 PM, Steffen Maier wrote:
On 12/14/2017 11:11 AM, Hannes Reinecke wrote:
When a device announces an 'FC' protocol we should be pulling
in the FC transport class to have the rports etc setup correctly.
It took some t
1 - 100 of 223 matches
Mail list logo
