[PATCH v2] target: remove initiatorname field in se_acl_lun

2015-08-13 Thread Spencer Baugh
From: Chris Zankel The initiatorname field in se_acl_lun is only a copy of the same field in se_node_acl, so remove it and use the version in se_node_acl where needed (it's actually only used for pr_debug) Signed-off-by: Chris Zankel Signed-off-by: Spencer Baugh --- drivers/t

[PATCH v2] target: remove unused lun_flags field from se_lun

2015-08-13 Thread Spencer Baugh
From: Chris Zankel The lun_flags field is not used, so drop it. Signed-off-by: Chris Zankel Signed-off-by: Spencer Baugh --- include/target/target_core_base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index

[PATCH v2] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-13 Thread Spencer Baugh
rather than return an error. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c

[PATCH] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-12 Thread Spencer Baugh
rather than return an error. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 36

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-23 Thread Spencer Baugh
b in there as soon as possible. At a later point t_task_cdb is reset to the correct buffer, but until then traces and printks don't cause a crash. Signed-off-by: Alexei Potashnik Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c| 4 ++-- drivers/target/target_cor

Re: [PATCH v3] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. v2: Get correct values for logging v3: Fix whitespace damage Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers

[PATCH v2] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. v2: Get correct values for logging Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/iscsi/

[PATCH] qla2xxx: remove unused rval

2015-07-22 Thread Spencer Baugh
From: Joern Engel We don't touch the return value of qla2x00_loop_resync in qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length

2015-07-22 Thread Spencer Baugh
From: Roland Dreier Solaris seems to go beserk if we respond to REPORT LUNS with a LUN LIST LENGTH of 0. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/target/target_core_spc.c

[PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c | 18 +---

[PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-22 Thread Spencer Baugh
ands. The Windows compliance test sends them. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transpo

[PATCH] target: improve unsupported opcode message

2015-07-22 Thread Spencer Baugh
From: Joern Engel Make the warning about unsupported SCSI opcode more useful: - Add in the initiator name so we know who's sending it. - Print the warning even for opcodes that spc_parse_cdb() knows about but that we don't handle. Signed-off-by: Joern Engel Signed-off-by: Spe

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
Please disregard, depends on another patch. Will send again later. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
b in there as soon as possible. At a later point t_task_cdb is reset to the correct buffer, but until then traces and printks don't cause a crash. Signed-off-by: Alexei Potashnik Signed-off-by: Spencer Baugh --- drivers/target/target_core_device.c| 7 +++ drivers/target/target_co

[PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Spencer Baugh
From: Dilip Kumar Uppugandla Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. Signed-off-by: Dilip Kumar Uppugandla Signed-off-by: Spencer Baugh --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6

[PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-21 Thread Spencer Baugh
Potashnik Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index a4cf58c..ebb1ece 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b

[PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-21 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 33 + 1 file changed, 33

Re: [PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-21 Thread Spencer Baugh
Christoph Hellwig writes: > Looks good, > > but what's up with your From lines: > > On Mon, Jul 20, 2015 at 04:29:49PM -0700, Spencer Baugh wrote: >> From: Spencer Baugh >> >> From: Chris Zankel > > plus another address for you in the actual ema

[PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-20 Thread Spencer Baugh
From: Alexei Potashnik Current implementation assumes that all the buffers of an IO are linked with a single SG list. Which makes it fail if SG chaining is used. Signed-off-by: Alexei Potashnik --- drivers/target/iscsi/iscsi_target.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(

[PATCH 2/2] target: remove initiatorname field in se_acl_lun

2015-07-20 Thread Spencer Baugh
From: Spencer Baugh From: Chris Zankel The initiatorname field in se_acl_lun is only a copy of the same field in se_node_acl, so remove it and use the version in se_node_acl where needed (it's actually only used for pr_debug) Signed-off-by: Chris Zankel --- drivers/t

[PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-20 Thread Spencer Baugh
From: Spencer Baugh From: Chris Zankel The lun_flags field is not used, so drop it. Signed-off-by: Chris Zankel --- include/target/target_core_base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 17ae2d6