Re: BUG and Oops while trying to issue a discard to LVM on RAID1 md

2016-10-05 Thread Sitsofe Wheeler
On 5 October 2016 at 16:04, Sitsofe Wheeler wrote: > On 4 October 2016 at 07:20, Sitsofe Wheeler wrote: >> On 4 October 2016 at 07:17, Sitsofe Wheeler wrote: >>> While trying to do a discard inside an ESXi 6 VM to an LVM device atop >>> an md RAID1 device composed of

Re: BUG and Oops while trying to issue a discard to LVM on RAID1 md

2016-10-05 Thread Sitsofe Wheeler
On 4 October 2016 at 07:20, Sitsofe Wheeler wrote: > On 4 October 2016 at 07:17, Sitsofe Wheeler wrote: >> While trying to do a discard inside an ESXi 6 VM to an LVM device atop >> an md RAID1 device composed of two SATA SSDs passed up as a raw disk >> mappings through a PV

Re: BUG and Oops while trying to issue a discard to LVM on RAID1 md

2016-10-03 Thread Sitsofe Wheeler
On 4 October 2016 at 07:17, Sitsofe Wheeler wrote: > While trying to do a discard inside an ESXi 6 VM to an LVM device atop > an md RAID1 device composed of two SATA SSDs passed up as a raw disk > mappings through a PVSCSI controller, this BUG followed by an Oops was > hit: >

BUG and Oops while trying to issue a discard to LVM on RAID1 md

2016-10-03 Thread Sitsofe Wheeler
While trying to do a discard inside an ESXi 6 VM to an LVM device atop an md RAID1 device composed of two SATA SSDs passed up as a raw disk mappings through a PVSCSI controller, this BUG followed by an Oops was hit: [ 86.902888] [ cut here ] [ 86.904600] kernel BUG at a

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-06-15 Thread Sitsofe Wheeler
On Wed, Jun 15, 2016 at 06:17:37PM +, Arvind Kumar wrote: > It is possibly some race. We saw a WRITE SAME related issue in past > for which Petr sent out a patch but looks like the patch didn't make > it. :( > > https://groups.google.com/forum/#!topic/linux.kernel/1WGDSlyY0y0 Indeed - the inv

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-31 Thread Sitsofe Wheeler
On 27 May 2016 at 10:30, Tom Yan wrote: > There seems to be some sort of race condition between > blkdev_issue_zeroout() and the scsi disk driver (disabling write same > after an illegal request). On my UAS drive, sometimes `blkdiscard -z > /dev/sdX` will return right away, even though if I then c

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-26 Thread Sitsofe Wheeler
On 27 May 2016 at 05:18, Darrick J. Wong wrote: > > It's possible that the pvscsi device advertised WRITE SAME, but if the device > sends back ILLEGAL REQUEST then the SCSI disk driver will set > write_same_max_bytes=0. Subsequent BLKZEROOUT attempts will then issue writes > of zeroes to the driv

BLKZEROOUT not zeroing md dev on VMDK

2016-05-18 Thread Sitsofe Wheeler
Hi, With Ubuntu's 4.4.0-22-generic kernel and a Fedora 23 4.6.0-1.vanilla.knurd.1.fc23.x86_64 kernel I've found that the BLKZEROOUT syscall can malfunction and not zero data. When BLKZEROOUT is issued to an MD device atop a PVSCSI controller supplied VMDK from ESXi 6.0 the call returns immediatel

Re: [PATCH] scsi:storvsc enable reading from VPD pages on SPC-2

2014-12-11 Thread Sitsofe Wheeler
On Wed, Dec 10, 2014 at 11:30:30PM +, KY Srinivasan wrote: > > > > > > > + {"Msft", "Virtual Disk", "1.0", BLIST_TRY_VPD_PAGES}, > > > > > > Is that version field meaningful or is it safe for us to inquire about > > > VPD pages without problems on older versions? > > > > This version is used

Re: [PATCH] scsi:storvsc enable reading from VPD pages on SPC-2

2014-12-10 Thread Sitsofe Wheeler
On Wed, Dec 10, 2014 at 12:38:25AM -0800, Long Li wrote: > MSFT targets currently claim SPC-2 compliance while they implement > post SPC-2 features. With this patch we can correctly handle > WRITE_SAME_16 issues. > > This patch fixes an issue where the flag is setup too late in drive > initializat

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-23 Thread Sitsofe Wheeler
On 23 October 2014 02:50, Martin K. Petersen wrote: >>>>>> "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> 2. On top of the above, when a disk is "small" (has less than > Sitsofe>2^32 sectors which is typically < 2 TBytes in

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Sitsofe Wheeler
On Sun, Oct 12, 2014 at 01:21:01AM +, KY Srinivasan wrote: > > > -Original Message- > > From: Jeff Leung [mailto:jle...@v10networks.ca] > > Sent: Saturday, October 11, 2014 1:22 PM > > > > > On the current release of Windows (windows 10), we are advertising > > > SPC3 compliance. > >

Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag

2014-10-20 Thread Sitsofe Wheeler
On Tue, Oct 14, 2014 at 09:08:28PM -0400, Martin K. Petersen wrote: > >>>>> "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Microsoft Hyper-V virtual disks currently only claim SPC-2 > Sitsofe> compliance causing the kernel skip checks for feature

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Sitsofe Wheeler
On Tue, Oct 14, 2014 at 09:06:37PM -0400, Martin K. Petersen wrote: > >>>>> "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> A previous patch attempted to add a quirk to workaround this > Sitsofe> but the quirk was only enabled after the features had

[PATCH 3/3] scsi: Use try_rc16 and try_vpd_pages quirks on Hyper-V virtual disks

2014-10-10 Thread Sitsofe Wheeler
impacts Hyper-V's VHD/VHDX virtual disks and not passthrough devices. Signed-off-by: Sitsofe Wheeler --- drivers/scsi/scsi_devinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 49014a1..3eadcb1 100644 --- a/drivers

[PATCH 2/3] scsi: add try_rc16 blacklist flag

2014-10-10 Thread Sitsofe Wheeler
: Sitsofe Wheeler --- drivers/scsi/scsi_scan.c| 3 +++ drivers/scsi/sd.c | 3 +++ include/scsi/scsi_device.h | 1 + include/scsi/scsi_devinfo.h | 1 + 4 files changed, 8 insertions(+) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index ba3f1e8..d3f6267 100644 --- a

[PATCH 1/3] Revert "Drivers: add blist flags"

2014-10-10 Thread Sitsofe Wheeler
This reverts commit f3cfabce7a2e92564d380de3aad4b43901fb7ae6 (Drivers: add blist flags) as it does not enable thin provisioning for my Hyper-V 2012 R2 virtual disks. Signed-off-by: Sitsofe Wheeler --- drivers/scsi/storvsc_drv.c | 10 -- 1 file changed, 10 deletions(-) diff --git a

[PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-10 Thread Sitsofe Wheeler
r to only Hyper-V virtual disks and work on small virtual disks. Sitsofe Wheeler (3): Revert "Drivers: add blist flags" scsi: add try_rc16 blacklist flag scsi: Use try_rc16 and try_vpd_pages quirks on Hyper-V virtual disks drivers/scsi/scsi_devinfo.c | 1 + drivers/scsi/scsi_sc

Re: [PATCH 1/1] Drivers: scsi: storvsc: Get rid of warning messages

2014-09-05 Thread Sitsofe Wheeler
On Thu, Sep 04, 2014 at 10:40:14PM -0700, Christoph Hellwig wrote: > Looks good to me. > > Olaf, Hannes - can I get another review for this (and the older hyperv > scanning patch set)? I agree this looks useful because on a 59753a805499f1ffbca4ac0a24b3dff67bf1 3.17rc2 kernel with 92578ea Dri

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-08-01 Thread Sitsofe Wheeler
while they implement post SPC-2 features. > >With this patch we can correctly handle WRITE_SAME_16 issues. > > > >Signed-off-by: K. Y. Srinivasan > > > Reviewed-by: Hannes Reinecke On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 a

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 02:09:11PM +, James Bottomley wrote: > On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > > compliance indicated even though they implement post SPC-2 features > &

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 08:35:13AM -0700, Christoph Hellwig wrote: > On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > > I agree - I'd like to pull in KY's simple fix as soon as I get a second > > review for it. > > Ok, looks like I just got that from Hannes. Let's see if there

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > >>>>> "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Fix incorrectly named variable. Some block devices (such as > Sitsofe> Hyper-V passthrough SSDs) support logical block provisi

Re: [PATCH 0/3] Enable discard on Hyper-V

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 08:47:39AM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: &g

[PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
ng tests. Signed-off-by: Sitsofe Wheeler --- drivers/scsi/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 8249e51..8bf34bc 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2559,7 +2559,7 @@ static void sd_read_bloc

[PATCH 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
Some block devices (such as Hyper-V passthrough SSDs) support logical block provisioning (e.g. via UNMAP) but don't set lbpme thus disabling discard. If the try_lbp quirk is in use skip lbpme checks that lead up to the logical block provisioning tests. Signed-off-by: Sitsofe Wheeler --- dr

[PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
previous version of this patch and https://lkml.org/lkml/2014/7/23/615 for example devices. Original-patch-by: K. Y. Srinivasan Signed-off-by: Sitsofe Wheeler --- drivers/scsi/storvsc_drv.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c

[PATCH 1/3] [SCSI] Add quirk for forcing logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
blacklist flag that allows the forcing of the paths leading to logical block provisioning tests. See https://lkml.org/lkml/2014/7/13/59 for the previous version. Reported-by: K. Y. Srinivasan Original-patch-by: Martin K. Petersen Signed-off-by: Sitsofe Wheeler --- drivers/scsi/scsi_scan.c

[PATCH 0/3] Enable discard on Hyper-V

2014-07-24 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > > I'm not sure this alone will work - won't sdev_bflags/bf

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > I'm not sure this alone will work - won't sdev_bflags/bflags have > > already been built at this point? > > They've be

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 07:10:14AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote: > > That's good to know (I was worried the device would not be detected as > > supporting discard because it doesn't report lb

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 04:51:28AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 11:04:48AM +0100, Sitsofe Wheeler wrote: > > OK I've just seen this as I was about to post a similar patch to get > > discard going on Hyper-V. Will your patches handle Hyper-V pass

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly