Re: [PATCHv4] fcoe: make use of fip_mode enum complete

On Mon, Feb 18, 2019 at 8:58 AM Sedat Dilek wrote: > > On Fri, Feb 15, 2019 at 6:35 PM Nathan Chancellor > wrote: > > > > On Fri, Feb 15, 2019 at 01:19:20PM +0100, Hannes Reinecke wrote: > > > From: Sedat Dilek > > > > > > commit 1917d42d1

Re: [PATCHv4] fcoe: make use of fip_mode enum complete

On Fri, Feb 15, 2019 at 6:35 PM Nathan Chancellor wrote: > > On Fri, Feb 15, 2019 at 01:19:20PM +0100, Hannes Reinecke wrote: > > From: Sedat Dilek > > > > commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate > > enum for the fip_mode

Re: [PATCH RFC v2] fcoe: make use of fip_mode enum complete

On Fri, Feb 15, 2019 at 8:35 AM Hannes Reinecke wrote: > > On 2/12/19 11:42 PM, Nathan Chancellor wrote: > > On Tue, Feb 12, 2019 at 08:50:04AM +0100, Sedat Dilek wrote: > >> On Mon, Feb 11, 2019 at 6:53 PM Nathan Chancellor > >> wrote: > >>> > >&g

Re: [PATCH RFC v2] fcoe: make use of fip_mode enum complete

On Mon, Feb 11, 2019 at 6:53 PM Nathan Chancellor wrote: > > On Mon, Feb 11, 2019 at 06:07:51PM +0100, Sedat Dilek wrote: > > From: Sedat Dilek > > > > commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate > > enum for the fip_mode

[PATCH RFC v2] fcoe: make use of fip_mode enum complete

From: Sedat Dilek commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate enum for the fip_mode that shall be used during initialisation handling until it is passed to fcoe_ctrl_link_up to set the initial fip_state. That change was incomplete and gcc quietly co

Re: [PATCH] fcoe: make use of fip_mode enum complete

Hi Lukas, I have tested your patch with LLVM/Clang from Git (will get version 9) with (RFC) asm-goto support. I was able to build with CONFIG_FCOE=m and CONFIG_LIBFCOE=m and boot on bare metal. Feel free to add my... Tested-by: Sedat Dilek If you want to send out a v2 please feel free