Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-06 Thread Scott Bauer
On Tue, Jun 06, 2017 at 11:59:55AM +0200, Christoph Hellwig wrote: > On Mon, Jun 05, 2017 at 03:15:31PM -0600, Scott Bauer wrote: > > I'm not familiar at all with ATA, but I noticed there was no unlock from > > suspend support > > in the series. Does ATA not have a

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-05 Thread Scott Bauer
On Sun, Jun 04, 2017 at 02:42:25PM +0200, Christoph Hellwig wrote: > Just wire up the generic TCG OPAL infrastructure to the SCSI disk driver > and the Security In/Out commands. > > Note that I don't know of any actual SCSI disks that do support TCG OPAL, > but this is required to support ATA disk

Re: [PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free

2017-05-04 Thread Scott Bauer
On Thu, May 04, 2017 at 03:32:44PM +, Bart Van Assche wrote: > On Thu, 2017-05-04 at 09:15 -0600, Scott Bauer wrote: > > On Thu, May 04, 2017 at 03:26:37PM +, Bart Van Assche wrote: > > > On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote: > > > > Ple

Re: [PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free

2017-05-04 Thread Scott Bauer
On Thu, May 04, 2017 at 03:26:37PM +, Bart Van Assche wrote: > On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote: > > Please just add a flag to ->flags instead of adding a whole new field. > > > > Otherwise this looks good to me. > > Hello Christoph, > > Thanks for the feedback. I w

Re: [PATCH] Avoid that scsi_exit_rq() triggers a use-after-free

2017-05-02 Thread Scott Bauer
fff8802b7fedf00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ^ > ffff8802b7fedf80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > 8802b7fee000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ======

BUG: KASAN: use-after-free in scsi_exit_rq

2017-04-20 Thread Scott Bauer
Hi all, While running xfs test testing some other features scheduled for 4.12 I came across this KASAN dump: [ 638.913813] XFS (nvme0n1): Mounting V5 Filesystem [ 638.917934] XFS (nvme0n1): Ending clean mount [ 639.035070] blk_update_request: I/O error, dev nvme1n1, sector 0 [ 639.071764] XF