ng
up these warnings.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Acked-by: Eric Moore <[EMAIL PROTECTED]>
---
[ Had not copied Andrew and linux-scsi@ last time,
don't yet see this in any of the SCSI git trees. ]
drivers/message/fusion/mptctl.c |8 +++-
1 file
On Sun, 2 Sep 2007, Jeff Garzik wrote:
> Satyam Sharma wrote:
> > drivers/scsi/ips.c: In function ‘ips_register_scsi’:
> > drivers/scsi/ips.c:6869:
> > warning: ignoring return value of ‘scsi_add_host’, declared with attribute
> > warn_unused_result
> >
> &
On Sun, 2 Sep 2007, Jeff Garzik wrote:
>
> Satyam Sharma wrote:
> > drivers/scsi/dc395x.c: In function ‘dc395x_init_one’:
> > drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this
> > function
> >
> > has been verified to
drivers/scsi/dc395x.c: In function ‘dc395x_init_one’:
drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this
function
has been verified to be a bogus warning. Let's shut it up.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
drivers/scsi/dc395x.c |2
drivers/scsi/ips.c: In function ‘ips_register_scsi’:
drivers/scsi/ips.c:6869:
warning: ignoring return value of ‘scsi_add_host’, declared with attribute
warn_unused_result
scsi_add_host() is __must_check, so let's check it's return and cleanup
appropriately on errors.
Signed-off-
Hi Jiri,
On Tue, 28 Aug 2007, Jiri Slaby wrote:
> Andrew Morton napsal(a):
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/
>
> I got this during gxine initialization of ocko.tv live stream without any cd
> in
> cdroms:
Yup, that's an old habit of h
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:
> The SCSI Tape driver uses a semaphore as mutex. Use the mutex API
> instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]>
-
To unsubscr
f (down_interruptible(&STp->lock))
> + if (mutex_lock_interruptible(&STp->lock))
> return (-ERESTARTSYS);
Same here.
Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
CONFIG_BLK_DEV_BSG=y
CONFIG_SCSI=m
block/built-in.o: In function `bsg_init':
block/bsg.c:1097: undefined reference to `scsi_register_interface'
make: *** [.tmp_vmlinux1] Error 1
on latest -git.
Satyam
-
To unsubscribe from this list: send
On 5/18/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
On Fri, May 18, 2007 at 10:58:05AM +0530, Satyam Sharma wrote:
> [ BTW, this is the last time I'll try explaining this to you. ]
Oh good. Perhaps you can just drop the idea entirely and give up?
Well, I do plan to, at l
On 5/18/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
On Thu, May 17, 2007 at 03:43:26PM -0400, Benjamin LaHaise wrote:
> On Thu, May 17, 2007 at 01:39:54PM -0600, Matthew Wilcox wrote:
> > On Fri, May 18, 2007 at 12:34:40AM +0530, Satyam Sharma wrote:
> > > Hmmm, ac
On Thu, May 17, 2007 at 01:39:54PM -0600, Matthew Wilcox wrote:
> On Fri, May 18, 2007 at 12:34:40AM +0530, Satyam Sharma wrote:
> > Hmmm, actually those other users could easily write and maintain
> > a 20-line patch that does the wait for async scans thing for them
> > usi
On 5/18/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
On Fri, May 18, 2007 at 12:17:40AM +0530, Satyam Sharma wrote:
> However, Ben does have a point that we shouldn't force those
> using SCSI (and wishing to use the new async scanning
> feature) to depend on and use s
Hi Christoph,
On 5/17/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
On Thu, May 17, 2007 at 11:11:10PM +0530, Satyam Sharma wrote:
> Another command to /proc/scsi/scsi isn't a bad thought at all, considering
Yes it is. /proc/scsi/scsi is a horrible interface and deprecated s
On 5/17/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
On Thu, May 17, 2007 at 10:43:06PM +0530, Satyam Sharma wrote:
> >No, it does matter. Your suggestion doesn't work, because
> >/sys/module/scsi_mod/parameters/ belongs to the module code. To create
> >a new
head of copying / installing at modules_install time.
You're claiming that 0.7 second (I just timed it on a 3 year old
laptop) *inconveniences* you?
...
On 5/16/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
OK, I'll get really silly here myself. ...
...
On 5/16/07, Satyam
On 5/17/07, James Bottomley <[EMAIL PROTECTED]> wrote:
[...]
Please don't bother ... I really want a more considered way of fixing
this. If everyone decides the best way is exposing this to the user,
then this is the way to do it ... however, I still don't consider this
argument made out yet.
On 5/16/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
>> > >semantics of it (read-only? read-write? write-only?
>
> Well, it _has_ to be write, don't really care if it's read-write or
> write-only. I would still prefer read-write,
Hi,
[ I appreciate you forked the thread and gave it a better subject name,
it would be better still if you could maintain the original CC list, thanks. ]
On Tue, May 15, 2007 at 12:26:29PM +0100, Simon Arlott wrote:
I've already suggested a sysfs attribute - or something equivalent - would
be
On 5/14/07, James Bottomley <[EMAIL PROTECTED]> wrote:
On Mon, 2007-05-14 at 17:53 +0530, Satyam Sharma wrote:
> > I guess this is probably the behaviour that James wanted originally?
No ... you're still not reading the explanation in the thread:
The wait scan module is des
boot-up), it would not be possible to
do so. But if someone really wants that, let me know, we can
add a depends, tristate "..." and help in this Kconfig option to
accomplish that too. ]
This has sadly become a one-person thread, but Robert informs
me in private mail that we can f
ow, we can
add a depends, tristate "..." and help in this Kconfig option to
accomplish that too. ]
Thanks,
Satyam
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig |5 +++--
drivers/scsi/scsi_scan.c |5 +
2 files changed, 4 insertions(+), 6 dele
On 5/14/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
[...]
config SCSI_WAIT_SCAN
tristate
- default m
- depends on SCSI
- depends on MODULES
+ default m if SCSI=m
+ default n
Note that this also means SCSI_WAIT_SCAN=n (will not get compiled
and buil
t
explicitly) would be as follows:
---
Clean up Kconfig entry for CONFIG_SCSI_WAIT_SCAN.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
---
diff -ruNp a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/
drivers/scsi/aic7xxx_old.c:aic7xxx_slave_alloc() unnecessarily passes
GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not
atomic. Remove the pointless GFP_ATOMIC.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
diff -ruNp linux-2.6.21.1/driver
On 5/4/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
[...]
>
> - aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL);
> + aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC);
No, this converts the allocation from a robust one which can sleep into a
flakey one which ca
26 matches
Mail list logo
