[PATCH] scsi: eata: drop EATA and EATA-PIO drivers

2018-03-14 Thread Salvatore Mesoraca
Remove support for EATA and EATA-PIO SCSI host adapters. These devices are ancient and, apparently, nobody is still using them. https://lkml.kernel.org/r/20180313090540.GA4810%20()%20infradead%20!%20org Signed-off-by: Salvatore Mesoraca --- Documentation/scsi/scsi-parameters.txt |2

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-13 Thread Salvatore Mesoraca
2018-03-13 10:05 GMT+01:00 Christoph Hellwig : > On Mon, Mar 12, 2018 at 10:35:36PM -0400, Martin K. Petersen wrote: >> No objections to Salvatore's patch but I have a slight affinity for >> retiring unused code over patching it. So unless there are objections... > > Lets kill it. And the not DMA

[PATCH v3] scsi: eata: drop VLAs in reorder()

2018-03-12 Thread Salvatore Mesoraca
Avoid 3 VLAs[1] by using a single dinamically allocated array and some helper variables: we don't need 3 arrays. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- drivers/scsi/eata.c | 40 ++-- 1 file changed, 26 insertions(+

Re: [PATCH v2] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Salvatore Mesoraca
2018-03-12 13:48 GMT+01:00 Salvatore Mesoraca : > Avoid 3 VLAs[1] by using a single dinamically allocated array > and some helper variables: we don't need 3 arrays. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca > --- &

[PATCH v2] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Salvatore Mesoraca
Avoid 3 VLAs[1] by using a single dinamically allocated array and some helper variables: we don't need 3 arrays. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- drivers/scsi/eata.c | 40 ++-- 1 file changed, 26 insertions(+

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Salvatore Mesoraca
2018-03-12 4:08 GMT+01:00 Tobin C. Harding : > Adding kernel newbies to CC because I pose a few noob questions :) > Adding Linus to CC because I quoted him. > > On Sun, Mar 11, 2018 at 10:06:58PM +0100, Salvatore Mesoraca wrote: >> n_ready will always be less than or equal to MA

[PATCH] scsi: eata: drop VLA in reorder()

2018-03-11 Thread Salvatore Mesoraca
n_ready will always be less than or equal to MAX_MAILBOXES. So we avoid a VLA[1] and use fixed-length arrays instead. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- drivers/scsi/eata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers