Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

2017-03-08 Thread Peter Senna Tschudin
igned-off-by: Romain Perier > > Acked-by: Peter Senna Tschudin > > Tested-by: Peter Senna Tschudin > > --- > >  drivers/net/ethernet/intel/e100.c | 12 ++-- > >  1 file changed, 6 insertions(+), 6 deletions(-) > > Acked-by: Jeff Kirsher > > My onl

Re: [PATCH v3 12/20] scsi: mpt3sas: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:17PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > dr

Re: [PATCH v3 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:16PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > dri

Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:22PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > driv

Re: [PATCH v3 13/20] scsi: mvsas: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:18PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- >

Re: [PATCH v3 10/20] scsi: lpfc: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:15PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. It also updates > some comments, accordingly. > Reviewed-by: Peter Senna Tschudin >

Re: [PATCH v3 19/20] PCI: Remove PCI pool macro functions

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:24PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > include/linux/pci.h | 9 - &g

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Peter Senna Tschudin
hes did sent some comments for this one, did you address them? Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > scripts/checkpatch.pl | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpat

Re: [PATCH v3 18/20] usb: host: Remove remaining pci_pool in comments

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:23PM +0100, Romain Perier wrote: > This replaces remaining occurences of pci_pool by dma_pool, as > this is the new API that could be used for that purpose. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > drivers/u

Re: [PATCH v3 07/20] wireless: ipw2200: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:12PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > dr

Re: [PATCH v3 00/20] Replace PCI pool by DMA pool API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:05PM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriated dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly a

Re: [PATCH v3 09/20] scsi: csiostor: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > drivers/scsi/csiostor/csio_hw.h | 2 +- > drivers/scsi/csiostor/csio_init.c | 11 ++- > drivers/scsi/csiostor/csio_scsi.c | 6 +++--- > 3 files changed, 10 insertions(+), 9 deletions(-) > >

Re: [PATCH v3 06/20] mlx5: Replace PCI pool old API

2017-02-27 Thread Peter Senna Tschudin
On Sun, Feb 26, 2017 at 08:24:11PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Romain Perier > --- > dr

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier > --- > drivers/scsi/megaraid

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier > --- > driv

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if the

Re: [RFC v2 01/20] block: DAC960: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
Acked-by: Peter Senna Tschudin > Tested-by: Peter Senna Tschudin > --- > drivers/block/DAC960.c | 36 ++-- > drivers/block/DAC960.h | 4 ++-- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/drivers/block/DAC960.c b/dr

Re: [RFC 10/19] scsi: lpfc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/lpfc/lpfc.h | 10 +++ > drivers/scsi/lp

Re: [RFC 03/19] IB/mthca: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Ts

Re: [RFC 11/19] scsi: megaraid: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/megaraid/megaraid_mbox.c | 30 ++--

Re: [RFC 14/19] scsi: pmcraid: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > pci_pool_*() functions should be replaced by the corresponding functions > in the DMA pool API. This adds support to check for use of these pci > functions and display a warning when it is the case. Don't know if relevant, but did no

Re: [RFC 00/19] Replace PCI pool by DMA pool API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote: Hi Romain, Nice set of patches! Thank you. I sent a few comments, but basically you missed to run checkpatch.pl on your patches. Also you can take the chance to fix some white space issues that are on the lines you are changing like s

Re: [RFC 05/19] mlx4: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin &g

Re: [RFC 04/19] net: e100: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin &g

Re: [RFC 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

Re: [RFC 17/19] usb: gadget: pch_udc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/usb/gadget/udc/pch_udc.c | 28 ++-

Re: [RFC 02/19] dmaengine: pch_dma: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

Re: [RFC 18/19] PCI: Remove PCI pool macro functions

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. Good news: make allyesconfig;make succeed after the changes until this point, but: $ grep -R pci_pool ... drivers/usb/gadget/udc/pch_udc.c:

Re: [RFC 16/19] usb: gadget: net2280: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

Re: [RFC 13/19] scsi: mvsas: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mvsas/mv_init.c | 4 ++-- > drivers/scsi/mvsas/m

Re: [RFC 12/19] scsi: mpt3sas: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 64 > +

Re: [RFC 09/19] scsi: csiostor: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/csiostor/csio_hw.h | 2 +- > drivers/scsi/csio

Re: [RFC 01/19] block: DAC960: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
the patch do not add new ones. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > --- > drivers/block/DAC960.c | 36 ++-- > drivers/block/DAC960.h | 4 ++-- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/dr

Re: [RFC 06/19] mlx5: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 10 +--

Re: [RFC 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

Re: [RFC 07/19] wireless: ipw2200: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 12 ++--

[PATCH 5/11] drivers/scsi/bfa/bfad_bsg.c: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin --- drivers/scsi/bfa/bfad_bsg.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c index

[PATCH 3/11] isci: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin --- drivers/scsi/isci/request.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c

[PATCH 1/5] scsi: Fix assignment of 0/1 to bool variables

2013-09-22 Thread Peter Senna Tschudin
-off-by: Peter Senna Tschudin --- drivers/scsi/csiostor/csio_hw.c|4 ++-- drivers/scsi/cxgbi/libcxgbi.c |4 ++-- drivers/scsi/device_handler/scsi_dh_alua.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff -u -p a/drivers/scsi/cxgbi/libcxgbi.c b

[PATCH 14/19] scsi: Change variable type to bool

2013-09-21 Thread Peter Senna Tschudin
: Peter Senna Tschudin --- drivers/scsi/isci/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c index 13098b0..26f8e5c 100644 --- a/drivers/scsi/isci/port.c +++ b/drivers/scsi/isci/port.c @@ -174,7 +174,7 @@ static void

[PATCH] drivers/target/target_core_configfs.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 6/15] drivers/scsi/pmcraid.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/pmcraid.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c

[PATCH 8/15] drivers/scsi: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/ibmvscsi/ibmvfc.c | 36 ++-- drivers/scsi/ibmvscsi/ibmvstgt.c |2 +- drivers/scsi/qlogicpti.c

[PATCH 2/15] drivers/scsi/bfa: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/bfa/bfa_fcs_lport.c |2 +- drivers/scsi/bfa/bfa_fcs_rport.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 2/10] drivers/scsi/sym53c8xx_2/sym_fw.c: removes unnecessary semicolon

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/sym53c8xx_2/sym_fw.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -u -p a/drivers/scsi/sym53c8xx_2/sym_fw.c