if (cmd->cmnd[0] == REPORT_LUNS)
> + ata_scsi_simulate(dev, cmd, done);
> + else
> + rc = ata_scsi_translate(dev, cmd, done, atapi_xlat);
> + }
>
> return rc;
> }
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi ... did you try James' patch? Looks like the same problem.
Patch here:
http://marc.theaimsgroup.com/?l=linux-scsi&m=112585164819923&w=2
Was hidden within some other thread ...
On Fri, Sep 09, 2005 at 11:17:16PM +0100, Daniel Drake wrote:
> Running a simple "touch /dev/scd0" on a SCSI cdrom w
o scsi_execute
> o convert the remaining mid-layer pieces to scsi_execute_req
The scsi_execute() retries argument is still not used.
How is this going to work?
For example, multiple unit attentions (power on / reset) during scanning.
We send REPORT LUN, READ CAPACITY, etc., and would not retry
Not that your patches are in it, but the scsi-misc tre is at:
http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=summary
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTEC
t leaves LUN 0 available for use via user
space, for compatibility it likely requires that it stay visible in the
future:
http://marc.theaimsgroup.com/?l=linux-scsi&m=111692497200507&w=2
Hannes' patch also causes a lot of extra vSCSI devices to show up on some
platforms :)
S
Just a patch for scanning with PQ == 3 for LUN 0, only for use in testing
previous patch, don't apply.
diff -uprN -X /home/patman/dontdiff scsi-misc-2.6/drivers/scsi/scsi_debug.c
lun0-replun-scsi-misc-2.6/drivers/scsi/scsi_debug.c
--- scsi-misc-2.6/drivers/scsi/scsi_debug.c 2005-07-26 11:08:5
On Wed, Aug 24, 2005 at 04:05:03PM -0400, Luben Tuikov wrote:
> On 08/24/05 13:12, Patrick Mansfield wrote:
> > On Tue, Aug 23, 2005 at 07:55:37PM -0400, Luben Tuikov wrote:
> >
> >>Where does udev get its label?
> >
> >
> > You can call any script or p
t determine the
problem area for a timeout, and if it can or should be retried.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(sdev);
out_reap:
+ if ((lun == 0) && (res == SCSI_SCAN_LUN_IGNORED))
+ scsi_scan_remove(sdev);
/* now determine if the target has any children at all
* and if not, nuke it */
scsi_target_reap(starget);
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
0:0:0/0:0:0:3/power
> ./rport-0:0-0/target0:0:0/0:0:0:3/power/state
> ./rport-0:0-0/target0:0:0/power
> ./rport-0:0-0/target0:0:0/power/state
> ./rport-0:0-0/power
> ./rport-0:0-0/power/state
> ./nvram
> ./fw_dump
> ./power
> ./power/state
>
>
> apparently the
a modifiable list or such under sysfs.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
istent id's. That does not help if you change scsi_device id values,
or (effectively) remove and add back the same scsi_device. dm-mp should
(eventually?) support that scenario - multipath is really 0 or more paths ...
-- Patrick Mansfield
-
To unsubscribe from this list: send the line &qu
+ 3 = 19.
i.e. use port_id as the id (8 digits?) and we are more likely to go above 20.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 22, 2005 at 09:03:03PM -0500, James Bottomley wrote:
> On Mon, 2005-08-22 at 17:39 -0700, Patrick Mansfield wrote:
> > But, we have to pass in a struct kref, to affect put/get_device, correct?
>
> Correct. Let me post the code mods to drivers/base/core.c so you can
>
are:
struct kobject * kobject_get(struct kobject * kobj)
{
if (kobj)
kref_get(&kobj->kref);
return kobj;
}
And then:
void kref_get(struct kref *kref)
{
WARN_ON(!atomic_read(&kref->refcount));
atomic_inc(&kref->refcount);
}
-
On Mon, Aug 22, 2005 at 03:14:27PM -0700, Patrick Mansfield wrote:
> Attached is a test module, it oopsed for me with CONFIG_DEBUG_SLAB, on
> ppc64. I was trying to complete testing of my hack (on current git tree,
> rather than scsi-misc), but have been preempted by other work today.
&g
On Mon, Aug 22, 2005 at 04:59:16PM -0500, James Bottomley wrote:
> On Mon, 2005-08-22 at 14:46 -0700, Patrick Mansfield wrote:
> > Did you test with CONFIG_DEBUG_SLAB enabled?
>
> Yes, but only on an ia64.
>
> > I have a workaround for problems with device_for_each_chi
und for problems with device_for_each_child() not being
"safe", I'm trying to verify it right now, but the underlying problem is
in klist_next(), I don't have a general solution for it (it looks hard to
fix).
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Luben -
On Fri, Aug 19, 2005 at 04:43:41PM -0400, Luben Tuikov wrote:
> On 08/19/05 16:11, Patrick Mansfield wrote:
> > I was changing it to wakeup the eh even while other IO is outstanding, so
> > the eh can wakeup and cancel individual commands while other IO is still
&g
On Fri, Aug 19, 2005 at 04:03:15PM -0400, Luben Tuikov wrote:
> On 08/19/05 15:38, Patrick Mansfield wrote:
> > On Fri, Aug 19, 2005 at 02:46:35PM -0400, Luben Tuikov wrote:
> >
> >
> >>Using the command time out hook and the strategy routine, gives _complete_
>
the hook are:
It calls the driver in interrupt context, so the called function can't
sleep.
There is no queueing or list mechanism, so LLDD's that can only cancel one
command at a time will have problem.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubsc
On Tue, Aug 16, 2005 at 10:51:13PM -0700, Pete Zaitcev wrote:
> On Tue, 16 Aug 2005 21:39:33 -0700, Patrick Mansfield <[EMAIL PROTECTED]>
> wrote:
> > On Tue, Aug 16, 2005 at 11:01:30PM -0400, Chuck Ebbert wrote:
>
> > > I just added some usb-storage devices
ser space and
set in uppper levels, like sdev->timeout, instead of hardcoding to the
timeout * allowed.
-- Patrick Mansfield
> James
>
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -
123625593&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=110848617107098&w=2
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Seeing sysrq-t stack traces might help debugging.
On Sat, Jul 23, 2005 at 09:58:18PM +0200, Stefan Richter wrote:
> I wrote:
> >Problem 1) Hot unplugging of SBP-2 hangs ieee1394's nodemgr
> [...]
> >[unplug disk]
> >Jul 23 20:08:53 shuttle kernel: ieee1394: Node changed: 1-01:1023 ->
> >1-00:1023
tionally print lun in both formats (old and new) depending on HBA
support.
But just adding a 64 bit LUN in parallel does not help much if the scan
code is not modified (we'll fail to scan LUNs with higher bits set).
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
atman]$ ls /sys/block/sdo/device/
block device_blocked iodone_cnt modelrescan state vendor
bus driver ioerr_cnt queue_depth rev timeout
delete iocounterbits iorequest_cnt queue_type scsi_level type
-- Patrick Mansfield
-
To unsubscribe from this l
On Mon, Jul 11, 2005 at 05:20:12PM -0700, Greg KH wrote:
> On Tue, Jul 05, 2005 at 05:38:50PM -0700, Patrick Mansfield wrote:
> > Hi Greg / Patrick -
> >
> > I'm getting an oops with current (pulled today) 2.6 git, the
> > device_for_each_child() does not seem
0 4b60 e89e8080 e87e80c8
4bec 3801 9003 4e800020 <81230000> 2fa9 7c26 5400fffe
-- Patrick Mansfield
On Mon, Jun 20, 2005 at 03:59:26PM -0700, Greg KH wrote:
> [PATCH] Use device_for_each_child() to unregister devices in
> scsi_remove_target().
>
&g
On Fri, Apr 22, 2005 at 12:52:56AM +0200, Lars Marowsky-Bree wrote:
> On 2005-04-21T15:13:16, Patrick Mansfield <[EMAIL PROTECTED]> wrote:
>
> > > The most recent udm patchset has a patch by Jens Axboe and myself to
> > > pass up sense data / error codes in the
ense or scsi core error
errors (i.e. scmd->result) in dm space.
Also, non-scsi drivers would like to use dm multipath, like DASD. Using
extended blk errors allows simpler support for such devices and drivers.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
7;t need sense data passed around via
the block layer.
scsi core could be changed to handle device specific decoding via sense
tables that can be modified via sysfs, similar to devinfo code (well,
devinfo still lacks a sysfs interface).
For ESS, you probably also need the BLIST_RETRY_HWERROR that
the first read will
> sometimes appear to have a realistic result, then the rest will all complete
> in the neighborhood of 10 microseconds.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROT
On Thu, Apr 07, 2005 at 08:35:16AM +0200, Frederic TEMPORELLI wrote:
> Hi,
>
>
> Sorry, no such "driver" directory in /sys/class/scsi_host/hostX/
Doug answered that.
> >>Why do you need it?
If you answer the above you might get better/other suggestions.
-- Pat
On Thu, Apr 07, 2005 at 11:06:03AM +1000, Douglas Gilbert wrote:
> Patrick Mansfield wrote:
> >On Wed, Apr 06, 2005 at 01:40:04PM +0200, Frederic TEMPORELLI wrote:
> >
> >
> >>2/ now, how can we get the adapter module name from sysfs ?
> >
> >
> >Why
quot;${i} module (driver) is: ${module}"
done
[elm3b79 tmp]$ sh ./xx.sh
/sys/class/scsi_host/host0 module (driver) is: qla1280
/sys/class/scsi_host/host1 module (driver) is: qla1280
/sys/class/scsi_host/host2 module (driver) is: qla2300
/sys/class/scsi_host/host3 module (driver) is: qla230
On Wed, Mar 30, 2005 at 08:32:44PM +0200, Kay Sievers wrote:
> On Thu, 2005-03-17 at 09:53 -0500, James Bottomley wrote:
> > On Wed, 2005-03-16 at 14:45 -0800, Patrick Mansfield wrote:
> > > Any comments on this? Should I resend these patches?
> >
> > Well, the bas
ointed out, the current get_device() will never return NULL when
called via:
get_device(&sdev->sdev_gendev)
The current code only narrows the window where problems might occur, I
don't see how it can completely avoid races with removal.
And the patch removes code from the mainline sc
On Wed, Mar 02, 2005 at 11:46:47AM -0800, Patrick Mansfield wrote:
> Use bus dev_attrs to create the default scsi_device attributes.
>
> Note sdev_default_attrs is not a pointer to an array (like
> scsi_sysfs_sdev_attrs), and so DEVICE_ATTR's can be removed, and __ATTR
>
On Wed, Mar 09, 2005 at 01:03:32AM -0800, [EMAIL PROTECTED] wrote:
>
> From: Hanno Boeck <[EMAIL PROTECTED]>
>
> I have a usb-cardreader here that needs some FORCELUN-entries in
> scsi_devinfo.c.
>
Hanno -
Instead of the patch, try running with CONFIG_SCSI_MULTI_
Use bus dev_attrs to create the default scsi_device attributes.
Note sdev_default_attrs is not a pointer to an array (like
scsi_sysfs_sdev_attrs), and so DEVICE_ATTR's can be removed, and __ATTR
used instaed.
Signed-off-by: Patrick Mansfield <[EMAIL PROTECTED]>
--- sattrs-linux-2.6
Get rid of the attr_changed_internally(), and always create queue_type and
queue_depth as read/write, and then writes fail if not supported.
Signed-off-by: Patrick Mansfield <[EMAIL PROTECTED]>
--- linux-2.6.11/drivers/scsi/scsi_sysfs.c 2005-03-02 02:59:50.0
-0800
+++ sattrs
writable queue_depth or queue_type.
The attr_overridden (and post these patches, scsi_sysfs_sdev_attrs) should
someday be removed, the only attribute being overridden (versus a host
specific scsi_device attribute) today is queue_depth, and we have
shost->change_queue_depth that can be used instead.
is so that upon completion it has enough information to
> mark blocks as either up to date or not while at the same time allowing
> the scsi layer to free the original block request at queue time, not at
> completion time. It was never intended to be used by low level drivers.
I
t the lun
> bits, conditional on sdev->scsi_level, right?
It already does so for all commands, see scsi_send_eh_cmnd():
if (scmd->device->scsi_level <= SCSI_2)
scmd->cmnd[1] = (scmd->cmnd[1] & 0x1f) |
(scmd->device->lun << 5
er if printing a warning if sdev->scsi_level > SCSI_2 would be
> useful...
Probably not.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 18, 2005 at 10:41:35PM +0300, Roman Kagan wrote:
> On Fri, Feb 18, 2005 at 10:33:50AM -0800, Patrick Mansfield wrote:
> > The block SG_IO handles the ioctls, but not devices without a SCSI upper
> > level driver (i.e. not tape, disk or cdrom).
>
> Then i
On Fri, Feb 18, 2005 at 09:11:06PM +0300, Roman Kagan wrote:
> On Fri, Feb 18, 2005 at 09:17:37AM -0800, Patrick Mansfield wrote:
> > You could also append the sdev->vendor and sdev->model, and use alias wild
> > cards.
>
> String values haven't been used in the a
e values
are not '\0' terminated. modprobe does not seem to handle spaces in an
alias.
And for st.c:
MODULE_ALIAS("scsi-type-1-*");
sd.c:
MODULE_ALIAS("scsi-type-4-*");
MODULE_ALIAS("scsi-type-5-*");
Also, sg loading would want (along with modprobe load all feature):
MODULE_ALIAS("scsi-type-*");
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
disk->fops->revalidate_disk(disk);
if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
return 0;
for (p = 1; p < state->limit; p++) {
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" i
ding, to disable for
all devices:
[scsi_mod.]default_dev_flags=0x4
Or for one device:
[scsi_mod.]dev_flags="vendor:model:0x4"
Or for one device via /proc after scsi_mod is running:
echo "vendor:model:0x4" > /proc/scsi/device_info
--
tplug loading of HBA
drivers.
We still need a nice way to display and modify a list or array in sysfs (for
both the devinfo or this asc/ascq table).
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 10, 2005 at 07:18:51PM +0100, Christoph Hellwig wrote:
> It's lacking EH support and the hardware is supported by the qla1280
> driver now.
Can we instead remove this one and the qlogicfc?
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscrib
sport" and verified it is in mainline.
But missed the first one "fix HBA removal problem with transport classes",
plus it is NOT in mainline.
I applied and no more oops (and no BUGs using _smp_processor_id()).
-- Patrick Mansfield
-
To unsubscribe from this list: send the line
On Tue, Feb 08, 2005 at 10:44:35PM -0800, Andrew Vasquez wrote:
> On Tue, 08 Feb 2005, Patrick Mansfield wrote:
>
> > I'm still getting lots of BUG's for the smp_processor_id, but via the
> > interrupt function.
> >
>
> It's during the driver&
r_attach+0x34/0x68
[] bus_add_driver+0x8b/0xbc
[] driver_register+0x50/0x54
[] pci_register_driver+0x86/0xa0
[] qla2300_init+0xa/0x10 [qla2300]
[] sys_init_module+0x111/0x270
[] syscall_call+0x7/0xb
BUG: using smp_processor_id() in preemptible [0001] code: modprobe/1362
...
-- Patr
On Mon, Jan 31, 2005 at 11:56:02AM -0500, [EMAIL PROTECTED] wrote:
> > On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote:
> > >
> > > Why not just set scmd->retries to zero in scsi_requeue_command()?
> > >
> >
> > This is exactly what I
if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
return 0;
for (p = 1; p < state->limit; p++) {
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
N that
looks like it could retry forever, independent of this problem.]
Fixing the NOT_READY case to quiesce (and not incrementing retries) would
fix the problem or make it much less likely, and is still a good idea.
And as a long term goal, losing the retry count and moving to allowing all
retrie
dard scsi disk drives).
I don't know why this is an issue for "new" devices, this should be a
problem for you when they first show up; existing and new devs should be
handled the same way.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux
KERN_INFO prefix, change it
back to not print it.
Signed off by: Patrick Mansfield <[EMAIL PROTECTED]>
diff -uprN -X /home/patman/dontdiff
scsi-rc-fix-2.6.11-rc2/drivers/scsi/constants.c
terser-cmd/drivers/scsi/constants.c
--- scsi-rc-fix-2.6.11-rc2/drivers/scsi/constants.c Tue Jan 25 12:26:2
v. Then you can get more
specific with an /etc/dev.d/scsi/*.dev script or something else.
I just tried something simple but did not get it working.
Try [EMAIL PROTECTED] list for help.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t multi-path IO implementation requires significant changes
to the current linux scsi interfaces/structures - especially where no
functional interfaces exist, such as the direct references to Scsi_Device
host, and Scsi_Host host_queue.
--
Patrick Mansfield
[EMAIL PROTECTED]
[EMAIL PROTECTED]
-
To unsubscribe
e bad, as it will allocate a Scsi_Device,
and use up an sd entry (and you can never access the device). Doug Ledford
posted a patch to skip these (apparently it is included in the redhat
7.1 2.4.2-2 kernel).
You might want to check the specs, and see if you can modify the PQ value
returned - some
without your adapter built as a module? I'd
expect you to get a READ CAPACITY failure for each LUN with PQ 1.
-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
iver_pages/21xx/21linux.html
Specifically:
http://www.qlogic.com/bbs-html/csg_web/drivers/linux/22xx/qla2x00src-4.24Beta.tgz
I had a similiar issue with the qlogicisp.c driver (per email sent
by Mike Anderson), no one answered if it was supported or not.
-- Patrick Mansfield
>
> I know my questio
66 matches
Mail list logo
