Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format

On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche wrote: > > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote: > > fnic_fcpio_icmnd_cmpl_handler() displays the value of sc with: > > > > FNIC_SCSI_DBG(KERN_INFO... > > "...

[PATCH 1/1] scsi: fnic: add a space after %p in printf format

a space. Signed-off-by: Nicolas Iooss --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 242e2ee494a1..8cbd3c9f0b4c 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/s

[PATCH 2/2] pcmcia: nsp_cs: add __printf attribute to logging functions

Adding __printf attributes helps to detect errors in printf format strings at build time. Signed-off-by: Nicolas Iooss --- drivers/scsi/pcmcia/nsp_cs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index

[PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions

x27;, but argument 6 has type 'pm_message_t {aka struct pm_message}' [-Werror=format=] nsp32_msg(KERN_INFO, "pci-suspend: pdev=0x%p, state=%ld, slot=%s, host=0x%p", pdev, state, pci_name(pdev), host); Fix all format string errors which were report

[PATCH 2/2] scsi: qla2xxx: make msix_entries const

msix_entries and qla82xx_msix_entries arrays are never modified in drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data. Signed-off-by: Nicolas Iooss --- drivers/scsi/qla2xxx/qla_isr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

[PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

odified, introduce a "%s" format parameter in order to silent this -Wformat-security warning and make clang able to detect at compile time real bugs related to string formatting. Signed-off-by: Nicolas Iooss --- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- 1 file changed, 2 insertions(+)

Uninitialized variable in bfad_im_bsg_els_ct_request

ode and dereferencing self-initialized local variables looks black magic to me, could you please describe why this code is valid? It has recently been introduced by commit 01e0e15c8b3b ("scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly"). Thanks, Nicolas Iooss [1] https://

Uninitialized variable in bfad_im_bsg_els_ct_request

ode and dereferencing self-initialized local variables looks black magic to me, could you please describe why this code is valid? It has recently been introduced by commit 01e0e15c8b3b ("scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly"). Thanks, Nicolas Iooss [1] https://