Re: [PATCH v2 0/9] fix max discard sectors limit

2013-04-22 Thread Namjae Jeon
2013/4/23, Kent Overstreet : > On Sat, Apr 20, 2013 at 01:40:02AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with >> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 >> (block:

Re: [PATCH v2 0/9] fix max discard sectors limit

2013-04-20 Thread Namjae Jeon
2013/4/21 James Bottomley : > On Sat, 2013-04-20 at 01:40 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with >> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 >> (block: add plug for

[PATCH v2 1/9] block: fix max discard sectors limit

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon https://lkml.org/lkml/2013/4/1/292 As per above discussion, it has been oberved that few drivers are setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9) If multiple discard requests get merged, merged discard request's size exceeds 4GB, there

[PATCH v2 2/9] mmc: fix max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon https://lkml.org/lkml/2013/4/1/292 As per above discussion, there is possibility that request's __data_len field may overflow when max_discard_sectors greater than UINT_MAX >> 9 If multiple discard requests get merged, merged discard request's size excee

[PATCH v2 9/9] bcache: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 8/9] dm thin: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 7/9] brd: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 6/9] nbd: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 5/9] loop: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 4/9] mtd: mtd_blkdevs: use generic helper to set

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 3/9] sd: use generic helper to set max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH v2 0/9] fix max discard sectors limit

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 (block: add plug for blkdev_issue_discard ) For example, 1) DISCARD rq-1 with size size 4GB 2) DISCARD rq-2 with size size 1GB If these 2 discard requests

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread Namjae Jeon
2013/3/18, James Bottomley : > On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Introduce msgbyte and statusbyte in the prints as part of the >> result which is returned by the lower layer driver in response to >> SCSI com

[PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Introduce msgbyte and statusbyte in the prints as part of the result which is returned by the lower layer driver in response to SCSI command issued, in case of any error conditions. Purpose of adding these prints is to convey, during any I/O error case, which condition exactly

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-19 Thread Namjae Jeon
2012/7/17 vinayak holikatti : > On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon wrote: >> Hi Vinayak. >>> + * ufshcd_pltfrm_remove - remove platform driver routine >>> + * @pdev: pointer to platform device handle >>> + * >>> + * Returns 0 on success, n

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-16 Thread Namjae Jeon
Hi Vinayak. > + * ufshcd_pltfrm_remove - remove platform driver routine > + * @pdev: pointer to platform device handle > + * > + * Returns 0 on success, non-zero value on failure > + */ > +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev) > +{ > + struct resource *mem_res;

Re: [PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread Namjae Jeon
Thanks Venkat ! 2012/7/11, Venkatraman S : > From: Namjae Jeon > > Currently the UFS host driver has returned incorrect values for SUCCESS > and FAILED. Fix it to return the correct value to the upper layer. > > Signed-off-by: Namjae Jeon > Acked-by: Santosh Y > Sign

[PATCH RESEND 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

2012-07-07 Thread Namjae Jeon
From: Namjae Jeon Update information of Seagate Portable HDD and WD My Passport HDD in quirk list. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Signed-off-by: Amit Sahrawat Acked-by: Alan Stern --- drivers/usb/storage/unusual_devs.h | 12 1 file changed, 12

[PATCH RESEND 1/3] scsi: set to WCE if usb cache quirk is present.

2012-07-07 Thread Namjae Jeon
From: Namjae Jeon Make use of USB quirk method to identify such HDD while reading the cache status in sd_probe(). If cache quirk is present for the HDD, lets assume that cache is enabled and make WCE bit equal to 1. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Signed-off-by: Amit

[PATCH RESEND 2/3] usb: storage: add support for write cache quirk

2012-07-07 Thread Namjae Jeon
From: Namjae Jeon Add support for write cache quirk on usb hdd. scsi driver will be set to wce by detecting write cache quirk in quirk list when plugging usb hdd. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Signed-off-by: Amit Sahrawat Acked-by: Alan Stern --- Documentation

[PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

2012-07-07 Thread Namjae Jeon
From: Namjae Jeon The numbers of USB HDDs(All USB HDD I checked) does not respond correctly to scsi mode sense command for retrieving the write cache page status. Even though write cache is enabled by default, due to scsi driver assume that cache is not enabled which in turn might lead to loss