Re: [PATCH 2.6.23.14] SCSI : scsi_device_lookup/scsi_device_lookup_by_target return NULL for an existent scsi_device

2008-01-28 Thread Nagendra Tomar
son(s) why that might not be a good idea. Pls apply o/w. Thanx, Tomar --- Nagendra Tomar <[EMAIL PROTECTED]> wrote: > Hello James, > My understanding is that the scsi_device in SDEV_DEL state > is there in the scsi_host->devices/scsi_target->devices queue, just >

Re: [PATCH 2.6.23.14] SCSI : scsi_device_lookup/scsi_device_lookup_by_target return NULL for an existent scsi_device

2008-01-23 Thread Nagendra Tomar
creates > a duplicate sdev in SDEV_RUNNING, then it's the wrong patch. What should > be considered is where did the resurrection of the sdev go wrong. I > remember that Hannes did some updates > http://marc.info/?l=linux-scsi&m=118215727101887&w=2 > but I don't beli

[PATCH 2.6.23.14] SCSI : scsi_device_lookup/scsi_device_lookup_by_target return NULL for an existent scsi_device

2008-01-23 Thread Nagendra Tomar
__scsi_device_lookup and __scsi_device_lookup_by_target do not check for the sdev_state and hence return scsi_devices with sdev_state set to SDEV_DEL also. It has the following side effects. We can have two scsi_devices with the same HBTL queued in the scsi_host->__devices/scsi_target->devices