Re: [PATCH V3 2/9] blk-zoned: update blkdev_nr_zones() with helper

2019-07-02 Thread Minwoo Im
On 19-07-02 10:42:28, Chaitanya Kulkarni wrote: > This patch updates the blkdev_nr_zones() with newly introduced helper > function to read the nr_sects from block device's hd_parts with the > help if part_nr_sects_read(). It looks good to me. Reviewed-by: Minwoo Im

[PATCH] libata: Support for an ATA PASS-THROUGH(32) command.

2017-06-23 Thread Minwoo Im
SAT-4(SCSI/ATA Translation) supports for an ata pass-thru(32). This patch will allow to translate an ata pass-thru(32) SCSI cmd to an ATA cmd. Signed-off-by: Minwoo Im Reviewed-by: Bart Van Assche --- drivers/ata/libata-core.c |2 +- drivers/ata/libata-scsi.c | 72

Re: [PATCH] scsi/libata: Support variable-length cdb of ata pass-thru(32).

2017-06-23 Thread Minwoo Im
On Sat, Jun 24, 2017 at 2:15 AM, Bart Van Assche wrote: > On Sat, 2017-06-24 at 01:50 +0900, Minwoo Im wrote: >> - * Handles either 12 or 16-byte versions of the CDB. >> + * Handles either 12 16, or 32-byte versions of the CDB. > > Please insert a comma between "

Re: [PATCH] scsi/libata: Support variable-length cdb of ata pass-thru(32).

2017-06-23 Thread Minwoo Im
On Thu, Jun 22, 2017 at 3:52 AM, Bart Van Assche wrote: > On Sat, 2017-06-17 at 20:00 +0900, Minwoo Im wrote: >> - if ((tf->protocol = ata_scsi_map_proto(cdb[1])) == ATA_PROT_UNKNOWN) { >> + /* >> + * if SCSI operation code in cdb[0] is ATA_12 or ATA_16, >

[PATCH] mpt3sas: Fix error "space prohibited before that ','"

2017-06-19 Thread Minwoo Im
It will fix the following error from checkpatch.pl. ERROR: space prohibited before that ',' Signed-off-by: Minwoo Im --- drivers/scsi/mpt3sas/mpt3sas_base.c | 18 +- drivers/scsi/mpt3sas/mpt3sas_ctl.c |2 +- drivers/scsi/mpt3sas/mpt3s

[PATCH] scsi/libata: Support variable-length cdb of ata pass-thru(32)-bug fixed.

2017-06-19 Thread Minwoo Im
Bug fixed in libata-scsi.c from previous patch. Bit shifting of service action value in ata_scsi_var_len_cdb_xlat() was reversed. I have tested a ata pass-thru(32) command with sg_io and it worked well. I'm sorry for making a confusion. Signed-off-by: Minwoo Im --- drivers/ata/libata-c

[PATCH] scsi/libata: Support variable-length cdb of ata pass-thru(32).

2017-06-17 Thread Minwoo Im
to support (32) pass-thru. pass-thru(32) has a different CDB contents from 12, or 16. Please refer below patch and fill free to give any opinions. Thanks, Minwoo. Signed-off-by: Minwoo Im --- drivers/ata/libata-core.c |2 +- drivers/ata/libata-scsi.c | 95

Re: [PATCH] scsi_proto.h: ATA_32 added for ata pass-thru(32).

2017-06-16 Thread Minwoo Im
On Sat, Jun 17, 2017 at 12:27 AM, Bart Van Assche wrote: > On Thu, 2017-06-15 at 20:29 +0900, Minwoo Im wrote: >> SAT-4(SCSI/ATA Translation Standard) supports a ATA PASS-THROUGH(32) >> SCSI command. It uses 7Fh as a operation code which means >> variable-length CDB. &g

[PATCH] scsi_proto.h: ATA_32 added for ata pass-thru(32).

2017-06-15 Thread Minwoo Im
should be added first. Signed-off-by: Minwoo Im --- include/scsi/scsi_proto.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/scsi/scsi_proto.h b/include/scsi/scsi_proto.h index ce78ec8..1eb4efd 100644 --- a/include/scsi/scsi_proto.h +++ b/include/scsi/scsi_proto.h @@ -164,6 +164,7