Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Apr 2019 16:35:34 +0100 Al Viro escreveu: > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s39

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
double-checked all these drivers to ensure that all ioctl arguments > are used as pointers or are ignored, but are not interpreted as integer > values. > > Acked-by: Jason Gunthorpe > Acked-by: Daniel Vetter > Acked-by: Mauro Carvalho Chehab > Acked-by: Greg Kroah-Hartman &

[PATCH v2 34/79] docs: target: convert docs to ReST and rename to *.rst

2019-04-22 Thread Mauro Carvalho Chehab
paragraphs; - fix tables markups; - add some lists markups; - mark literal blocks; - adjust title markups. At its new index.rst, let's add a :orphan: while this is not linked to the main index.rst file, in order to avoid build warnings. Signed-off-by: Mauro Carvalho Chehab --- Document

[PATCH v2 26/79] docs: powerpc: convert docs to ReST and rename to *.rst

2019-04-22 Thread Mauro Carvalho Chehab
file, in order to avoid build warnings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/PCI/pci-error-recovery.txt | 2 +- .../{bootwrapper.txt => bootwrapper.rst} | 28 +++- .../{cpu_families.txt => cpu_families.rst}| 23 +-- .../{cpu_features.txt => cpu_f

Avoiding merge conflicts while adding new docs - Was: Re: [PATCH 00/57] Convert files to ReST

2019-04-18 Thread Mauro Carvalho Chehab
Jon, Em Mon, 15 Apr 2019 23:55:25 -0300 Mauro Carvalho Chehab escreveu: > I have a separate patch series with do the actual rename and > adjustment of references. I opted to submit this first, as it > sounds easier to merge this way, as each subsystem maintainer > can apply th

[PATCH 00/57] Convert files to ReST

2019-04-15 Thread Mauro Carvalho Chehab
in html can be seen at: https://www.infradead.org/~mchehab/rst_conversion/ Mauro Carvalho Chehab (57): docs: trace: fix some Sphinx warnings docs: acpi: convert text files to ReST docs: aoe: convert text files to ReST docs: arm64: convert documentation to ReST format docs: cdrom

[PATCH 34/57] docs: target: convert it to ReST format

2019-04-15 Thread Mauro Carvalho Chehab
Convert the TCM docs to ReST format and add them to the bookset. This has a mix of userspace-faced and Kernelspace faced docs. Still, it sounds a better candidate to be added at the kernel API set of docs. Signed-off-by: Mauro Carvalho Chehab --- Documentation/target/tcm_mod_builder.txt | 200

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Mauro Carvalho Chehab
remote controller codes to adjust the air conditioning system ;-) From lirc driver's PoV, there's nothing that really prevents one to do that and use lirc API, and the driver is generic enough to work on any hardware platform. I didn't check the implementation of generic_compat_ioctl_ptrarg(), but assuming it is ok, Acked-by: Mauro Carvalho Chehab Thanks, Mauro

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-09 Thread Mauro Carvalho Chehab
BIOS update request to the BIOS. So on the next > reboot > the BIOS knows about the new image downloaded and it updates itself. You should likely remove the "Also" here. With that, Reviewed-by: Mauro Carvalho Chehab Regards, Mauro

Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-09 Thread Mauro Carvalho Chehab
, which which registers a > +struct class firmware_class. Because the attributes exposed are part of the > +module name, the module name firmware_class cannot be renamed in the future, > to > +ensure backward compatibilty with old userspace. Ah, now the explanation makes a lot more sens

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-19 Thread Mauro Carvalho Chehab
ork > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches For the media patch: Acked-by: Mauro Carvalho Chehab > --- > git diff -w shows no difference other than the ab

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-02 Thread Mauro Carvalho Chehab
Em Sun, 1 Oct 2017 20:52:20 -0400 Jérémy Lefaure escreveu: > Anyway, I can tell to each maintainer that they can apply the patches > they're concerned about and next time I may send individual patches. In the case of media, we'll handle it as if they were individual ones. Thanks, Mauro

[PATCH v2 33/53] scsi: fix some kernel-doc markups

2017-05-16 Thread Mauro Carvalho Chehab
: Mauro Carvalho Chehab --- drivers/scsi/scsi_scan.c | 7 --- drivers/scsi/scsi_transport_fc.c | 18 ++ drivers/scsi/scsicam.c | 4 ++-- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index

[PATCH v2 46/53] ia64, scsi: update references for the device-io book

2017-05-16 Thread Mauro Carvalho Chehab
The book is now at Documentation/driver-api/device-io.rst. Update such references. Signed-off-by: Mauro Carvalho Chehab --- arch/ia64/include/asm/io.h | 2 +- arch/ia64/sn/kernel/iomv.c | 2 +- drivers/scsi/qla1280.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 06/13] ia64, scsi: update references for the device-io book

2017-05-14 Thread Mauro Carvalho Chehab
The book is now at Documentation/driver-api/device-io.rst. Update such references. Signed-off-by: Mauro Carvalho Chehab --- arch/ia64/include/asm/io.h | 2 +- arch/ia64/sn/kernel/iomv.c | 2 +- drivers/scsi/qla1280.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 34/36] scsi: fix some kernel-doc markups

2017-05-12 Thread Mauro Carvalho Chehab
: Mauro Carvalho Chehab --- drivers/scsi/scsi_scan.c | 7 --- drivers/scsi/scsi_transport_fc.c | 18 ++ drivers/scsi/scsicam.c | 4 ++-- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Mauro Carvalho Chehab
> > with a call to the new helper dma_set_mask_and_coherent(). > > > > Signed-off-by: Russell King > > Acked-by: Hans Verkuil Somehow, I lost your original post (I got unsubscribed on a few days from all vger mailing lists at the end of september). I suspect that you want to sent this via

Re: [PATCH 10/28] proc: Add proc_mkdir_data() [RFC]

2013-04-16 Thread Mauro Carvalho Chehab
-off-by: David Howells cc: Neela Syam Kolli cc: Jerry Chuang cc: Mauro Carvalho Chehab cc: linux-scsi@vger.kernel.org cc: de...@driverdev.osuosl.org cc: linux-wirel...@vger.kernel.org --- drivers/message/i2o/i2o_proc.c |8 ++-- drivers/scsi/megaraid.c|4

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
created even if the device doesn't support get/set the scub rate. Change the logic to only create this device node when the operation is supported. Reported-by: Felipe Balbi Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
that back. Mauro's patch will already create the file > > anyway: > > > > if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate) > > > > Adjusting the permissions is simply the last missing piece to this patch > > to make the interface to users

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 15:38:09 +0200 Felipe Balbi escreveu: > Hi, > > On Tue, Feb 19, 2013 at 02:28:54PM +0100, Borislav Petkov wrote: > > On Tue, Feb 19, 2013 at 03:15:00PM +0200, Felipe Balbi wrote: > > > what's the problem with that ? > > > > Not a problem - simply annoying. > > > > $ ./test.

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 14:06:26 +0100 Borislav Petkov escreveu: > > No, on both cases, open() will return an error (-ENOENT against -EPERM). > > What if it is a shell script doing: > > cat /sys/devices/system/edac/mc/mc0/sdram_scrub_rate > > or similar? Well, cat will return "1" if an error is f

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 13:35:02 +0100 Borislav Petkov escreveu: > On Tue, Feb 19, 2013 at 09:16:10AM -0300, Mauro Carvalho Chehab wrote: > > I'm not sure if is there a way to pass fs permissions to something similar > > to device_create_file(). > > struct device_attribu

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 12:43:46 +0100 Borislav Petkov escreveu: > On Tue, Feb 19, 2013 at 08:11:49AM -0300, Mauro Carvalho Chehab wrote: > > > > I remember I saw some discussions about it in the past at bluesmoke ML, > > > > saying that -ENODEV is the expected behavior

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Feb 2013 12:11:21 +0200 Felipe Balbi escreveu: > Hi, > > On Tue, Feb 19, 2013 at 07:03:10AM -0300, Mauro Carvalho Chehab wrote: > > > But my gut feeling says to stay concervative and not touch this code - > > > we don't know what uses it and how mu

Re: SYSFS "errors"

2013-02-19 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 23:44:05 +0100 Borislav Petkov escreveu: > On Mon, Feb 18, 2013 at 02:26:18PM -0800, Greg KH wrote: > > I don't know, it depends on if userspace can handle this properly or > > not. What tools rely on this sysfs file? WHat happens when they get a > > non-number in the file? T

Re: SYSFS "errors"

2013-02-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 22:05:42 +0200 Felipe Balbi escreveu: > Hi, > > On Mon, Feb 18, 2013 at 04:46:38PM -0300, Mauro Carvalho Chehab wrote: > > > > > No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate > > > > > > > > Odd,

Re: SYSFS "errors"

2013-02-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Feb 2013 20:46:33 +0200 Felipe Balbi escreveu: > Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: > > > Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms > > > > The issue with this file is, if the power.use_autosuspend flag is not > > set for the device, th