On Mon, Aug 26, 2019 at 05:29:49PM +0100, Al Viro wrote:
> On Mon, Aug 26, 2019 at 03:48:38AM +0100, Al Viro wrote:
>
> > We might be able to paper over that mess by doing what /dev/st does -
> > checking that file_count(file) == 1 in ->flush() instance and doing commit
> > there in such case.
On Fri, Jan 11, 2019 at 08:41:43AM -0800, James Bottomley wrote:
> On Fri, 2019-01-11 at 16:46 +0100, Hannes Reinecke wrote:
> > > - asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head)
> > > +
> > > - use_sg * sizeof(struct asc_sg_list),
> > > GFP_ATOMIC);
> > > + asc_
On Tue, Dec 04, 2018 at 12:28:54PM -0800, Andrew Morton wrote:
> On Tue, 4 Dec 2018 12:18:01 -0800 Matthew Wilcox wrote:
> > I only had a review comment on 8/9, which I then withdrew during my review
> > of patch 9/9. Unless I missed something during my re-review of my
> >
On Tue, Dec 04, 2018 at 12:14:43PM -0800, Andrew Morton wrote:
> On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby
> wrote:
>
> > On 11/13/18 1:36 AM, Matthew Wilcox wrote:
> > > On Mon, Nov 12, 2018 at 10:46:35AM -0500, Tony Battersby wrote:
> > >>
On Mon, Nov 12, 2018 at 10:40:57AM -0500, Tony Battersby wrote:
> I posted v3 on August 7. Nobody acked or merged the patches, and then
> I got too busy with other stuff to repost until now.
Thanks for resending. They were in my pile of things to look at, but
that's an ever-growing pile.
> I be
#x27;t
normally in the performance path, but might be with the right config
options. With that, I withdraw my objection to the previous patch and
Acked-by: Matthew Wilcox
Andrew, can you funnel these in through your tree? If you'd rather not,
I don't mind stuffing them into a git tree and asking Linus to pull
for 4.21.
On Mon, Nov 12, 2018 at 10:45:58AM -0500, Tony Battersby wrote:
> +++ linux/mm/dmapool.c2018-08-06 17:52:53.0 -0400
> @@ -61,6 +61,7 @@ struct dma_pool { /* the pool */
> struct device *dev;
> unsigned int allocation;
> unsigned int boundary;
> + unsi
'size_t' when counting all
> the blocks in the entire pool.
>
> Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
> dmapool private data directly in 'struct page', thereby eliminating
> 'struct dma_page'. In big O notation, this improves the algorithm from
> O(n^2) to O(n) while also reducing memory usage.
>
> Thanks to Matthew Wilcox for the suggestion to use struct page.
&
On Mon, Nov 12, 2018 at 10:44:02AM -0500, Tony Battersby wrote:
> Rename fields in 'struct dma_page' in preparation for moving them into
> 'struct page'. No functional changes.
>
> in_use -> dma_in_use
> offset -> dma_free_off
>
> Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
> list of pages that have free blocks ready to (re)allocate. In big O
> notation, this improves the algorithm from O(n^2) to O(n).
>
> Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
rsby
Acked-by: Matthew Wilcox
l.c for pool->dev == NULL are both insufficient and causing bloat.
> Remove them.
>
> Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
On Mon, Nov 12, 2018 at 10:41:34AM -0500, Tony Battersby wrote:
> Fixes: e34f44b3517f ("pool: Improve memory usage for devices which can't
> cross boundaries")
> Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote:
> On 17/10/18 14:34, YueHaibing wrote:
> > - srb_tag = le32_to_cpu(scsiqp->srb_tag);
> > scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>
> Shouldn't this be:
> scp = scsi_host_find_tag(boardp->shost,
>
On Mon, Aug 27, 2018 at 02:45:15PM -0500, Mike Christie wrote:
> Signed-off-by: Vincent Pelletier
> [rebased against idr/ida changes and to handle ret review comments from
> Matthew]
> Signed-off-by: Mike Christie
> Cc: Matthew Wilcox
Reviewed-by: Matthew Wilcox
On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
>
> The patches were made against Martin's 4.19/scsi-queue b
On Fri, Aug 24, 2018 at 01:37:12PM -0500, Mike Christie wrote:
> Also, let idr_alloc return value through instead of replacing it with -ENOMEM,
> as it is already a negative value and caller checks sign, not exact value.
I bet it's less code to just return -ENOMEM in all situations instead of
maki
On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
>
> The patches were made against Martin's 4.19/scsi-queue b
Ping? It'd be nice to get some answers to these questions rather than
merging this conversion with the questions still in the changelog ...
- Forwarded message from Matthew Wilcox -
Date: Thu, 21 Jun 2018 14:28:27 -0700
From: Matthew Wilcox
To: linux-ker...@vger.kernel.o
From: Matthew Wilcox
The sbitmap and the percpu_ida perform essentially the same task,
allocating tags for commands. Since the sbitmap is more used than
the percpu_ida, convert the percpu_ida users to the sbitmap API.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/qla2xxx/qla_target.c
From: Matthew Wilcox
This is a pretty rough-and-ready conversion of the target drivers
from using percpu_ida to sbitmap. It compiles; I don't have a target
setup, so it's completely untested. I haven't tried to do anything
particularly clever here, so it's possible that, f
From: Matthew Wilcox
With its one user gone, remove the library code.
Signed-off-by: Matthew Wilcox
---
include/linux/percpu_ida.h | 83
lib/Makefile | 2 +-
lib/percpu_ida.c | 391 -
3 files changed, 1 insertion(+), 475
On Sat, Apr 28, 2018 at 09:46:52PM +0200, Julia Lawall wrote:
> FWIW, here is my semantic patch and the output - it reports on things that
> appear to be too small and things that it doesn't know about.
>
> What are the relevant pci wrappers? I didn't find them.
Basically all of the functions in
On Fri, Apr 27, 2018 at 04:14:56PM +, Luis R. Rodriguez wrote:
> > Not really. We have unchecked_isa_dma to support about 4 drivers,
>
> Ah very neat:
>
> * CONFIG_CHR_DEV_OSST - "SCSI OnStream SC-x0 tape support"
That's an upper level driver, like cdrom, disk and regular tapes.
> * CO
On Fri, Apr 27, 2018 at 11:07:07AM -0500, Christopher Lameter wrote:
> Well it looks like what we are using it for is to force allocation from
> low physical memory if we fail to obtain proper memory through a normal
> channel. The use of ZONE_DMA is only there for emergency purposes.
> I think we
On Fri, Apr 08, 2016 at 01:29:26PM +0200, Hannes Reinecke wrote:
> I'd like to propose a topic on block-mq issues with FC.
> During my performance testing using block/scsi-mq with FC I've hit
> several issues I'd like to discuss:
If there's a general block-mq bitching session, I have some ideas :-
On Fri, Apr 17, 2015 at 10:37:15PM +0200, Christoph Hellwig wrote:
> The real RFC is the last one which allocates the block_pc specific
> data separately in the callers instead of bloating every struct
> request with it. I always hated what we did, but with the upcoming
> split of nvme into transp
On Wed, Jul 30, 2014 at 05:18:47PM +0300, Boaz Harrosh wrote:
> When brd_direct_access() is called on a partition-bdev
> it would access the wrong sector. And caller would then
> corrupt the device's data.
>
> This is a preliminary fix, Matthew Wilcox has a patch
> in his
On Tue, Jul 29, 2014 at 07:37:49PM +0300, Boaz Harrosh wrote:
> But before we are running to fix this bug. Could we please do better and just
> remove the support for partitions
> all together.
> Since it *never* worked anyway, so probably no one needs it! Surly no
> one used it
I fixed th
On Wed, Apr 02, 2014 at 03:41:15AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 27, 2014 at 04:40:31PM -0400, Matthew Wilcox wrote:
> > Removing the host_lock from the I/O submission path gives a huge
> > scalability improvement.
>
> This looks reasonable to me, but did you
Reusing a msg frame quickly means it's still cache-hot. This yields
a small but noticable performance improvement in a well-known database
benchmark. This improvement is already present in the mpt3sas driver.
Signed-off-by: Matthew Wilcox
---
drivers/message/fusion/mptbase.c | 2 +-
1
structure to track the I/O instead of the least
recently used keeps the cache-hot lines in use, which is a nice
performance improvement. It's already present in the mpt3sas driver,
it just didn't make it into the fusion or mpt2sas drivers yet.
Matthew Wilcox (7):
mpt3sas: Remove uses of ser
The mpt2sas_scsih_issue_tm() function does not use the 'serial_number'
argument passed to it. Removing it removes the last vestiges of the
scsi_cmnd's serial_number field from this driver.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/mpt2sas/mpt2sas_base.h | 2 +-
drive
Removing the host_lock from the I/O submission path gives a huge
scalability improvement.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi
Removing the host_lock from the I/O submission path gives a huge
scalability improvement.
Signed-off-by: Matthew Wilcox
---
drivers/message/fusion/mptfc.c| 12 +---
drivers/message/fusion/mptsas.c | 10 --
drivers/message/fusion/mptscsih.c | 8 +++-
drivers/message
Reusing a smid quickly means it's still cache-hot. This yields a small
but noticable performance improvement in a well-known database benchmark.
This improvement is already present in the mpt3sas driver.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 8
1
Removing the host_lock from the I/O submission path gives a huge
scalability improvement.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
b/drivers/scsi
The mpt3sas_scsih_issue_tm() function does not use the 'serial_number'
argument passed to it. Removing it removes the last vestiges of the
scsi_cmnd's serial_number field from this driver.
Signed-off-by: Matthew Wilcox
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 2 +-
drive
st and it's not obvious how we would deal with the VMAs in that
> case. It would get more than just the storage gains though. Some of the
> scalability problems that deal with massive amount of struct pages may
> magically go away if the base unit of allocation and management changes.
--
mean T10DIF. I've seen other people use
DIX to mean separate SGLs for metadata and DIF to mean interleaved data.
Can you confirm which thing you mean here?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interes
On Mon, Jun 24, 2013 at 10:07:51AM +0200, Ingo Molnar wrote:
> I'm wondering, how will this scheme work if the IO completion latency is a
> lot more than the 5 usecs in the testcase? What if it takes 20 usecs or
> 100 usecs or more?
There's clearly a threshold at which it stops making sense, and
On Mon, Jun 24, 2013 at 08:11:02PM -0400, Steven Rostedt wrote:
> What about hooking into the idle_balance code? That happens if we are
> about to go to idle but before the full schedule switch to the idle
> task.
>
>
> In __schedule(void):
>
> if (unlikely(!rq->nr_running))
>
On Mon, Jun 24, 2013 at 09:15:45AM +0200, Jens Axboe wrote:
> Willy, I think the general design is fine, hooking in via the bdi is the
> only way to get back to the right place from where you need to sleep.
> Some thoughts:
>
> - This should be hooked in via blk-iopoll, both of them should call in
A paper at FAST2012
(http://static.usenix.org/events/fast12/tech/full_papers/Yang.pdf) pointed
out the performance overhead of taking interrupts for low-latency block
I/Os. The solution the author investigated was to spin waiting for each
I/O to complete. This is inefficient as Linux submits man
nt in drivers/scsi/mpt2sas. Why? That's a recipe for maintenance
> hell...
I would go further and ask why this needs a new driver; why can't mpt2sas
be enhanced to drive the 12Gbit cards?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, l
with performance. Have you done performance testing with
these changes? I seem to remember we used an eight-socket box to show
host_lock problems in the past.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interest
On Tue, Feb 26, 2008 at 11:23:01AM -0800, Benny Halevy wrote:
> Pete, the subject says "PATCH 1/2" but I didn't see any follow-up message
> for PATCH 2/2. Just wondering :)
I think the problem's on your end ... I got it and so did marc:
http://marc.info/?l=linux-scsi&m=120405067313933&w=2
--
Int
On Tue, Feb 26, 2008 at 07:18:18AM -0800, James Bottomley wrote:
> On Tue, 2008-02-26 at 04:44 +0100, Andi Kleen wrote:
> > No pci_alloc_coherent works, but pci_map_* will not.
>
> Yes, it does ... dma_map is a flush/virt_to_phys on x86. so of course it
> works. If you mean it doesn't transform f
On Mon, Feb 25, 2008 at 11:40:35PM +0100, Andi Kleen wrote:
> On Mon, Feb 25, 2008 at 02:47:46PM -0700, Matthew Wilcox wrote:
> > I have to say I really don't like this patch. I'll look up my current
>
> Why do you not like it? What would you do better?
>
> >
On Mon, Feb 25, 2008 at 11:40:35PM +0100, Andi Kleen wrote:
> > (I must have fixed it somehow because it works on parisc, which is most
> > unforgiving of drivers which do DMA without the DMA API).
>
> At least on x86 the DMA API cannot do ISA bouncing.
You're saying that if I set a 24-bit DMA ma
On Mon, Feb 25, 2008 at 12:35:16AM +0100, Andi Kleen wrote:
> That patch is a little more complicated than the others. advansys
> was the only ISA driver who actually passed ->cmnd to the firmware.
> So I implemented a simple own bounce buffer scheme for this case.
> Also did sense_buffer bouncing
On Sun, Feb 24, 2008 at 12:31:17AM -0500, Christoph Hellwig wrote:
> On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
> > hm. We'll see how it plays out... on the remove side, the above is
> > exact what happens in gdth_remove_one() without my patch, thus
> > consolidating two c
On Fri, Feb 22, 2008 at 09:17:33AM -0700, Yang, Bo wrote:
> James,
>
> What is the status for this patch? We need to submit more patches based
> on the acceptance of this patch.
I've NAKed it. You need to use compat_ioctl. That way your code will
work even if you run a 32-bit x86 application o
3f725a5d071eea1830bbbfab78cfe3fc9baaf introduced locking in
lpfc_sli_hbqbuf_fill_hbqs, but missed unlocking on one exit.
Reported-by: Harvey Harrison <[EMAIL PROTECTED]>
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
Cc: James Smart <[EMAIL PROTECTED]>
diff --git a/drivers/
Sorry, $SUBJECT should have read 'gfp_mask' instead of 'gfp_flags'.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
scsi_init_io() is already passed a gfp_mask, so we should use that
instead of an explicit GFP_ATOMIC
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f243fc3..b81170d 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/driver
There is no need to allocate this memory atomically. There is no problem
with sleeping during a bus scan, and it's actually causing problems
for libata.
Also remove the GFP_DMA flag. If it's needed, the block layer will
bounce-buffer it.
Signed-off-by: Matthew Wilcox <[EMAIL PROT
On Wed, Oct 31, 2007 at 09:03:24PM +, ian wrote:
> I'd like to ask that this not happen - there are several users of this
> code in the handhelds.org tree, which we hope will merge into mainline.
> this code is _essential_ to allow support of these devices.
So ... it's been 4 months. Any new
On Tue, Feb 19, 2008 at 10:14:53PM +0900, FUJITA Tomonori wrote:
> I see that two drivers have very different objectives but if we add
> use_thread option to scsi_debug (we can do easily), it seems that
> scsi_debug can provide all the features that scsi_ram does.
It's not just use_thread. It's a
ible, hence the options
+ * to discard writes and reads.
+ * By default, it'll allocate half a gigabyte of RAM to use as a ramdisc;
+ * you can change this with the `capacity' module parameter.
+ *
+ * (C) Copyright 2007-2008 Intel Corporation
+ * Author: Matthew Wilcox <[EMAI
On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote:
> No, he means that kmap_atomic can only map a page of data. This makes
> single page only sg list entries and input assumption into this loop.
> with ENABLE_CLUSTERING, that's potentially not true. Of course, this
> accidentally w
On Sat, Feb 16, 2008 at 11:57:15PM +0900, FUJITA Tomonori wrote:
> scsi_debug does at several places:
>
> for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
> kaddr = (unsigned char *)
> kmap_atomic(sg_page(sg), KM_USER0);
>
>
> We cannot do something like that with the c
On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote:
> I still don't have a card for testing myself. Again anyone
> wants to send me a card. Intel people anybody home?
Apparently Intel sold this line of cards to Adaptec. The copyright
notice in the file backs this up:
* Copyright (C) 1
On Fri, Feb 15, 2008 at 10:44:52AM -0500, Jeff Garzik wrote:
> I kept those array for one reason: you need it to preserve the existing
> in-driver PCI device sort.
Just get rid of it. I got rid of it for sym2 during 2.5 and very few
people have complained.
--
Intel are signing my paycheques .
On Mon, Feb 11, 2008 at 10:27:46AM -0800, Chandra Seetharaman wrote:
> On Sat, 2008-02-09 at 05:45 -0700, Matthew Wilcox wrote:
> > On Mon, Feb 04, 2008 at 01:19:30PM -0800, Chandra Seetharaman wrote:
> > > The device does send these error messages currently, but it takes some
On Sat, Feb 09, 2008 at 01:50:20PM +, Alan Cox wrote:
> On Fri, 08 Feb 2008 20:32:54 -0500 Douglas Gilbert <[EMAIL PROTECTED]> wrote:
> > Alan Cox wrote:
> > > The word "illegal" has a precise dictionary meaning of "prohibited by
> > > law".
> >
> > Also "contrary to or forbidden by official
On Sat, Feb 09, 2008 at 02:12:07PM -0500, Robert P. J. Day wrote:
> On Sat, 9 Feb 2008, Matthew Wilcox wrote:
> > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote:
> > > just an observation that, even though 53c7xx content has been
> > > officially rem
On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote:
> just an observation that, even though 53c7xx content has been
> officially removed, there are still a few droppings hanging around the
> tree:
Erm. It's not just a driver, it's also the name of some chips.
> $ grep -r 53c7xx *
On Mon, Feb 04, 2008 at 01:19:30PM -0800, Chandra Seetharaman wrote:
> The device does send these error messages currently, but it takes some
> time to get the check condition back, which adds up the time to boot
> especially when the # of LUNS is huge.
>
> For example, in my test configuration, I
On Tue, Jan 29, 2008 at 02:09:52PM -0800, Luben Tuikov wrote:
> > The ideal solution would be to do mapping against a
> > different struct
> > device for each port, so that we could maintain the proper
> > DMA mask for
> > each of them at all times. However I'm not sure if
> > that's possible. Th
On Mon, Jan 28, 2008 at 06:08:44PM -0600, Robert Hancock wrote:
> The
> thought of using the SCSI struct device for DMA mapping was brought up
> at one point.. any thoughts on that?
I believe this will work on some architectures and not others.
Anything that uses include/asm-generic/dma-mapping.
On Tue, Jan 22, 2008 at 02:30:12PM -0700, Yang, Bo wrote:
> Alan/Matthew,
>
> I found inb_p/outb_p are defined as inb/outb in kernel src. So it
> should not have problems to change inb_p/outb_p to inb/outb.
That's not true for x86-32. Please, can you look up the documentation
for this chip and
On Tue, Jan 22, 2008 at 01:19:09PM -0500, Tony Battersby wrote:
> When unloading, sym53c8xx calls dma_free_coherent() while holding a
> spinlock (sym53c8xx_lock) with irqs disabled, which produces the
> following warning with 2.6.24:
Ugh. I'm slightly torn. On the one hand, it's probably possibl
On Mon, Jan 21, 2008 at 01:08:58PM +0900, FUJITA Tomonori wrote:
> On Sun, 20 Jan 2008 09:40:11 -0700
> Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> > Longer-term, I want to allow low-level drivers to allocate the
> > sense_buffer themselves so they can DMA directly
On Wed, Jan 16, 2008 at 01:32:17PM +0900, FUJITA Tomonori wrote:
> This removes static array sense_buffer in scsi_cmnd and uses
> dynamically allocated sense_buffer (with GFP_DMA).
>
> The reason for doing this is that some architectures need cacheline
> aligned buffer for DMA:
>
> http://lkml.or
I got an interesting mail from Mike Anderson yesterday detailing how he
managed to provoke an error recovery path that didn't work so well.
In sym_soft_reset(), we check to see if the chip has an ISTAT1
register, and if it does, and the scripts are running, we take
additional action to abort the
On Fri, Jan 18, 2008 at 01:32:12PM -0700, Yang, Bo wrote:
> Alan,
>
> The in/outb_p in MegaRAID scsi driver is used for our old io mapped
> megaraid controller. There are still some customers are using those old
> controller. Please keep them.
Hi Bo,
I think you've misunderstood the question.
On Tue, Jan 15, 2008 at 12:04:09PM +0900, K.Tanaka wrote:
> I would like to introduce a SCSI fault injection framework using SystemTap.
>
> Currently, kernel has Fault-injection framework and Faulty mode for md,
> which can also be used for testing the error handling. But, they could
> only produc
You seem to have used one tab
too many for the first three lines.
Please correct that one, and then add my:
Reviewed-by: Matthew Wilcox <[EMAIL PROTECTED]>
Thanks!
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're intere
On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote:
> +#include
You don't add any uses of lock_kernel() and there are none in the
driver currently.
> - .owner= THIS_MODULE,
> - .open = ch_open,
> - .release = ch_release,
> - .ioctl= ch_ioc
On Fri, Jan 11, 2008 at 09:50:46PM +0100, Krzysztof Helt wrote:
> + BUG_ON(!sym_data->io_reset);
> + sym_data->io_reset = &eh_done;
Isn't that BUG_ON still the wrong sense?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, w
On Thu, Jan 10, 2008 at 08:32:27PM +0100, Andi Kleen wrote:
> Not many really in the core kernel. Hardly any. Grep for
> lock_kernel to be sure, but there is not much.
>
> It's mostly drivers that still need it.
>
> How about the low level SCSI drivers that might called from the high
> level SCS
On Thu, Jan 10, 2008 at 07:59:44PM +0100, Andi Kleen wrote:
> > Really, all this is doing is open coding what the ioctl handler is doing
> > anyway, isn't it? in which case, why bother to change it at all?
>
> Because once it's open coded it is visible and can then be eliminated.
> Does SCSI need
On Thu, Jan 10, 2008 at 02:19:08PM +0100, Oliver Neukum wrote:
> Am Donnerstag, 10. Januar 2008 14:05:25 schrieb Boaz Harrosh:
> > On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> > > could you explain to me why this code can get away with allocating t
On Thu, Jan 10, 2008 at 02:47:33AM +, Matthew Hall wrote:
> I am using the Supermicro H8DCE motherboard. Some (not all) of the SATA
> channels quit working due to some kind of resource conflict when I
> upgrade to any kernel above 2.6.20.xx series, in my case I am running
> 2.6.20.21 SMP x86
On Wed, Jan 09, 2008 at 12:36:26PM -0800, Jon Watte wrote:
> Stefan Richter wrote:
> >>Those systems (servers) typically have enough memory to tolerate a few
> >>extra KB of code without problems. In fact most PCs these days have.
> >>
> >
> >It would be a stupid solution nevertheless.
> >
> >
On Wed, Jan 09, 2008 at 09:05:52AM -0600, James Bottomley wrote:
> On Tue, 2008-01-08 at 19:22 -0700, Matthew Wilcox wrote:
> > On Tue, Jan 08, 2008 at 04:55:46PM -0800, Vinay Venkataraghavan wrote:
> > > Is there a limit on the number of devices that SCSI supports. In other
>
On Tue, Jan 08, 2008 at 04:55:46PM -0800, Vinay Venkataraghavan wrote:
> Is there a limit on the number of devices that SCSI supports. In other words,
> I have a QLogic HBA card, and I am connecting to a SAN which has 64 targets.
I've personally had over five hundred LUNs. You shouldn't be hitt
On Tue, Jan 08, 2008 at 01:17:15PM -0800, Grant Grundler wrote:
> Why apply le32_to_cpu() to the constant instead of the variable?
> On systems were le32_to_cpu() is doing something, can gcc or
> preprocessor optimize the constant?
> I've always assumed it could not but that might be wrong.
$ grep
On Tue, Jan 08, 2008 at 06:56:11PM +0100, Stefan Richter wrote:
> It's hald or something like that.
Can't we get hald to look at the cached results of the inquiry command,
handily available through sysfs?
> Matthew Wilcox wrote:
> > I have a hard time thinking th
On Tue, Jan 08, 2008 at 02:43:34PM +0100, Hannes Reinecke wrote:
> Hi all,
>
> I have here a buggy firewire bridge (Prolific PL3507) which requires that
> each 'INQUIRY' command is followed by a 'READ CAPACITY' command. Otherwise
> any read will return invalid data (the payload is preceded by 36
On Sat, Jan 05, 2008 at 03:18:12PM -0600, James Bottomley wrote:
> Just a check up on this: Matthew were you ever going to complete the
> mca_94x conversion? It's quite topical because it would be another
> example driver for the m68k people to look at.
>
> If not, I can probably complete the bi
On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote:
> Bodo Eggert wrote:
> > ---
> > SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ?
> >
> > If you want to use SCSI target mode drivers enable this option.
> > If you choose M, the module will be called scsi_tgt.
> > ---
> >
> > What
>From the backtrace, this doesn't seem to be a scsi or ide problem.
It might be a block-layer bug, or a VM problem. I've cc'd the VM people
to see what they think.
On Mon, Dec 31, 2007 at 12:06:00AM +0100, Erno Kovacs wrote:
> [1.] One line summary of the problem:
>
> using dd on a broken hdd c
On Fri, Dec 21, 2007 at 02:30:28PM +0100, Thomas Bogendoerfer wrote:
> there are SCSI host drivers, which also DMA to the sense buffer like
> sgiwd93.c for example.
Yes ... and there are others which don't, for example qla2xxx and
sym53c8xx.
--
Intel are signing my paycheques ... these opinions
On Fri, Dec 21, 2007 at 10:33:26AM +, Alan Cox wrote:
> On Fri, 21 Dec 2007 13:30:08 +1100
> Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly
> > by some low level drivers (that typically happens with USB mass
> > stora
On Fri, Dec 14, 2007 at 11:13:40AM -0700, Matthew Wilcox wrote:
> I'll send it to our DB team to see if this improves our numbers at all.
It does, by approximately 0.67%. This is about double the margin of
error, and a significant improvement. Thanks!
--
Intel are signing my pa
On Wed, Dec 19, 2007 at 10:50:40AM -0600, James Bottomley wrote:
> So, to get the best of both worlds, file a bugzilla and note the bugid.
> Then email a complete report to the relevant list, but add [BUG ]
> to the subject line and cc [EMAIL PROTECTED] If you do
> this, bugzilla will keep track o
On Wed, Dec 19, 2007 at 10:48:27AM +0200, Filippos Papadopoulos wrote:
> Would it be better to open a bug report at bugzilla?
No, it wouldn't. Bugzilla is a place where bug reports go to be
ignored. Witness 9370 where despite my best efforts to move discussion
to the mailing list, it's been thor
1 - 100 of 615 matches
Mail list logo
