Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

2019-01-27 Thread Masanori Goto
Thanks for the fix! 2019年1月27日(日) 4:11 Nathan Chancellor : > > On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of > > variable of type 'unsigned char' to itself [-Wself-assign] > >

Re: [PATCH] scsi: nsp32: fix logic bug in error handling

2017-10-15 Thread Masanori Goto
2017-09-05 16:51 GMT+09:00 Arnd Bergmann : > gcc-8 points out a logic error that has existed since the start > of the git history: > > drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': > drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to > false [-Werror=tautolo

Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.

2017-08-06 Thread Masanori Goto
nding it twice due to an error) Acked-by: Masanori Goto > --- > drivers/scsi/nsp32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c > index 53c8477..1430b3c 100644 > --- a/drivers/scsi/nsp32.c > +

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-29 Thread Masanori Goto
Oops, you're absolutely correct. Thanks for the follow up! Please change it as follow as you mentioned: Acked-by: GOTO Masanori Best regrads, -- gotom 2013/4/29 Arnd Bergmann : > On Friday 26 April 2013, Masanori Goto wrote: >> 2013/4/25 Arnd Bergmann >> > >> &

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-04-25 Thread Masanori Goto
2013/4/25 Arnd Bergmann > > ARM cannot handle udelay for more than 2 miliseconds, so we > should use mdelay instead for those. > Singed-off-by: GOTO Masanori > Signed-off-by: Arnd Bergmann > Cc: GOTO Masanori > Cc: YOKOTA Hiroshi > Cc: "James E.J. Bottomley" > Cc: linux-scsi@vger.kernel.org

Re: [PATCH 425/493] scsi: remove use of __devexit

2012-11-23 Thread Masanori Goto
2012/11/23 Guennadi Liakhovetski : > On Mon, 19 Nov 2012, Bill Pemberton wrote: > >> CONFIG_HOTPLUG is going away as an option so __devexit is no >> longer needed. > >> drivers/scsi/tmscsim.c| 2 +- > > Acked-by: Guennadi Liakhovetski Acked-by: GOTO Masanori Regards, -- goto

Re: [PATCH 097/493] scsi: remove use of __devexit_p

2012-11-23 Thread Masanori Goto
2012/11/23 Guennadi Liakhovetski : > On Mon, 19 Nov 2012, Bill Pemberton wrote: > >> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer >> needed. > >> drivers/scsi/tmscsim.c| 2 +- > > Acked-by: Guennadi Liakhovetski Acked-by: GOTO Masanori Regards, -- go

Re: [PATCH 319/493] scsi: remove use of __devinitdata

2012-11-23 Thread Masanori Goto
2012/11/23 Guennadi Liakhovetski : > On Mon, 19 Nov 2012, Bill Pemberton wrote: > >> drivers/scsi/tmscsim.c | 2 +- > > Acked-by: Guennadi Liakhovetski Acked-by: GOTO Masanori Regards, -- gotom > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Sof