consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada
---
drivers/scsi/cxgbi/Makefile | 2 +-
dr
My main motivation is to get rid of crappy header search path manipulation
from Kbuild core.
Before that, I want to do as many treewide cleanups as possible.
The full work of this is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
build-test
Masahiro
I was able to build without these extra header search paths.
Especially, the header search path -I. in kernel Makefiles is always
suspicious; it allows the compiler to search for headers in the top
of $(srctree), where obviously no header file exists.
Signed-off-by: Masahiro Yamada
Hi Christoph,
On Fri, Oct 19, 2018 at 9:58 PM Masahiro Yamada
wrote:
>
> On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux
> wrote:
>
> > > index a68b34183107..b185794549be 100644
> > > --- a/arch/arm/mach-pxa/Kconfig
> > > +++ b/arch/arm/
lp
> > @@ -219,6 +221,7 @@ config AKEBONO
> > select SWIOTLB
> > select 476FPE
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_HSTA_MSI
> > select I2C
> > --
> > 2.19.1
> >
--
Best Regards
Masahiro Yamada
amp; SCSI
> + depends on EISA && SCSI
> select SCSI_SPI_ATTRS
> ---help---
> This driver is for NCR53c710 based SCSI host adapters.
>
> - It currently supports Compaq EISA cards and NCR MCA cards
> + It currently supports Compaq EISA cards.
>
> config SCSI_DC395x
> tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
gt; - Say Y here if you have a system based on a Motorola 8xx-series
> - embedded processor with a QSPAN PCI interface, otherwise say N.
> -
> config PCI_8260
> bool
> depends on PCI && 8260
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
s/scsi/pcmcia/aha152x_core.c
> b/drivers/scsi/pcmcia/aha152x_core.c
> index dba3716511c5..24b89228b241 100644
> --- a/drivers/scsi/pcmcia/aha152x_core.c
> +++ b/drivers/scsi/pcmcia/aha152x_core.c
> @@ -1,3 +1,3 @@
> -#define PCMCIA 1
> +#define AHA152X_PCMCIA 1
> #define AHA152X_STAT 1
> #include "aha152x.c"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
Your patch will
> cause Kconfig to complain for those which mandatorily have PCI but
> do not set HAVE_PCI.
Good catch!
But, adding a bunch of 'select HAVE_PCI' along with 'select PCI' is ugly.
Do you have any suggestion?
How about letting CONFIG_ARM to select HAVE_PCI ?
--
Best Regards
Masahiro Yamada
rrect it easily by selecting
> HAVE_EISA for the right arm configs after this series.
What is your concern?
This absolutely looks dead to me.
> Suggested-by: Masahiro Yamada
> Signed-off-by: Christoph Hellwig
> ---
> arch/arm/Kconfig | 15 ---
> 1 file changed, 15 de
HAS_DMA.
We could add 'depends on HAVE_PCI' or something
to guard it to avoid changing the logic.
config PCI_ENDPOINT
bool "PCI Endpoint Support"
depends on HAVE_PCI # Is this correct ??
depends on HAS_DMA
or better to have 'depends on PCI' ?
PCI ML is also CC'ed, so comments are appreciated.
--
Best Regards
Masahiro Yamada
Acked-by: Thomas Gleixner
--
Best Regards
Masahiro Yamada
> Acked-by: Thomas Gleixner
> ---
--
Best Regards
Masahiro Yamada
kernel for an EISA-based machine.
> -
> - Otherwise, say N.
> -
> config SBUS
> bool
>
--
Best Regards
Masahiro Yamada
+ depends on EISA && SCSI
> select SCSI_SPI_ATTRS
> ---help---
> This driver is for NCR53c710 based SCSI host adapters.
>
> - It currently supports Compaq EISA cards and NCR MCA cards
> + It currently supports Compaq EISA cards.
>
> config SCSI_DC395x
> tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
On Mon, Oct 15, 2018 at 5:57 PM Christoph Hellwig wrote:
>
> On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote:
> > I think HAVE_ is a preferred prefix in this case according to this doc:
> > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kc
nce
> (when needed) and then handles everything in the bus-specific
> Kconfig file under drivers/.
>
Thanks for great work again.
However, I suspect some breakages
(not testing yet, just quick review by my eyes.)
I left some comments in individual patches.
--
Best Regards
Masahiro Yamada
@ -518,11 +521,6 @@ config ALPHA_SRM
>
> If unsure, say N.
>
> -config EISA
> - bool
> - depends on ALPHA_GENERIC || ALPHA_JENSEN || ALPHA_ALCOR ||
> ALPHA_MIKASA || ALPHA_SABLE || ALPHA_LYNX || ALPHA_NORITAKE || ALPHA_RAWHIDE
> - default y
> -
Better to add CONFIG_EISA=y to arch/alpha/defconfig
to not flip the default?
--
Best Regards
Masahiro Yamada
so it may be safest to say "Y" anyway.
> -
> -source "drivers/pci/Kconfig"
> -
> config GSC_DINO
> bool "GSCtoPCI/Dino PCI support"
> depends on PCI && GSC
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 56ff8f6d31fc..229a518b68cd 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -3,6 +3,18 @@
> # PCI configuration
> #
>
> +config HAS_PCI
> + bool
> +
> +menuconfig PCI
> + bool "PCI support"
> + depends on HAS_PCI
> +
> + help
> + This option enables support for the PCI local bus, including
> + support for PCI-X and the fundations for PCI Express support.
> + Say 'Y' here unless you know what you are doing.
> +
> source "drivers/pci/pcie/Kconfig"
>
> config PCI_MSI
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
_QSPAN
arch/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx
arch/powerpc/Kconfig:config PCI_QSPAN
With your patch, PCI_QSPAN will become
a dead config option.
How about removing it entirely?
--
Best Regards
Masahiro Yamada
Remove unneeded variables and assignments.
Signed-off-by: Masahiro Yamada
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 6 +-
drivers/scsi/arcmsr/arcmsr_hba.c| 4 +---
drivers/scsi/esas2r/esas2r_ioctl.c | 20
drivers/scsi/lpfc/lpfc_attr.c | 8
21 matches
Mail list logo
