if queue is broken
https://git.kernel.org/mkp/scsi/c/d6b75ba52189
--
Martin K. Petersen Oracle Linux Engineering
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series has couple bug fixes for the driver.
>
> First patch addresses initialization error with the newer adapter on a
> blade systems.
>
> Second patch adds protection for accidental flash corruption using SysFS
> path.
Applied to 5.4/scsi-fixes,
d by this
series. Please review and address those. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
s-bsg driver might send various commands, disregarding the pm
> status of the device. This is wrong, regardless if its request queue
> is pm-aware or not.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
unlock_irqrestore(&pg->lock, flags);
Instead of checking for EXPLICIT one place and checking for !IMPLICIT
another, can we consolidate the two and maybe do:
if (pg->flags & ALUA_PG_RUN_STPG &&
scsi_device_tpgs(sdev) == TPGS_MODE_EXPLICIT) {
Hannes,
> DRIVER_ERROR is a a driver byte setting, not a host byte. The qla2xxx
> driver should rather return DID_ERROR here to be in line with the
> other drivers.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
merged by Linus. You can then request a stable backport.
--
Martin K. Petersen Oracle Linux Engineering
58
Johannes: Whatever happened to your efforts at cleaning all this up? Do
you have a patch series or a working tree we could use as starting
point?
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> Like other callers of scsi_execute(send_trespass_cmd, hp_sw_tur...),
> we need to check whether sshdr is valid.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
erybody
is handling DRIVER_SENSE and scsi_sense_valid() correctly. Looks like
we're generally OK, but please verify.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
then the sense is
present. It really should check both driver_byte(result) == DRIVER_SENSE
and scsi_sense_valid(sshdr) before poking at the sense data.
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> I modify these in a patch? or every .c a patch, use a patchset?
A patchset consisting of one patch per file, please.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Hannes,
> The BUILD_NVME define never got defined anywhere, causing NVMe
> commands to be treated as SCSI commands when freeing the buffers.
> This was causing a stuck discovery and a horrible crash in
> lpfc_set_rrq_active() later on.
Applied to 5.4/scsi-fixes, thanks!
--
Martin
s!
> Please consider to contribute the test case to the blktests project.
Yes, please do!
--
Martin K. Petersen Oracle Linux Engineering
Don,
> - correct returning from reset before outstanding
> commands are completed for the device.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> Clearing ch->device in ch_release() is wrong because that pointer must
> remain valid until ch_remove() is called. This patch fixes the
> following crash the second time a ch device is opened:
Applied to 5.4/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
n
> Signed-off-by: Sumit Saxena
> Signed-off-by: Chandrakanth Patil
Next time, please make sure you put a "---" separator before the patch
changelog.
> v2:
[...]
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Don,
> These patches are based on Linus's tree
Applied to 5.5/scsi-queue. There was some fuzz but I think I figured it
out.
--
Martin K. Petersen Oracle Linux Engineering
27;t need to evaluate the RTPG
> data (which we won't have anyway).
Applied to 5.4/scsi-fixes, thanks you!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> This line is indented too far so it's a bit confusing.
Applied to 5.5/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol
> 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
lied patches 8-14 to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
I'm assuming that Himanshu and Quinn are working on another
> series of fixes, in which case that should take precedence
> over this patch. I just wanted to provide this so that the
> already known problems are fixed in your tree.
Himanshu: Please review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Update maintainer's entries for qla2xxx driver now that email
> addresses have been changed to Marvell.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
n end user scenario
> where I need a quick switch to let even shaky paths survive.
Can't say I like it. But it's your driver.
Applied to 5.4/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Damien,
> When a non-passthrough command is terminated with CHECK CONDITION,
> request sense is executed by hijacking the command descriptor. [...]
Applied to 5.4/scsi-fixes. Thanks for debugging this issue!
--
Martin K. Petersen Oracle Linux Engineering
it of allowing things to continue? Are you hoping things
will eventually recover in a single-path scenario?
--
Martin K. Petersen Oracle Linux Engineering
t
removing the line. Or--if people feel the size is valuable
information--just zap the pointer. Also, since this is unrelated to the
duration randomization it should be a separate patch.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
n. It makes no
mention of the actual kernel changes and the introduced module
parameter.
> +static bool ber_stop = true;
> +module_param(ber_stop, bool, 0600);
> +MODULE_PARM_DESC(ber_stop,
> + "Shuts down FCP devices for FCP channels that report a
> bit-error count in excess of its threshold (default on)");
> +
--
Martin K. Petersen Oracle Linux Engineering
MEGASAS_MSIX_NAME_LEN is too small given that naming scheme?
Also, please use %u.
--
Martin K. Petersen Oracle Linux Engineering
when the
> system is asked to perform a suspend of the drive, it will be sent a
> SYNCHRONIZE CACHE. If that fails due to password protection, the error
> must be ignored. --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2
> insertions(+), 1 deletion(-)
Applied to 5.4/scsi-fixes, th
Ryan,
> Add sysfs attributes for the ATA information page and Supported VPD
> Pages page.
Applied to 5.5/scsi-queue, thank you.
--
Martin K. Petersen Oracle Linux Engineering
ime suspend
> the underlying hardware will be always on even when it is not doing
> any useful work and thus wasting power.
Applied to 5.5/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> This patch series contains enhancements w.r.t to diag buffer support
> and few bug fix patches.
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
James,
> Update lpfc to revision 12.4.0.1
Applied to 5.5/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
re no
longer available for smartmontools to monitor.
--
Martin K. Petersen Oracle Linux Engineering
her have a SCSI host flag to override the behavior or
consider masking PQ in the driver. Unfortunately, I don't have any
aacraid controllers I can test with in my test setup so I'd have to
synthesize a setup with scsi_debug.
--
Martin K. Petersen Oracle Linux Engineering
ertises both
> capabilites under same WWNN.
>
> Please apply this series for 5.4/scsi-queue at your earliest
> convenience.
This came in too late for 5.4. I applied patches #1-7 to fixes. Patch #8
and beyond are more like features and will have to wait for 5.5.
Thanks!
--
Martin K. Pe
> For pci device, need to disable device when probe failed after enabled
> device.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Stanley,
> In some cases, hba may go through shutdown flow without successful
> initialization and then make system hang.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ess/submitting-patches.rst. Your patch got
all mangled since you put tags after the --- separator.
Also, please use the -vN option when submitting updated patches.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
is patch fixes it.
I am not going to rebase this late in the cycle. Himanshu or Quinn will
need to send a request to stable@ after Linus pulls 5.4/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
" separator.
> V2. Indent comments as suggested
>
> Signed-off-by: Laurence Oberman
--
Martin K. Petersen Oracle Linux Engineering
4132 was not
> affected, as it called blk_rq_set_block_pc().
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> In fcoe_if_init, if fc_attach_transport(&fcoe_vport_fc_functions)
> fails, need to free the previously memory and return fail,
> otherwise will trigger null-ptr-deref Read in fc_release_transport.
Applied to 5.4/scsi-queue. Thank you.
--
Martin K. Petersen
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Use kmemdup rather than duplicating its implementation
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bjorn,
> This series adds a new ufs vops to allow platform specific methods for
> resetting an attached UFS device, then implements this for the
> Qualcomm driver. This reset seems to be necessary for the majority of
> Dragonboard845c devices.
Applied to 5.4/scsi-queue, thanks!
tate
> being set, the recovery fails and the adapter is left in limbo.
>
> Revise the adapter reset routine so that it will only mark the adapter
> in error if it was unable to reset the adapter.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sakari,
> Convert the remaining %pf users to %ps to prepare for the removal of
> the old %pf conversion specifier support.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series has few bug fixes for the driver.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Damien,
> For commands completing with a resid not aligned on the device logical
> sector size, also print the command CDB in addition to the current
> message to help debug hardware generating such incorrect command
> completion information.
Applied to 5.4/scsi-queue. Thanks!
Govindarajulu,
> pci_alloc_irq_vectors() returns number of vectors allocated.
> Fix the check for error condition.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
port speed
> at driver initialization and if the speed changes. Also clean up a
> small typo in fnic_trace.c.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> zhengbin (3):
> scsi: bnx2fc: remove set but not used variable 'fh'
> scsi: bnx2fc: remove set but not used variables 'lport','host'
> scsi: bnx2fc: remove set but not used variables
> 'task','port','
Saurav,
> This series have bug fixes and improve the log messages for better
> debugging.
>
> Kindly apply this series to scsi-queue at your earliest convenience.
Applied to 5.4/scsi-queue. I fixed a warning in patch #8. Please
verify. Thanks!
--
Martin K. Petersen
river changes.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
cal variable,
> obtaining a random pointer value that when used eventually faulted
> the system
>
> Convert offending code to use local variable.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
James,
> Raise the config max for lpfc_fcp_mq_threshold variable to 256.
Not a big fan of these magic values.
Applied to 5.3/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
James,
> Capturing and downloading dif command data and dif data was done a
> dozen years ago and no longer being used. Also creates a potential
> security hole.
>
> Remove the debugfs buffer for dif debugging.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen
a 784 vs 768
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
zhengbin,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/ufs/ufs-qcom.c: In function ufs_qcom_pwr_change_notify:
> drivers/scsi/ufs/ufs-qcom.c:808:6: warning: variable val set but not used
> [-Wunused-but-set-variable]
Applied to 5.4/scsi-que
to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> This patch provides the module parameter and sysfs interface named
> 'enable_sdev_max_qd' to switch between the driver provided
> (optimal)queue depth and controller queue depth (can_queue).
Applied to 5.4/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
ny serious io load triggers controller aborts)
Microchip folks: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
Martin K. Petersen Oracle Linux Engineering
Stanley,
> Currently bits in hba->outstanding_tasks are cleared only after their
> corresponding task management commands are successfully done by
> __ufshcd_issue_tm_cmd().
Applied to 5.4/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
James,
> Update lpfc to revision 12.4.0.0
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
declared as
> constant. Hence declare ufs_hba_qcom_vops itself constant as well to
> protect it from unintended modification.
> Issue found with Coccinelle.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
low memory
> conditions.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
_sli_handle_fast_ring_event
> <- lpfc_sli_fp_intr_handler
> <- lpfc_sli_intr_handler
> and lpfc_sli_intr_handler is an interrupt handler.
> Interrupts are enabled in interrupt handler.
> Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
> in IRQ context to avoid this
Fuqian,
> Remove the redundant initialization code.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
Martin,
> The first patch of the series is a fix for a memory corruption we
> saw in a test where qla2xxx was loaded/unloaded repeatedly under
> memory pressure. The second one is a cleanup/consistency fix.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Ora
deallocated
> by the target core at that moment. As the result, this access triggers
> a use-after-free warning from KASAN.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
oherent.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
eing
described as "optimum" when it clearly isn't.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
s for kernel
> version v5.4.
Applied to 5.4/scsi-queue. Thanks you!
--
Martin K. Petersen Oracle Linux Engineering
Suganath,
> This patch series includes below Enhancements and Bug fixes.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
oth land linus tree.
I'll set up an amalgamated for-next branch tomorrow.
--
Martin K. Petersen Oracle Linux Engineering
which leaves
> mappings to hardware queues incomplete and crashes the system.
>
> Fix by recognizing the null mask and assigning the vector to the first
> cpu in the system.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Helge,
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Li,
> If the userspace process crashes while we send the nl msg, it is
> possible that the cmd in curr_nl_cmd of tcmu_dev never gets reset to
> 0, and and returns busy for other commands after the userspace process
> is restartd.
Applied to 5.4/scsi-queue, thanks!
--
Martin
Bart,
> The patches in this series address SCSI device blocking and unblocking
> and fix a boot failure. Please consider these patches for kernel
> version v5.4.
Applied to 5.4/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Chandrakanth,
> This patch provides the module parameter and sysfs interface to switch
> between the firmware provided (optimal) queue depth and controller
> queue depth (can_queue).
This smells a bit like a don't-be-broken flag.
Why isn't the firmware-provided value opt
Himanshu,
> This series contains bug fixes for the driver. Most of the fixes are
> obvious memory leak and/or error handling fixes.
>
> Please apply this series to 5.4/scsi-queue at your earliest
> convenience.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen
ve updated the function to the latest style as well.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Andy,
> We can use for_each_set_bit() to slightly simplify the code.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Suganath,
> Although SAS3 & SAS3.5 IT HBA controllers support 64-bit DMA
> addressing, as per hardware design, if DMA able range contains all
> 64-bits set (0x-) then it results in a firmware fault.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen
Don,
> These patches are based on Linus's tree
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
the usage by embedding
> fc_rport_priv into fcoe_rport, and use the fcoe_rport structure
> wherever possible. This patchset also contains some minor whitespace
> cleanups for libfc.h.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sergei,
> Here's a set of 3 patches against the Linus' repo. The recently
> resurrected Future Domain SCSI driver got a facelift by Ondrej (thank
> you!); however, several magic numbers were overlooked, so I went and
> fixed these cases.
Applied to 5.4/scsi-queue. Th
f isn't new to me -- I wrote a FD SCSI driver for
> another OS back in '90s... I thought I might still have a real card
> somewhere in my flat but none were found... :-(
Ondrej: Please review!
--
Martin K. Petersen Oracle Linux Engineering
I queued this up since it breaks stuff for enough people. But I do feel
that some of Bart's concerns may be valid.
--
Martin K. Petersen Oracle Linux Engineering
.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
ess those and repost.
Hannes: Please fix!
--
Martin K. Petersen Oracle Linux Engineering
e by moving 'mutex_lock(&scsi_sense_cache_mutex)' before
> scsi_select_sense_cache().
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Zhang,
> Retrying immediately after we've received a 'transitioning' sense
> code is pretty much pointless, we should always use a delay before
> retrying.
Does Hannes' patch alleviate your issue?
--
Martin K. Petersen Oracle Linux Engineering
1 - 100 of 3475 matches
Mail list logo
