Re: [PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-02-15 Thread Manivannan Sadhasivam
On Fri, Jan 11, 2019 at 03:35:02PM -0600, Rob Herring wrote: > On Sat, 5 Jan 2019 12:58:57 +0530, Manivannan Sadhasivam wrote: > > Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very > > similar to HI3660 SoC with almost same IPs. Only major difference in terms &g

Re: [PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-01-26 Thread Manivannan Sadhasivam
On Sat, Jan 05, 2019 at 12:58:59PM +0530, Manivannan Sadhasivam wrote: > Add HI3670 SoC UFS driver support by extending the common ufs-hisi > driver. One major difference between HI3660 ad HI3670 SoCs interms of > UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is

[PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-01-04 Thread Manivannan Sadhasivam
Add UFS controller support for HiSilicon HI3670 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi

[PATCH v2 0/3] Add UFS controller support for HI3670 SoC

2019-01-04 Thread Manivannan Sadhasivam
the difference between two in driver. Thanks, Mani Changes in v2: As per Rob's review: * Removed interrupt-parent property from binding. * Fixed the bindings patch commit message. Manivannan Sadhasivam (3): dt-bindings: ufs: Add HI3670 UFS controller binding arm64: dts: hisilicon: hi3670

[PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-01-04 Thread Manivannan Sadhasivam
Add HI3670 SoC UFS driver support by extending the common ufs-hisi driver. One major difference between HI3660 ad HI3670 SoCs interms of UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is used to distinguish the configuration. Signed-off-by: Manivannan Sadhasivam

[PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-01-04 Thread Manivannan Sadhasivam
HI3670 without any fallback. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt

Re: [PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2018-12-20 Thread Manivannan Sadhasivam
Hi Rob, On Thu, Dec 20, 2018 at 11:12:44AM -0600, Rob Herring wrote: > On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote: > > Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very > > similar to HI3660 SoC with almost same IPs. Only major dif

[PATCH 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2018-12-07 Thread Manivannan Sadhasivam
Add HI3670 SoC UFS driver support by extending the common ufs-hisi driver. One major difference between HI3660 ad HI3670 SoCs interms of UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is used to distinguish the configuration. Signed-off-by: Manivannan Sadhasivam

[PATCH 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2018-12-07 Thread Manivannan Sadhasivam
Add UFS controller support for HiSilicon HI3670 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi

[PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2018-12-07 Thread Manivannan Sadhasivam
Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very similar to HI3660 SoC with almost same IPs. Only major difference interms of UFS is the PHY. HI3670 has 10nm PHY. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 4 +++- 1 file

[PATCH 0/3] Add UFS controller support for HI3670 SoC

2018-12-07 Thread Manivannan Sadhasivam
the difference between two in driver. Thanks, Mani Manivannan Sadhasivam (3): dt-bindings: ufs: Add HI3670 UFS controller binding arm64: dts: hisilicon: hi3670: Add UFS controller support scsi: ufs: Add HI3670 SoC UFS driver support .../devicetree/bindings/ufs/ufs-hisi.txt | 4

LED trigger for UFS device activity

2018-10-01 Thread Manivannan Sadhasivam
Hello everyone, I'm looking into adding LED trigger support for UFS device activity. This essentially means a dedicated LED will blink upon the UFS device activity like we have for ATA, MTD, NAND devices. Currently, I'm not sure about the places where we have to insert this trigger. My only choic