From: Long Li
This is a best effort for estimating on how busy the ring buffer is for
that channel, based on available buffer to write in percentage. It is still
possible that at the time of actual ring buffer write, the space may not be
available due to other processes may be writing at the
> Subject: Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE
> devices
>
>
> Long,
>
> > Can you take a look at the following patch?
>
> >> > + max_sub_channels =
> >> > +(num_cpus - 1) / storvsc_vcpus_per_sub_channel;
>
> What happens if num_cpus = 1?
If num_c
Hi Martin
Can you take a look at the following patch?
Long
> > -Original Message-
> > From: linux-kernel-ow...@vger.kernel.org
> > On Behalf Of Long Li
> > Sent: Thursday, March 22, 2018 2:47 PM
> > To: KY Srinivasan ; Haiyang Zhang
> > ; S
> Subject: RE: [Resend Patch 3/3] Storvsc: Select channel based on available
> percentage of ring buffer to write
>
> > -Original Message-
> > From: linux-kernel-ow...@vger.kernel.org
> > On Behalf Of Long Li
> > Sent: Tuesday, March 27, 2018 5:49 PM
>
> Subject: Re: [Resend Patch 1/3] Vmbus: Add function to report available ring
> buffer to write in total ring size percentage
>
>
> Long,
>
> > Netvsc has a function to calculate how much ring buffer in percentage
> > is available to write. This function is also useful for storvsc and
> > other
> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
>
>
> Long, KY: Please confirm.
>
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it imp
From: Long Li
In Vmbus, we have defined a function to calculate available ring buffer
percentage to write.
Use that function and remove netvsc's private version.
Signed-off-by: Long Li
---
drivers/net/hyperv/hyperv_net.h | 1 -
drivers/net/hyperv/netvsc.c | 17 +++--
dr
From: Long Li
This is a best effort for estimating on how busy the ring buffer is for
that channel, based on available buffer to write in percentage. It is still
possible that at the time of actual ring buffer write, the space may not be
available due to other processes may be writing at the
From: Long Li
Netvsc has a function to calculate how much ring buffer in percentage is
available to write. This function is also useful for storvsc and other
vmbus devices.
Define a similar function in vmbus to be used by other vmbus devices.
Signed-off-by: Long Li
---
drivers/hv
> Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring
> buffer percentage
>
>
>
> > -Original Message-
> > From: Haiyang Zhang
> > Sent: Friday, March 23, 2018 8:01 AM
> > To: Long Li ; KY Srinivasan
> > ; Stephen Hemmi
From: Long Li
In Vmbus, we have defined a function to calculate available ring buffer
percentage to write.
Use that function and remove duplicate netvsc code.
Signed-off-by: Long Li
---
drivers/net/hyperv/netvsc.c | 17 +++--
drivers/net/hyperv/netvsc_drv.c | 3 ---
2 files
From: Long Li
This is a best effort for estimating on how busy the ring buffer is for
that channel, based on available buffer to write in percentage. It is still
possible that at the time of actual ring buffer write, the space may not be
available due to other processes may be writing at the
From: Long Li
Netvsc has a similar function to calculate how much ring buffer in
percentage is available to write. This function is useful for storvsc and
other vmbus devices.
Define a similar function in vmbus to be used by storvsc.
Signed-off-by: Long Li
---
drivers/hv/ring_buffer.c | 2
From: Long Li
Unlike SCSI and FC, we don't use multiple channels for IDE.
Also fix the calculation for sub-channels.
Change log:
v2: Addressed comment on incorrect number of sub-channels.
(Michael Kelley )
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 7 +--
1 file chang
> > Subject: [PATCH] storvsc: Set up correct queue depth values for IDE
> > devices
> >
> > From: Long Li
> >
> > Unlike SCSI and FC, we don't use multiple channels for IDE. So set
> > queue depth correctly for IDE.
> >
> > Also set the
From: Long Li
Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth
correctly for IDE.
Also set the correct cmd_per_lun for all devices.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --
From: Long Li
This patch backports upstream commit ca8dc694045e9aa248e9916e0f614deb0494cb3d
for 4.14-stable.
commit ca8dc694045e9aa248e9916e0f614deb0494cb3d:
We should set the error code if fc_remote_port_add() fails.
Cc: #v4.12+
Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC
> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
> channel for I/O requests
>
> > From: Long Li
> > Sent: Wednesday, January 31, 2018 12:23 PM
> > To: Michael Kelley (EOSG) ; KY
> > Srinivasan ; Stephen Hemminger
> &g
> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
> channel for I/O requests
>
> Updated/corrected two email addresses ...
>
> > -Original Message-
> > From: Michael Kelley (EOSG)
> > Sent: Wednesday, January 24, 2018 2:14 PM
> > To: KY Srinivasan ; Stephen Hemmin
From: Long Li
The original patch was made for stable 4.1 and was Acked on 08/22/2017, but for
some reason it never made it to the stable tree.
Change from v1:
Changed comment that this patch is for linux-stable 4.1 and all prior stable
kernels.
storvsc checks the SG list for gaps before
> Christoph,
>
> > Ok. If the stable maintainers are ok with your small fix I'm not
> > going to complain too loudly. But I'm always worried about stable
> > trees divering too much from mainline.
>
> The seemingly innocuous transition from SG_GAPS to virt boundary has
> caused several data cor
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Monday, November 6, 2017 7:40 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; James E . J . Bottomley
> ; Martin K . Petersen
> ; de...@linuxdriverproject.org; linux
From: Long Li
When there are multiple disks attached to the same SCSI controller,
the host may send several VSTOR_OPERATION_REMOVE_DEVICE or
VSTOR_OPERATION_ENUMERATE_BUS messages in a row, to indicate there is a
change on the SCSI controller. In response, storvsc rescans the SCSI host.
There
n't need
> the separate allocation.
>
> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
>
> Except for this nit this looks fine to me:
>
> Reviewed-by: Christoph Hellwig
The work storvsc_host_scan (scheduled fro
> Long,
>
> >> Which kernel version is this patch aimed at?
> >
> > Martin, thanks for pointing this out. This should also go to stable
> > trees.
>
> The reason I asked is that it didn't apply to neither fixes, nor for-next.
>
> I applied it to 4.13/scsi-fixes by hand and added a stable tag.
T
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, August 29, 2017 6:31 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; James E . J . Bottomley
> ; de...@linuxdriverproject.org; linux-
> s...@vg
From: Long Li
When storvsc is sending I/O to Hyper-v, it may allocate a bigger buffer
descriptor for large data payload that can't fit into a pre-allocated
buffer descriptor. This bigger buffer is freed on return path.
If I/O request to Hyper-v fails due to ring buffer busy, the st
> Wouldn't it make sense to backport the changes to set the virt_boundary
> (which probably still is the SG_GAPS flag in such an old kernel)?
We can make storvsc use SG_GAPS. But the following patch is missing in 4.1
stable block layer to make this work on some I/O situations. Backporting is
m
From: Long Li
This patch is for linux-stable 4.1 branch only.
storvsc checks the SG list for gaps before passing them to Hyper-v device.
If there are gaps, data is copied to a bounce buffer and a continuous data
buffer is passed to Hyper-V.
The check on gaps assumes SG list is continuous, and
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, June 14, 2017 1:25 AM
> To: Long Li ; James E.J. Bottomley
> ; Martin K. Petersen ;
> linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; KY Srinivasan
> ; Bart Van
From: Long Li
FC disks issue I/O directly to the host storage port driver, this is
diffirent to VHD disks where I/O is virtualized and timeout is handled
by the host VSP (Virtualization Service Provider).
FC disks are usually setup in a multipath system, and they don't want to
reset timer
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Tuesday, June 13, 2017 8:38 AM
> To: linux-ker...@vger.kernel.org; KY Srinivasan ;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org; Stephen Hemminger
> ; Long Li ;
> j.
From: Long Li
FC disks are usually setup in a multipath system, and they don't want to
unconditionaly reset I/O on timeout. I/O timeout is detected by multipath
as a good time to failover and recover.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 7 +++
1 file chang
From: Long Li
In lower layer driver's (LLD) scsi_host_template, the driver may optionally
ask SCSI to allocate its private driver memory for each command, by
specifying cmd_size. This memory is allocated at the end of scsi_cmnd by SCSI.
Later when SCSI queues a command, the LLD ca
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Thursday, May 18, 2017 8:52 AM
> To: h...@infradead.org
> Cc: j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org; Stephen Hemminger ; KY
>
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Monday, May 15, 2017 5:01 PM
> To: j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org; Long Li ;
> martin.peter...@oracle.com
> Cc: Stephen Hemm
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Monday, May 15, 2017 4:03 PM
> To: j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org; Long Li ;
> martin.peter...@oracle.com
> Cc: Long Li
>
> -Original Message-
> From: Long Li [mailto:lon...@exchange.microsoft.com]
> Sent: Wednesday, May 10, 2017 2:07 PM
> To: James E.J. Bottomley ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: Long Li
> Subject: [PATCH] s
From: Long Li
Lower layer driver may not initialize private data before use. Zero them
out to prevent use of stale data.
Signed-off-by: Long Li
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, September 7, 2016 12:47 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; de...@linuxdriverproject.org; linux
From: Long Li
When sense message is present on error, we should pass along to the upper layer
to decide how to deal with the error. This patch fixes connectivity issues with
Fiber Channel devices.
---
drivers/scsi/storvsc_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
From: Long Li
We no long have the restriction of page size limit in the SG list. Remove it.
The driver can properly handle default block segment size.
---
drivers/scsi/storvsc_drv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
From: Long Li
Properly set SRB flags when hosting device supports tagged queuing. This patch
improves the performance on Fiber Channel disks.
---
drivers/scsi/storvsc_drv.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
From: Long Li
This patch set fixes connectivity issues and improves performance for Fiber
Channel disks.
Long Li (3):
Use tagged SRB requests if supported by the device
Properly handle SRB_ERROR when sense message is present
Use block layer default segment size
drivers/scsi
ay, June 6, 2016 8:42 PM
> To: Long Li
> Cc: Tom Yan ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] sd: remove redundant check for
> BLK_DEF_MAX_SECTORS
>
> >>>>> "Lon
change it again. If
they want max_sectors to be set by sd, they can use BLOCK LIMITS VPD to tell it
to do so.
> -Original Message-
> From: Tom Yan [mailto:tom.t...@gmail.com]
> Sent: Saturday, June 4, 2016 1:41 AM
> To: Long Li
> Cc: James E.J. Bottomley ; Martin K. Pete
ing values on optional VPD page 0xb0 "Block
Limits".
Signed-off-by: Long Li
---
drivers/scsi/sd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 60bff78..d8c4047 100644
--- a/drivers/scsi/sd.c
+++ b/driv
It tested well with hyper-v virtual disk.
Tested-by: Long Li
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Andrew Patterson
> Sent: Wednesday, June 1, 2016 2:57 PM
> To: Christoph Hellwig ; Mar
Hi Martin,
Yes I would like to test it. Please let me know when they get in there.
Thanks
Long
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, May 31, 2016 7:44 PM
> To: Long Li
> Cc: Bart Van Assche ; James
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Thursday, May 26, 2016 7:19 PM
> To: Long Li ; James E.J. Bottomley
> ; Martin K. Petersen
>
> Cc: KY Srinivasan ; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.o
The block sector size should be in unit of 512 bytes, not in bytes.
Signed-off-by: Long Li
---
drivers/scsi/sd.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, December 4, 2015 1:53 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; James E.J. Bottomley ;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux-
&
Introduce a logging level for storvsc to log certain error/warning messages.
Those messages are helpful in some environments, e.g. Microsoft Azure, for
customer support and troubleshooting purposes.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 34
Thanks Joe.
I'll send out another patch.
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Thursday, December 3, 2015 6:28 PM
> To: Long Li ; KY Srinivasan ;
> Haiyang Zhang ; James E.J. Bottomley
>
> Cc: de...@linuxdriverproject.org;
Introduce a logging level for storvsc to log certain error/warning messages.
Those messages are helpful in some environments, e.g. Microsoft Azure, for
customer support and troubleshooting purposes.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 30 +-
1
> -Original Message-
> From: KY Srinivasan
> Sent: Friday, July 03, 2015 11:35 AM
> To: Vitaly Kuznetsov; linux-scsi@vger.kernel.org
> Cc: Long Li; Haiyang Zhang; James E.J. Bottomley;
> de...@linuxdriverproject.org;
> linux-ker...@vger.kernel.org
> Subject: R
;
> Allow WRITE_SAME for Windows10 and above hosts.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scsi/storvsc_drv.c |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>
;
> From: keith.ma...@microsoft.com
>
> Currently we are making decisions based on vmbus protocol versions that have
> been negotiated; use storage potocol versions instead.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by:
t.com
>
> Use a single value to track protocol versions to simplify comparisons and to
> be
> consistent with vmbus version tracking.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scs
based on ranges.
>
> From: keith.ma...@microsoft.com
>
> Rather than look for sets of specific protocol versions, make decisions based
> on
> ranges. This will be safer and require fewer changes going forward as we add
> more storage protocol versions.
>
Reviewed-by: Long Li
h.ma...@microsoft.com
>
> Use storage protocol version instead of vmbus protocol version when
> determining storage capabilities.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scsi/st
om: keith.ma...@microsoft.com
>
> Use correct defaults for values determined by protocol negotiation, instead of
> resetting them with every scsi controller.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by:
tion without properly freeing up the maapings we may
> have acquired. Fix the bug.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> Cc:
> ---
> drivers/scsi/storvsc_drv.c | 15 ---
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git
terlists presented are not chained.
> Fix the code to not make this assumption.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 98 +--
> 1 files changed, 57 insertions(+), 41 deletions(-)
ut that WS2008R2 cannot correctly
> handle these new limits. Fix this bug by setting the limits based on the host.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 15 ---
> 1 files changed, 12 insertions(+), 3 deletion
e host when the host notifies that a scan is needed.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 19 +++
> 1 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/d
support on these hosts.
>
> Suggested by: James Bottomley
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 13 +
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/storvsc
ay have been removed prior to discovering LUNs that may have
> been added.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 26 ++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --gi
Thanks Martin for the explanation.
I'll send out another patch.
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, December 11, 2014 7:04 PM
> To: Long Li
> Cc: Martin K. Petersen; KY Srinivasan; Haiyang Zhang;
> j
> >>>>> "Long" == Long Li writes:
>
> Long> MSFT targets currently claim SPC-2 compliance while they implement
> Long> post SPC-2 features. With this patch we can correctly handle
> Long> WRITE_SAME_16 issues.
>
> Handle the issues or han
> -Original Message-
> From: Sitsofe Wheeler [mailto:sits...@gmail.com]
> Sent: Wednesday, December 10, 2014 12:58 PM
> To: Long Li
> Cc: KY Srinivasan; Haiyang Zhang; jbottom...@parallels.com; linux-
> s...@vger.kernel.org; de...@linuxdriverproject.org; linux-
> k
MSFT targets currently claim SPC-2 compliance while they implement post SPC-2
features. With this patch we can correctly handle WRITE_SAME_16 issues.
This patch fixes an issue where the flag is setup too late in drive
initialization process.
Reviewed-by: K. Y. Srinivasan
Signed-off-by: Long
When ring buffer returns an error indicating retry, storvsc may not return a
proper error code to SCSI when bounce buffer is not used. This has introduced
I/O freeze on RAID running atop storvsc devices. This patch fixes it by always
returning a proper error code.
Signed-off-by: Long Li
73 matches
Mail list logo
