Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Linus Walleij
ssive) work by hiding all the ATA drives behind SCSI emulation with libata, so they want me to keep up that tradition by also making the temperature reading behave "as if it was a SCSI drive" too so I'm on board with trying that out even if I think the bar is a bit high for causal c

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Linus Walleij
of libata that USB need to share. I can certainly start with just ATA. The thing/command I pass in now is ATA_16 (0x85) 16-byte pass-thru, I take it that a ATA_16 pass thru is NOT a proper command or modepage but something like an uglyhack?... Yours, Linus Walleij

[PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-18 Thread Linus Walleij
river registers using devm_hwmon_device_register_with_info() so hwmon sensors will go away with their parent devices. Reviewed-by: Guenter Roeck # HWMON Signed-off-by: Linus Walleij --- ChangeLog v6->v7: - Updated the commit message. - Partly bumping because SCSI maintainers seem to be ghosting the patch. I&

[PATCH v6 RESEND] scsi: Add hwmon support for SMART temperature sensors

2018-11-12 Thread Linus Walleij
sensors will go away with their parent devices. Reviewed-by: Guenter Roeck # HWMON Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Add the hwmon sensor on the scsi_add_lun() synchronous or scsi_sysfs_add_devices() asynchronous path. - Add a flag to drivers/usb/storage/scsiglue.c so

[PATCH v6] scsi: Add hwmon support for SMART temperature sensors

2018-10-30 Thread Linus Walleij
sensors will go away with their parent devices. Reviewed-by: Guenter Roeck # HWMON Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Add the hwmon sensor on the scsi_add_lun() synchronous or scsi_sysfs_add_devices() asynchronous path. - Add a flag to drivers/usb/storage/scsiglue.c so

Re: [smartmontools-support] [PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-16 Thread Linus Walleij
Hi Christian, thanks a lot for your feedback! On Tue, Oct 16, 2018 at 7:36 AM Christian Franke wrote: > Linus Walleij wrote: > > ... > > - I am uncertain if this applies to SAS drives as well, > >it appears not (Christian Frankes answer) they > >require a dif

Re: [PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-11 Thread Linus Walleij
On Mon, Oct 8, 2018 at 8:09 AM Hannes Reinecke wrote: > On 10/7/18 10:49 PM, Linus Walleij wrote: > Hmm. I might be getting something wrong here, but the main problem with > SMART values is that they are _not_ really standardized; plus any drive > is free to implement whatever they w

[PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-07 Thread Linus Walleij
uniform way without need for any special tools such as "hddtemp" (which seems dormant). This driver does not block any simultaneous use of other SMART userspace tools, it's a both/and approach, not either/or. Reviewed-by: Guenter Roeck # HWMON Signed-off-by: Linus Walleij --- Ch