Re: Userspace regression with 6baca7601bde ("scsi: target: drop unused pi_prot_format attribute storage")

2019-02-03 Thread Laura Abbott
On 2/4/19 1:40 AM, David Disseldorp wrote: Hi Laura, Thanks for the report... On Sun, 3 Feb 2019 17:56:00 +0100, Laura Abbott wrote: Fedora got a bug report of a new permission denied error with 5.0-rc2: File "/usr/lib/python3.7/site-packages/rtslib_fb/utils.py", line 100,

Userspace regression with 6baca7601bde ("scsi: target: drop unused pi_prot_format attribute storage")

2019-02-03 Thread Laura Abbott
Hi, Fedora got a bug report of a new permission denied error with 5.0-rc2: File "/usr/lib/python3.7/site-packages/rtslib_fb/utils.py", line 100, in fread with open(path, 'r') as file_fd: PermissionError: [Errno 13] Permission denied: '/sys/kernel/config/target/core/fileio_28/xxx/attrib/p

[PATCHv3 0/2] String fixups in ibmvscsi

2018-09-11 Thread Laura Abbott
Hi, This is (hopefully) the last version of the string fixups found in the ibmvscsi driver. Laura Abbott (2): scsi: ibmvscsis: Fix a stringop-overflow warning scsi: ibmvscsis: Ensure partition name is properly NUL terminated drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 ++--- 1 file

[PATCHv2 2/2] scsi: ibmvscsis: Ensure partition name is properly NUL terminated

2018-09-11 Thread Laura Abbott
While reviewing another part of the code, Kees noticed that the strncpy of the partition name might not always be NUL terminated. Switch to using strscpy which does this safely. Reported-by: Kees Cook Signed-off-by: Laura Abbott --- v2: Switch to strscpy instead of just strlcpy --- drivers

[PATCHv3 1/2] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Laura Abbott
ow=] strncat(vscsi->eye, vdev->name, MAX_EYE); ^~~~ Switch to a single snprintf instead of a strcpy + strcat to handle this cleanly. Signed-off-by: Laura Abbott --- v3: Make sure there is an extra space in the partition name --- drivers/scsi/ibmvscs

[PATCH] scsi: ibmvscsis: Ensure partition name is properly NUL terminated

2018-09-11 Thread Laura Abbott
While reviewing another part of the code, Kees noticed that the strncpy of the partition name might not always be NUL terminated. Switch to using strlcpy which does this safely. Reported-by: Kees Cook Signed-off-by: Laura Abbott --- I realized looking at this that I probably should have made

[PATCHv2] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Laura Abbott
ow=] strncat(vscsi->eye, vdev->name, MAX_EYE); ^~~~ Switch to a single snprintf instead of a strcpy + strcat to handle this cleanly. Signed-off-by: Laura Abbott --- v2: Swtich to using snprintf per suggestion of Kees --- drivers/scsi/ibmvscsi_tgt

Re: [PATCH] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Laura Abbott
On 09/11/2018 07:34 AM, Bryant G. Ly wrote: On 9/10/18 6:30 PM, Kees Cook wrote: On Mon, Sep 10, 2018 at 3:37 PM, Laura Abbott wrote: There's currently a warning about string overflow with strncat: drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe'

Re: CISS driver error introduced with kernel-4.9.0-0.rc2.git1.1.fc26

2016-11-07 Thread Laura Abbott
On 11/07/2016 04:44 AM, Johnny Bieren wrote: Hello, It appears that a check_unmap kernel failure for the CISS driver was introduced with kernel-4.9.0-0.rc2.git1.1.fc26. When booting this kernel, or any newer kernel, I see the following: [3.676658] HP CISS Driver (v 3.6.26) 0m] Reached t

Re: alloc failure in qla1280 probe -- need to decrease can_queue?

2016-04-21 Thread Laura Abbott
On 04/20/2016 07:15 AM, Johannes Thumshirn wrote: [+Cc Michael Reed as get_maintainer.pl lists him as qla1280 maintainer ] On Mon, Apr 18, 2016 at 03:07:15PM -0700, Laura Abbott wrote: Hi, We received a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1321033 of qla1280 scsi host

alloc failure in qla1280 probe -- need to decrease can_queue?

2016-04-18 Thread Laura Abbott
Hi, We received a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1321033 of qla1280 scsi host failure on 4.4 based kernels that looks to be caused by page alloc failure: [4.804166] scsi host0: QLogic QLA1040 PCI to SCSI Host Adapter Firmware version: 7.65.06, D

Re: [BISECTED] WARNING: CPU: 2 PID: 142 at block/genhd.c:626 add_disk+0x480/0x4e0()

2015-12-10 Thread Laura Abbott
On 12/09/2015 10:52 PM, Hannes Reinecke wrote: There's a patchset to update the ALUA handler in Martin Petersens tree which should help here; most notably the commit 'scsi: ignore errors from scsi_dh_add_device()' should fix this particular issue. Yep, that fixed it. Thanks. Cheers, H

[BISECTED] WARNING: CPU: 2 PID: 142 at block/genhd.c:626 add_disk+0x480/0x4e0()

2015-12-09 Thread Laura Abbott
Hi, We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1288687) that live images with the rawhide kernel were failing to boot on USB sticks. Similar issues were reported when just inserting a USB stick into a boot from a CD instead of USB ("I see /dev/sdb, but no /dev/sdb1 etc." pe

[PATCH] scsi_dh: Use module_request_nowait

2015-10-27 Thread Laura Abbott
scsi_dh, not dm-mpath") Reported-by: mustafa10...@gmail.com Signed-off-by: Laura Abbott --- Not actually tested, just an attempt at a patch from the backtrace --- drivers/scsi/scsi_dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_dh.c b/drivers/sc

[RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread Laura Abbott
Cc: Fenghua Yu Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: "James E.J. Bottomley" Cc: Fenghua Yu Cc: Tony Luck Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: Andrew Morton Signed-

[RESEND][PATCH 0/2] Cleanup asm/scatterlist.h

2014-03-22 Thread Laura Abbott
ed-bys can we take this through your tree as suggested by Will? Thanks, Laura [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/240435.html Laura Abbott (2): lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig Cleanup useless architecture versions of scatterlist.h

[PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-14 Thread Laura Abbott
Cc: Fenghua Yu Benjamin Herrenschmidt Paul Mackerras Signed-off-by: Laura Abbott --- arch/arm/Kconfig | 1 + arch/arm/include/asm/Kbuild| 1 + arch/arm/include/asm/scatterlist.h | 12 arch/arm64/Kconfig | 1 + arch/ia64