From: kbuild test robot
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 26e2aa63d568 ("ZEN: Add VHBA driver")
Signed-off-by: kbuild test robot
Signed-off-by: Julia Lawall
---
There was als
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
The patch should have a log message. For example, you could point out
where the type is so the reader doesn't have to search for it.
The subject line should also give a hint about what file is affected, so
that the right person will pay attention to
ned-off-by: Julia Lawall
---
url:
https://github.com/0day-ci/linux/commits/Saurav-Kashyap/qedf-Misc-fixes-for-the-driver/20190305-205913
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:: branch date: 8 hours ago
:: commit date: 8 hours ago
Please take the
It looks like an unlock is missing before line 1000.
Is it correct that the same test is done on lines 994 and 999?
julia
-- Forwarded message --
Date: Wed, 13 Feb 2019 16:26:08 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 07/12] qla2xxx
These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side. This was done using the following semantic match
(http://coccinelle.lip6.fr/). It has a lot of false positives,
because Coccinelle doesn't record the differenc
Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/pm8001/pm8001_sas.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Fri, 28 Dec 2018, Darrick J. Wong wrote:
> On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote:
> > On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> > > there was discussion about this just some days ago. CC 4-5 lists is
> > > more than enough
> > >
> >
> > I don't kn
ted files.
julia
>
> On 23/12/2018, Julia Lawall wrote:
> > Drop LIST_HEAD where the variable it declares is never used.
> >
> > ---
> >
> > drivers/dma/at_hdmac.c|5 -
> > drivers/dma/dw/core.c
: 01649561a8b4b ("scsi: lpfc: NVME Initiator: bind to nvme_fc api")
Signed-off-by: Julia Lawall
---
Successfully 0-day tested on 151 configurations.
drivers/scsi/lpfc/lpfc_nvme.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nv
ows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
//
Fixes: 8a9d2e8003040 ("[SCSI] lpfc 8.3.31: Correct handling of SLI4-port XRI
resource-provisioning profile change")
Signed-off-by: Julia Lawall
---
Successfully 0-day tested on 151 configurat
Drop LIST_HEAD where the variable it declares is never used.
---
drivers/dma/at_hdmac.c|5 -
drivers/dma/dw/core.c |1 -
drivers/dma/pl330.c |1 -
drivers/dma/sa11x0-dma.c
t;)
Signed-off-by: Julia Lawall
---
Successfully 0-day tested on 151 configurations.
drivers/scsi/lpfc/lpfc_sli.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 30734caf77e1..13fe9d3331b9 100644
--- a/drivers/scsi/lpfc/lpfc_s
le.lip6.fr/)
//
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
//
Fixes: 726b85487067 ("qla2xxx: Add framework for async fabric discovery")
Signed-off-by: Julia Lawall
---
Successfully 0-day tested on 151 configurations.
drivers/scsi/qla2xxx/qla_init.c |1 -
1 file changed, 1 deletion(-)
Hello,
The complaint is actually about line 6956. Has the mutex been released
there?
julia
-- Forwarded message --
Date: Fri, 31 Aug 2018 00:37:52 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 1/7] mpt3sas: Introduce
Here are some improved results, also taking into account the pci
functions.
julia
too small: drivers/gpu/drm/i915/i915_drv.c:1138: 30
too small: drivers/hwtracing/coresight/coresight-tmc.c:335: 0
too small: drivers/media/pci/sta2x11/sta2x11_vip.c:859: 29
too small: drivers/media/pci/sta2x11/sta2x
On Sat, 28 Apr 2018, Luis R. Rodriguez wrote:
> On Sat, Apr 28, 2018 at 01:42:21AM -0700, Christoph Hellwig wrote:
> > On Fri, Apr 27, 2018 at 04:14:56PM +, Luis R. Rodriguez wrote:
> > > Do we have a list of users for x86 with a small DMA mask?
> > > Or, given that I'm not aware of a tool t
There is a duplicated test on line 360.
julia
-- Forwarded message --
Date: Mon, 16 Apr 2018 23:04:18 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 08/12] mmc: reduce use of block bounce buffers
CC: kbuild-...@01.org
In-Reply-To
On Tue, 2 Jan 2018, Bart Van Assche wrote:
> On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote:
> > On Tue, 2 Jan 2018, Bob Peterson wrote:
> > > - Original Message -
> > > > - Original Message -
> > > >
> > > Still, the G
On Tue, 2 Jan 2018, Bob Peterson wrote:
> - Original Message -
> | - Original Message -
> | | Drop newline at the end of a message string when the printing function
> adds
> | | a newline.
> |
> | Hi Julia,
> |
> | NACK.
> |
> | As much as it's a pain when searching the source c
On Tue, 2 Jan 2018, Bob Peterson wrote:
> - Original Message -
> | Drop newline at the end of a message string when the printing function adds
> | a newline.
>
> Hi Julia,
>
> NACK.
>
> As much as it's a pain when searching the source code for output strings,
> this patch set goes agains
Drop newline at the end of a message string when the printing function adds
a newline.
The complete semantic patch that detects this issue is as shown below
(http://coccinelle.lip6.fr/). It works in two phases - the first phase
counts how many uses of a function involve a newline and how many don
hpsa_show_dev_msg prints other information and a newline after the
message string, so the message string does not need to include a
newline explicitly. Done using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Wed, 20 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > > Why you didn't send that patch to the sysfs maintainer is a bit odd...
> > > > :)
> > >
> > > So here's an opportunity for you:
> > >
> > > The sysfs maintainer hasn't added include/l
Please check whether an unlock is needed before the return on line 891.
julia
-- Forwarded message --
Date: Wed, 8 Nov 2017 15:05:33 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [target:for-next 17/33] drivers/target/target_core_user.c:891:2-8
On Wed, 8 Nov 2017, Himanshu Jha wrote:
> On Tue, Nov 07, 2017 at 08:51:36PM +0100, Luis R. Rodriguez wrote:
> > On Sun, Nov 05, 2017 at 03:26:26AM +0530, Himanshu Jha wrote:
> > > Use vzalloc instead of vmalloc/memset to allocate memory filled with 0
> > > value.
> > >
> > > Done using Coccinel
On Thu, 19 Oct 2017, Laurent Pinchart wrote:
> Hi Christoph,
>
> On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
> > > Now we have 9 const instances of the config_item_type structure that are
> > > identical, with only the .ct_owner field set. Should they be all merged
> > >
On Tue, 17 Oct 2017, Greg KH wrote:
> On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote:
> > Make the ci_type field and some function arguments as const. After this
> > change, make config_item_type structures as const.
> >
> > * Changes in v2- Combine all the followup patches and th
Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and
drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers
structure is defined in one file and used in another file. The structure
definition references various functions that are static in the same file.
Should I try
On Sat, 12 Aug 2017, Christoph Hellwig wrote:
> On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote:
> > OK, sure. So to be precise, you want the fields error_detected,
> > mmio_enabled, etc to be added as new fields to the pci_driver structure?
>
> Yes.
>
>
On Sat, 12 Aug 2017, Christoph Hellwig wrote:
> On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote:
> > These pci_error_handlers structures are only stored in the err_handler
> > field of a pci_driver structure, and this field is declared as const. Thus
> > t
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/aacraid/linit.c
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/mpt3sas
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/be2iscsi
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/csiostor
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/bfa/bfad.c
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
---
drivers/misc/genwqe/card_base.c |2 +-
drivers/sc
Hello,
It looks like the goto on line 2374 could result in the io_lock not being
released.
julia
-- Forwarded message --
Date: Sat, 24 Jun 2017 13:27:41 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 34/35] scsi: Move
Please check on whether an unlock is neeed before line 1965.
julia
-- Forwarded message --
Date: Fri, 23 Jun 2017 15:23:00 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with
qpair->qp_lock
On Mon, 5 Jun 2017, Milan P. Gandhi wrote:
> Remove the white spaces in do/while loop used for checking fcoe
> debug logging
Is it converting spaces to tabs? If so, saying that would be clearer.
julia
>
> Signed-off-by: Milan P. Gandhi
> ---
> drivers/scsi/fcoe/fcoe.h | 2 +-
> 1 file chan
On Fri, 2 Jun 2017, walter harms wrote:
>
>
> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> > Simplify the check for return code of fcoe_if_init routine
> > in fcoe_init function such that we could eliminate need for
> > extra 'out_free' label and duplicate mutex_unlock statement.
> >
> > Sign
On Fri, 2 Jun 2017, Milan P. Gandhi wrote:
> Simplify the check for return code of fcoe_if_init routine
> in fcoe_init function such that we could eliminate need for
> extra 'out_free' label and duplicate mutex_unlock statement.
>
> Signed-off-by: Milan P. Gandhi
> ---
> drivers/scsi/fcoe/fcoe
On Fri, 2 Jun 2017, Milan P. Gandhi wrote:
> On 06/01/2017 08:32 PM, Dan Carpenter wrote:
> > On Thu, Jun 01, 2017 at 05:41:06PM +0530, Milan P. Gandhi wrote:
> >> Simplify the check for return code of fcoe_if_init routine
> >> in fcoe_init function such that we could eliminate need for
> >> ext
It looks like &udev->cmdr_lock should be released at line 512 if it has
not been released otherwise. The lock was taken at line 438.
julia
-- Forwarded message --
Date: Fri, 14 Apr 2017 22:21:44 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subj
Hello,
I don't have the compete context, but I have the impression that there
should be a goto done at which sp can be NULL.
julia
-- Forwarded message --
Date: Thu, 19 Jan 2017 12:38:31 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH
...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers
Stream Detection and IO Coalescing
In-Reply-To: <1481065220-18431-5-git-send-email-sasikumar...@broadcom.com>
Hi Sasikumar,
[auto build test WARNING on scsi/for-next]
[also buil
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Jarkko Sakkinen writes:
> > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> > >>
> >
On Mon, 12 Sep 2016, Felipe Balbi wrote:
>
> Hi,
>
> Jarkko Sakkinen writes:
> > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> >>
> >>
> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> >>
> >> > On Sun, Sep 1
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> >
> >
> > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> >
> > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> > > >
On Sun, 11 Sep 2016, Julia Lawall wrote:
> For structure types defined in the same file or local header files, find
> top-level static structure declarations that have the following
> properties:
> 1. Never reassigned.
> 2. Address never taken
> 3. Not passed to a top-level
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> > Constify local structures.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
>
> Just my two cents b
On Sun, 11 Sep 2016, Joe Perches wrote:
> On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> > Constify local structures.
>
> Thanks Julia.
>
> A few suggestions & questions:
>
> Perhaps the script should go into scripts/coccinelle/
> so that future cases
in a
variable.
Declare structures having all of these properties as const.
Done using Coccinelle.
Based on a suggestion by Joe Perches .
Signed-off-by: Julia Lawall
---
The semantic patch seems too long for a commit log, but is in the cover
letter.
drivers/scsi/esas2r/esas2r_flash.c |2
Constify local structures.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
// The first rule ignores some cases that posed problems
@r disable optional_qualifier@
identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer};
identifier i != {s5k5baf
in a
variable.
Declare structures having all of these properties as const.
Done using Coccinelle.
Based on a suggestion by Joe Perches .
Signed-off-by: Julia Lawall
---
The semantic patch seems too long for a commit log, but is in the cover
letter.
drivers/scsi/hptiop.c |6 +++---
1 file
sr_pm_ops, of type struct dev_pm_ops, is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/sr.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index ed17934
Please check the return on line 1517. It looks suspicious that it does
not release the lock, unlike the return on line 1508.
julia
---
Hi Jitendra,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, pl
On Sat, 13 Aug 2016, Christophe JAILLET wrote:
> This fixes:
>- missing spaces in string split on several lines
>- extra spaces after ':'
>- missing '\n' at the end of some messages
>- turn a \\n to \n in 1 message (v2)
>- concatenate strings on the same line to fix checkpatc
On Fri, 12 Aug 2016, Christophe JAILLET wrote:
> This fixes:
>- missing spaces in string split on several lines
>- extra spaces after ':'
>- missing '\n' at the end of some messages
>- too long lines
I think that the strings should be concatenated, even if they go past 80
chars.
On Tue, 17 May 2016, Kalle Valo wrote:
> Julia Lawall writes:
>
> > firmare -> firmware
> >
> > ---
> >
> > drivers/media/dvb-frontends/mn88473.c |2 +-
> > drivers/net/wireless/ath/ath6kl/core.h |2 +-
> > drivers/net/wir
firmare -> firmware
Signed-off-by: Julia Lawall
---
drivers/scsi/pm8001/pm8001_init.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_init.c
b/drivers/scsi/pm8001/pm8001_init.c
index 6bd7bf4..fdbee8b4 100644
--- a/drivers/scsi/pm8
firmare -> firmware
Signed-off-by: Julia Lawall
---
drivers/scsi/snic/snic_fwint.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/snic/snic_fwint.h b/drivers/scsi/snic/snic_fwint.h
index c5f9e19..2a045a5 100644
--- a/drivers/scsi/snic/snic_fwint.h
++
firmare -> firmware
---
drivers/media/dvb-frontends/mn88473.c |2 +-
drivers/net/wireless/ath/ath6kl/core.h |2 +-
drivers/net/wireless/marvell/mwifiex/pcie.c |2 +-
drivers/scsi/pm8001/pm8001_init.c |2 +-
drivers/scsi/snic/snic_fwint.h |2 +
On Sat, 12 Dec 2015, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 12 Dec 2015 13:44:06 +0100
>
> The variable "pl" was declared and immediately assigned a return value
> from a function call in a separate statement.
>
> * Let us express the desired variable initialisation direct
On Wed, 9 Dec 2015, Dan Carpenter wrote:
> We should add a tag to indicate that we are sending a patch for a crappy
> driver.
>
> IMHO-this-driver-is-garbage: Your Name
>
> If it got 10 votes of no confidence it would be moved to staging and
> then deleted.
Forgive my ignorance, but what is th
Looks suspicious. Please check.
julia
On Tue, 8 Dec 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> In-Reply-To: <1449535747-2850-14-git-send-email-himanshu.madh...@qlogic.com>
> TO: Himanshu Madhani
> CC: target-de...@vger.kernel.org, n...@linux-iscsi.org
> CC: giridhar.malav...@qlog
The mpt_pci_driver structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/message/fusion/mptbase.c |8 +---
drivers/message/fusion/mptbase.h |3 ++-
drivers/message/fusion/mptctl.c |2 +-
drivers
This pci_error_handlers structure is never modified, like all the other
pci_error_handlers structures, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
There are no dependencies between these patches.
drivers/scsi/csiostor/csio_init.c |2 +-
1
This pci_error_handlers structure is never modified, like all the other
pci_error_handlers structures, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
There are no dependencies between these patches.
drivers/scsi/bfa/bfad.c |2 +-
1 file changed
This pci_error_handlers structure is never modified, like all the other
pci_error_handlers structures, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
There are no dependencies between these patches.
drivers/scsi/be2iscsi/be_main.c |2 +-
1 file
This pci_error_handlers structure is never modified, like all the other
pci_error_handlers structures, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
There are no dependencies between these patches.
drivers/scsi/mpt3sas/mpt3sas_scsih.c |2 +-
1
Constify never-modified pci_error_handlers structures.
---
drivers/crypto/qat/qat_common/adf_aer.c |2 +-
drivers/misc/genwqe/card_base.c |2 +-
drivers/net/ethernet/cavium/liquidio/lio_main.c |2 +-
drivers/net/ethernet/sfc/efx.c |2 +-
d
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when !
amp;ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
//
This patch also changes the subsequent dev_err call to use err rather
than recomputing PTR_ERR(hba->devfreq). The format of the error value
is changed from %ld to %d to reflect the type or err.
Signed-off-by: Ju
From: Julia Lawall
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
//
Signed-off-by: Julia Lawall
---
drivers/target
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f
From: Julia Lawall
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
//
Signed-off-by: Julia Lawall
---
drivers/scsi
On Sat, 7 Feb 2015, Dan Carpenter wrote:
> On Fri, Feb 06, 2015 at 11:15:13PM +0100, SF Markus Elfring wrote:
> > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> > index 2a00fd3..a7ca479 100644
> > --- a/drivers/scsi/qla4xxx/ql4_os.c
> > +++ b/drivers/scsi/qla4xxx/ql4_
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > fu
Replace a misspelled function name by %s and then __func__.
This was done using Coccinelle, including the use of Levenshtein distance,
as proposed by Rasmus Villemoes.
Signed-off-by: Julia Lawall
---
The semantic patch is difficult to summarize, but is available in the cover
letter of this
These patches replace what appears to be a reference to the name of the
current function but is misspelled in some way by either the name of the
function itself, or by %s and then __func__ in an argument list.
//
// sudo apt-get install python-pip
// sudo pip install python-Levenshtein
// spatch
On Wed, 3 Dec 2014, Dan Carpenter wrote:
> The issue_reset variables were never set to zero. This bug was found
> with static analysis.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
> b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 58e4521..98bd546 100644
>
From: Julia Lawall
Delete a local array that is only used to be initialized by memset.
A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x;
type T;
@@
{
... when any
-T x[...];
<+... when != x
- memset(x,...);
...+>
}
//
Signed-
Remove an array or structure that only serves as the first argument to
memset. The complete semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x;
type T;
@@
{
... when any
-T x[...];
<+... when != x
- memset(x,...);
...+>
}
@@
identifier x,i;
@@
From: Julia Lawall
Delete a local structure that is only used to be initialized by memset.
A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x,i;
@@
{
... when any
-struct i x;
<+... when != x
- memset(&x,...);
...+>
}
//
Sig
From: Julia Lawall
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when !=
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when !
>From nobody Sat Aug 9 08:17:15 CEST 2014
From: Julia Lawall
To: Adaptec OEM Raid Solutions
Cc: "James E.J. Bottomley"
,linux-scsi@vger.kernel.org,linux-ker...@vger.kernel.org
Subject: [PATCH] dpt_i2o: delete unnecessary null test on array
From: Julia Lawall
Convert a NULL tes
On Fri, 8 Aug 2014, James Bottomley wrote:
> On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote:
> > > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > > > index 67283ef..62e276b 100644
> > > > --- a/drivers/scsi/dpt_i2o
> > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > index 67283ef..62e276b 100644
> > --- a/drivers/scsi/dpt_i2o.c
> > +++ b/drivers/scsi/dpt_i2o.c
> > @@ -1169,11 +1169,6 @@ static struct adpt_device*
> > adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
> > if(chan < 0 |
Delete NULL test on array. The complete semantic patch that finds this
problem is as follows: (http://coccinelle.lip6.fr/)
//
@r@
type T;
T [] e;
position p;
@@
(
e ==@p NULL
|
e !=@p NULL
|
!@p e
)
@ disable fld_to_ptr@
expression e;
identifier f;
position r.p;
@@
(
* (e.f) ==@p NULL
|
*
From: Julia Lawall
Delete NULL test on array (always false).
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r@
type T;
T [] e;
position p;
@@
e ==@p NULL
@ disable fld_to_ptr@
expression e;
identifier f;
position r.p
These patches fix typos in the name of a type referenced in a sizeof
command. These problems are not caught by the compiler, because they have
no impact on execution - the size of a pointer is independent of the size
of the pointed value.
The semantic patch that finds these problems is shown belo
From: Julia Lawall
Correct typo in the name of the type given to sizeof. Because it is the
size of a pointer that is wanted, the typo has no impact on compilation or
execution.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The
semantic patch used can be found in
From: Julia Lawall
Correct typo in the name of the type given to sizeof. Because it is the
size of a pointer that is wanted, the typo has no impact on compilation or
execution.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The
semantic patch used can be found in
On Fri, 4 Jul 2014, Julia Lawall wrote:
>
>
> On Fri, 4 Jul 2014, Elliott, Robert (Server Storage) wrote:
>
> >
> >
> > > -Original Message-
> > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> > > ow...@vger.kernel.o
;
> > expression x,e1,e2,e3;
> > identifier alloc;
> > @@
> >
> > ret = 0
> > ... when != ret = e1
> > *x = alloc(...)
> > ... when != ret = e2
> > if (x == NULL) { ... when != ret = e3
> > return ret;
> > }
> > //
> >
On Wed, 4 Jun 2014, scame...@beardog.cce.hp.com wrote:
> On Wed, Jun 04, 2014 at 11:07:56AM +0200, Julia Lawall wrote:
> > From: Julia Lawall
> >
> > Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may
> > return a larger number than the maximu
On Wed, 4 Jun 2014, Geert Uytterhoeven wrote:
> Hi Julia,
>
> On Wed, Jun 4, 2014 at 1:00 PM, Julia Lawall wrote:
> > OK, thanks. I was only looking at the C code.
> >
> > But the C code contains a loop that is followed by:
> >
> > if (!
On Wed, 4 Jun 2014, Geert Uytterhoeven wrote:
> Hi Julia,
>
> On Wed, Jun 4, 2014 at 11:52 AM, Julia Lawall wrote:
> >> Maybe the documented return code should be changed to allow for the
> >> existing behaviour.
> >
> > Sorry, I'm not sure to under
On Wed, 4 Jun 2014, David Laight wrote:
> From: Julia Lawall
> > On Wed, 4 Jun 2014, Geert Uytterhoeven wrote:
> >
> > > Hi Julia,
> > >
> > > On Wed, Jun 4, 2014 at 11:07 AM, Julia Lawall
> > > wrote:
> > > > Find_firs
1 - 100 of 126 matches
Mail list logo
