Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI

2018-10-19 Thread Josh Triplett
On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote: > Various powerpc boards select the PCI_MSI config option without selecting > PCI, resulting in potentially not compilable configurations if the by > default enabled PCI option is disabled. Explicitly select PCI to ensure > we alwa

Re: scsi: Implement per-cpu logging buffer

2015-02-15 Thread Josh Triplett
On Sat, Feb 14, 2015 at 03:29:37PM +0100, Hannes Reinecke wrote: > On 02/13/2015 04:45 PM, Josh Triplett wrote: > > On Fri, Feb 13, 2015 at 09:48:36AM +0100, Hannes Reinecke wrote: > >> On 02/12/2015 06:18 PM, Josh Triplett wrote: > >>> On Thu, Feb 12, 2015 at 02:

Re: scsi: Implement per-cpu logging buffer

2015-02-13 Thread Josh Triplett
On Fri, Feb 13, 2015 at 09:48:36AM +0100, Hannes Reinecke wrote: > On 02/12/2015 06:18 PM, Josh Triplett wrote: > > On Thu, Feb 12, 2015 at 02:29:35PM +0100, Hannes Reinecke wrote: > >> On 02/12/2015 01:36 PM, Geert Uytterhoeven wrote: > >>> On Wed, Feb 11, 2015 at

Re: scsi: Implement per-cpu logging buffer

2015-02-12 Thread Josh Triplett
coming in from > various CPUs overwriting each other and _not_ introduce additional > latency by locking a single buffer, then yes. > > We can possibly reduce it to, say, 1KiB or even lower by imposing > stricter rules on the logging functions. > But I don't see a way aroun

Re: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Josh Triplett
ning in isci/phy.c: > > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for > > ‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > Acked-by: Lukasz Dorau Since

Re: [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c

2013-12-13 Thread Josh Triplett
_add’ [-Wmissing-prototypes] > drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for > ‘mptsas_shutdown’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptsas.c |6 +++--- > 1 file changed, 3 in

Re: [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c

2013-12-13 Thread Josh Triplett
/message/fusion/mptspi.c:624:1: warning: no previous prototype for > ‘mptscsih_quiesce_raid’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptspi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c

2013-12-13 Thread Josh Triplett
/mptbase.c:7011:1: warning: no previous prototype for > ‘mpt_SoftResetHandler’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptbase.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi