Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr

Let me search for it. Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Fe

Re: [PATCH v4 02/22] sg: remove typedefs, type+formatting cleanup

Highly appreciated, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

On Wed, Jul 03, 2019 at 12:36:30AM +0200, Andrea Vai wrote: > On 02/07/19 13:51:17, Johannes Thumshirn wrote: > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > Hi, > > > I have a problem writing data to a USB pendrive, and it seems > > > k

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

0min vs. half a minute. > > The problem is still present in last tested git (cloned today in the > morning). > > You can see the previous discussion that lead to these results at > > https://marc.info/?t=15592223071&r=1&w=2 Hi, Can you please check what IO schedule

Re: [scsi:misc 301/301] drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in 'fdomain_host_reset' - wrong count at exit

ck, flags); > 92408047 Ondrej Zary 2019-04-29 449 fdomain_reset(fd->base); > 92408047 Ondrej Zary 2019-04-29 450 > spin_lock_irqsave(sh->host_lock, flags); That should be a spin_unlock_irqrestore() here ~^ Otherwise this would end badly. -- Johannes Thumshirn

Re: [PATCH] Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO"

This is missing you Signed-off-by -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key

Re: [PATCH V5 2/9] blk-mq: move cancel of requeue_work into blk_mq_release

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [PATCH V5 1/9] blk-mq: grab .q_usage_counter when queuing request from plug code path

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [PATCH 00/10] Improve qla2xxx coding style

t once (another > 20 patches will follow at a later time). Please consider these patches for > kernel v5.2. For the whole series, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911

Re: [PATCH 01/11] Declare wwn_to_u64() argument const

Fair enough, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

help others understand when back_lock must be held. You're missing a S-o-b here. Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

e also lacking tests for things like ioprio, persistent reservation, bcache and so on. Adding support for collecting gcov information after running a test case would also be awesome (this is missing in xfstests as well). So I think a session on blktests can help us get the gap closed. Byte,

[PATCH] MAINTAINERS: Move FCoE to Hannes Reinecke

I'll be moving on to different things in the storage stack and Hannes agreed to take over FCoE. Cc: Hannes Reinecke Signed-off-by: Johannes Thumshirn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9f64f8d3740e..49b8297

Re: [PATCH V2 1/3] megaraid_sas: Rework code to get PD and LD list

o start your kerneldoc comments with '/**' (i.e. one asterisk is missing on your side). -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imend

Re: [PATCH] libsas: Remove scsi_to_u32()

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 2/7] scsi: csiostor: no need to check return value of debugfs_create functions

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] fcoe: make use of fip_mode enum complete

urn FIP_MODE_FABRIC; case FIP_ST_VMMP_START: return FIP_MODE_VN2VN; default: WARN(1, "Invalid FIP state"); } return FIP_ST_AUTO; } Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthum

Re: [PATCH -next] scsi: fcoe: remove set but not used variable 'port'

I somehow have a deja vu feeling I have already acked it, but anyways: Acked-by: Johannes Thumshirn

Re: [PATCH 1/6] scsi: hpsa: Add function to check if device is a disk or a zoned device

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/2] scsi: aacraid: change wait_sem to a completion

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/2] scsi: aacraid: change event_wait to a completion

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the pat

Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl

On 06/12/2018 17:50, Johannes Thumshirn wrote: > Why not calling dma_alloc_coherent() directly instead of using the > pci_alloc_consistent() wrapper? Ah should've read the whole series -- Johannes ThumshirnSUSE Labs Filesystems jthumsh

Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl

g one. This avoids a case where we might > be doing a memory allocation under a spinlock with irqs disabled. Why not calling dma_alloc_coherent() directly instead of using the pci_alloc_consistent() wrapper? Johannes -- Johannes ThumshirnSUSE Labs File

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

further (like you don't need the line wrap at 80 chars, and so on). Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Ime

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

a(task->task_proto)) return; Would save you a level of indentation and make the above more readable. -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nü

Re: [PATCH 21/41] scsi: libfc: fc_rport: Mark expected switch fall-through

Acked-by: Johannes Thumshirn

Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

On 13/11/2018 17:22, Sabyasachi Gupta wrote: > On Tue, Nov 13, 2018 at 9:46 PM Johannes Thumshirn wrote: >> >> On 13/11/2018 17:11, James Bottomley wrote: >>> This is incorrect advice: there's no need to cast it to other *pointer* >>> types, but if you cast i

Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

or spotting it James. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

((trace_max_pages * >> +    PAGE_SIZE)); > > If you remove the extra brackets in vzalloc() argument then you may not > spill onto the next line. And remove the unnecessary cast. vzalloc() (just like vmalloc()) returns a void*, so no reason to cast it. -- Joh

Re: [PATCH 7/7] block: remove the BLKPREP_* values.

So long and thanks for all the fish, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard

Re: [PATCH 6/7] scsi: return blk_status_t from device handler ->prep_fn

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 5/7] scsi: return blk_status_t from scsi_init_io and ->init_command

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 4/7] scsi: clean up error handling in scsi_init_io

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/7] scsi: push blk_status_t up into scsi_setup_{fs,scsi}_cmnd

Look good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: lpfc: fix remoteport access

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 16/28] blk-cgroup: remove legacy queue bypassing

On 29/10/18 15:23, Jens Axboe wrote: > On 10/29/18 5:00 AM, Johannes Thumshirn wrote: >> Hi Jens, >> >> On 25/10/18 23:10, Jens Axboe wrote: >> [...] >>> @@ -1487,8 +1485,6 @@ int blkcg_activate_policy(struct request_queue *q, >&g

Re: [PATCH 16/28] blk-cgroup: remove legacy queue bypassing

gt; Now that we only have mq, do we still need all these checks for q->mq_ops? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Ja

Re: [PATCH 12/28] bsg: provide bsg_remove_queue() helper

On 25/10/18 23:10, Jens Axboe wrote: > All drivers do unregister + cleanup, provide a helper for that. > > Cc: Johannes Thumshirn > Cc: Benjamin Block > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Jens Axboe > --- > block/bsg-lib.c | 7

Re: [PATCH 3/8] sg: split header, expand and correct descriptions

re are no _t variants for the above, or am I missing something? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Gr

Re: [PATCH 4/8] sg: expand request states

Looks good (but the ifdefs are creepy), Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard

Re: [PATCH 2/8] sg: introduce sg_log macro

} \ > + } while (0) Hi Doug, have you considered using the kernel's dynamic debug infrastructure instead? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49

Re: [PATCH 1/8] sg: types and naming cleanup

is is highly appreciated. I have one minor Nit if you need to resend the series, please remove the casts form void* (mostly filp->private_data). Otherwise: Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jth

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

On 17/10/18 15:00, Matthew Wilcox wrote: > On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote: >> On 17/10/18 14:34, YueHaibing wrote: >>> - srb_tag = le32_to_cpu(scsiqp->srb_tag); >>> scp = scsi_host_find_tag(boardp->shost, scsiqp-&

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

The adv_req_t structure actually contains the >* completed ADV_SCSI_REQ_Q structure. >*/ > - srb_tag = le32_to_cpu(scsiqp->srb_tag); > scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag); Shouldn't this b

Re: [PATCH 28/28] mesh: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 27/28] ips: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 26/28] smartpqi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 25/28] vmw_pscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 24/28] snic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 23/28] qla4xxx: fully convert to the generic DMA API

that: At exit, the @ha's flags.enable_64bit_addressing set to indicated supported addressing method. Comment in the function description as well? It wasn't even correct with the initial submission of qla4xxx (according to git blame. Otherwise, Reviewed-by: Johannes Thum

Re: [PATCH 22/28] qla2xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 21/28] qla1280: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 20/28] qedi: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 19/28] qedf: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 17/28] nsp32: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 18/28] pm8001: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 16/28] mvsas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 15/28] mvumi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 14/28] mpt3sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 12/28] megaraid_mbox: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 10/28] fnic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 11/28] hpsa: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 09/28] csiostor: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 08/28] be2iscsi: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 07/28] atp870u: switch to generic DMA API

e = > dma_alloc_coherent(&atp_dev->pdev->dev, 1024, &(atp_dev->id[c][k].prd_bus), > GFP_KERNEL); > if (!atp_dev->id[c][k].prd_table) { > printk("atp870u_init_tables fail\n"); >

Re: [PATCH 06/28] a100u2w: switch to generic DMA API

t;escb_virt = pci_zalloc_consistent(pdev, sz, &host->escb_phys); > + host->escb_virt = dma_zalloc_coherent(&pdev->dev, sz, &host->escb_phys, > + GFP_KERNEL); and here. Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 05/28] BusLogic: switch to generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 01/28] aic94xx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] megaraid_mbox: remove bogus use of pci_dma_sync_sg_* APIs

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] lpfc: remove a bogus pci_dma_sync_single_for_device call

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2] scsi: sd: don't crash the host on invalid commands

On Tue, Sep 25, 2018 at 08:52:58PM -0400, Martin K. Petersen wrote: > Looks like a bunch of my merge mails didn't make it out last week. > > For the record, I did merge this into 4.19/scsi-fixes and it has made > its way upstream. Thanks for the info. Byte, Joha

Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

On Fri, Sep 21, 2018 at 02:15:05PM +0200, Hannes Reinecke wrote: > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > at that time, so no new commands can be submitted via srp_queuecomment() s/srp_queuecomment/srp_queuecommand/ -- Johannes Thu

[PATCH v2] scsi: sd: don't crash the host on invalid commands

ge the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Assche Cc: Christoph Hellwig Reviewed-by: Christoph Hellwig --- Changes since v1: - Use WARN_ON_ON

Re: [PATCH] scsi: sd: don't crash the host on invalid commands

On Thu, Sep 20, 2018 at 11:18:19AM -0700, Bart Van Assche wrote: > On Thu, 2018-09-20 at 09:19 +0200, Johannes Thumshirn wrote: > > Have you considered to use WARN_ON_ONCE() instead of WARN_ON(1)? Otherwise > this patch looks good to me. Indeed I did and then forgot to 'git c

[PATCH] scsi: sd: don't crash the host on invalid commands

ge the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Assche Cc: Christoph Hellwig --- Fixed Typo in Bart's mail, sorry for this. drivers/scsi/sd.c

[PATCH] scsi: sd: don't crash the host on invalid commands

ge the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Asche Cc: Christoph Hellwig --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH v2 5/5] scsi: libsas: fix a race condition when smp task timeout

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 4/5] scsi: libsas: check the ata device status by ata_dev_enabled()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] libfc: remove unnecessary condition check

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH 0/3] scsi: fcoe: memleak fixes

7 17:54:31 localhost kernel: [ 17.909081] host10: fip: > vn_rport_callback c76e event 1 > Aug 7 17:54:34 localhost kernel: [ 20.992106] host10: rport 00c76e: > Received ADISC request > > So in the "working" case I see that the other node (4.

Re: [PATCH] Remove extra goto label from nvmet_ns_enable

please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer

Re: [PATCH] Simplify nvmet_init to remove extra out label

please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer

Re: [PATCH] scsi: aic94xx: fix an error code in aic94xx_init()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] sr: Avoid that opening a CD-ROM hangs with runtime power management enabled

On Fri, Aug 03, 2018 at 10:28:45AM +0200, Johannes Thumshirn wrote: > On Thu, Aug 02, 2018 at 10:44:42AM -0700, Bart Van Assche wrote: > > Surround scsi_execute() calls with scsi_autopm_get_device() and > > scsi_autopm_put_device(). Note: removing sr_mutex protection from > >

Re: [PATCH] sr: Avoid that opening a CD-ROM hangs with runtime power management enabled

[ 985.161303] schedule+0x23/0x80 [ 985.161480] async_synchronize_cookie_domain+0x89/0xd0 [ 985.161734] ? wait_woken+0x80/0x80 [ 985.161914] ? rest_init+0xb0/0xb0 [ 985.162080] kernel_init+0xa/0x100 [ 985.162334] ret_from_fork+0x35/0x40 -- Johannes Thumshirn

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

ivers/ata/libata-scsi.c | 1 + 4 files changed, 51 insertions(+), 14 deletions(-) I'll be looking into it. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

> CONFIG_BLK_DEV_RAM=y on top of defconfig: > > > https://people.collabora.com/~gtucker/lava/boot/debug/bzImage-85eac382fa06-blk-dev.config OK, this is a deviation from what I see here (on mkp's 4.19/scsi-queue not next though). -- Johannes Thumshirn

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

ou please enable CONFIG_BLK_DEV_RAM? See my other mails in this thread for details. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg G

Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)

053690] ata2.00: ATAPI: QEMU DVD-ROM, 2.5+, max UDMA/100 [2.072269] scsi 1:0:0:0: CD-ROMQEMU QEMU DVD-ROM 2.5+ P5 [2.107220] sr 1:0:0:0: [sr0] scsi3-mmc drive: 4x/4x cd/rw xa/form2 tray [2.107675] cdrom: Uniform CD-ROM driver Revision: 3.20 [2.111851] sr 1

  1   2   3   4   5   6   7   8   9   10   >