[PATCH v2] be2iscsi: Fix bad WARN_ON

2015-10-01 Thread Joel Stanley
> 0); ^ Check that length is not zero (and not less than zero, but it's unsigned, so that will always be satisfied). Signed-off-by: Joel Stanley --- v2: invert the check to lose the ! as suggested by Johannes drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 i

Re: [PATCH] be2iscsi: Fix bad WARN_ON

2015-10-01 Thread Joel Stanley
On Thu, Oct 1, 2015 at 6:01 PM, Johannes Thumshirn wrote: >> diff --git a/drivers/scsi/be2iscsi/be_main.c >> b/drivers/scsi/be2iscsi/be_main.c >> index 7a6dbfb..0b87abb 100644 >> --- a/drivers/scsi/be2iscsi/be_main.c >> +++ b/drivers/scsi/be2iscsi/be_main.c >> @@ -3184,7 +3184,7 @@ be_sgl_create_

[PATCH] be2iscsi: Fix bad WARN_ON

2015-10-01 Thread Joel Stanley
> 0); ^ Add the brackets that the check was was looking for. Signed-off-by: Joel Stanley --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 7a6d