Re: [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'

2018-11-11 Thread Javali, Nilesh
On 11/12/18, 7:24 AM, "YueHaibing" wrote: >External Email > >Fixes gcc '-Wunused-but-set-variable' warning: > >drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl': >drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning: > variable 'cid_num' set but not used [-Wunused-but-set-variabl

Re: [PATCH] qedi: Fix a potential buffer overflow

2018-07-27 Thread Javali, Nilesh
On 7/27/18, 2:40 AM, "Bart Van Assche" wrote: >External Email > >Tell snprintf() to store at most 255 characters in the output buffer >instead of 256. This patch avoids that smatch reports the following >warning: > >drivers/scsi/qedi/qedi_main.c:891: qedi_get_boot_tgt_info() error: >snprintf()

Re: [PATCH] qedi: Fix static checker warning

2018-06-26 Thread Javali, Nilesh
On 6/25/18, 8:31 PM, "Bart Van Assche" wrote: >External Email > >On 06/25/18 05:32, Nilesh Javali wrote: >> This patch fixes the static checker warning, >> >> drivers/scsi/qedi/qedi_main.c:891 qedi_get_boot_tgt_info() >> error: snprintf() is printing too much 256 vs 255 > >Which s

Re: [PATCH V2 1/2] qedi: Fix truncation of CHAP name and secret

2018-02-07 Thread Javali, Nilesh
On 2/6/18, 8:53 PM, "Bart Van Assche" wrote: >On Tue, 2018-02-06 at 05:12 -0800, Nilesh Javali wrote: >> From: Andrew Vasquez >> >> The data in NVRAM is not guaranteed to be NUL terminated. >> Copy the data upto the element size or to the first NUL >> in the byte-stream and then append a NUL.

Re: [PATCH] qedi: Fix truncation of name and secret

2018-02-05 Thread Javali, Nilesh
On 2/6/18, 12:51 AM, "Lee Duncan" wrote: >On 02/05/2018 11:15 AM, Lee Duncan wrote: >> On 01/31/2018 10:57 PM, Nilesh Javali wrote: >>> Adjust the NULL byte added by snprintf. >>> >>> Signed-off-by: Nilesh Javali >>> --- >>> drivers/scsi/qedi/qedi_main.c | 12 ++-- >>> 1 file changed,

Re: [PATCH] scsi: qedi: select CONFIG_ISCSI_BOOT_SYSFS

2017-07-23 Thread Javali, Nilesh
On 21/07/17, 9:41 PM, "Arnd Bergmann" wrote: >Without the base library support, we get a link failure > >drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0': >qedi_main.c:(.text+0x2d8e): undefined reference to >`iscsi_boot_create_target' >qedi_main.c:(.text+0x2dee): undefined r

Re: [PATCH 1/1] qedi: Add support for offload iSCSI Boot

2017-06-27 Thread Javali, Nilesh
On 26/06/17, 10:29 PM, "Martin K. Petersen" wrote: > >Nilesh, > >> This patch adds support for offload iSCSI boot (Boot from SAN >> over iSCSI offload). >> >> The dependent qed patches for this support are, >> - qed: Support NVM-image reading API >> - qed: Share additional information with qedf

Re: [PATCH v2] scsi: qla4xxx: Use dma_pool_zalloc

2017-01-13 Thread Javali, Nilesh
On 02/01/17, 11:10 AM, "Souptick Joarder" wrote: >Hi Nilesh, > >On Thu, Dec 22, 2016 at 5:42 PM, Souptick Joarder >wrote: >> We should use dma_pool_zalloc instead of dma_pool_alloc/memset >> >> Signed-off-by: Souptick joarder >> --- >> v2 changes: >>- Address comment from Nilesh to make s

Re: [PATCH] scsi/qla4: comments correction

2016-12-22 Thread Javali, Nilesh
On 19/12/16, 11:50 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Cao jin" wrote: >Signed-off-by: Cao jin >--- > drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c >index 0

Re: [PATCH] scsi: qla4xxx: Use dma_pool_zalloc

2016-12-21 Thread Javali, Nilesh
On 13/12/16, 6:35 PM, "Souptick Joarder" wrote: >On Tue, Dec 13, 2016 at 4:11 PM, Javali, Nilesh > wrote: >> >> >> On 12/12/16, 10:16 AM, "linux-scsi-ow...@vger.kernel.org on behalf of >> Souptick Joarder" > jrdr.li...@gmail.com> wrote

Re: [PATCH] scsi: qla4xxx: Use dma_pool_zalloc

2016-12-13 Thread Javali, Nilesh
On 12/12/16, 10:16 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Souptick Joarder" wrote: >On Wed, Dec 7, 2016 at 1:53 AM, Souptick Joarder >wrote: >> We should use dma_pool_zalloc instead of dma_pool_alloc/memset >> >> Signed-off-by: Souptick joarder >> --- >> drivers/scsi/qla4xxx/ql4_

Re: [PATCH v2] qla4xxx: switch to pci_alloc_irq_vectors

2016-12-06 Thread Javali, Nilesh
On 06/12/16, 7:26 PM, "Christoph Hellwig" wrote: >And simplify the MSI-X logic in general - just request the two >vectors directly instead of going through an indirection table. > >Signed-off-by: Christoph Hellwig >--- > drivers/scsi/qla4xxx/ql4_def.h | 18 + > drivers/scsi/qla4xxx/ql4_

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

2016-12-06 Thread Javali, Nilesh
Please see comments inline. Thanks, Nilesh On 18/11/16, 12:45 PM, "Christoph Hellwig" wrote: >And simplify the MSI-X logic in general - just request the two >vectors directly instead of going through an indirection table. > >Signed-off-by: Christoph Hellwig >--- > drivers/scsi/qla4xxx/ql4_def.

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

2016-11-29 Thread Javali, Nilesh
Hi Martin, We would test this internally and then ACK within a week. Thanks, Nilesh On 29/11/16, 10:15 PM, "Martin K. Petersen" wrote: >> "Christoph" == Christoph Hellwig writes: > >Christoph> And simplify the MSI-X logic in general - just request the >Christoph> two vectors directly inst