[PATCH] target: fix a case of data corruption during COMPARE_AND_WRITE

2015-11-23 Thread Jan Engelhardt
instructed with the -D file, it corrupts the data in the sector by splicing some of the original bytes in. The page of the first entry of cmd->t_data_sg includes the CDB, and sg->offset is set to a position past the CDB. I presume that sg->offset is also the right choice to use for subs

Arbitrary SCSI commands and CAP_SYS_ADMIN

2013-05-07 Thread Jan Engelhardt
In include/uapi/linux/capability.h, next to CAP_SYS_ADMIN, one will find the notice /* Allow enabling/disabling tagged queuing on SCSI controllers and sending arbitrary SCSI commands */ #define CAP_SYS_ADMIN 21 To the best of my knowledge, arbitrary commands can be issued with the SG_IO io

Re: Read I/O starvation with writeback RAID controller

2013-02-22 Thread Jan Engelhardt
On Friday 2013-02-22 20:28, Martin Svec wrote: > > Yes, I've already tried the ROW scheduler. It helped for some low iodepths > depending on quantum settings but generally didn't solve the problem. I think > the key issue is that none of the schedulers can throttle I/O according to > e.g. > avera

Talking to reset disk without device node

2013-01-18 Thread Jan Engelhardt
I have here a system with Linux 3.4.4 and what seems to be flakey PCI bridge hardware, as it has occurred previously on different SATA controllers and had fixed itself up after a reboot. Anyhow, as a result of the disk "disappearing", sd_mod will deregister it so that /dev/sdl will be invalid/cle

[PATCH] scsi: move scsi_netlink code out of SCSI core

2012-09-28 Thread Jan Engelhardt
Only scsi_transport_fc needs scsi_netlink, so recombine the logic such that scsi_netlink is bundled with scsi_transport_fc instead of scsi_mod. Cc: James Smart Cc: James Bottomley Cc: Eric W. Biederman Cc: David S. Miller Signed-off-by: Jan Engelhardt --- (What's with the 2001-09-17

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 13:07, Boaz Harrosh wrote: >+static struct pci_device_id gdthtable[] __devinitdata = { >+ { PCI_VDEVICE(VORTEX, PCI_ANY_ID) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC_XSCALE) }, >+ { } /* terminate l

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Jan Engelhardt
On Feb 13 2008 11:03, Boaz Harrosh wrote: >> >> I've tested this patch now - and it works fine. Now rmmod, halt and >> reboot also works. >> >> Stefan Priebe >> >This is grate news Stefan. Thank you very much for all your time >and effort, with out we could not have fixed all this. Do you hav

Re: [BUG?] GDTH driver not working after upgrade to 2.6.24

2008-01-31 Thread Jan Engelhardt
Hi, On Jan 31 2008 14:35, Boaz Harrosh wrote: > >Thanks, Perhaps someone else then. >Anyone with gdth HW that can test patches? Is bisecting down the existing chain and finding the bad commit sufficient? (I also take new patches.) >Your lspci said: "Intel Corporation RAID Controller" Matthew >

[PATCH] [SCSI]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/scsi/lpfc/lpfc_debugfs.c | 10 +- drivers/scsi/sg.c|8 diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index d6a98bc..002f541 100644 --- a/drivers/scs

Disk spindown on rmmod sd_mod

2007-10-02 Thread Jan Engelhardt
Hi, I am using 2.6.23-rc9 with pata_sis. `modprobe -r sd_mod`, which I ran from initramfs, caused all my disks to spindown - sd even told me so. I recall there has been talk a while back about whether to spin down disks on shutdown or not, but I do not think it touched the removal of sd_mod,

sym53c8xx rescan

2007-09-06 Thread Jan Engelhardt
Hi list, issuing `echo "- - -" >/sys/class/scsi_host/host0/scan` where host0 is a 0001:00:03.0 SCSI storage controller: LSI Logic / Symbios Logic 53c875 (rev 14) sym0: <875> rev 0x14 at pci 0001:00:03.0 irq 13 does not produce any dmesg messages (2.6.21), so I suspect it did not rescan the b

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 13:02, Matthew Wilcox wrote: >> >> Well, you can send it to Linus/Andrew, that will usually upset people and >> they >> start commenting on it. Or they don't, and everything is fine. >> (The "default y" approach so to speak ;-) > >The problem is that we don't really have a maintai

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 20:55, Denys Vlasenko wrote: >> Fwiw I do like your debloat patch a lot; it's just only half the >> equation ... if you also do the namespace fixes, I bet the driver >> debloats even more... > >Yes, I know, and I am happy to do that too. I just don't know >whether patches will be ac

Re: Inclusion of vmware mptbase regression fix

2007-07-31 Thread Jan Engelhardt
On Jul 31 2007 20:24, Maarten Bressers wrote: >Hi Petr, > >The patch you posted for the MPT Fusion driver regression with VMware >5.5.4 (http://lkml.org/lkml/2007/3/23/345) was used to fix a Gentoo >kernel bug (http://bugs.gentoo.org/show_bug.cgi?id=185272). > >Have you received word from upstre

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > - Implemented as a block device driver with a dynamic major > - Disk names (and partitions) are of the format ps3d%c(%u) > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor >

Re: block/bsg.c

2007-07-17 Thread Jan Engelhardt
On Jul 16 2007 16:57, Andrew Morton wrote: >A belated review (I've never seen this before and there it is in mainline) > >> static char bsg_version[] = "block layer sg (bsg) 0.4"; > >`const' would be better. That moves it into a write-protected memory section. Or perhaps MODULE_DESCRIPTION() and

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-14 Thread Jan Engelhardt
On May 14 2007 19:46, Alan Cox wrote: >> On May 13 2007 12:48, James Bottomley wrote: >> > >> >> Why does ATA select SCSI anyway? Surely PATA doesn't require it? >> >That's a bit offtopic and to the wrong list. >> >libata-pata does require SCSI ... >> >> And in the long run, that SCSI parts which

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-14 Thread Jan Engelhardt
On May 13 2007 12:48, James Bottomley wrote: > >> Why does ATA select SCSI anyway? Surely PATA doesn't require it? > >That's a bit offtopic and to the wrong list. > >libata-pata does require SCSI ... And in the long run, that SCSI parts which are actually used by ATA should be factored out so tha

[PATCH 27/36] Use menuconfig objects II - SCSI

2007-04-30 Thread Jan Engelhardt
Make a "menuconfig" out of the Kconfig objects "menu, ..., endmenu", so that the user can disable all the options in that menu at once instead of having to disable each option separately. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig

[PATCH 06/36] Use menuconfig objects II - fusion

2007-04-30 Thread Jan Engelhardt
Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/message/fusion/Kconfig | 14 +- 1 file c

Re: [PATCH]: Final ESP driver rewrite

2007-04-27 Thread Jan Engelhardt
On Apr 27 2007 01:24, David Miller wrote: >> On Apr 27 2007 00:28, David Miller wrote: >> >> >This is the patch I intend to send to Linus via my >> >sparc-2.6 tree. >> > >> >Thanks to everyone for the review and testing! >> > >> >commit cd9ad58d4061494e7fdd70ded7bcf2418daf356a >> >Author: David S

Re: [PATCH]: Final ESP driver rewrite

2007-04-27 Thread Jan Engelhardt
On Apr 27 2007 00:28, David Miller wrote: >This is the patch I intend to send to Linus via my >sparc-2.6 tree. > >Thanks to everyone for the review and testing! > >commit cd9ad58d4061494e7fdd70ded7bcf2418daf356a >Author: David S. Miller <[EMAIL PROTECTED]> >Date: Thu Apr 26 21:19:23 2007 -0700

[PATCH 29/30] Use menuconfig objects - SCSI

2007-04-10 Thread Jan Engelhardt
Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: linux-2.6.21-rc5/drivers/scsi/Kconfig === ---

[PATCH 09/30] Use menuconfig objects - fusion

2007-04-10 Thread Jan Engelhardt
Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: linux-2.6.21-rc5/drivers/message/fusion/K

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jan Engelhardt
On Mar 11 2007 22:45, Ric Wheeler wrote: > Jan Engelhardt wrote: >> On Mar 11 2007 18:51, Ric Wheeler wrote: >> >> > During the recent IO/FS workshop, we spoke briefly about the >> > coming change to a 4k sector size for disks on linux. If I >> > reca

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jan Engelhardt
On Mar 11 2007 18:51, Ric Wheeler wrote: > > During the recent IO/FS workshop, we spoke briefly about the > coming change to a 4k sector size for disks on linux. If I > recall correctly, the general feeling was that the impact was > not significant since we already do most file system IO in 4k > p