Re: Problems with logout in qlt_free_session_done

2019-05-08 Thread Giridhar Malavali
On 5/8/19, 1:42 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Shivaram Upadhyayula" wrote: Hi, There seem to be a few issues when trying to do a logout qla_target.c:qlt_free_session_done in 4.19.41 1. When the logout timesout qla2x00_sp_timeout is called. This

Re: [PATCH] nvme,scsi: display FC-NVMe port roles

2019-04-12 Thread Giridhar Malavali
ers/scsi/scsi_transport_fc.c | 3 +++ > include/linux/nvme-fc-driver.h | 6 -- > include/scsi/scsi_transport_fc.h | 3 +++ > 8 files changed, 37 insertions(+), 15 deletions(-) > Reviewed-by: Giridhar Malavali

Re: [PATCH 01/15] qla2xxx: Set the SCSI command result before calling the command done

2019-03-28 Thread Giridhar Malavali
On 3/28/19, 10:36 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On Thu, 2019-03-28 at 10:09 -0700, Himanshu Madhani wrote: > From: Giridhar Malavali > > This patch sets SCSI cmd->result before scsi_done() is called.

Re: [PATCH 04/15] qla2xxx: Increase the max_sgl_segments to 1024

2019-03-28 Thread Giridhar Malavali
On 3/28/19, 10:39 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On Thu, 2019-03-28 at 10:10 -0700, Himanshu Madhani wrote: > From: Giridhar Malavali > > This patch increases max_sgl_segments value to max supported > w

Re: [PATCH] Fix panic from use after free in qla2x00_async_tm_cmd

2019-02-12 Thread Giridhar Malavali
SENT; + fcport->flags &= ~FCF_ASYNC_SENT; done: return rval; } -- Acked-by: Giridhar Malavali 1.8.3.1

Re: qla2xxx init warning with blk_mq at drivers/pci/msi.c:1273 pci_irq_get_affinity+0xf4/0x120

2019-02-11 Thread Giridhar Malavali
We are working on this and we will have an update for this. On 2/10/19, 4:29 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Meelis Roos" wrote: External Email I tested todays 5.0.0-rc5-00358-gdf3865f on my sparcs and a couple of servers that have qla2xxx FC adapter gave m

Re: [EXT] Re: [PATCH 08/13] qla2xxx: Fix SRB allocation flag to avoid sleeping in IRQ context

2019-02-04 Thread Giridhar Malavali
On 2/4/19, 6:19 PM, "Bart Van Assche" wrote: External Email -- On 2/4/19 12:22 PM, Himanshu Madhani wrote: > Let us know if there are any other comments? Hi Himanshu, Sorry but I do not h

Re: [PATCH 08/13] qla2xxx: Fix SRB allocation flag to avoid sleeping in IRQ context

2019-01-29 Thread Giridhar Malavali
On 1/25/19, 7:55 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: External Email On Thu, 2019-01-24 at 23:23 -0800, Himanshu Madhani wrote: > From: Giridhar Malavali > > This patch fixes SRB allocation flag from GFP_K

Re: [SCSI] qla2xxx: Enhancements to support ISPFx00.

2016-04-15 Thread Giridhar Malavali
On 4/13/16, 5:39 AM, "Dan Carpenter" wrote: >Hello Giridhar Malavali, > >The patch 8ae6d9c7eb10: "[SCSI] qla2xxx: Enhancements to support >ISPFx00." from Mar 28, 2013, leads to the following static checker >warning: > > drivers/scsi/qla2x

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-05 Thread Giridhar Malavali
On 2/5/16, 12:00 PM, "Bart Van Assche" wrote: >On 02/05/2016 09:26 AM, Himanshu Madhani wrote: >> On 2/4/16, 10:16 AM, "Bart Van Assche" >>wrote: >>> On 02/04/2016 08:45 AM, Himanshu Madhani wrote: From: Quinn Tran #cat /sys/kernel/debug/qla2xxx/qla2xxx_31/tgt_sess

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-08 Thread Giridhar Malavali
On 10/8/15 4:10 PM, "Julian Calaby" wrote: >Hi James, > >On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley > wrote: >> On Thu, 2015-10-08 at 15:46 +, Himanshu Madhani wrote: >>> >>> On 10/7/15, 4:41 PM, "Julian Calaby" wrote: >>> >>> >Hi Xose, >>> > >>> >On Thu, Oct 8, 2015 at 2:13 AM, Xose

Re: Delayed FC rport removal causes errors on other device

2014-12-18 Thread Giridhar Malavali
Tony, We will get back to you after looking at the logs. -- Giri On 12/18/14 8:37 AM, "Tony Battersby" wrote: >On 12/17/2014 06:17 PM, Giridhar Malavali wrote: >> Tony, >> >> We will look into this further and get back to you. >> >> Do you have

Re: Delayed FC rport removal causes errors on other device

2014-12-17 Thread Giridhar Malavali
Tony, We will look into this further and get back to you. Do you have driver logs with extended error logging for this failure. If not, can you please capture one and send it across. Thanks, Giridhar On 12/17/14 2:41 PM, "Tony Battersby" wrote: >Initiator-mode problem summary: > >FC initiato

Re: [PATCH RESEND 00/35] qla2xxx: Patches for 3.18 scsi "misc" branch.

2014-10-01 Thread Giridhar Malavali
Christoph, In order to synchronize with our internal testing and minimize the regression, we are planning to fix those sparse errors in a staggered phase. We will update what can be fixed for 3.19. Hope this approach works. -- Giri On 9/25/14 10:01 AM, "Christoph Hellwig" wrote: >Thanks, I'

Re: [PATCH 0/6] qla2xxx device removal fixups

2014-06-18 Thread Giridhar Malavali
Hi Joe, Thanks for the patches. We will review and update. -- Giri On 6/18/14 7:02 AM, "Joe Lawrence" wrote: >Hi Chad, Giri, et al. > >Stratus has been testing the upstream qla2xxx driver against surprise >device removal and has found a few minor issues along the way. With >this patchset, res

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-07 Thread Giridhar Malavali
On 5/7/14 12:21 PM, "Konrad Rzeszutek Wilk" wrote: >On Wed, May 07, 2014 at 07:12:31PM +, James Bottomley wrote: >> On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote: >> > On Wed, May 07, 2014 at 05:00:20AM -0400, vikas.chaudh...@qlogic.com >>wrote: >> > > From: Vikas Chaudhary

Re: [LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

2014-01-22 Thread Giridhar Malavali
On 1/22/14 1:54 AM, "Bart Van Assche" wrote: >On 01/16/14 23:35, Giridhar Malavali wrote: >> On 1/10/14 10:27 AM, "Mike Snitzer" wrote: >>> I would like to attend to participate in discussions related to topics >>> listed in the subject. As a

[LSF/MM TOPIC] [ATTEND] scsi_eh updates, scsi-mq

2014-01-20 Thread Giridhar Malavali
I would like to attend to participate in discussions related to topic mentioned in the subject line. I would like to learn/discuss the changes in the following areas and plan supporting them in qla2xxx (LLDs). Thanks, Giri <>

Re: [LSF/MM TOPIC] [ATTEND] scsi_eh updates

2014-01-20 Thread Giridhar Malavali
On 12/20/13 6:54 AM, "Hannes Reinecke" wrote: >Hi all, > >(before leaving for holiday ...) > >I'd like to attend LSF 2014. > >During that I'd like to discuss the current status of the SCSI EH >and the future planned updates. > >As discussed during last year's LSF the SCSI error handler should b

Re: [LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

2014-01-16 Thread Giridhar Malavali
On 1/10/14 10:27 AM, "Mike Snitzer" wrote: >I would like to attend to participate in discussions related to topics >listed in the subject. As a maintainer of DM I'd be interested to >learn/discuss areas that should become a development focus in the months >following LSF. +1 for scsi-mq. --

Re: [PATCH] qla2xxx: Configure NPIV fc_vport via tcm_qla2xxx_npiv_make_lport

2014-01-15 Thread Giridhar Malavali
Sent from my iPhone. Please excuse any typos. > On Jan 14, 2014, at 10:02 PM, "Nicholas A. Bellinger" > wrote: > > From: Nicholas Bellinger > > Hi Saurav & Co, > > Here is the updated NPIV patch on top of the original here: > > [PATCH] qla2xxx: Enhancements to enable NPIV support for QLO

Re: [SCSI] qla2xxx: Enhancements to support ISPFx00.

2013-04-15 Thread Giridhar Malavali
Dan, Thanks for bringing this to our attention. We will look into this and take care of this. -- Giri On 4/15/13 1:34 PM, "Dan Carpenter" wrote: >Hello Giridhar Malavali, > >The patch 8ae6d9c7eb10: "[SCSI] qla2xxx: Enhancements to support >ISPFx00." from M

Re: [PATCH 04/12] [SCSI] qla2xxx: Use standard PCIe Capability Link register field names

2012-12-07 Thread Giridhar Malavali
Acked-by: Giridhar Malavali On 12/7/12 12:17 AM, "Saurav Kashyap" wrote: >Acked-by: Saurav Kashyap > >Thanks, >~Saurav > > > >>Use the standard #defines for PCIe Link Capability register fields >>rather than bare numbers. This also uses the new PC

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-18 Thread Giridhar Malavali
On 9/18/12 10:54 AM, "Bjorn Helgaas" wrote: >On Mon, Sep 17, 2012 at 6:06 AM, Yijing Wang >wrote: >> On 2012/9/16 11:30, Bjorn Helgaas wrote: >>> On Sat, Sep 15, 2012 at 4:22 AM, Yijing Wang >>>wrote: Hi all, I encountered a very strange problem when I hot plug a fiber channe

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-17 Thread Giridhar Malavali
On 9/17/12 5:06 AM, "Yijing Wang" wrote: >[ 769.531289] qla2xxx [:08:00.0]-001d: : Found an ISP2532 irq 32 >iobase 0xc90016bcc000. >[ 769.531748] qla2xxx :08:00.0: irq 91 for MSI/MSI-X >[ 769.531768] qla2xxx :08:00.0: irq 92 for MSI/MSI-X >[ 799.503673] qla2xxx [:08:00.0