[PATCH 1/1 linux-next] scsi: make bnx2fc_global_lock spinlock static

2015-02-04 Thread Fabian Frederick
bnx2fc_global_lock is only used in bnx2fc_fcoe.c Signed-off-by: Fabian Frederick --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 98d06d1..66fb527 100644 --- a

[PATCH V4 linux-next RESEND 2] bfa: replace 2 kzalloc/copy_from_user by memdup_user

2014-11-14 Thread Fabian Frederick
This patch also removes unnecessary printk(KERN_INFO Signed-off-by: Fabian Frederick --- V4: remove blank line after memdup_user V3: memdup_user first argument is already void __user * (thanks to Joe Perches) typo in title V2: Remove printk(KERN_INFO (suggested by Alan) drivers/scsi/bfa

[PATCH 1/1 linux-next] fusion: move seq_mpt_print_ioc_summary under CONFIG_PROC_FS

2014-11-01 Thread Fabian Frederick
tatic void seq_mpt_print_ioc_summary(MPT_ADAPTER *ioc, struct seq_file *m, int showlan) This patch also fixes some checkpatch warnings: -lines over 80 characters -(u8*) -> (u8 *) -seq_puts instead of seq_printf for "(disabled)" -blank line after declarations Signed-off-by: Fabian

[PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Fabian Frederick
Fix -Wunused-but-set-variable warning Signed-off-by: Fabian Frederick --- drivers/scsi/hpsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index cef5d49..34330e1 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 1/1 linux-next] bsg: fix shadow warning in bsg_ioctl()

2014-10-23 Thread Fabian Frederick
directly call scsi_cmd_ioctl() with (void __user *)arg instead of uarg redeclaration. Signed-off-by: Fabian Frederick --- block/bsg.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 276e869..c2f90bd 100644 --- a/block/bsg.c +++ b/block

[PATCH 1/1] aic79xx: replace kmalloc/memset 0 by kzalloc

2014-07-04 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic79xx_core.c | 3 +-- drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/sc

[PATCH 1/1] [SCSI] bfa: use ARRAY_SIZE instead of sizeof/sizeof[0]

2014-06-30 Thread Fabian Frederick
Use macro definition Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/scsi/bfa/bfa_fcs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/b

[PATCH 1/1] drivers/message/fusion/mptfc.c: remove unnecessary null test before kfree

2014-06-28 Thread Fabian Frederick
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: linux-scsi@vger.kernel.org Cc: dl-mptfusionli...@lsi.com Signed-off-by: Fabian Frederick --- drivers/message/fusion/mptfc.c | 3 +-- 1 file changed, 1

[PATCH 1/1] drivers/scsi/aic94xx/aic94xx_init.c: remove null test before kfree

2014-06-17 Thread Fabian Frederick
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/scsi/aic94xx/aic94xx_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH 1/1] drivers/message/i2o/i2o_block.c: remove unnecessary test on unsigned value

2014-06-11 Thread Fabian Frederick
unsigned value is never < 0 Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/message/i2o/i2o_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c index 6fc3866..2b684ec 100

[PATCH 1/1] include/scsi/osd_protocol.h: remove unnecessary __constant

2014-06-01 Thread Fabian Frederick
__constant_cpu_to_be16 converted to cpu_to_be16 This patch fixes checkpatch warnings: "WARNING: __constant_cpu_to_be16 should be cpu_to_be16" Cc: Boaz Harrosh Cc: Benny Halevy Signed-off-by: Fabian Frederick --- include/scsi/osd_protocol.h | 10 +- 1 file changed, 5 insert

[RFC 1/1] drivers/scsi/bfa/bfad_debugfs.c: replace 2 kzalloc/copy_from_user to memdup_user

2014-05-30 Thread Fabian Frederick
(memdup_user can be used to replace kmalloc/copy_from_user. Not sure if it's ok with kzalloc ...) Cc: linux-scsi@vger.kernel.org Cc: Anil Gurumurthy Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/bfa/bfad_debugfs.c | 30 ++-

[PATCH 1/1] drivers/scsi/megaraid/megaraid_sas_base.c: replace kmalloc/copy_from_user by memdup_user

2014-05-30 Thread Fabian Frederick
Cc: Neela Syam Kolli Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/megaraid/megaraid_sas_base.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_

[PATCH 1/1] drivers/scsi/libsas/sas_scsi_host.c: use PTR_ERR_OR_ZERO

2014-05-30 Thread Fabian Frederick
replace IS_ERR/PTR_ERR Cc: Lukasz Dorau Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/libsas/sas_scsi_host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_ho

[PATCH 1/1] drivers/scsi/aacraid/commctrl.c: replace kmalloc/copy_from_user by memdup_user

2014-05-30 Thread Fabian Frederick
Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/aacraid/commctrl.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c index fbcd48d..3d5d6a6 100644 --- a/dr

[PATCH 1/1] drivers/scsi/aic7xxx/aic79xx_core.c: replace kmalloc/memset 0 by kzalloc

2014-05-28 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic79xx_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 0bcacf7..9ce3

[PATCH 1/1] drivers/scsi/aic7xxx/aic7xxx_core.c: replace 3 kmalloc/memset 0 by kzalloc

2014-05-28 Thread Fabian Frederick
Cc: "James E.J. Bottomley" Cc: Hannes Reinecke Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic7xxx_core.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c index 10172a

[PATCH 1/1] drivers/scsi/aic7xxx/aic7xxx_osm.c: replace kmalloc/memset 0 by kzalloc

2014-05-27 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index c0c6258..7167

[PATCH 1/1] drivers/scsi/aic7xxx/aic79xx_osm.c: replace kmalloc/memset by kzalloc

2014-05-27 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index 69d5c43..76b5

[PATCH 1/1] drivers/scsi/lpfc/lpfc_init.c: remove unnecessary casting

2014-05-27 Thread Fabian Frederick
Fix coccicheck warning: "WARNING: casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *) is useless." Cc: James Smart Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/lpfc/lpfc_init.c | 6 +++--- 1 file changed, 3 insertions(+),

Fw: [PATCH 1/1 RESEND] drivers/scsi/sd.c: remove positive test on unsigned value

2014-05-10 Thread Fabian Frederick
val is unsigned. Signed-off-by: Fabian Frederick --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index efcbcd1..b54d4f8 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -296,7 +296,7