Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-17 Thread Eric W. Biederman
Christoph Hellwig writes: > On Thu, May 17, 2018 at 12:28:01AM -0500, Eric W. Biederman wrote: >> > struct pid_namespace *proc_pid_namespace(struct inode *inode) >> > { >> >// maybe warn on for s_magic not on procfs?? >> >return inode->i_sb-

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-16 Thread Eric W. Biederman
Christoph Hellwig writes: > On Sat, May 05, 2018 at 07:37:33AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig writes: >> >> > The shole seq_file sequence already operates under a single RCU lock pair, >> > so move the pid namespace lookup into it, and s

Re: [PATCH 34/40] atm: simplify procfs code

2018-05-16 Thread Eric W. Biederman
Christoph Hellwig writes: > On Sat, May 05, 2018 at 07:51:18AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig writes: >> >> > Use remove_proc_subtree to remove the whole subtree on cleanup, and >> > unwind the registration loop into individual calls. S

Re: [PATCH 38/40] ide: remove ide_driver_proc_write

2018-05-05 Thread Eric W. Biederman
REG|S_IRUGO so I don't think the write support was ever finished. That cap_capable in the write method looks down right scary/buggy. Acked-by: "Eric W. Biederman" Eric > > Signed-off-by: Christoph Hellwig > --- > drivers/ide/ide-proc.c | 46 --

Re: [PATCH 34/40] atm: simplify procfs code

2018-05-05 Thread Eric W. Biederman
Christoph Hellwig writes: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Can you please explain why you are removing the error handling when you are unwinding the regis

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-05 Thread Eric W. Biederman
Christoph Hellwig writes: > The shole seq_file sequence already operates under a single RCU lock pair, > so move the pid namespace lookup into it, and stop grabbing a reference > and remove all kinds of boilerplate code. This is wrong. Move task_active_pid_ns(current) from open to seq_start act

Re: [PATCH v4 00/10] ufs: sysfs: read-only access to device descriptors, attributes and flags

2018-02-01 Thread Eric W. Biederman
Can you please clarify the naming, at least as far as saying scsi/ufs. Universal Flash Storage is not the same thing as all as the Unix File System which has been using the acronym ufs for much longer. I saw this patchset and I was wondering what in the world does a filesystem need with sysfs en

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-05 Thread Eric W. Biederman
ything, or are in any sense correct for the problem they are trying to fix as the problem is not clearly described. In at least one place (mpls) you are patching a fast path. Compile out or don't load mpls by all means. But it is not acceptable to change the fast path without even conside

Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-09 Thread Eric W. Biederman
Aleksa Sarai writes: > On 11/05/2017 01:56 PM, Aleksa Sarai wrote: >> Previously, the only capability effectively required to operate on the >> /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, >> having an fsuid of GLOBAL_ROOT_UID was enough). This means that >> semi-privileged

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-14 Thread Eric W. Biederman
Brian King writes: > On 02/13/2017 08:04 PM, Benjamin Herrenschmidt wrote: >> On Mon, 2017-02-13 at 15:57 -0600, Brian King wrote: >>> If we do transition to use remove rather than shutdown, I think we >>> want >>> some way for a device driver to know whether we are doing kexec or >>> not. >>> A

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-13 Thread Eric W. Biederman
Brian King writes: > On 02/12/2017 07:01 PM, Benjamin Herrenschmidt wrote: >> On Mon, 2017-02-13 at 13:21 +1300, Eric W. Biederman wrote: >>>> Good point, at the very least we should call remove if shutdown doesn't >>>> exist. Eric: could we make the ch

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-02-12 Thread Eric W. Biederman
Anton Blanchard writes: > Hi Ben, > > On Mon, 13 Feb 2017 10:14:54 +1100 > Benjamin Herrenschmidt wrote: > >> On Mon, 2017-02-13 at 08:49 +1100, Anton Blanchard wrote: >> > From: Anton Blanchard >> > >> > We see lpfc devices regularly fail during kexec. Fix this by adding >> > a shutdown metho

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-10 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 20:10 -0600, Eric W. Biederman wrote: >> James Bottomley writes: >> >> > On Tue, 2016-11-08 at 18:57 -0600, Eric W. Biederman wrote: > [...] >> > > I am pretty certain that if you are going

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 18:57 -0600, Eric W. Biederman wrote: >> James Bottomley writes: >> >> > On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: > [...] >> > > Is it really the dropping of the lock that is causing th

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
Bart Van Assche writes: > On 11/08/2016 11:15 AM, Eric W. Biederman wrote: >> James Bottomley writes: >> >>> On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: >>>> On 11/08/2016 07:28 AM, James Bottomley wrote: >>>>> On Mon, 2016-11-07

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: >> James Bottomley writes: >> >> > On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: >> > > On 11/08/2016 07:28 AM, James Bottomley wrote: >> > > >

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: >> On 11/08/2016 07:28 AM, James Bottomley wrote: >> > On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: >> > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c >> > > index cf4c636..44ec536 100644 >> > > --

Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

2016-06-23 Thread Eric W. Biederman
Linus Torvalds writes: > On Thu, Jun 23, 2016 at 9:13 AM, Quinn Tran wrote: >> >> >> QT: setting up the interrupt vector does not mean the interrupt starts >> firing immediately. > > Actually, it very much can mean that. If the interrupt can possibly be > shared, there is a very real possibilit

Re: [PATCH RESEND 2/5] kexec: Export kexec_in_progress

2014-12-08 Thread Eric W. Biederman
Brian King writes: > On 12/02/2014 12:49 PM, Brian King wrote: >> On 12/02/2014 12:47 PM, Brian King wrote: >>> A kexec boot for some ipr SAS adapters was seen to take ~20 seconds >>> just doing ipr adapter initialization. This is due to the fact that >>> a kexec invokes the driver's shutdown han

Re: [PATCH 2/5] kexec: Export kexec_in_progress

2014-08-30 Thread Eric W. Biederman
Brian King writes: > On 08/04/2014 09:21 AM, Brian King wrote: >> On 07/28/2014 03:28 PM, Brian King wrote: >>> >>> Export kexec_in_progress for use by device drivers and other modules >>> to optimize kexec boot. >>> >>> Signed-off-by: Brian King >>> --- >>> >>> kernel/kexec.c |2 ++ >>> 1

Re: [PATCH] scsi_netlink: Remove dead and buggy code

2012-09-11 Thread Eric W. Biederman
James Bottomley writes: > On Mon, 2012-09-10 at 15:07 -0400, David Miller wrote: >> From: ebied...@xmission.com (Eric W. Biederman) >> Date: Fri, 07 Sep 2012 15:39:21 -0700 >> >> > >> > The scsi netlink code confuses the netlink port id with a p

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-16 Thread Eric W. Biederman
Rob Landley <[EMAIL PROTECTED]> writes: > On Monday 15 October 2007 11:38:33 pm Eric W. Biederman wrote: >> > I don't follow your logic. We don't need SWAP > RAM in order to swap >> > effectively, IMO. >> >> The steady state of a system that is

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: > > on some kernel versions you are correct about needing swap > ram, but on > current > versions you are not. the swap space gets allocated as needed, and re-used as > needed (I don't know the mechanism of this, but I remember the last time this > changed from vm=max(ra

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Eric W. Biederman
Nick Piggin <[EMAIL PROTECTED]> writes: > On Tuesday 16 October 2007 13:55, Eric W. Biederman wrote: >> Nick Piggin <[EMAIL PROTECTED]> writes: > >> > How much swap do you have configured? You really shouldn't configure >> > so much unless you d

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Eric W. Biederman
Nick Piggin <[EMAIL PROTECTED]> writes: > On Monday 15 October 2007 18:04, Rob Landley wrote: >> On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: > >> > > excuse for conflating different categories of devices in the first >> > > place. >> > >> > See the thinkpad Ultrabay drive example abov

Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-17 Thread Eric W. Biederman
Kirill Korotaev <[EMAIL PROTECTED]> writes: > Eric, though I personally don't care much: > 1. I ask for not setting your authorship/copyright on the code which you just > copied > from other places. Just doesn't look polite IMHO. I can't claim complete ownership of the code, there was plenty of

Re: [PATCH 0/59] Cleanup sysctl

2007-01-17 Thread Eric W. Biederman
Kirill Korotaev <[EMAIL PROTECTED]> writes: > Eric, really good job! > > Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) > Acked-By: Kirill Korotaev <[EMAIL PROTECTED]> > > 14/59 - minor (extra space) > 25/59 - minor note > 33/59 - not sorted sysctl IDs > 45/59 - typo >

[PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The semantic effect of insert_at_head is that it would allow new registered sysctl entries to override existing sysctl entries of the same name. Which is pain for caching and the proc interface never implemented. I have done an aud

[PATCH 14/59] sysctl: C99 convert xfs ctl_tables

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_sysctl.c | 258 1 files changed, 180 insertions(+), 78 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_sysct

[PATCH 58/59] sysctl: Reimplement the sysctl proc support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With this change the sysctl inodes can be cached and nothing needs to be done when removing a sysctl table. For a costk of 2K code we will save about 4K of static tables (when we remove de from ctl_table) and 70K in proc_dir_entries t

[PATCH 32/59] sysctl: C99 convert arch/mips/lasat/sysctl.c and remove ABI breakage.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted While C99 converting the ctl_table initializers I realized that the binary sysctl numbers were in conflict with the binary values under CTL_KERN. Including CTL_KERN KERN_VERSION as used by glibc. So I just removed the sysctl

[PATCH 56/59] sysctl: factor out sysctl_head_next from do_sysctl

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The current logic to walk through the list of sysctl table headers is slightly painful and implement in a way it cannot be used by code outside sysctl.c I am in the process of implementing a version of the sysctl proc support that inst

[PATCH 59/59] sysctl: Remove the proc_dir_entry member for the sysctl tables.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted It isn't needed anymore, all of the users are gone, and all of the ctl_table initializers have been converted to use explicit names of the fields they are initializing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> -

[PATCH 28/59] sysctl: C99 Convert arch/ia64/sn/kernel/xpc_main.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/ia64/sn/kernel/xpc_main.c | 86 +-- 1 files changed, 38 insertions(+), 48 deletions(-) diff --git a/arch/ia64/sn/kernel/xpc_m

[PATCH 34/59] sysctl: s390 Remove unnecessary use of insert_at_head

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/s390/appldata/appldata_base.c |4 ++-- arch/s390/kernel/debug.c |2 +- arch/s390/mm/cmm.c |2 +- 3 files changed, 4 inse

[PATCH 46/59] sysctl: C99 convert coda ctl_tables and remove binary sysctls.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Will converting the coda sysctl initializers I discovered that it is yet another user of sysctl that was stomping CTL_KERN. So off with it's sys_sysctl support since it wasn't done in a supportable way. Signed-off-by: E

[PATCH 29/59] sysctl: C99 convert arch/ia64/kernel/perfmon and remove ABI breakage

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This convers the sysctl ctl_tables to use C99 initializers. While I was looking at it I discovered it was using a portion of the sysctl binary addresses space under CTL_KERN KERN_OSTYPE which was completely inappropriate. So I comp

[PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted While doing the C99 conversion I notices that the top level sh64 directory was using the binary number for CTL_KERN. That is a no-no so I removed the support for the sysctl binary interface only leaving sysctl /proc support. At lea

[PATCH 27/59] sysctl: sn Remove sysctl ABI BREAKAGE

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted By not using the enumeration in sysctl.h (or even understanding it) the SN platform placed their arch specific xpc directory on top of CTL_KERN and only because they didn't have 4 entries in their xpc directory got lucky and d

[PATCH 52/59] sysctl: Create sys/fs/binfmt_misc as an ordinary sysctl entry

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted binfmt_misc has a mount point in the middle of the sysctl and that mount point is created as a proc_generic directory. Doing it that way gets in the way of cleaning up the sysctl proc support as it continues the existence of a horribl

[PATCH 30/59] sysctl: mips/au1000 Remove sys_sysctl support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The assignment of binary numbers for sys_sysctl use was in shambles and despite requiring methods. Nothing was implemented on the sys_sysctl side. So this patch gives a mercy killing to the sys_sysctl support for powermanagment o

[PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/pm.c | 50 +++--- 1 files changed, 43 insertions(+), 7 deletions(-) diff --git a/arch/frv/kernel/pm.c b/arc

[PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/mips/au1000/common/power.c | 38 -- 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/arch/mips/au1000/common/po

[PATCH 4/59] sysctl: sunrpc Don't unnecessarily set ctl_table->de

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted We don't need this to prevent module unload races so remove the unnecessary code. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/sunrpc/sysctl.c |8 +--- net/sunrpc/xprtsock.c |7 +-- 2

[PATCH 3/59] sysctl: sunrpc Remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Because the sunrpc sysctls don't conflict with any other sysctls the setting the insert at head flag to register_sysctl has no semantic meaning. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/sunrpc/sysctl.c

[PATCH 26/59] sysctl: C99 convert arch/frv/kernel/sysctl.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/sysctl.c | 29 - 1 files changed, 24 insertions(+), 5 deletions(-) diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/kernel/sy

[PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The real time clock driver was using the binary number reserved for cdroms in the sysctl binary number interface, which is a no-no. So since the sysctl binary interface is wrong remove it. Signed-off-by: Eric W. Biederman <[EMAIL

[PATCH 20/59] sysctl: cdrom Don't set de->owner

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted There is no need for open files in /proc/sys/XXX to hold a reference count on the module that provides the file to prevent module unload races. While there is code active in the module p->used in the sysctl_table_header is in

[PATCH 53/59] sysctl: Remove support for CTL_ANY

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted There are currently no users in the kernel for CTL_ANY and it only has effect on the binary interface which is practically unused. So this complicates sysctl lookups for no good reason so just remove it. Signed-off-by: Eric W. Bie

[PATCH 39/59] sysctl: C99 convert ctl_tables in arch/x86_64/ia32/ia32_binfmt.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/ia32/ia32_binfmt.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/arch/x86_64/ia32/ia32_binfmt.c b/arch

[PATCH 38/59] sysctl: x86_64 Remove unnecessary use of insert_at_head

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The only sysctl x86_64 provides are not provided elsewhere, so insert_at_head is unnecessary. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/ia32/ia32_binfmt.c |2 +- arch/x86_64/mm/init.c

[PATCH 2/59] sysctl: Move CTL_SUNRPC to sysctl.h where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/sunrpc/debug.h |1 - include/linux/sysctl.h |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sunrpc/debug

[PATCH 23/59] sysctl: Move CTL_FRV into sysctl.h where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/sysctl.c |1 - include/linux/sysctl.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/frv/kernel/sysctl.c b/arch/frv/ker

[PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- init/main.c |3 +++ kernel/sysctl.c |3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/init/main.c b/init/main.c index 8b4a7d7..8af5c6e

[PATCH 21/59] sysctl: Move CTL_PM into sysctl.h where it belongs.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel/pm.c |1 - include/linux/sysctl.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/frv/kernel/pm.c b/arch/frv/kerne

[PATCH 40/59] sysctl: C99 convert ctl_tables in arch/x86_64/kernel/vsyscall.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Basically everything was done but I removed all element initializers from the trailing entries to make it clear the entire last entry should be zero filled. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x

[PATCH 42/59] sysctl: Remove sys_sysctl support from the hpet timer driver.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted In the binary sysctl interface the hpet driver was claiming to be the cdrom driver. This is a no-no so remove support for the binary interface. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/char/hpet.c |

[PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique sysctl binary numbers setting insert_at_head is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/char/ipmi/ipmi_poweroff.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 35/59] sysctl: C99 convert ctl_tables in arch/powerpc/kernel/idle.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This was partially done already and there was no ABI breakage what a relief. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/powerpc/kernel/idle.c | 11 --- 1 files changed, 8 insertions(+), 3 deleti

[PATCH 9/59] sysctl: decnet remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag does not succeed in overriding any sysctls, and is just confusing because it doesn't. Clear the flag. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>

[PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc_htab.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted And make the mode of the kernel directory 0555 no one is allowed to write to sysctl directories. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/ppc/kernel/ppc_htab.c | 11 --- 1 files changed, 8 inse

[PATCH 19/59] sysctl: cdrom remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique binary sysctl numbers setting insert_at_head to override other sysctl entries is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/cdrom/cdrom.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 1/59] sysctl x25: Remove unnecessary insert_at_head from register_sysctl_table.

2007-01-16 Thread Eric W. Biederman
Since x25 uses unique binary numbers inserting yourself at the head of the search list for sysctls so you can override already registered sysctls is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/x25/sysctl_net_x25.c |2 +- 1 files changed, 1 insertions

[PATCH 8/59] sysctl: ipx remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag servers no semantic purpose and is just confusing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/ipx/sysctl_net_ipx.c |2 +- 1 file

[PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantic purpose. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/rose/sysctl_net_rose.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 16/59] sysctl: md Remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctls used by the md driver are have unique binary numbers so remove the insert_at_head flag as it serves no useful purpose. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/md/md.c |2 +- 1 file

[PATCH 17/59] sysctl: mac_hid remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique sysctl binary numbers setting insert_at_head is pointless. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/macintosh/mac_hid.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --g

[PATCH 22/59] sysctl: frv pm remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted With unique binary numbers setting insert_at_head to insert yourself at the head of sysctl list and thus override existing sysctl entries serves no point. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/frv/kernel

[PATCH 12/59] sysctl: atalk remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/appletalk/sysctl_net_atalk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/appletalk/sysctl_net_atalk.c b/net/appletalk/sysctl_net_a

[PATCH 11/59] sysctl: ax25 remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/ax25/sysctl_net_ax25.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c index d23a

[PATCH 10/59] sysctl: dccp remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/dccp/sysctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c index fdcfca3..3391631 100644 --- a/net/d

[PATCH 13/59] sysctl: xfs remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_sysctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_sysctl.c b/fs/xfs/linux-2.6/xfs_sysctl.c i

[PATCH 48/59] sysctl: Register the ocfs2 sysctl numbers

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted ocfs2 was did not have the binary number it uses under CTL_FS registered in sysctl.h. Register it to avoid future conflicts, and change the name of the definition to be in line with the rest of the sysctl numbers. Signed-off-by:

[PATCH 41/59] sysctl: C99 convert ctl_tables in arch/x86_64/mm/init.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/x86_64/mm/init.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c i

[PATCH 47/59] sysctl: C99 convert ctl_tables in NTFS and remove sys_sysctl support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Putting ntfs-debug under FS_NRINODE was not a kosher thing to do so don't give it any binary number. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- fs/ntfs/sysctl.c | 24 1 files chang

[PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This is just a simple cleanup to keep kernel/sysctl.c from getting to crowded with special cases, and by keeping all of the utsname logic to together it makes the code a little more readable. Signed-off-by: Eric W. Biederman &

[PATCH 54/59] sysctl: Remove support for directory strategy routines.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted parse_table has support for calling a strategy routine when descending into a directory. To date no one has used this functionality and the /proc/sys interface has no analog to it. So no one is using this functionality kill it and ma

[PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/parport/procfs.c | 264 +- 1 files changed, 189 insertions(+), 75 deletions(-) diff --git a/drivers/parport/procfs

[PATCH 6/59] sysctl: netrom remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantic purpose, so it is just confusing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/netrom/sysctl_net_netrom.c |2 +- 1 file

[PATCH 57/59] sysctl: allow sysctl_perm to be called from outside of sysctl.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/sysctl.h |2 ++ kernel/sysctl.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/linux/sysctl.h b/i

[PATCH 7/59] sysctl: llc remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantis purpose, and is just confusing. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- net/llc/sysctl_net_llc.c |2 +- 1 file

[PATCH 15/59] sysctl: scsi remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/scsi/scsi_sysctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c index 04d0

[PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted We need to have the the definition of all top level sysctl directories registers in sysctl.h so we don't conflict by accident and cause abi problems. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- arch/s390/ap

[PATCH 44/59] sysctl: Register the sysctl number used by the arlan driver.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/net/wireless/arlan-proc.c |2 +- include/linux/sysctl.h|1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wi

[PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
There has not been much maintenance on sysctl in years, and as a result is there is a lot to do to allow future interesting work to happen, and being ambitious I'm trying to do it all at once :) The patches in this series fall into several general categories. - Removal of useless attempts to ove

[PATCH 24/59] sysctl: frv remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Since the binary sysctl numbers are unique putting the registered sysctls at the head of the sysctl list where they can override existing sysctls serves no useful purpose. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> -

[PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted This is just a simple cleanup to keep kernel/sysctl.c from getting to crowded with special cases, and by keeping all of the ipc logic to together it makes the code a little more readable. Signed-off-by: Eric W. Biederman <[EMAIL