Re: mpt3sas and T10DIF

2019-02-01 Thread Douglas Miller
I saw "ref tag" errors on NVMe devices, starting with 4.18 kernels. The fix was: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=7809167da5c86fd6bf309b33dee7a797e263342f On 02/01/2019 10:20 AM, Sebastian Andrzej Siewior wrote: Hi, I tried to use

Re: mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

2018-06-07 Thread Douglas Miller
e msix for issuing abort to timed out IO. With this driver will process IO's reply first followed by TM. Signed-off-by: Suganath prabu Subramani Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Signed-off-by: Martin K. Petersen Thanks, Suganath Prabu S On Wed, Jun 6, 2018 at 7:50 PM, Dougla

mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

2018-06-06 Thread Douglas Miller
Running a heavy I/O load on multipath/dual-ported SSD disks attached to a SAS3008 adapter (mpt3sas driver), we are seeing I/Os get aborted and tasks stuck in blk_complete_request() and this sometimes results in hitting a BUG_ON in blk_start_request(). It would appear that we are seeing two comp

[PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-20 Thread Douglas Miller
t NULL before doing cleanup on it. Since in the error case this is also not NULL, it ends up trying to access an invalid task pointer. Solution is to assign NULL to ha->dpc_thread in the error path to avoid kthread cleanup in that case. Signed-off-by: Douglas Miller --- drivers/scsi/qla2xxx

[PATCH 0/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-20 Thread Douglas Miller
See [PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

Re: [PATCH] ses: do not add a device to an enclosure if enclosure_add_links() fails.

2017-07-10 Thread Douglas Miller
On 06/27/2017 07:50 AM, Douglas Miller wrote: On 06/27/2017 04:53 AM, Maurizio Lombardi wrote: The enclosure_add_device() function should fail if it can't create the relevant sysfs links. Signed-off-by: Maurizio Lombardi --- drivers/misc/enclosure.c | 14 ++ 1 file change

Re: [PATCH] ses: do not add a device to an enclosure if enclosure_add_links() fails.

2017-06-27 Thread Douglas Miller
_links(cdev); + if (err) { + put_device(cdev->dev); + cdev->dev = NULL; + } + return err; } EXPORT_SYMBOL_GPL(enclosure_add_device); Tested-by: Douglas Miller This fixes a problem where udevd (insmod ses) races with/overtakes do_scan_async(), wh

Re: enclosure: fix sysfs symlinks creation when using multipath

2017-06-26 Thread Douglas Miller
On 06/20/2017 06:38 AM, Maurizio Lombardi wrote: Dne 16.6.2017 v 18:08 Douglas Miller napsal(a): Just to respond to James' question on the cause. What I observed was a race condition between udevd (ses_init()) and a worker thread (do_scan_async()), where the worker thread is creatin

Re: enclosure: fix sysfs symlinks creation when using multipath

2017-06-16 Thread Douglas Miller
On 06/16/2017 10:41 AM, Douglas Miller wrote: On 03/16/2017 01:49 PM, James Bottomley wrote: On Wed, 2017-03-15 at 19:39 -0400, Martin K. Petersen wrote: Maurizio Lombardi writes: With multipath, it may happen that the same device is passed to enclosure_add_device() multiple times and that

Re: enclosure: fix sysfs symlinks creation when using multipath

2017-06-16 Thread Douglas Miller
On 03/16/2017 01:49 PM, James Bottomley wrote: On Wed, 2017-03-15 at 19:39 -0400, Martin K. Petersen wrote: Maurizio Lombardi writes: With multipath, it may happen that the same device is passed to enclosure_add_device() multiple times and that the enclosure_add_links() function fails to crea

Re: [RFC] enclosure: fix sysfs symlinks creation when using multipath

2017-06-16 Thread Douglas Miller
On 06/16/2017 07:48 AM, Maurizio Lombardi wrote: Dne 16.6.2017 v 14:40 Douglas Miller napsal(a): I'd like to add that we are seeing this problem with singlepath installations and need to get this fixed upstream as soon as possible. RHEL new product contains this fix and is working f

Re: [RFC] enclosure: fix sysfs symlinks creation when using multipath

2017-06-16 Thread Douglas Miller
100644 --- a/include/linux/enclosure.h +++ b/include/linux/enclosure.h @@ -97,6 +97,7 @@ struct enclosure_component { struct device cdev; struct device *dev; enum enclosure_component_type type; + int links_created; int number; int fault; int active;

Re: [PATCH] block: Fix kernel panic occurs while creating second raid disk

2017-01-24 Thread Douglas Miller
On 11/03/2016 12:15 AM, Sreekanth Reddy wrote: On Tue, Nov 1, 2016 at 11:52 PM, Douglas Miller wrote: On 10/24/2016 01:54 PM, Sreekanth Reddy wrote: Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here

Re: [PATCH RESEND v2 1/2] blk-mq: Fix failed allocation path when mapping queues

2016-12-07 Thread Douglas Miller
On 12/07/2016 02:06 PM, Douglas Miller wrote: On 12/06/2016 09:31 AM, Gabriel Krisman Bertazi wrote: In blk_mq_map_swqueue, there is a memory optimization that frees the tags of a queue that has gone unmapped. Later, if that hctx is remapped after another topology change, the tags need to be

Re: [PATCH RESEND v2 2/2] blk-mq: Avoid memory reclaim when remapping queues

2016-12-07 Thread Douglas Miller
ned-off-by: Gabriel Krisman Bertazi Cc: Brian King Cc: Douglas Miller Cc: linux-bl...@vger.kernel.org Cc: linux-scsi@vger.kernel.org --- block/blk-mq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 6718f894fbe1..5f4e452eef72 100644 -

Re: [PATCH RESEND v2 1/2] blk-mq: Fix failed allocation path when mapping queues

2016-12-07 Thread Douglas Miller
9404 system_call+0x38/0xec Signed-off-by: Gabriel Krisman Bertazi Cc: Brian King Cc: Douglas Miller Cc: linux-bl...@vger.kernel.org Cc: linux-scsi@vger.kernel.org --- block/blk-mq.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/block/blk-mq.c b

Re: [PATCH] block: Fix kernel panic occurs while creating second raid disk

2016-11-01 Thread Douglas Miller
On 10/24/2016 01:54 PM, Sreekanth Reddy wrote: Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here ] [ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 [ +0.02] sysfs: canno

Issues with LSI-3008 adapters, mpt3sas driver

2016-08-31 Thread Douglas Miller
Hi all, I am seeing an issue while using an LSI-3008-based adapter (mpt3sas driver) on a PowerPC system (although I am not yet convinced it is architecture dependent). When I create a RAID1 volume, the physical disk devices get "hidden" as expected however the various kernel objects are out o