On Monday, March 31, 2014 11:36 AM Josh Triplett wrote:
> On Mon, Mar 31, 2014 at 08:54:49AM +0000, Dorau, Lukasz wrote:
> > On Saturday, March 29, 2014 7:04 PM Rashika Kheria
> wrote:
> > >
> > > Mark function as static in isci/phy.c because it is no
On Saturday, March 29, 2014 7:05 PM Rashika Kheria
wrote:
> Mark function as static in isci/remote_device.c because it is not used
> outside this file.
>
> This eliminates the following warning in isci/remote_device.c:
> drivers/scsi/isci/remote_device.c:1387:6: warning: no previous prototype fo
On Saturday, March 29, 2014 7:07 PM Rashika Kheria
wrote:
> Mark function as static in isci/port.c because they are not used outside
> this file.
>
> This eliminates the following warning in isci/port.c:
> drivers/scsi/isci/port.c:65:13: warning: no previous prototype for
> ‘port_state_name’ [-W
On Saturday, March 29, 2014 7:04 PM Rashika Kheria
wrote:
>
> Mark function as static in isci/phy.c because it is not used outside
> this file.
>
> This eliminates the following warning in isci/phy.c:
> drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for
> ‘scu_link_layer_set_txco
On Monday, February 24, 2014 9:02 AM Alexander Gordeev
wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
On Tuesday, February 04, 2014 12:17 PM Alexander Gordeev
wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range
On Thursday, January 23, 2014 10:39 AM Lukasz Dorau
wrote:
> The version of isci driver has not been updated for 2 years.
> It was 83 isci commits ago. Suspend/resume support has been implemented
> and many bugs have been fixed since 1.1. Now update the version to 1.2.
>
> Signed-off-by: Lukasz
On Monday, January 20, 2014 7:26 PM Dan Williams
wrote:
> On Mon, Jan 20, 2014 at 8:54 AM, Lukasz Dorau wrote:
> > In the first place, the loop 'for' in the macro 'for_each_isci_host'
> > (drivers/scsi/isci/host.h:314) is incorrect, because it accesses
> > the 3rd element of 2 element array. Aft
On Thursday, January 16, 2014 2:16 PM Lukasz Dorau
wrote:
>
> The loop 'for' in macro 'for_each_isci_host' (drivers/scsi/isci/init.c:717)
> is executed more times than it can be. Regardless the condition:
>'id < ARRAY_SIZE(to_pci_info(pdev)->hosts)' (drivers/scsi/isci/host.h:315)
> it is exe
;> > On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz
> wrote:
> >> >> Hi
> >> >>
> >> >> My story is very simply...
> >> >> I applied the following patch:
> >> >>
> >> >> diff --git a/drivers/scsi
On Friday, January 17, 2014 5:40 PM Sebastian Riemer
wrote:
> On 17.01.2014 14:55, Dorau, Lukasz wrote:
> >
> > Some additional information:
> >
> > The loop 'for' in macro ' for_each_isci_host ' defined as
> (drivers/scsi/isci/host.h:313):
On Friday, January 17, 2014 2:58 PM Richard Weinberger
wrote:
>
> Can you reproduce this using a standalone test?
> I.e:
> #include
>
> int main()
> {
> assert(2 < 2 != 1);
>
> return 0;
> }
>
No, I can't of course.
Lukasz
--
To unsubscribe from this list: send the line "u
On Friday, January 17, 2014 2:37 PM Dorau, Lukasz
wrote:
>
> Hi
>
> My story is very simply...
> I applied the following patch:
>
> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
> --- a/drivers/scsi/isci/init.c
> +++ b/drivers/scsi/isci/init.c
&g
Hi
My story is very simply...
I applied the following patch:
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -698,8 +698,11 @@ static int isci_pci_probe(struct pci_dev *pdev, const
struct pci_device_id *id)
On Monday, December 09, 2013 8:47 PM Williams, Dan J
wrote:
> Remove an erroneous BUG_ON() in the case of a hard reset timeout. If a
> SATA device is unable to restore the link in time we expect the port to
> go back to the "awaiting link-up" state. Since the timeout path
> notified libsas that
On 07/19/2013 Xinghai Yu wrote:
> The "sci_phy_link_layer_initialization()" was called only once in
> "sci_phy_initialize()" and it is called before a call of
> "sci_change_state(&iphy-
> >sm, SCI_PHY_STOPPED)". So the same call in the end of
> "sci_phy_link_layer_initialization()" is redundant.
On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin
wrote:
>
> The variable success is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> ide
On Wednesday, July 17, 2013 4:54 AM Xinghai Yu wrote:
>
> It seems the "phy_index++;" have been placed in wrong place, without it
> the while circle up will do a infinite loop.
>
> Signed-off-by: Xinghai Yu
Acked-by: Lukasz Dorau
> ---
> drivers/scsi/isci/port_config.c |2 +-
> 1 files
On Tue, 26 Mar 2013 00:01:38 -0700 Jingoo Han wrote:
> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
> build warning when CONFIG_PM_SLEEP is not selected. This is because
> sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
> the CONFIG_PM_SLEEP is enabled.
>
Hi James
What are you going to do with the following four ISCI patches from isci-for-3.6
tag?:
6734092e66011def7875bd67beef889d0fee1cc9isci: add a couple __iomem
annotations
67787c330762eb884bf8c169fe942263d55ec162isci: make function declaration
match implementation
a90037560588e51b3e9
20 matches
Mail list logo
