gt;> goto out;
>> }
>>
>> - err = ufshcd_hold(hba, true);
>> + err = ufshcd_hold(hba, false);
>> if (err) {
>> err = SCSI_MLQUEUE_HOST_BUSY;
>> clear_bit_unlock(tag, &hba->
Reviewed-by: Dolev Raviv
Thanks,
Dolev
--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project
-Original Message-
From: Yaniv Gardi [mailto:yga...@codeaurora.org]
Sent
> On Sun, Oct 26, 2014 at 11:04:06AM -0000, Dolev Raviv wrote:
>> > Btw, MAINTAINERS doesn't mention you for the ufs driver, should it?
>>
>> No it shouldn't.
>
> It seems like I'm getting a lot of the series from you and your signoff,
> why should
> On Fri, Oct 24, 2014 at 07:53:23AM -0000, Dolev Raviv wrote:
>> The first patch is Akinobu Mita's patch.
>> You can add my ack on it.
Sorry I meant 'reviewed-by'.
>
> Given that you passed them on to me you should normally sign off on them
> as well.
My
> On Thu, Oct 23, 2014 at 01:25:11PM +0300, Dolev Raviv wrote:
>> Contains a couple of bug fixes reported by Akinobu Mita, In adition to
>> "static checker" warnings reported by Dan Carpenter.
>
> Any reason you didn't add a signoff to the first patch?
The
ee(clkfreq) statement.
In addition we removed the redundant goto label.
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 2cdec78..1c3467b 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -10
HBA is not initialized or is
not powered.
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 77a4e38..d3f6ddb 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5104,7 +5104,7 @@ int ufshcd_system_suspend(struct uf
o fix it we return -ENOMEM and skip the message print.
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 8adf067..2cdec78 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -162,10 +162,8 @@ static i
Mita
Cc: Vinayak Holikatti
Cc: Santosh Y
Cc: Dolev Raviv
Cc: Subhash Jadavani
Cc: Yaniv Gardi
Cc: Christoph Hellwig
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 497c38a..59b6544 100644
--- a/driver
,
power mode change won't execute again after driver initialization.
This patch solves the problem by setting pwr_info to PWM G1 after link
start-up.
Signed-off-by: Yaniv Gardi
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 59b6544..77a4e38 1
Contains a couple of bug fixes reported by Akinobu Mita, In adition to
"static checker" warnings reported by Dan Carpenter.
Akinobu Mita (1):
scsi: ufs: fix reference counting of W-LUs
Dolev Raviv (4):
scsi: ufs: fix static checker errors in ufshcd_system_suspend
scsi: ufs:
e condition.
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index d3f6ddb..b9da446 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4473,7 +4473,7 @@ out:
if (!IS_ERR_OR_NULL(clki-&g
Hi Dan,
This seem like a false alarm, please let me know if it requires a fix.
Thanks,
Dolev
--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
-Original Messa
HBA is not initialized or is
not powered.
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 497c38a..836ea72 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5087,7 +5087,7 @@ int ufshcd_system_suspend(struct uf
2025:5: sparse: symbol
'ufshcd_change_power_mode' was not declared. Should it be static?
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5c78c3d..497c38a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -214
This patch fixes newly introduced sparse warning, introduced by
"scis: fixing the "type" for well known LUs".
Sparse warning:
>> drivers/scsi/scsi_scan.c:825: warning: format '%16p' expects type
'void *', but argumen
clocks up if
the load is more than upthreshold and scales down if the load is less than
downthreshold.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index f07f901..6e07b2a 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers
s patch adds the scsi device instances for each of all well known LUs
(except "REPORT LUNS" LU).
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dc89c48..692fd7a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++
From: Sahitya Tummala
Add freq-table-hz propery for UFS device to keep track of
frequencies supported by UFS clocks.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd
gulators,
phy) if the UFS device detection fails. This saves power while UFS device
is not embedded into the system.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3f2b30d..af29d4c 100644
--- a/drivers/scsi
llapsed, full UFS reinitialization will be required on resume to
re-establish the link between host and device.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 37d64c1..42c459a 100644
- Adding some of the definitions missing in unipro.h, including power
enumeration.
- Read Modify Write Line helper function
- Indication for the type of suspend
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b
ff-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1679cbfb..60260e8 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4884,13 +4884,19 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum
ufs_pm_op
r this mapping.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 4ca99ed..37d64c1 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -49,9 +49,28 @@
#define UPIU_HEADER_DW
and avoid reading them each link startup
during resume.
Signed-off-by: Raviv Shvili
Signed-off-by: Yaniv Gardi
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index f76a304..4ca99ed 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -115,6
sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 052f940..fe3511e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -177,6 +177,11 @@ static
: Dolev Raviv
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fad039e..052f940 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -179,6 +179,8 @@ static void ufshcd_hba_exit(struct ufs_hba *hba);
static int
From: Subhash Jadavani
Currently reading query descriptor is more tightened to each
descriptor type. This patch generalize the approach and allows
reading any parameter from any query descriptor.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b
.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 65e3117..b0f791a 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b
specifics. The methods can be extended in
future, for example, for power mode transitions.
The operations are vendor/board specific and hence determined with
the help of compatible property in device tree.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi
From: Raviv Shvili
Add the support for voting of the regulator powering the
host controller logic.
Signed-off-by: Raviv Shvili
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings
For some devices VCCQ or VCCQ2 are optional as they can be
generated using internal LDO inside the UFS device.
Add DT bindings for voltage regulators that can be controlled
from host driver.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree
From: Subhash Jadavani
Some devices may respond with wrong type for well-known logical units.
This patch forces well-known type for devices which doesn't report it
correct.
Signed-off-by: Subhash Jadavani
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers
scsi_sysfs_add_sdev()
if it's already visible to rest of the kernel.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 1095d5a..c6c5716 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1
lt of further
development and testing.
Changes from V1:
- 6 new patches apended at the end
- Allow overriding power configuration with controller support and
preferences/capabilities
- Allow overriding power choice with controller capabilities
- Add support for clock gating and clock scaling
Thanks Mita,
You are right these are careless mistakes.
I will fix all of them and upload a new version shortly.
> __ufshcd_send_uic_cmd() is called with host_lock held here, but
> host_lock is acquired again in __ufshcd_send_uic_cmd(). So it causes
> recursive deadlock.
Correct I forgot to comp
From: Subhash Jadavani
Currently reading query descriptor is more tightened to each
descriptor type. This patch generalize the approach and allows
reading any parameter from any query descriptor.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b
For some devices VCCQ or VCCQ2 are optional as they can be
generated using internal LDO inside the UFS device.
Add DT bindings for voltage regulators that can be controlled
from host driver.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree
.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 65e3117..b0f791a 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b
and avoid reading them each link startup
during resume.
Signed-off-by: Raviv Shvili
Signed-off-by: Yaniv Gardi
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index f76a304..4ca99ed 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -115,6
of
scsi_sysfs_add_sdev() to skip the device add if it's already visible to
rest of the kernel.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 3524b68..00890b3 100644
--- a/drivers/scsi/scsi_sysfs.c
specifics. The methods can be extended in
future, for example, for power mode transitions.
The operations are vendor/board specific and hence determined with
the help of compatible property in device tree.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi
t;RPMB" (Replay Protected
Memory Block) LU so user space process can control this LU. User space may
also want to have access to BOOT LU.
This patch adds the scsi device instances for each of all well known LUs
(except "REPORT LUNS" LU).
Signed-off-by: Subhash Jadavani
Signed-off-by:
: Dolev Raviv
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 11c6320..6bc4996 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -179,6 +179,8 @@ static void ufshcd_hba_exit(struct ufs_hba *hba);
static int
From: Subhash Jadavani
Some devices may respond with wrong type for well-known logical units.
This patch forces well-known type for devices which doesn't report it
correct.
Signed-off-by: Subhash Jadavani
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers
sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 6bc4996..ff889723 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -177,6 +177,11 @@ static
- Adding some of the definitions missing in unipro.h, including power
enumeration.
- Read Modify Write Line helper function
- Indication for the type of suspend
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b
clocks up if
the load is more than upthreshold and scales down if the load is less than
downthreshold.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index f07f901..6e07b2a 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers
From: Raviv Shvili
Add the support for voting of the regulator powering the
host controller logic.
Signed-off-by: Raviv Shvili
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings
- Allow overriding power choice with controller capabilities
- Add support for clock gating and clock scaling
- Add capability to control the auto bkops during suspend
- Add misc changes for phy/unipro driver usage
Dolev Raviv (2):
scsi: ufs: refactor configuring power mode
scsi: uf
gulators,
phy) if the UFS device detection fails. This saves power while UFS device
is not embedded into the system.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3f2b30d..af29d4c 100644
--- a/drivers/scsi
llapsed, full UFS reinitialization will be required on resume to
re-establish the link between host and device.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 37d64c1..42c459a 100644
ff-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dcab003..d35719d 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4858,13 +4858,19 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum
ufs_pm_op
From: Sahitya Tummala
Add freq-table-hz propery for UFS device to keep track of
frequencies supported by UFS clocks.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd
>> /**
>> * ufshcd_slave_alloc - handle initial SCSI device configurations
>> * @sdev: pointer to SCSI device
>> @@ -2232,6 +2403,21 @@ static int ufshcd_slave_alloc(struct scsi_device
>> *sdev)
>>
>> ufshcd_set_queue_depth(sdev);
>>
>> +ufshcd_get_lu_power_on_wp_status(hba, sdev);
>
> None of the REPORT LUNS language makes sense as we're not using it.
>
> Can you respon the patch with a better description, and a little comment
> in the code on why you're adding these wluns.
ok.
>
> Also can I assume none of the later patches relies on their existance?
In UFS power manageme
- Adding some of the definitions missing in unipro.h, including power
enumeration.
- Read Modify Write Line helper function
- Indication for the type of suspend
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b
sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e820262..b6043a6 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -177,6 +177,11 @@ static
: Dolev Raviv
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index a621827..e820262 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -179,6 +179,8 @@ static void ufshcd_hba_exit(struct ufs_hba *hba);
static int
ff-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 70c1f5d..15ec238 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4816,13 +4816,19 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum
ufs_pm_op
r this mapping.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 4ca99ed..37d64c1 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -49,9 +49,28 @@
#define UPIU_HEADER_DW
llapsed, full UFS reinitialization will be required on resume to
re-establish the link between host and device.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 37d64c1..42c459a 100644
with SELECT REPORT set to 00h hence
this patch manually add the UFS well known logical units.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dc89c48..1c5422b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scs
clocks up if
the load is more than upthreshold and scales down if the load is less than
downthreshold.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index f07f901..6e07b2a 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers
.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 65e3117..b0f791a 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b
From: Sahitya Tummala
Add freq-table-hz propery for UFS device to keep track of
frequencies supported by UFS clocks.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd
and avoid reading them each link startup
during resume.
Signed-off-by: Raviv Shvili
Signed-off-by: Yaniv Gardi
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index f76a304..4ca99ed 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -115,6
From: Raviv Shvili
Add the support for voting of the regulator powering the
host controller logic.
Signed-off-by: Raviv Shvili
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings
abilities
- Add support for clock gating and clock scaling
- Add capability to control the auto bkops during suspend
- Add misc changes for phy/unipro driver usage
Dolev Raviv (2):
scsi: ufs: refactor configuring power mode
scsi: ufs: definitions for phy interface
Raviv Shvili (1):
scsi: u
et earlier in the function.
- let drivers do paired get/put calls in their probe methods.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 8b4105a..3524b68 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/dr
For some devices VCCQ or VCCQ2 are optional as they can be
generated using internal LDO inside the UFS device.
Add DT bindings for voltage regulators that can be controlled
from host driver.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree
specifics. The methods can be extended in
future, for example, for power mode transitions.
The operations are vendor/board specific and hence determined with
the help of compatible property in device tree.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi
gulators,
phy) if the UFS device detection fails. This saves power while UFS device
is not embedded into the system.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3f2b30d..af29d4c 100644
--- a/drivers/scsi
From: Subhash Jadavani
Currently reading query descriptor is more tightened to each
descriptor type. This patch generalize the approach and allows
reading any parameter from any query descriptor.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b
Hi Kiran,
Thanks for bringing it to my attention. Fortunately I already noticed it
and fixed it. It will be sent soon when all comments on this series are
addressed.
Thanks,
Dolev
> Hi Dolev,
>
> On Wednesday 10 September 2014 05:24 PM, Dolev Raviv wrote:
>> From: Subhash Jadav
> 2014-09-10 20:54 GMT+09:00 Dolev Raviv :
>> +static int ufshcd_config_pwr_mode(struct ufs_hba *hba,
>> + struct ufs_pa_layer_attr *desired_pwr_mode)
>> +{
>> + struct ufs_pa_layer_attr final_params = { 0 };
>> + int ret;
>> +
>
> 2014-09-10 20:54 GMT+09:00 Dolev Raviv :
>> +static inline void ufshcd_enable_irq(struct ufs_hba *hba)
>> +{
>> + if (!hba->is_irq_enabled) {
>> + enable_irq(hba->irq);
>> + hba->is_irq_enabled = true;
>
> 2014-09-10 20:54 GMT+09:00 Dolev Raviv :
>> +static void ufshcd_set_queue_depth(struct scsi_device *sdev)
>> +{
>> + int ret = 0;
>> + u8 lun_qdepth;
>> + struct ufs_hba *hba;
>> +
>> + hba = shost_priv(sdev->host);
>>
sys/kernel/debug/tracing/trace_pipe
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index bfa9a75..c762a6a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -177,6 +177,11 @@ static
r this mapping.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index b0e1f62..bcc3a7f 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -49,9 +49,28 @@
#define UPIU_HEADER_DW
clocks up if
the load is more than upthreshold and scales down if the load is less than
downthreshold.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index f07f901..6e07b2a 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers
ff-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 0bbb933..33984cc 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4719,13 +4719,19 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum
ufs_pm_op
llapsed, full UFS reinitialization will be required on resume to
re-establish the link between host and device.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index bcc3a7f..2a82959 100644
From: Sahitya Tummala
Add freq-table-hz propery for UFS device to keep track of
frequencies supported by UFS clocks.
Signed-off-by: Sahitya Tummala
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd
For some devices VCCQ or VCCQ2 are optional as they can be
generated using internal LDO inside the UFS device.
Add DT bindings for voltage regulators that can be controlled
from host driver.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree
- Adding some of the definitions missing in unipro.h, including power
enumeration.
- Read Modify Write Line helper function
- Indication for the type of suspend
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b
: Dolev Raviv
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 79ef312..bfa9a75 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -178,6 +178,8 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int
tag);
static void
gulators,
phy) if the UFS device detection fails. This saves power while UFS device
is not embedded into the system.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 57a8dbb..1fabff4 100644
--- a/drivers/scsi
From: Subhash Jadavani
Currently reading query descriptor is more tightened to each
descriptor type. This patch generalize the approach and allows
reading any parameter from any query descriptor.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b
.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 65e3117..b0f791a 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b
and avoid reading them each link startup
during resume.
Signed-off-by: Raviv Shvili
Signed-off-by: Yaniv Gardi
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 7ea8e71..b0e1f62 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -115,6
specifics. The methods can be extended in
future, for example, for power mode transitions.
The operations are vendor/board specific and hence determined with
the help of compatible property in device tree.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi
1 then it would report only well
known logical unit and if it's set to 2 then device would report both
standard and well known logical units.
Signed-off-by: Subhash Jadavani
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/scsi_scan.c b/drivers/sc
et earlier in the function.
- let drivers do paired get/put calls in their probe methods.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 8b4105a..3524b68 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/dr
ing suspend
- Add misc changes for phy/unipro driver usage
Dolev Raviv (2):
scsi: ufs: refactor configuring power mode
scsi: ufs: definitions for phy interface
Sahitya Tummala (3):
scsi: ufs: Add support for clock gating
scsi: ufs: Add freq-table-hz property for UFS device
scsi: ufs: Add
Hi all,
Thanks for reviewing the patches, I'm sorry for the late replay. I was
waiting for some comments before I address all at once and re-send the
series.
>> > +/**
>> > + * ufshcd_resume - helper function for resume operations
>> > + * @hba: per adapter instance
>> > + * @pm_op: runtime PM or
Hi all,
Thanks for reviewing the patches, I'm sorry for the late replay. I was
waiting for some comments before I address all at once and re-send the
series.
>>
>> +static int ufshcd_config_vreg_load(struct device *dev, struct ufs_vreg
>> *vreg,
>> + int ua)
>> +{
>>
gulators,
phy) if the UFS device detection fails. This saves power while UFS device
is not embedded into the system.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 57a8dbb..1fabff4 100644
--- a/drivers/scsi
From: Subhash Jadavani
Currently reading query descriptor is more tightened to each
descriptor type. This patch generalize the approach and allows
reading any parameter from any query descriptor.
Signed-off-by: Subhash Jadavani
Signed-off-by: Dolev Raviv
diff --git a/drivers/scsi/ufs/ufs.h b
- Adding some of the definitions missing in unipro.h, including power
enumeration.
- Read Modify Write Line helper function
- Indication for the type of suspend
Signed-off-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
diff --git a/drivers/scsi/ufs/ufshcd.c b
1 - 100 of 212 matches
Mail list logo
