Re: [Open-FCoE] [PATCH] MAINTAINERS: Change FCoE maintainer

2016-06-28 Thread Vasu Dev
t a/MAINTAINERS b/MAINTAINERS > index e1b090f..70af8c0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4661,7 +4661,7 @@ S: Maintained >  F: drivers/staging/fbtft/ >   >  FCOE SUBSYSTEM (libfc, libfcoe, fcoe) > -M: Vasu Dev > +M: Johannes Thumshirn >  L

Re: [PATCHv2] libfc: Update rport reference counting

2016-05-24 Thread Vasu Dev
@@ -1494,6 +1494,7 @@ static void fc_rport_recv_els_req(struct > fc_lport *lport, struct fc_frame *fp) >   break; >   default: >   mutex_unlock(&rdata->rp_mutex); > + kref_put(&rdata->kref, lport->tt.rport_destroy); >  

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache_destroy"

2015-11-19 Thread Vasu Dev
em_cache_destroy(scsi_pkt_cachep); > } > > /** Looks good. Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

2015-10-06 Thread Vasu Dev
continue; > } > > spin_unlock_bh(&p->fcoe_rx_list.lock); Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant_htons to htons

2015-09-01 Thread Vasu Dev
type.type = htons(ETH_P_FCOE); > fcoe->fcoe_packet_type.dev = netdev; > dev_add_pack(&fcoe->fcoe_packet_type); > Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] libfc: correct function name in comment

2015-08-05 Thread Vasu Dev
- Create a new NPIV vport instance > * @vport: fc_vport structure from scsi_transport_fc > * @privsize: driver private data size to allocate along with the Scsi_Host > */ > > struct fc_lport *libfc_vport_create(struct fc_vport *vport, int privsize) > _ Looks good. Ac

Re: [PATCH 0/3] libfc patches for kernel v4.2

2015-06-29 Thread Vasu Dev
On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: > These libfc fixes are for kernel 4.2 and with two patches CCed for stable > kernel also, those two could be picked for current 4.1 cycle now but in case > too late for current 4.1 then anyway should get picked up by 4.1 stable >

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "fc_fcp_ddp_done"

2015-06-25 Thread Vasu Dev
if (fsp) > - fc_fcp_ddp_done(fsp); > + fc_fcp_ddp_done(fsp); > rc = fc_exch_done_locked(ep); > spin_unlock_bh(&ep->ex_lock); > if (!rc) Looks good. Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scs

Re: [Open-FCoE] [PATCH] [trivial] scsi:fcoe: Fix typo "a ethernet" in fcoe_transport.c

2015-06-23 Thread Vasu Dev
uot;); > +MODULE_PARM_DESC(disable, " Disables fcoe on an ethernet interface."); > > /* notification function for packets from net device */ > static struct notifier_block libfcoe_notifier = { I don't this patch applied yet, Looks good. Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH 0/3] libfc patches for kernel v4.2

2015-06-05 Thread Vasu Dev
On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: > These libfc fixes are for kernel 4.2 and with two patches CCed for stable > kernel also, those two could be picked for current 4.1 cycle now but in case > too late for current 4.1 then anyway should get picked up by 4.1 stable >

[PATCH 3/3] libfc: Fix fc_fcp_cleanup_each_cmd()

2015-06-05 Thread Vasu Dev
.org/pipermail/fcoe-devel/2015-May/012471.html ] Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 4cd49d4..5121272 100644 --- a/driv

[PATCH 0/3] libfc patches for kernel v4.2

2015-06-05 Thread Vasu Dev
These libfc fixes are for kernel 4.2 and with two patches CCed for stable kernel also, those two could be picked for current 4.1 cycle now but in case too late for current 4.1 then anyway should get picked up by 4.1 stable kernel later. These patches were posted by Bart Van Assche at open-fcoe.org

[PATCH 2/3] libfc: Fix fc_exch_recv_req() error path

2015-06-05 Thread Vasu Dev
atch fixes the following crash: general protection fault: [#3] PREEMPT SMP RIP: fc_lport_recv_req+0x72/0x280 [libfc] Call Trace: fc_exch_recv+0x642/0xde0 [libfc] fcoe_percpu_receive_thread+0x46a/0x5ed [fcoe] kthread+0x10a/0x120 ret_from_fork+0x42/0x70 Signed-off-by: Bart Van Assche Cc: Va

[PATCH 1/3] libfc: Fix a typo in a source code comment

2015-06-05 Thread Vasu Dev
From: Bart Van Assche Signed-off-by: Bart Van Assche Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c679594..4cd49d4 100644 --- a/drivers/scsi

Re: [PATCH] scsi: match wait_for_completion_timeout return type

2015-03-18 Thread Vasu Dev
-1292,7 +1293,7 @@ static int fc_lun_reset(struct fc_lport *lport, struct > fc_fcp_pkt *fsp, > fsp->wait_for_comp = 0; > spin_unlock_bh(&fsp->scsi_pkt_lock); > > - if (!rc) { > + if (!ticks_left) { > FC_SCSI_DBG(lport, "lun reset

[PATCH] libfc: abort an exchange in case of underrun error

2015-03-17 Thread Vasu Dev
Currently exchange is not aborted in case underrun, so this patch fixes this by issuing exchange abort along FC_DATA_UNDRUN error since such error-ed exchange must be aborted first before same can be re-used. Tested-By: Jack Morgan Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c |4

[PATCH] MAINTAINERS: updated open-fcoe maintainer-ship

2015-02-06 Thread Vasu Dev
Robert Love sent this patch before along his open-fcoe transition announcement in May, 2014. However that was never applied, so sending again. Link to original send: http://marc.info/?l=linux-scsi&m=140131194613697 CC: Robert Love Signed-off-by: Vasu Dev --- MAINTAINERS |2 +- 1

Re: [PATCH] libfs: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-09-25 Thread Vasu Dev
pe], NULL); > + RCU_INIT_POINTER(fc_passive_prov[type], NULL); > else > - rcu_assign_pointer(fc_active_prov[type], NULL); > + RCU_INIT_POINTER(fc_active_prov[type], NULL); > mutex_unlock(&fc_prov_mutex); > synchronize_rcu(); > } Lo

[PATCH] fcoe: extend ethtool to FC port speed mapping

2014-09-25 Thread Vasu Dev
From: Chris Leech add support for 20 Gbit and 40 Gbit links Signed-off-by: Chris Leech Signed-off-by: Vasu Dev --- drivers/scsi/fcoe/fcoe_transport.c | 39 ++-- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fcoe

Re: [PATCH] fcoe: Reduce max_sectors to 1024

2014-07-09 Thread Vasu Dev
On Wed, 2014-07-09 at 08:40 +0200, Hannes Reinecke wrote: > On 07/09/2014 08:18 AM, Christoph Hellwig wrote: > > On Wed, Jul 09, 2014 at 08:16:21AM +0200, Hannes Reinecke wrote: > >> The DDP offload on ixgbe is only capable of handling requests up > >> to 1024 sectors. So we should be exposing this

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 16:54 -0400, Neil Horman wrote: > On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: > > On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: > > > debugfs caught this: > > > WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0(

Re: [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 14:11 -0700, Nicholas A. Bellinger wrote: > , changing this to pr_info_ratelimited and doing the same in > ft_queue_data_in() well. Since doing more places and therefore can be done in separate patch. //Vasu -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 14:02 -0700, Nicholas A. Bellinger wrote: > The break aborts the DataIN send loop and invokes ft_queue_status() > below in an attempt to send TASK_SET_FULL status. > > If the ft_queue_status() -> lport->tt.seq_send() also fails, then > -ENOMEM will be returned to the target a

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

2014-06-09 Thread Vasu Dev
On Fri, 2014-06-06 at 14:09 -0700, Nicholas A. Bellinger wrote: > > So if you don't mind I'll go ahead and queue these up for now in > target-pending/for-next, given they are pretty straight-forward fixes. > > If they end up being problematic, they can be dropped before the v3.16 > PULL request g

Re: [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures

2014-06-06 Thread Vasu Dev
onse. > > It also does the same for a fc_frame_alloc() failures, in order to > signal the initiator that it should try to reduce it's current > queue_depth, to lower the number of outstanding I/Os on the wire. > > Reported-by: Vasu Dev > Cc: Vasu Dev >

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-06 Thread Vasu Dev
gt; Also, add a check to skip sending DataIN if TASK_SET_FULL status > has already been set due to a response lport->tt.seq_send() > failure, that has asked target-core to requeue a response. > > Reported-by: Vasu Dev > Cc: Vasu Dev > Cc: Jun Wu > Signed-off

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

2014-06-06 Thread Vasu Dev
On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi Vasu, > > This series generates SAM_STAT_TASK_SET_FULL status for lport->tt.seq_send() > failures in DataIN + response status codepaths, which is done in order to get > the initiator to reduce it's

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-02 Thread Vasu Dev
[] kthread+0xed/0x100 > [] ? insert_kthread_work+0x80/0x80 > [] ret_from_fork+0x7c/0xb0 > [] ? insert_kthread_work+0x80/0x80 > > Seems to be because the scan_work work_struct might be active when the housing > fc_rport struct gets freed. Ensure that we cancel it prior to freeing the &g

RE: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, January 17, 2014 9:31 AM > To: Miller, Mike (OS Dev) > Cc: Tomas Henzl; Andrew Morton; James E. J. Bottomley; LKML; LKML-scsi; > Stephen M. Cameron > Subject: Re: [PATCH 1/1] scsi: h

RE: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, January 17, 2014 9:14 AM > To: Miller, Mike (OS Dev); Andrew Morton; James E. J. Bottomley > Cc: LKML; LKML-scsi; h...@suse.de; Stephen M. Cameron > Subject: Re: [PATCH 1/1] scsi: hpsa

RE: [PATCH 03/11] hpsa: add 5 second delay after doorbell reset

2013-12-02 Thread Miller, Mike (OS Dev)
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, December 02, 2013 11:23 AM > To: Miller, Mike (OS Dev) > Cc: scame...@beardog.cce.hp.com; Tomas Henzl; > stephenmcame...@gmail.com; linux-scsi@vger.kernel.org;

RE: [PATCH 1/1] remove cpqarray from mainline kernel

2013-10-18 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Friday, October 18, 2013 11:55 AM > To: Miller, Mike (OS Dev); Andrew Morton > Cc: LKML-scsi; LKML > Subject: Re: [PATCH 1/1] remove cpqarray from mainline kernel > > On 10/18/2013 10:22

RE: [PATCH 1/1] remove cpqarray from mainline kernel

2013-10-18 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Thursday, October 17, 2013 5:36 PM > To: Andrew Morton > Cc: Miller, Mike (OS Dev); LKML-scsi; LKML > Subject: Re: [PATCH 1/1] remove cpqarray from mainline kernel > > On Thu, Oct 17 2

RE: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's

2013-09-10 Thread Miller, Mike (OS Dev)
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Tuesday, September 10, 2013 5:02 PM To: Miller, Mike (OS Dev) Cc: Andrew Morton; LKML; LKML-scsi Subject: Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's On Wed, 2013-09-04 at

RE: [PATCH 1/1] cciss: set max scatter gather entries to 32 on P600

2013-08-14 Thread Miller, Mike (OS Dev)
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Wednesday, August 14, 2013 4:27 PM To: Miller, Mike (OS Dev); mi...@thumper.usa.hp.com Cc: Andrew Morton; Jens Axboe; LKML-scsi; LKML; the...@redhat.com; bubr...@redhat.com; scame

Re: [PATCH 1/1] cciss: bug fix to prevent cciss from loading in kdump crash kernel

2013-05-03 Thread Mike Miller (OS Dev)
On Fri, 2013-05-03 at 11:02 -0700, James Bottomley wrote: > On Tue, 2013-04-23 at 12:25 -0500, Mike Miller wrote: > > PATCH 1/1 > > > > By default the cciss driver supports all "older" HP Smart Array controllers > > and hpsa supports all controllers starting with the G6 family. There are > > modul

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-18 Thread Mike Miller (OS Dev)
On Wed, 2013-04-17 at 15:02 -0700, Andrew Morton wrote: > On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > > > Patch 1/1 > > > > If hpsa is selected as the Smart Array driver cciss may try to load in the > > kdump kernel. When this happens kdump fails and a core file cannot be > > create

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-18 Thread Mike Miller (OS Dev)
On Tue, 2013-04-16 at 15:00 -0700, Andrew Morton wrote: > On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > > > Patch 1/1 > > > > If hpsa is selected as the Smart Array driver cciss may try to load in the > > kdump kernel. When this happens kdump fails and a core file cannot be > > create

[PATCH] Fixed build failure when using -j option of make.

2008-02-25 Thread Vasu Dev
This patch removed make dependency on any other .o files which were causing build failure when make -j 10 used. So moved other .o related code under openfc dir as these .o files were used only by openfc module. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/Ma

[PATCH 2/5] Removed outer port use from fcs

2008-02-25 Thread Vasu Dev
will be used for frame alloc and removing inner port later. Also moved outer port event list to fcs_state. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_local_port.h|2 + drivers/scsi/ofc/include/fcs_state.h|4 ++ drivers/scsi/ofc

[PATCH 4/5] Fixed style error reported by checkpatch

2008-02-25 Thread Vasu Dev
Fixed checkpatch ERROR here: do not use assignment in if condition (+ } else if ((fp = fc_frame_alloc(lp->dev, sizeof(*pl))) == NULL) Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libfc/fc_sess.c | 57 +- 1 files changed, 31 i

[PATCH 0/5] Series short description

2008-02-25 Thread Vasu Dev
cdev will simplify openFC implementation which will help in converting OpenFC into generic libfc library as suggested by linux-scsi reviewers. -- Signature : Vasu Dev <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

[PATCH 3/5] Removed outer port use in fc_exch

2008-02-25 Thread Vasu Dev
Used fcdev for frame_alloc instead outer port. The frame_alloc() is modified in next patch with its all other references. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_exch.h |5 +++-- drivers/scsi/ofc/include/fc_frame.h|2 ++ drivers/scsi/ofc

[PATCH 1/5] Removed outer port allocation

2008-02-25 Thread Vasu Dev
Instead used fcs_recv() port ingress function directly. The port egress and frame-alloc functions will be used from fcdev directly. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/openfc/openfc_if.c | 19 +-- 1 files changed, 1 insertions(+), 18 del

[PATCH 5/5] Removed fc_port from fc_frame_alloc()

2008-02-25 Thread Vasu Dev
Instead used fcdev. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_frame.h| 17 + drivers/scsi/ofc/libfc/fc_disc_targ.c |4 ++-- drivers/scsi/ofc/libfc/fc_frame.c |4 ++-- drivers/scsi/ofc/libfc/fc_local_port.c

RE: [PATCH 1/1] resubmit: cciss: procfs updates to display info about many volumes

2008-02-21 Thread Miller, Mike (OS Dev)
Jens wrote: > > On Wed, Feb 20 2008, Mike Miller wrote: > > Patch 1 of 1 > > > > This patch hopefully fixes all the brokeness in my last > submission. It > > compiles cleanly with tape support on or off. I added a couple of > > #ifdef's and removed the broken macro definition. The > #ifdef's made i

RE: [PATCH 1/1] cciss: procfs updates to display info about many volumes

2008-02-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Andrew Morton [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 19, 2008 6:00 AM > To: Jens Axboe > Cc: Miller, Mike (OS Dev); LKML; LKML-scsi > Subject: Re: [PATCH 1/1] cciss: procfs updates to display > info about many volumes >

FW: [Bug 9859] hp smart array E200i kernel panic upon boot

2008-02-14 Thread Miller, Mike (OS Dev)
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > Sent: Thursday, February 14, 2008 8:16 AM > To: Miller, Mike (OS Dev) > Subject: [Bug 9859] hp smart array E200i kernel panic upon boot > > http://bugzilla.kernel.org/show_bug.cgi?id=985

[PATCH] Removed sa_timer functions as part of libsa cleanup

2008-01-23 Thread Vasu Dev
Instead used standard Linux timer functions directly Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/sa_timer.h | 96 --- drivers/scsi/ofc/libfc/fc_disc_targ.c | 20 +++--- drivers/scsi/ofc/libfc/fc_exch.c

[PATCH] Allow FCoE to run on top of VLAN driver even though it has no pause.

2008-01-11 Thread Vasu Dev
If the net_device has no ethtool ops and it is a VLAN, find the underlying physical device using the VLAN driver's macro, and use it's ethtool ops. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/fcoe/fcoe_def.h |1 + drivers/scsi/ofc/fcoe/fcoe_if.c |

RE: [PATCH] cciss: section mismatch

2008-01-11 Thread Miller, Mike (OS Dev)
> --- linux-2.6.24-rc7-git1.orig/drivers/block/cciss.c > +++ linux-2.6.24-rc7-git1/drivers/block/cciss.c > @@ -2927,7 +2927,7 @@ default_int_mode: > return; > } > > -static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev) > +static int __devinit cciss_pci_init(ctlr_info_t *c, struc

RE: Open-FCoE on linux-scsi

2008-01-04 Thread Dev, Vasu
>> >> _If_ there will indeed be dedicated FCoE HBAs in the future, the >> following stack could exist in addition to the one above: >> >> - SCSI core, >> scsi_transport_fc >> - FCoE HBA driver(s) > >Agreed. My FCoE initiator design would be something like: > >scsi-ml >fcoe initiator driver

RE: [PATCH 1/3] cciss: export more attributes to sysfs (repost)

2007-12-27 Thread Miller, Mike (OS Dev)
> > Mike, what's going on? I definitely told you last time I > looked at this patch that it is a bug to call > sysfs_remove_group() under spinlock, because > sysfs_remove_group() takes sleeping locks. Yet here it is again. > > Maybe you lost my email. It is here: > http://lkml.org/lkml/2007/11/2

[PATCH 2/2] Removed unused sa_log functions

2007-12-21 Thread Vasu Dev
Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libsa/Makefile|1 drivers/scsi/ofc/libsa/sa_cons_linux.c | 37 -- drivers/scsi/ofc/libsa/sa_log.c| 117 3 files changed, 0 insertions(+), 155 deletions(-)

[PATCH 0/2] Series short description

2007-12-21 Thread Vasu Dev
The following series implements... Cleaned up FCoE logging by use of simpler logging macro OFC_DBG. -- Signature - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.htm

RE: [PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-12 Thread Miller, Mike (OS Dev)
> > > > Why is this removed? > > Sorry for the less explanation. > > Because it is done in __end_that_request_first() called from > blk_end_request(). > I'll add the explanation to the patch description when I > update the patch. > Thank you. I've Acked the patch. -- mikem - To unsubscribe from t

RE: [PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-12 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Kiyoshi Ueda [mailto:[EMAIL PROTECTED] > Sent: Tuesday, December 11, 2007 4:50 PM > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED];

RE: [PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-12 Thread Miller, Mike (OS Dev)
> > This patch converts cciss to use blk_end_request interfaces. > Related 'uptodate' arguments are converted to 'error'. > > cciss is a little bit different from "normal" drivers. > cciss directly calls bio_endio() and disk_stat_add() when > completing request. But those can be replaced with > __

RE: [PATCH 22/30] blk_end_request: changing cpqarray (take 4)

2007-12-12 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Kiyoshi Ueda [mailto:[EMAIL PROTECTED] > Sent: Tuesday, December 11, 2007 4:50 PM > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED];

Fedora Core 5 Drivers

2007-09-05 Thread Dev
Hi, I am a newbie to Linux. We are installing Fedora Core 5, but unable to view the SCSI hard drives. We are using Dell Power Edge 1850 with on-board SCSI RAID. From my research, it requires the following drivers as the kernel is 2.6.18-1.2257.fc5smp, use the 'megaraid_mbox' and 'megaraid_mm' drive

[PATCH 1/1] cciss: fix error reporting for SG_IO

2007-08-14 Thread Mike Miller (OS Dev)
Patch 1/1 Steve has been trying to send this out but it doesn't seem to be getting anywhere. Please review this patch for accuracy. There's a couple of things not clear to us. Thanks, mikem We found a problem with th

[PATCH 1/1] cciss: add new controller support for P700m

2007-06-19 Thread Mike Miller (OS Dev)
PATCH 1/1 This patch adds support for the Smart Array P700m SAS controller. This new controller will ship Fall 2008. Please consider this for inclusion. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> diff --git a/dr

RE: [PATCH 1/1] cciss: add new controller support for P700m

2007-06-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Jens Axboe [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 19, 2007 1:51 PM > To: Miller, Mike (OS Dev) > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org > Subject: Re: [PATCH 1/1] cciss: add new controller supp

RE: [PATCH] cciss: force ignore of responses to unsent scsi commands after kexec reboot

2007-06-18 Thread Miller, Mike (OS Dev)
Vivek wrote: > > I think this is not the right usage of reset_devices > parameter. This parameter instructs the driver to reset the > device before going ahead with rest of the initialization > before as underlying device might not be in a sane state. > kexec/kdump is one of the usages and t

RE: cciss broken with 2.6.22-rc2

2007-05-29 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Hannes Reinecke [mailto:[EMAIL PROTECTED] > Sent: Tuesday, May 29, 2007 7:01 AM > To: Miller, Mike (OS Dev); SCSI Mailing List > Subject: cciss broken with 2.6.22-rc2 > > Hi Mike, > > with the latest git snapshot th

Re: [PATCH] cciss: Fix pci_driver.shutdown while device is still active

2007-05-17 Thread MIke Miller (OS Dev)
On Mon, 2007-05-14 at 17:53 +, Gerald Britton wrote: > Fix an Oops in the cciss driver caused by system shutdown while a filesystem > on a cciss device is still active. The cciss_remove_one function only > properly removes the device if the device has been cleanly released by its > users, whic

RE: [PATCH] cciss: Fix pci_driver.shutdown while device is still active

2007-05-14 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Gerald Britton [mailto:[EMAIL PROTECTED] > Sent: Monday, May 14, 2007 12:53 PM > To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > Miller, Mike (OS Dev); ISS StorageDev; > linux-scsi@vger.kernel.org; [EMAIL PROTECTED] > Subjec

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 19, 2007 11:22 AM > To: Miller, Mike (OS Dev) > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org; Cameron

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 19, 2007 10:19 AM > To: Miller, Mike (OS Dev) > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org; Cameron

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Hisashi Hifumi [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 18, 2007 2:03 AM > To: Miller, Mike (OS Dev); [EMAIL PROTECTED] > Subject: [PATCH] cciss: Fix warnings during compilation under > 32bit environment > > >

[PATCH 1/1] cciss: kconfig patch to make cciss dependent on scsi for SG_IO ioctl

2007-04-12 Thread Mike Miller (OS Dev)
PATCH 1/1 This kconfig patch makes cciss dependent on scsi for the new SG_IO ioctl we just added. If cciss is built into the kernel it makes sures that scsi is also statically linked. If scsi is a module then cciss will also be built as a module. Please consider this for inclusion. Signed-off-b

[PATCH 3/3] cciss: set rq->errors more correctly in driver

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 3/3 Set rq->errors more correctly in cciss driver. Previously we had set it synonymously with the meaning of the last parameter of end_that_last_request and complete_buffers (the "uptodate" parameter) and had gotten away with it for all this time because nobody ever looked at rq->errors. S

[PATCH 2/3] cciss: add SG_IO ioctl to cciss

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 2/3 For all of you that think cciss should be a scsi driver here is the patch that you have been waiting for all these years. This patch actually adds the SG_IO ioctl to cciss. The primary purpose is for clustering and high-availibilty. But now anyone can exploit this ioctl in any manner the

[PATCH 1/3] cciss: reformat error handling

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 1/3 This patch reformats some error handling code to reduce line lengths a bit. It accompanies the SG_IO patch which is 2/3 of this set. Please consider this for inclusion. Signed-off-by: Stephen M. Cameron <[EMAIL PROTECTED]> Signed-off-by: Mike Miller <[EMAIL PROTECTED]> --- linux-2.6.

RE: [PATCH] Perverting cciss

2007-04-05 Thread Miller, Mike (OS Dev)
James wrote: > > On Thu, 2007-04-05 at 11:03 +0100, Christoph Hellwig wrote: > > On Thu, Apr 05, 2007 at 11:58:06AM +0200, Hannes Reinecke wrote: > > > Hi All, > > > > > > this patch adds the SG_IO ioctl to the cciss driver. > > > As the driver is capable of sending SCSI CDBs to the controller

[PATCH 1/1] cciss: add init of drv->cylinders back to cciss_geometry_inquiry

2007-04-04 Thread Mike Miller (OS Dev)
PATCH 1/1 This patch adds initialization of drv->cylinders back into the failing case in cciss_geometry_inquiry. I inadvertently removed it in one my 2TB updates. Please consider this for inclusion. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> --

Re: [Patch 2/2] cciss: add struct pci_driver shutdown support (replaces reboot notifier)

2007-03-05 Thread Mike Miller (OS Dev)
On Tue, Feb 27, 2007 at 12:26:34PM -0800, Andrew Morton wrote: > > On Fri, 23 Feb 2007 14:42:39 -0600 "Mike Miller (OS Dev)" <[EMAIL > > PROTECTED]> wrote: > > This patch supercedes yesterdays cciss-shutdown patch. The primary > > difference is >

Re: [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier)

2007-02-23 Thread Mike Miller (OS Dev)
On Fri, Feb 23, 2007 at 01:32:36PM -0800, Greg KH wrote: > On Fri, Feb 23, 2007 at 02:42:39PM -0600, Mike Miller (OS Dev) wrote: > > Patch 2/2 > > > > This patch supercedes yesterdays cciss-shutdown patch. The primary > > difference is > > removing __devexit

[Patch 1/2] cciss: fix for 2TB support (again)

2007-02-23 Thread Mike Miller (OS Dev)
Patch 1/2 This patch changes the constant 0x to 0xULL to prevent sign extension. Previously: This patch changes the way we determine if a logical volume is larger than 2TB. The original test looked for a total_size of 0. Originally we added 1 to the total_size. That would make

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-23 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 04:06:41PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 16:02 -0600, Mike Miller (OS Dev) wrote: > > Will this patch for my patch work for now? > > Yes, I think that should be fine ... it's only a theoretical worry; at > the moment secto

[Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier)

2007-02-23 Thread Mike Miller (OS Dev)
Patch 2/2 This patch supercedes yesterdays cciss-shutdown patch. The primary difference is removing __devexit from cciss_remove_one. Instead of create another function I'd rather use the code that was intended to perform the cleanup and cache flush. I've tested as a loadable module and statically

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:55:01PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote: > > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > > > .remove = __devexit_p(cciss_remove_one), >

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 03:41:24PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 13:24 -0800, Andrew Morton wrote: > > > On Thu, 22 Feb 2007 10:51:23 -0600 "Mike Miller (OS Dev)" <[EMAIL > > > PROTECTED]> wrote: > > > On Wed, Feb 21,

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:45:02PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:38:45PM -0600, Mike Miller (OS Dev) wrote: > > Patch 2/2 > > > > This adds support for struct pci_driver shutdown and negates the previous > > NAK'ed > > reboot_

RE: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Mike Miller (OS Dev) [mailto:[EMAIL PROTECTED] > > Andrew, > Using this test program and changing the type of x to int, > long, long long signed and unsigned the comparison always > worked on x86, x86_64, and ia64. It looks to me l

[Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
Patch 2/2 This adds support for struct pci_driver shutdown and negates the previous NAK'ed reboot_notifier patch. It's much easier, wish I had know about this before. Thanks to Christoph for pointing this out. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> ---

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote: > > > > + if (total_size == 0x) { > > I seem to remember having already questioned this. total_size is sector_t, > which > can be either 32-bit or 64-bit. Are you sure that comparison works as > intended in both cases? >

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote: > On Wed, 21 Feb 2007 15:10:39 -0600 "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> > wrote: > > > Patch 1/2 > > > > This patch changes the way we determine if a logical volume is larger than

[Patch 2/2] cciss: add reboot notifier support to driver

2007-02-21 Thread Mike Miller (OS Dev)
Patch 2/2 This patch adds reboot_notifier support to cciss. Changes in firmware make this patch essential. Without this patch there may be valid data left in the controller's battery backed write cache (BBWC) on shutdown. We found out the hard way that the kernel does not call our cleanup routi

[Patch 1/2] cciss: fix for 2TB support

2007-02-21 Thread Mike Miller (OS Dev)
Patch 1/2 This patch changes the way we determine if a logical volume is larger than 2TB. The original test looked for a total_size of 0. Originally we added 1 to the total_size. That would make our read_capacity return size 0 for >2TB lv's. We assumed that we could not have a lv size of 0 so i

[PATCH 2/2] cciss: fix XFER_READ/XFER_WRITE in do_cciss_request

2006-12-15 Thread Mike Miller (OS Dev)
Patch 2 of 2 This patch fixes a stupid bug. Sometime during the 2tb enhancement I ended up replacing the macros XFER_READ and XFER_WRITE with h->cciss_read and h->cciss_write respectively. It seemed to work somehow at least on x86_64 and ia64. I don't know how. But people started complaining about

[PATCH 1/2] cciss: set default raid level when reading geometry fails

2006-12-15 Thread Mike Miller (OS Dev)
PATCH 1 of 2 This patch sets a default raid level on a volume that either does not support reading the geometry or reports an invalid geometry for whatever reason. We were always setting some values for heads and sectors but never set a raid level. This caused lots of problems on some buggy firmwa

[PATCH 2/2] cciss: remove calls to pci_disable_device

2006-12-12 Thread Mike Miller (OS Dev)
PATCH 2/2 This patch removes calls to pci_disable_device except in fail_all_cmds. The pci_disable_device function does something nasty to Smart Array controllers that pci_enable_device does not undo. So if the driver is unloaded it cannot be reloaded. Also, customers can disable any pci device

[PATCH 1/2] cciss: map out more memory for config table

2006-12-12 Thread Mike Miller (OS Dev)
PATCH 1/2 This patch maps out more memory for our config table. It's required to reach offset 0x214 to disable DMA on the P600. I'm not sure how I lost this hunk. Please consider this for inclusion. Thanks, mikem Signed-off-by: Mike Miller <[EMAIL PROTECTED]> drivers/block/cciss.c |2 +-

Re: [PATCH 9/12] repost: cciss: add busy_configuring flag

2006-12-12 Thread Mike Miller (OS Dev)
On Mon, Nov 06, 2006 at 09:32:00PM +0100, Jens Axboe wrote: > On Mon, Nov 06 2006, Mike Miller (OS Dev) wrote: > > PATCH 9 of 12 > > > > This patch adds a check for busy_configuring to prevent starting a queue > > on a drive that may be in the midst of updating,

RE: can't boot 2.6.13

2005-09-08 Thread Miller, Mike (OS Dev)
Thanks, Eric. Anyone have any ideas why my cciss based system won't boot? mikem > -Original Message- > From: Moore, Eric Dean [mailto:[EMAIL PROTECTED] > Sent: Thursday, September 08, 2005 5:52 PM > To: Miller, Mike (OS Dev); linux-kernel@vger.kernel.org; > linux-

RE: 2.6: how do I this in sysfs?

2005-08-29 Thread Miller, Mike (OS Dev)
> This is after my minimal sas transport class, please also > read the thread about it on linux-scsi > In the referenced code for using sysfs, there only appear to be methods for reading attributes. How about if we want to cause a command to get written out to the hardware? Do we do something

2.6: how do I this in sysfs?

2005-08-25 Thread Miller, Mike (OS Dev)
I've been asked to pass this on for some kind of clarification. We have management apps requiring specific information from the Smart Array controller. We're trying to use sysfs to accomplish the task. An example of what we need to do is below. I'm sure some of you will recognize this as CSMI. The

RE: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Miller, Mike (OS Dev)
> From: Christoph Hellwig [mailto:[EMAIL PROTECTED] > > This looks like a patch for Linux 2.4. Such major changes for the > 2.4 tree don't make sense anymore, especially for > functionality not even in Linux 2.6. > This is for 2.4, I should have specified that in the Subject line. We did this

FW: [patch 1/1] block/cciss: replace schedule_timeout() with msleep()

2005-03-07 Thread Miller, Mike (OS Dev)
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 05, 2005 4:45 PM > To: Miller, Mike (OS Dev) > Cc: ISS StorageDev; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: [patch 1/1] block/cciss: replace schedule_timeou

  1   2   >