Re: [PATCH v3 net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI

2019-06-10 Thread David Miller
From: Varun Prakash Date: Mon, 10 Jun 2019 18:36:34 +0530 > Page pods are used for direct data placement, this patch > enables eDRAM page pods if firmware supports this feature. > > Signed-off-by: Varun Prakash > --- > v3: reordered local variable declarations in reverse christmas tree format

Re: [PATCH] revert async probing of VMBus scsi device

2019-06-05 Thread David Miller
From: Christoph Hellwig Date: Wed, 5 Jun 2019 12:07:23 -0700 > On Wed, Jun 05, 2019 at 12:06:40PM -0700, Stephen Hemminger wrote: >> > Which is true for every device, and why we use UUIDs or label for >> > mounts that are supposed to be stable. >> >> Not everyone is smart enough to do that. > >

Re: [PATCH v2 net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI

2019-06-04 Thread David Miller
From: Varun Prakash Date: Tue, 4 Jun 2019 15:41:49 +0530 > +static int setup_ppod_edram(struct adapter *adap) > +{ > + int ret; > + unsigned int param, val; Reverse christmas tree please.

Re: [PATCH v2 net-next 00/11] qed*: Improve performance on 100G link for offload protocols

2019-05-26 Thread David Miller
From: Michal Kalderon Date: Sun, 26 May 2019 15:22:19 +0300 > This patch series modifies the current implementation of PF selection. > The refactoring of the llh code enables setting additional filters > (mac / protocol) per PF, and improves performance for offload protocols > (RoCE, iWARP, iSCSI

Re: [PATCH net-next 07/10] qed*: Add iWARP 100g support

2019-05-01 Thread David Miller
From: Michal Kalderon Date: Wed, 1 May 2019 12:57:19 +0300 > diff --git a/drivers/infiniband/hw/qedr/main.c > b/drivers/infiniband/hw/qedr/main.c > index d93c8a893a89..8bc6775abb79 100644 > --- a/drivers/infiniband/hw/qedr/main.c > +++ b/drivers/infiniband/hw/qedr/main.c > @@ -52,6 +52,10 @@ MOD

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jarkko Sakkinen Date: Fri, 30 Nov 2018 13:44:05 -0800 > On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote: >> No because use of what some people consider to be bad language isn't >> necessarily abusive, offensive or degrading. Our most heavily censored >> medium is TV and "fu

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jarkko Sakkinen Date: Fri, 30 Nov 2018 13:42:33 -0800 > Can you tell how the CoC should be interpreted then? Regardless of what I think, as others have showen the CoC explicitly does not apply to existing code.

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Abuse Date: Fri, 30 Nov 2018 20:39:01 + > I assume I will now be barred. Perhaps, but not because you said fuck. It would be because you're intentionally creating a disturbance on the list and making it more difficult for developers to get their work done and intentionally creating a

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jens Axboe Date: Fri, 30 Nov 2018 13:12:26 -0700 > On 11/30/18 12:56 PM, Davidlohr Bueso wrote: >> On Fri, 30 Nov 2018, Kees Cook wrote: >> >>> On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen >>> wrote: In order to comply with the CoC, replace with a hug. >> >> I hope thi

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Davidlohr Bueso Date: Fri, 30 Nov 2018 11:56:52 -0800 > I hope this is some kind of joke. Whether or not it is a joke, it is censorship. And because of that I have no intention to apply any patches like this to any code I am in charge of.

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 21 Nov 2018 13:40:24 +0530 > From: Santosh Rastapur > > If the fw supports returning VIN/VIVLD in FW_VI_CMD save it > in port_info structure else retrieve these from viid and save > them in port_info structure. Do the same for smt_idx from > FW_VI_MAC_CMD > > Si

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-22 Thread David Miller
From: Jason Gunthorpe Date: Wed, 21 Nov 2018 19:46:24 -0700 > On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote: >> From: Santosh Rastapur >> >> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it >> in port_info structure else retrieve these from viid and save >> them in p

Re: [PATCH v1 RESEND] mpt3sas: Swap I/O memory read value back to cpu endianness

2018-08-03 Thread David Miller
From: Sreekanth Reddy Date: Fri, 3 Aug 2018 16:04:15 +0530 > On Fri, Aug 3, 2018 at 3:07 PM, Andy Shevchenko > wrote: >> On Thu, 2018-08-02 at 16:16 -0400, Martin K. Petersen wrote: >>> Andy, >>> >>> Please review the changes Sreekanth made to address your feedback. >> >> From my point of view t

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

2018-07-09 Thread David Miller
From: Sreekanth Reddy Date: Mon, 9 Jul 2018 17:12:51 +0530 > This is a shared structure between the host drivers and HBA device. > HBA Firmware sends the information though this structures which are > defined in the MPI headers. Now we can't change the order of these u8 > objects. > > typedef st

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

2018-07-04 Thread David Miller
From: Sreekanth Reddy Date: Wed, 4 Jul 2018 16:54:05 +0530 > > Also I tried replacing readl() API with readw()API (as HBA FW will > send 16 bit data at a time) as shown below and still I see same issue, > > MPI2DefaultReply_t *default_reply = (MPI2DefaultReply_t *)reply; > u16 r

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

2018-07-03 Thread David Miller
From: Sreekanth Reddy Date: Tue, 3 Jul 2018 17:48:49 +0530 > Any suggestion/update over my previous mail. I am using 4.13 kernel. I think the issue is that if you are reading a 32-bit word and then interpreting it as a struct full of individual bytes, you have to order the bytes in the structure

Re: [PATCH] mpt3sas: Fix for regression caused due to cf6bf9710c patch

2018-06-29 Thread David Miller
From: Andy Shevchenko Date: Fri, 29 Jun 2018 18:42:30 +0300 > On Fri, Jun 29, 2018 at 5:58 PM, Chaitra P B > wrote: >> "scsi: mpt3sas: Bug fix for big endian systems" >> >> Above patch with commit id "cf6bf9710cabba1fe94a4349f4eb8db623c77ebc" was >> posted to fix sparse warnings. While posting

Re: mpt3sas regression...

2018-06-27 Thread David Miller
From: Chaitra Basappa Date: Wed, 27 Jun 2018 19:58:34 +0530 > Please let us know what is the issue faced and if its recreating then > share the driver logs with logging_level=0x3f8. The driver cannot even probe successfully to start scanning for disks because some busy bit never clears. I thi

mpt3sas regression...

2018-06-23 Thread David Miller
Commit: commit cf6bf9710cabba1fe94a4349f4eb8db623c77ebc Author: Chaitra P B Date: Tue Apr 24 05:28:30 2018 -0400 scsi: mpt3sas: Bug fix for big endian systems. actually breaks big-endian. This driver has been working perfectly fine for more a d

Re: [PATCH net-next 1/2] cxgb4: change the port capability bits definition

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:02:58 +0530 > MDI Port Capabilities bit definitions were inconsistent with > regard to the MDI enum values. 2 bits used to define MDI in > the port capabilities are not really separable, it's a 2-bit > field with 4 different values. Change the port ca

Re: [PATCH net-next 2/2] cxgb4: do L1 config when module is inserted

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:03:33 +0530 > trigger an L1 configure operation when a transceiver module > is inserted in order to cause current "sticky" options like > Requested Forward Error Correction to be reapplied. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Gou

Vmbus series...

2018-03-29 Thread David Miller
Please feel free put it in via the scsi tree: Acked-by: David S. Miller

Re: [PATCH v2 net-next] qed*: Utilize FW 8.33.11.0

2018-03-29 Thread David Miller
From: Michal Kalderon Date: Wed, 28 Mar 2018 11:42:16 +0300 > This FW contains several fixes and features > > RDMA Features > - SRQ support > - XRC support > - Memory window support > - RDMA low latency queue support > - RDMA bonding support > > RDMA bug fixes > - RDMA remote invalidate during

Re: [PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

2018-01-02 Thread David Miller
From: Tomer Tayar Date: Wed, 27 Dec 2017 19:30:04 +0200 > This series advances all qed* drivers to use firmware 8.33.1.0 which brings > new capabilities and initial support of new HW. The changes are mostly in > qed, and include changes in the FW interface files, as well as updating the > FW init

Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread David Miller
This says "0/3" and then a 4 patch series shows up...

Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

2017-12-20 Thread David Miller
From: Jakub Kicinski Date: Tue, 19 Dec 2017 15:46:51 -0800 > On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote: >> Sorry for the very long patch. >> The firmware changes are spread all over w/o a good modularity. > > Rings false. Significant portion of this patch is just whitespace > and c

Re: [PATCH v16 2/4] net: e100: Replace PCI pool old API

2017-12-18 Thread David Miller
From: Romain Perier Date: Fri, 15 Dec 2017 20:31:21 +0100 > From: Romain Perier > > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin > Acked-by: Jef

Re: [PATCH v16 3/4] hinic: Replace PCI pool old API

2017-12-18 Thread David Miller
From: Romain Perier Date: Fri, 15 Dec 2017 20:31:22 +0100 > From: Romain Perier > > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier Acked-by: David S. Miller

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:27:04 -0700 > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ > $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) > > Sig

Re: [PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:58 -0700 > This refactors the only users of init_timer_pinned() to use > the new timer_setup() and from_timer(). Drops the definition of > init_timer_pinned(). > > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: net...@vger.kernel.org > Signed-off-by:

Re: [PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:59 -0700 > This refactors the only users of init_timer_deferrable() to use > the new timer_setup() and from_timer(). Removes definition of > init_timer_deferrable(). > > Cc: Benjamin Herrenschmidt > Cc: Michael Ellerman > Cc: Sebastian Reichel > Cc

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread David Miller
From: Allen Pais Date: Wed, 13 Sep 2017 13:02:15 +0530 > Signed-off-by: Allen Pais This is quite pointless as the caller doesn't do anything with the value, it just tests whether a negative value is returned or not.

Re: [PATCH 08/22] isdn: divert: fix sprintf buffer overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:00 +0200 > One string we pass into the cs->info buffer might be too long, > as pointed out by gcc: > > drivers/isdn/divert/isdn_divert.c: In function 'll_callback': > drivers/isdn/divert/isdn_divert.c:488:22: error: '%d' directive writing > betwe

Re: [PATCH 09/22] net: niu: fix format string overflow warning:

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:01 +0200 > We get a warning for the port_name string that might be longer than > six characters if we had more than 10 ports: > > drivers/net/ethernet/sun/niu.c: In function 'niu_put_parent': > drivers/net/ethernet/sun/niu.c:9563:21: error: '%d' d

Re: [PATCH 10/22] bnx2x: fix format overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:02 +0200 > gcc notices that large queue numbers would overflow the queue name > string: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function > 'bnx2x_get_strings': > drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: err

Re: [PATCH 11/22] net: thunder_bgx: avoid format string overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:03 +0200 > gcc warns that the temporary buffer might be too small here: > > drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' > directive writing b

Re: [PATCH 13/22] liquidio: fix possible eeprom format string overflow

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:05 +0200 > gcc reports that the temporary buffer for computing the > string length may be too small here: > > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function > 'lio_get_eeprom_len': > /drivers/net/ethernet/cavium/liquidio/lio_etht

Re: [PATCH 12/22] vmxnet3: avoid format strint overflow warning

2017-07-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Jul 2017 14:07:04 +0200 > gcc-7 notices that "-event-%d" could be more than 11 characters long > if we had larger 'vector' numbers: > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev': > drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sp

Re: [PATCH net-next] cxgb4: Fix tids count for ipv6 offload connection

2017-06-07 Thread David Miller
From: Ganesh Goudar Date: Wed, 7 Jun 2017 15:04:51 +0530 > the adapter consumes two tids for every ipv6 offload > connection be it active or passive, calculate tid usage > count accordingly. > > Also change the signatures of relevant functions to get > the address family. > > Signed-off-by: Ri

Re: [PATCH net-next 0/4] qed: Enhance storage APIs

2017-06-02 Thread David Miller
From: Yuval Mintz Date: Fri, 2 Jun 2017 08:58:29 +0300 > This series is intended to add additional information and features > to the API between qed and its storage protocol drivers [qedi, qedf]. > > Patch #2 adds some information stored on device such as wwpn & wwnn > to allow qedf utilize it;

Re: [PATCH v9 06/15] mlx5: Replace PCI pool old API

2017-05-23 Thread David Miller
From: Romain Perier Date: Tue, 23 May 2017 10:53:36 +0200 > Hello, > > > Le 23/05/2017 à 09:27, Leon Romanovsky a écrit : >> On Mon, May 22, 2017 at 06:48:58PM +0200, Romain Perier wrote: >>> The PCI pool API is deprecated. This commit replaces the PCI pool old >>> API by the appropriate functi

Re: [PATCH v2 net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: Yuval Mintz Date: Thu, 18 May 2017 19:41:04 +0300 > This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > firmware. The changes are mostly contained in qed with minor changes > to qedi due to some HSI changes. > > Content-wise, the firmware contains fixes to various issue

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: David Miller Date: Thu, 18 May 2017 10:34:28 -0400 (EDT) > From: Yuval Mintz > Date: Wed, 17 May 2017 22:38:40 +0300 > >> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 >> firmware. The changes are mostly contained in qed with minor changes &

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: Yuval Mintz Date: Wed, 17 May 2017 22:38:40 +0300 > This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > firmware. The changes are mostly contained in qed with minor changes > to qedi due to some HSI changes. > > Content-wise, the firmware contains fixes to various issue

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

2017-04-26 Thread David Miller
From: Christoph Hellwig Date: Wed, 26 Apr 2017 09:34:22 +0200 > The caller only looks at the scsi_request result field anyway. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

2017-04-26 Thread David Miller
From: Christoph Hellwig Date: Wed, 26 Apr 2017 09:34:21 +0200 > ide_pm_execute_rq exectures a PM request synchronously, and in the failure > case where it calls __blk_end_request_all it never checks the error field > passed to the end_io callback, so don't bother setting it. > > Signed-off-by: C

Re: [PATCH] qedf: fix wrong le16 conversion

2017-03-23 Thread David Miller
From: "Martin K. Petersen" Date: Thu, 23 Mar 2017 10:19:03 -0400 > Arnd Bergmann writes: > >> gcc points out that we are converting a 16-bit integer into a 32-bit >> little-endian type and assigning that to 16-bit little-endian >> will end up with a zero: >> >> drivers/scsi/qedf/drv_fcoe_fw_fun

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Christoph Hellwig Date: Mon, 13 Mar 2017 16:19:47 -0700 > On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: >> Applied, thanks. > > So everyone who doesn't have the very latests linux-firmware will now > have a non-working card after upgrading the kernel

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Yuval Mintz Date: Sat, 11 Mar 2017 18:39:18 +0200 > This patch advances the qed* drivers into using the newer firmware - > This solves several firmware bugs, mostly related [but not limited to] > various init/deinit issues in various offloaded protocols. > > It also introduces a major 4-Ca

Re: [PATCH V5 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-02-19 Thread David Miller
Applied to net-next, thanks.

Re: [PATCH V4 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-02-14 Thread David Miller
From: "Dupuis, Chad" Date: Mon, 13 Feb 2017 11:17:00 -0800 > @@ -255,6 +259,10 @@ struct qed_hw_info { > u32 part_num[4]; > > unsigned char hw_mac_addr[ETH_ALEN]; > + u64 node_wwn; > + u64

Re: [PATCH] cdrom: Make device operations read-only

2017-02-13 Thread David Miller
From: Kees Cook Date: Mon, 13 Feb 2017 16:25:26 -0800 > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c > index 9cbd217bc0c9..ab9232e1e16f 100644 > --- a/drivers/ide/ide-cd.c > +++ b/drivers/ide/ide-cd.c > @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf) >

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-10 Thread David Miller
From: Kalle Valo Date: Thu, 09 Feb 2017 16:10:06 +0200 > Florian Fainelli writes: > If not, for something like this it's a must: drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’ module_param(disable_ap_sme, bool, 0444);

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Feb 2017 15:02:53 -0800 > I'm hoping this doesn't conflict with what's already in net-next... > > David, this should probably go via your tree considering the diffstat. I think you need one more respin. Are you doing an allmodconfig build? If not, for somet

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-06 Thread David Miller
From: Parav Pandit Date: Sat, 4 Feb 2017 11:00:49 -0600 > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens Applied.

Re: [PATCH 09/10] ide: don't abuse cmd_type

2017-01-31 Thread David Miller
From: Christoph Hellwig Date: Tue, 31 Jan 2017 16:57:30 +0100 > Currently the legacy ide driver defines several request types of it's own, > which is in the way of removing that field entirely. > > Instead add a type field to struct ide_request and use that to distinguish > the different types o

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread David Miller
From: Chad Dupuis Date: Mon, 16 Jan 2017 16:47:52 -0500 > I forgot to add netdev-next to the subject line. Is a repost needed > here? Not this time, no. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-01 Thread David Miller
From: Bart Van Assche Date: Sun, 1 Jan 2017 14:22:11 + > My recommendation is to revert commit 18f6084a989b ("scsi: mpt3sas: Fix > secure erase premature termination"). Since the mpt3sas driver uses the > single-queue approach and since the SCSI core unlocks the block layer > request queue lo

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2016-12-29 Thread David Miller
From: Jason Baron Date: Wed, 28 Dec 2016 23:30:24 -0500 > On ata passthru commands scsih_qcmd() ends up spinning in > scsi_wait_for_queuecommand() indefinitely. scsih_qcmd() is called from > __blk_run_queue_uncond() which first increments request_fn_active to a > non-zero value. Thus, scsi_wait_f

Bootup regression from srp_transport queuecommand() change...

2016-12-28 Thread David Miller
Commit 669f044170d8933c3d66d231b69ea97cb8447338 ("scsi: srp_transport: Move queuecommand() wait code to SCSI core") causes my sparc64 T4-2 machine to stop booting properly. It gets past mounting root but then the disk seems to wedge and scsi command resets don't seem to improve the situation. Th

Re: [PATCH v3 0/3] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-12-02 Thread David Miller
From: "Rangankar, Manish" Date: Fri, 2 Dec 2016 07:00:39 + > Please consider applying the qed patches 1 & 2 to net-next. Ok, done. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH v2] qlogicpti: Fix compiler warnings

2016-11-28 Thread David Miller
From: Tushar Dave Date: Wed, 23 Nov 2016 18:28:04 -0800 > qlogicpti uses '__u32' for dma handle while invoking kernel DMA APIs, > instead of using dma_addr_t. This hasn't caused any 'incompatible > pointer type' warning on SPARC because until now dma_addr_t is of > type u32. However, recent chang

Re: [PATCH] qlogicpti: Fix compiler warnings

2016-11-23 Thread David Miller
From: tndave Date: Wed, 23 Nov 2016 17:08:23 -0800 > As per my understanding, I think, all DMA map/unmap go through > ATU (iommu) in sun4v sparc. To guarantee that driver doesn't get DMA > address beyond its addressable range , driver must set dma mask before > requesting any DMA mapping! > > I

Re: [PATCH] qlogicpti: Fix compiler warnings

2016-11-23 Thread David Miller
From: James Bottomley Date: Wed, 23 Nov 2016 14:57:39 -0800 > What's the guarantee, since the device descriptors only cope with 32 > bits of physical address, that this driver never gets any dma address > beyond its addressable range? Is it that the sbus can never be > attached to this ATU type

Re: [PATCH net-next] cxgb4: Allocate Tx queues dynamically

2016-11-18 Thread David Miller
From: Atul Gupta Date: Fri, 18 Nov 2016 16:37:40 +0530 > From: Hariprasad Shenai > > Allocate resources dynamically for Upper layer driver's (ULD) like > cxgbit, iw_cxgb4, cxgb4i and chcr. The resources allocated include Tx > queues which are allocated when ULD register with cxgb4 driver and fr

Re: [PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-18 Thread David Miller
From: Hariprasad Shenai Date: Sat, 17 Sep 2016 08:12:39 +0530 > Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like > cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with > cxgb4 driver and free them while unregistering. All the queues and the > interrupts

Re: [net-next v3 0/6] common library for Chelsio drivers.

2016-07-25 Thread David Miller
From: Varun Prakash Date: Thu, 21 Jul 2016 22:57:13 +0530 > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this code > was u

Re: [net-next v2 0/6] common library for Chelsio drivers

2016-07-20 Thread David Miller
From: "Nicholas A. Bellinger" Date: Wed, 20 Jul 2016 14:13:55 -0700 > DaveM, if you'd prefer to pick it up, I'm happy to drop it. There were review comments and changes requested. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.

Re: [net-next v2 1/6] libcxgb: add library module for Chelsio drivers

2016-07-19 Thread David Miller
From: Varun Prakash Date: Sat, 16 Jul 2016 22:49:15 +0530 > } > + > +static int __init libcxgb_init(void) > +{ > + return 0; > +} > + > +static void __exit libcxgb_exit(void) > +{ > +} > + > +module_init(libcxgb_init); > +module_exit(libcxgb_exit); If these functions don't have to do anythi

Re: [net-next 0/6] common library for Chelsio drivers

2016-07-11 Thread David Miller
From: Varun Prakash Date: Fri, 8 Jul 2016 23:03:53 +0530 > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this code > was used

Re: [PATCH] cxgbi: fix uninitialized flowi6

2016-04-25 Thread David Miller
From: Jiri Benc Date: Fri, 22 Apr 2016 13:09:13 +0200 > ip6_route_output looks into different fields in the passed flowi6 structure, > yet cxgbi passes garbage in nearly all those fields. Zero the structure out > first. > > Fixes: fc8d0590d9142 ("libcxgbi: Add ipv6 api to driver") > Signed-off-b

Re: [PATCH net] bnx2x: Prevent false warning for lack of FC NPIV

2016-03-18 Thread David Miller
From: Yuval Mintz Date: Tue, 15 Mar 2016 19:52:04 +0200 > Not all adapters have FC-NPIV configured. If bnx2fc is used with such an > adapter, driver would read irrelevant data from the the nvram and log > "FC-NPIV table with bad length..." In system logs. > > Simply accept that reading '0' as th

Re: [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition

2016-03-04 Thread David Miller
From: Nicolas Dichtel Date: Fri, 4 Mar 2016 11:52:15 +0100 > The inital goal was to consolidate ethtool.h uapi header. But I took the > opportunity to remove all duplicate definitions of DIV_ROUND_UP. > > v3: add patch #2 and #3 > > v2: split the patch > define DIV_ROUND_UP in uapi Series

Re: [PATCH net-next] cxgb4i: Increased the value of MAX_IMM_TX_PKT_LEN from 128 to 256 bytes

2015-10-14 Thread David Miller
From: Karen Xie Date: Tue, 13 Oct 2015 17:13:59 -0700 > This helps improving the latency of small packets. > > Signed-off-by: Rakesh Ranjan > Signed-off-by: Karen Xie Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-06-01 Thread David Miller
icitly included > and that tends to hide places where vmalloc() et al are added to files > but the include of vmalloc.h is forgotten. > ... > Suggested-by: David Miller > Signed-off-by: Stephen Rothwell With the follow-on allnoconfig fixes: Acked-by: David S. Miller Than

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread David Miller
From: Eric Dumazet Date: Tue, 26 May 2015 21:43:44 -0700 > From: Eric Dumazet > > vmalloc.h used to be included from include/net/inet_hashtables.h > but it is no longer the case. > > Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()") > Reported-by: kbuild test robot > Signed-of

Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

2015-04-13 Thread David Miller
From: Varun Prakash Date: Mon, 13 Apr 2015 19:34:25 +0530 > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > index 6c8a62e..f78d632 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > +++ b/drivers/net/ethernet/chelsi

Re: [PATCH net-next 0/3] cxgb4: add FCoE DDP and RSS

2015-03-31 Thread David Miller
From: David Miller Date: Tue, 31 Mar 2015 12:04:13 -0400 (EDT) > From: Varun Prakash > Date: Fri, 27 Mar 2015 20:29:36 +0530 > >> This patch series enables RSS for FCoE frames and adds >> DDP support for FCoE target. > > Series applied, thanks Varun. I have to rev

Re: [PATCH net-next 0/3] cxgb4: add FCoE DDP and RSS

2015-03-31 Thread David Miller
From: Varun Prakash Date: Fri, 27 Mar 2015 20:29:36 +0530 > This patch series enables RSS for FCoE frames and adds > DDP support for FCoE target. Series applied, thanks Varun. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kern

Re: [PATCH 0/3] FCoE support in cxgb4 driver

2015-03-24 Thread David Miller
From: Varun Prakash Date: Tue, 24 Mar 2015 19:14:44 +0530 > This patch series enables FCoE support in cxgb4 driver, it enables > FCOE_CRC and FCOE_MTU net device features. > > This series is created against net-next tree. Series applied, thank you. -- To unsubscribe from this list: send the lin

Re: [PATCH] csiostor:Use firmware version from cxgb4/t4fw_version.h

2015-02-04 Thread David Miller
From: Praveen Madhavan Date: Tue, 3 Feb 2015 17:18:26 +0530 > This patch is to use firmware version macros from t4fw_version.h > and also enables 40g T5 adapter. > > Signed-off-by: Praveen Madhavan Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body o

Re: [PATCH] csiostor:T5 Firmware fix and cleanup.

2015-01-27 Thread David Miller
From: Praveen Madhavan Date: Tue, 27 Jan 2015 19:46:37 +0530 > This patch fix is to use default firmware configuration files > present in the adapter incase if not available in standard > /lib/firmware/* dir. Additional cleanup is done to reuse flash > related defines from cxgb4 header file. > >

Re: [PATCH v2 0/2] csiostor:Remove T4 FCoE support

2015-01-19 Thread David Miller
From: Praveen Madhavan Date: Fri, 16 Jan 2015 21:30:18 +0530 > We found a subtle issue with FCoE on T4 very late in the game > and decided not to productize FCoE on T4 and therefore there > are no customers that will be impacted by this change. FCoE is > supported on T5 cards. > > Please apply o

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread David Miller
From: Praveen Madhavan Date: Thu, 15 Jan 2015 19:15:50 +0530 > These patches removes FCoE support for chelsio T4 adapter. > Please apply on net-next since depends on previous commits. Why is it being removed? You have to state this in the commit log messages at a minimum. -- To unsubscribe from

Re: [PATCH net-next 0/2] All Chelsio drivers : Cleanup CPL messages macros

2015-01-12 Thread David Miller
From: Anish Bhatt Date: Thu, 8 Jan 2015 21:38:14 -0800 > This patch series cleans up all register defines/MACROS defined in t4_msg.h > and > affected files as part of the continuing cleanup effort > > The patches series is created against 'net-next' tree and includes patches > to the cxgb4,

Re: [PATCH 1/1] csiostor:fix sparse warnings

2015-01-11 Thread David Miller
From: Praveen Madhavan Date: Fri, 9 Jan 2015 21:25:16 +0530 > This patch fixes sparse warning reported by kbuild. > Apply this on net-next since it depends on previous commit. > > drivers/scsi/csiostor/csio_hw.c:259:17: sparse: cast to restricted __le32 > drivers/scsi/csiostor/csio_hw.c:536:31:

Re: [PATCH v3 4/4] scsi: esp_scsi: adjust module reference for scsi host

2015-01-11 Thread David Miller
From: Akinobu Mita Date: Sun, 11 Jan 2015 22:50:06 +0900 > While accessing a scsi device on host adapter supported by sub driver for > the ESP chip (mac_esp, am53c974, sun_esp, jazz_esp, sun3x_esp), the module > reference count is not incremented. Because these drivers allocate scsi > hosts with

Re: [PATCH] csiostor:firmware upgrade fix

2015-01-08 Thread David Miller
From: Praveen Madhavan Date: Wed, 7 Jan 2015 19:16:28 +0530 > This patch fixes removes older means of upgrading Firmware using MAJOR version > and adds newer interface version checking mechanism. > > Please apply this patch on net-next since it depends on previous commits. > > Signed-off-by: P

Re: [PATCH net-next 0/5] RDMA/cxgb4/cxgb4vf/csiostor: Cleanup register defines

2015-01-05 Thread David Miller
From: Hariprasad Shenai Date: Mon, 5 Jan 2015 16:30:42 +0530 > This series continues to cleanup all the macros/register defines related to > SGE, PCIE, MC, MA, TCAM, MAC, etc that are defined in t4_regs.h and the > affected files. > > Will post another 1 or 2 series so that we can cover all the

Re: [PATCH net-next v10 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-12 Thread David Miller
From: Karen Xie Date: Thu, 11 Dec 2014 19:13:26 -0800 > This patch set fixes cxgb4i's tx credit calculation and adds handling of > additional rx message and negative advice types. It also removes the duplicate > code in cxgb4i to set the outgoing queues of a packet. Series applied, thanks. -- T

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Anish Bhatt Date: Thu, 11 Dec 2014 20:24:48 + >> This series does not apply cleanly at all to net-next, it gets many >> rejects. > > Hey Dave, this patchset was mostly bugfixes and hence meant for net where it > applies cleanly. not net-next. We can rebase to net-next and send if you'r

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Karen Xie Date: Thu, 11 Dec 2014 07:25:37 -0800 > This patch set fixes cxgb4i's tx credit calculation and adds handling of > additional rx message and negative advice types. It also removes the duplicate > code in cxgb4i to set the outgoing queues of a packet. This series does not apply c

Re: [PATCH] cxgb4/csiostor: Don't use MASTER_MUST for fw_hello call

2014-12-11 Thread David Miller
From: Hariprasad Shenai Date: Thu, 11 Dec 2014 11:11:43 +0530 > Remove use of calls into t4_fw_hello() with MASTER_MUST, which results in > FW_HELLO_CMD_MASTERFORCE being set. The firmware doesn't support this and of > course any existing PF Drivers will totally go for a toss. > > Signed-off-by:

Re: [PATCH net v8 1/7] cxgb4i: fix tx immediate data credit check

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 13:11:06 -0800 > From: Karen Xie > > Only data skbs need the wr header added while control skbs do not. Make sure > they are treated differently. > > Signed-off-by: Karen Xie Please text format your commit messages to 80 characters or less per line. P

Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 21:02:34 + > Sorry, misread the comment, will resubmit. Thanks. Please do not top-post. Quote the relevant material, then provide your own content after the quoted material, not before. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-10 Thread David Miller
From: James Bottomley Date: Wed, 10 Dec 2014 23:41:29 +0300 > On Wed, 2014-12-10 at 15:31 -0500, David Miller wrote: >> From: Karen Xie >> Date: Wed, 10 Dec 2014 12:24:09 -0800 >> >> > [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware. >&g

Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 20:26:59 + > Thanks, v7 has been submitted to address your comment. Please review. Sorry, you did not actually address his comments. He said to not duplicate your Subject lines in your message bodies, and you did not fix that. -- To unsubscribe from th

Re: [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 12:24:09 -0800 > [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware. Please listen to the feedback you have been given. Again, you should not duplicate the Subject line in your message body, that makes more work for the people integrating

Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync'

2014-11-26 Thread David Miller
From: Christoph Hellwig Date: Wed, 26 Nov 2014 20:13:09 +0100 > On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote: >> wd819x should probably depend on VIRT_TO_BUS? But that means it will not >> work >> on sparc. Is there a way to make it work? I have a sparc machine but haven't >> te

Re: [PATCH net-next] cxgb4/cxgb4vf/csiostor: Add T4/T5 PCI ID Table

2014-11-25 Thread David Miller
From: Hariprasad Shenai Date: Tue, 25 Nov 2014 08:33:58 +0530 > Add a new file t4_pci_id_tbl.h that contains T4/T5 PCI ID Table so that for > all > drivers that uses T4/T5 PCI functions changes can be done in one place. > > checkpatch.pl script reports following error, which if tried to fix end

  1   2   3   >