Re: simplify procfs code for seq_file instances V2

2018-04-30 Thread David Howells
Note that your kernel hits the: inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. swapper/0/0 [HC1[1]:SC0[0]:HE0:SE1] takes: (ptrval) (fs_reclaim){?.+.}, at: fs_reclaim_acquire+0x12/0x35 {HARDIRQ-ON-W} state was registered at: fs_reclaim_acquire

Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

2018-04-30 Thread David Howells
Christoph Hellwig wrote: > + > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > + struct proc_dir_entry *parent, const struct seq_operations *ops, > + void *data) > +{ > ... > +EXPORT_SYMBOL(proc_create_seq_data); Please add documentation com

Re: [PATCH 20/39] afs: simplify procfs code

2018-04-19 Thread David Howells
Christoph Hellwig wrote: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Note that this is likely going to clash with my patch to net-namespace all of the afs proc files

[PATCH 21/24] scsi: Lock down the eata driver

2017-04-05 Thread David Howells
device to access or modify the kernel image. The eata driver takes a single string parameter that contains a slew of settings, including hardware resource configuration. Prohibit use of the parameter if the kernel is locked down. Suggested-by: Alan Cox Signed-off-by: David Howells cc: Dario

[PATCH 27/38] Annotate hardware config module parameters in drivers/scsi/

2017-04-05 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/scsi/. Suggested-by: Alan Cox Signed-off-by: David Howells cc: "Juergen E. Fischer" cc: "James E.J. Bottomley" cc: "

Re: [PATCH 27/39] Annotate hardware config module parameters in drivers/scsi/

2017-04-05 Thread David Howells
Finn Thain wrote: > I can see how base addresses and IO ports are relevant, but the irq > parameter changes below don't protect the kernel image AFAICT. What's the > rationale for those changes? I think it should be stated here. Easier grepping for one. But I'm also currently preventing the c

[PATCH 27/39] Annotate hardware config module parameters in drivers/scsi/

2016-12-01 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/scsi/. Suggested-by: One Thousand Gnomes Signed-off-by: David Howells cc: "Juergen E. Fischer" cc: "James E.J. Bottomley" cc:

SCSI vs MN10300: Can get_user() be given an array?

2013-06-28 Thread David Howells
The MN10300 arch is throwing up an error in the SCSI driver and I'm not sure whether it needs fixing in the arch - in get_user() - or in the SCSI code. The problem is this line in sg_scsi_ioctl(): if (get_user(opcode, sic->data)) sic points to the following struct: typedef stru

[PATCH 14/28] proc: Supply an accessor for getting the data from a PDE's parent [RFC]

2013-04-16 Thread David Howells
this has no release function). Signed-off-by: David Howells cc: Jerry Chuang cc: Mauro Carvalho Chehab cc: Maxim Mikityanskiy cc: YAMANE Toshiaki cc: linux-wirel...@vger.kernel.org cc: linux-scsi@vger.kernel.org cc: de...@driverdev.osuosl.org --- drivers/scsi/megaraid.c|2

[PATCH 10/28] proc: Add proc_mkdir_data() [RFC]

2013-04-16 Thread David Howells
Add proc_mkdir_data() to allow procfs directories to be created that are annotated at the time of creation with private data rather than doing this post-creation. This means no access is then required to the proc_dir_entry struct to set this. Signed-off-by: David Howells cc: Neela Syam Kolli

[PATCH 18/26] megaraid: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Neela Syam Kolli cc: James E.J. Bottomley cc: linux-scsi@vger.kernel.org --- drivers/scsi/megaraid.c |

UAPI: What remains to be pulled: SCSI and FCoE

2012-12-20 Thread David Howells
Disintegration 2012-12-19 -------- David Howells (1): UAPI: (Scripted) Disintegrate include/scsi include/scsi/Kbuild | 3 --- include/uapi/scsi/Kbuild | 3 +++ include/{ => uapi}/scsi/scsi_bsg_fc.h

[PATCH] UAPI: (Scripted) Disintegrate include/rdma

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/rdma/Kbuild |6 -- include/rdma/rdma_netlink.h | 36

[PATCH] UAPI: (Scripted) Disintegrate include/scsi/fc

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/scsi/fc/Kbuild|4 include/uapi/scsi/fc/Kbuild |4 include/uapi/scsi/fc/fc_els.h |0 include

[PATCH] UAPI: (Scripted) Disintegrate include/scsi

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/scsi/Kbuild |3 --- include/uapi/scsi/Kbuild|3 +++ include/uapi/scsi/scsi_bsg_fc.h

UAPI disintegration for SCSI, FCoE and RDMA

2012-11-16 Thread David Howells
Hi James, Robert, David, I have patches still outstanding for the UAPI header disintegration of linux/scsi/, linux/scsi/fs/ and linux/rdma. I have updated them from the original pull requests and they can be found at tags: disintegrate-scsi-20121116 disintegrate-fc-20121116

[PATCH/GIT PULL] UAPI: (Scripted) Disintegrate include/scsi/fc

2012-10-09 Thread David Howells
for the strictly kernel internal stuff. This patch can be pulled from: git://git.infradead.org/users/dhowells/linux-headers.git tags/disintegrate-fc-20121009 Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E

[PATCH/GIT PULL] UAPI: (Scripted) Disintegrate include/scsi

2012-10-09 Thread David Howells
for the strictly kernel internal stuff. This patch can be pulled from: git://git.infradead.org/users/dhowells/linux-headers.git tags/disintegrate-scsi-20121009 Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E

Re: CONFIG_BLK_DEV_BSG=n

2007-09-17 Thread David Howells
ings that we've tried to make sure specifically aren't declared. David --- [PATCH] VFS: Make BSG declarations dependent on CONFIG_BLOCK From: David Howells <[EMAIL PROTECTED]> Make BSG function declarations dependent on CONFIG_BLOCK as they are not compilable if the block layer i

Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-24 Thread David Howells
Fine by me. Acked-By: David Howells <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread David Howells
The FRV bits look okay. I can't test them until I get back from Australia in Feb. David - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html