RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-09-09 Thread David Carroll
> > > > > > > "Don" == Don Brace writes: > > > > Don, > > > > Don> Depends on smartpqi driver adoption > > > > -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC > > Series 9 */ > > > > How are people that load aacraid in their initrd going to boot after > > this? > > >

RE: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-07 Thread David Carroll
> > We get 1 warning when building kernel with W=1: > drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for > 'aac_src_select_comm' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared and > don't need > a declaration, but can be made

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

2016-08-25 Thread David Carroll
> > > > Hi Markus, > > > > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look > pretty. > > Do you eventually prefer that this source code adjustment should be combined > with the update suggestion "[2/7] aacraid: One function call less in > aac_send_raw_srb() after error d

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

2016-08-22 Thread David Carroll
> From: Markus Elfring > Date: Sat, 20 Aug 2016 20:05:24 +0200 > > Reuse existing functionality from memdup_user() instead of keeping duplicate > source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aacraid/commctrl.

RE: aacraid / Adaptec 3805 - AAC: Host adapter dead -1

2016-08-08 Thread David Carroll
> On Mon, Aug 01, 2016 at 11:42:24AM +0200, Piotr Szymaniak wrote: > > Hi, > > (Sorry, for almost-topposting. Leaving below for reference.) > > As a followup to this thread - looking for answers here and there I've added > intel_iommu=igfx_off (found at some thread with some other hardware > ment

RE: [PATCH] aacraid: prevent out-of-bounds access due to changing fip header sizes

2016-08-05 Thread David Carroll
[snip] > > > goto cleanup; > > > } > > > > > > + if (size != le16_to_cpu(kfib->header.Size) > > > + + sizeof(struct aac_fibhdr)) { > > > + retval = -EINVAL; > > > + goto cleanup; > > > + } > > > + > > > if

RE: [PATCH] aacraid: prevent out-of-bounds access due to changing fip header sizes

2016-08-04 Thread David Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Johannes Thumshirn > Sent: Thursday, August 04, 2016 2:36 AM > To: Martin K . Petersen; James Bottomley > Cc: Linux SCSI Mailinglist; Pengfei Wang; Johannes Thumshirn; > s

RE: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-07-07 Thread David Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Pengfei Wang > Sent: Thursday, July 07, 2016 7:00 AM > To: linux-scsi@vger.kernel.org > Subject: Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > Hi, >

[no subject]

2013-06-28 Thread David Carroll
auth 45008867 subscribe linux-scsi \ david.carr...@pmcs.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html