Re: [PATCH 00/20] drop useless LIST_HEAD

2018-12-28 Thread Darrick J. Wong
On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote: > On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote: > > there was discussion about this just some days ago. CC 4-5 lists is > > more than enough > > > > I don't know who you were discussing this with... > > You should CC t

Re: [LSF/MM TOPIC] Patch Submission process and Handling Internal Conflict

2018-01-24 Thread Darrick J. Wong
On Wed, Jan 24, 2018 at 01:36:00PM -0800, James Bottomley wrote: > On Wed, 2018-01-24 at 11:20 -0800, Mike Kravetz wrote: > > On 01/24/2018 11:05 AM, James Bottomley wrote: > > > > > > I've got two community style topics, which should probably be > > > discussed > > > in the plenary > > > > > > 1

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Darrick J. Wong
struct xfs_buf *bp) > - { > +{ > struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(&mp->m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) >

Re: [PATCH 0/3] Improve block device testing coverage

2017-03-31 Thread Darrick J. Wong
On Fri, Mar 31, 2017 at 03:11:28PM +, Bart Van Assche wrote: > On Fri, 2017-03-31 at 13:02 +0300, Dmitry Monakhov wrote: > > Another good example may be a bug with dirty page cache after blkdiscard > > https://lkml.org/lkml/2017/3/22/789 . This simple bug result in crappy > > fsimage if mkfs r

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-26 Thread Darrick J. Wong
On Wed, May 18, 2016 at 11:39:30PM +0100, Sitsofe Wheeler wrote: > Hi, > > With Ubuntu's 4.4.0-22-generic kernel and a Fedora 23 > 4.6.0-1.vanilla.knurd.1.fc23.x86_64 kernel I've found that the > BLKZEROOUT syscall can malfunction and not zero data. > > When BLKZEROOUT is issued to an MD device a

Re: [Lsf] LSF/MM Schedule and improving discard support

2016-04-13 Thread Darrick J. Wong
On Wed, Apr 13, 2016 at 09:51:04AM -0700, James Bottomley wrote: > On Wed, 2016-04-13 at 09:29 -0700, Bart Van Assche wrote: > > On 04/13/2016 09:21 AM, Martin K. Petersen wrote: > > > From a filesystem/ioctl perspective, BLKDISCARD is a hint. We > > > should not be > > > rounding off or aligning a

Please submit specific discussion proposals for the File & Storage miniconf at LPC2015

2015-06-04 Thread Darrick J. Wong
Hi folks, Well, we made it! As of yesterday, the File & Storage systems microconf has been approved for Plumbers! If you're interested in attending, I highly recommend that you register[0] immediately, as the earlybird deadline is tomorrow, June 5th. We have a solid list of discussion ideas on

Re: [dm-devel] Proposal for annotating _unstable_ pages

2015-05-22 Thread Darrick J. Wong
On Thu, May 21, 2015 at 09:21:12PM +0200, Jan Kara wrote: > On Thu 21-05-15 11:09:55, Kent Overstreet wrote: > > On Thu, May 21, 2015 at 06:54:53PM +0200, Jan Kara wrote: > > > On Wed 20-05-15 18:04:40, Kent Overstreet wrote: > > > > > Yeah. I never figured out a sane way to migrate pages and keep

LPC2015: File and Storage Systems uconf

2015-04-03 Thread Darrick J. Wong
Hi everyone, Linux Plumbers is coming up in just four months! I would like for there to be a file & storage miniconf at this year's LPC, so I've started assembling a plan for what we might discuss. As a starting point, I've filled the planning page with the topics that didn't achieve any sort of

[PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-01-21 Thread Darrick J. Wong
avoid returning stale cache contents at a later time. Depends on "block: Add discard flag to blkdev_issue_zeroout() function". Signed-off-by: Darrick J. Wong --- block/ioctl.c | 45 ++--- include/uapi/linux/fs.h |7 +++ 2 fi

[PATCH] uas: disable UAS on Apricorn SATA dongles

2014-12-11 Thread Darrick J. Wong
The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in response to SCSI commands when running in UAS mode. Therefore, disable UAS mode on this dongle. Signed-off-by: Darrick J. Wong --- drivers/usb/storage/unusual_uas.h | 10 ++ 1 file changed, 10 insertion

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-11 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 05:41:54PM -0800, Darrick J. Wong wrote: > On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: > > > On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: >

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote: > On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: > > > On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: > On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 09-12-14 20:31, Darrick J. Wong wro

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: > On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: > > Hi, > > > > On 09-12-14 20:31, Darrick J. Wong wrote: > > >Hi, > > > > > >I have an Apricorn USB 3 disk dongle thi

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: > Hi, > > On 09-12-14 20:31, Darrick J. Wong wrote: > >Hi, > > > >I have an Apricorn USB 3 disk dongle thing that claims to support UAS. > >However, the kernel crashes when I plug it in[1]. > &g

UAS crash with Apricorn USB3 SATA bridge

2014-12-09 Thread Darrick J. Wong
Hi, I have an Apricorn USB 3 disk dongle thing that claims to support UAS. However, the kernel crashes when I plug it in[1]. I'm not sure what this is caused by, but I also have an ASMedia 2105 SATA bridge that works with UAS just fine. Not sure if the Apricorn thing is simply broken, or if this

[PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2014-11-17 Thread Darrick J. Wong
avoid returning stale cache contents at a later time. This patch depends on mkp's earlier patch "block: Introduce blkdev_issue_zeroout_discard() function". Signed-off-by: Darrick J. Wong --- block/ioctl.c | 45 ++--- include/ua

Re: [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function

2014-11-17 Thread Darrick J. Wong
On Fri, Nov 14, 2014 at 03:22:05PM -0500, Martin K. Petersen wrote: > > "Martin" == Martin K Petersen writes: > > Martin> What would you prefer as the default for the ext4 use case? To > Martin> allocate or to discard? > > I didn't get a preference for whether sb_issue_zeroout() should disca

Re: [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function

2014-11-10 Thread Darrick J. Wong
On Fri, Nov 07, 2014 at 12:08:14AM -0500, Martin K. Petersen wrote: > blkdev_issue_discard() will zero a given block range on disk. This is > done by way of either WRITE SAME or regular WRITE. I.e. the blocks on > disk will be written and thus provisioned. > > There are use cases where the desired

Re: [PATCH 2/6] io: define an interface for IO extensions

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 03:53:33PM -0700, Zach Brown wrote: > > > I'd just remove this generic teardown callback path entirely. If > > > there's PI state hanging off the iocb tear it down during iocb teardown. > > > > Hmm, I thought aio_complete /was/ iocb teardown time. > > Well, usually :). I

Re: [PATCH 3/6] aio/dio: enable PI passthrough

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 03:33:11PM -0700, Zach Brown wrote: > > One thing I'm not sure about: What's the largest IO (in terms of # of > > blocks, > > not # of struct iovecs) that I can throw at the kernel? > > Yeah, dunno. I'd guess big :). I'd hope that the PI code already has a > way to clamp

Re: [PATCH 2/6] io: define an interface for IO extensions

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 12:49:47PM -0700, Zach Brown wrote: > > @@ -916,6 +921,17 @@ void aio_complete(struct kiocb *iocb, long res, long > > res2) > > struct io_event *ev_page, *event; > > unsigned long flags; > > unsigned tail, pos; > > + int ret; > > + > > + ret = io_teardown_

Re: [PATCH 2/6] io: define an interface for IO extensions

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 03:22:20PM -0400, Jeff Moyer wrote: > "Darrick J. Wong" writes: > > > Define a generic interface to allow userspace to attach metadata to an > > IO operation. This interface will be used initially to implement > > protection information

Re: [PATCH 3/6] aio/dio: enable PI passthrough

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 01:01:33PM -0700, Zach Brown wrote: > > +static int setup_pi_ext(struct kiocb *req, int is_write) > > +{ > > + struct file *file = req->ki_filp; > > + struct io_extension *ext = &req->ki_ioext->ke_kern; > > + void *p; > > + unsigned long start, end; > > + int retva

Re: [PATCH 1/6] fs/bio-integrity: remove duplicate code

2014-04-02 Thread Darrick J. Wong
On Wed, Apr 02, 2014 at 12:17:58PM -0700, Zach Brown wrote: > > +static int bio_integrity_generate_verify(struct bio *bio, int operate) > > { > > > + if (operate) > > + sector = bio->bi_iter.bi_sector; > > + else > > + sector = bio->bi_integrity->bip_iter.bi_sector; > > >

[PATCH 6/6] blk-integrity: refactor various routines

2014-03-24 Thread Darrick J. Wong
Refactor blk-integrity.c to avoid duplicating similar functions, and remove all users of pi_buf, since it's really only there to handle the (common) case where the kernel auto-generates all the PI data. Signed-off-by: Darrick J. Wong --- fs/bio-integrity.c |

[PATCH 5/6] PI IO extension: advertise possible userspace flags

2014-03-24 Thread Darrick J. Wong
Expose possible userland flags to the new PI IO extension so that userspace can discover what flags exist. Signed-off-by: Darrick J. Wong --- Documentation/ABI/testing/sysfs-block | 14 ++ Documentation/block/data-integrity.txt | 22 + block/blk-integrity.c

[PATCH 1/6] fs/bio-integrity: remove duplicate code

2014-03-24 Thread Darrick J. Wong
Frøm: Gu Zheng Most code of function bio_integrity_verify and bio_integrity_generate is the same, so introduce a help function bio_integrity_generate_verify() to remove the duplicate code. Signed-off-by: Gu Zheng --- fs/bio-integrity.c | 83 +++

[PATCH 3/6] aio/dio: enable PI passthrough

2014-03-24 Thread Darrick J. Wong
Provide an IO extension handler that attaches PI data from the io extension structure to a kiocb, then teach directio how to attach the pages representing the PI buffer directly to a bio. Signed-off-by: Darrick J. Wong --- Documentation/block/data-integrity.txt | 11 fs/aio.c

[PATCH 4/6] PI IO extension: allow user to ask kernel to fill in parts of the protection info

2014-03-24 Thread Darrick J. Wong
nt to provide. This is intended, for example, to satisfy programs that really only care to provide an app tag. Signed-off-by: Darrick J. Wong --- Documentation/block/data-integrity.txt | 11 block/blk-integrity.c |1 drivers/scsi/sd_dif.c |

[PATCH 2/6] io: define an interface for IO extensions

2014-03-24 Thread Darrick J. Wong
the non-AIO calls to use this mechanism. Signed-off-by: Darrick J. Wong --- fs/aio.c | 180 +- include/linux/aio.h |7 ++ include/uapi/linux/aio_abi.h | 15 +++- 3 files changed, 197 insertions(+), 5 deletions(-) diff

[RFC PATCH DONOTMERGE v2 0/6] userspace PI passthrough via AIO/DIO

2014-03-24 Thread Darrick J. Wong
This RFC provides a rough implementation of a mechanism to allow userspace to attach protection information (e.g. T10 DIF) data to a disk write and to receive the information alongside a disk read. There's a new "IO extension" interface wherein we define a structure (per zab's comments on the v2 se

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-23 Thread Darrick J. Wong
On Sun, Mar 23, 2014 at 03:02:44PM +0100, Jan Kara wrote: > On Sat 22-03-14 02:43:20, Darrick J. Wong wrote: > > On Fri, Mar 21, 2014 at 07:32:16PM -0700, Darrick J. Wong wrote: > > > On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote: > > > > I'll admi

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-22 Thread Darrick J. Wong
On Fri, Mar 21, 2014 at 07:32:16PM -0700, Darrick J. Wong wrote: > On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote: > > On Fri, Mar 21, 2014 at 03:54:37PM -0700, Darrick J. Wong wrote: > > > On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote: > > &

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-21 Thread Darrick J. Wong
On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote: > On Fri, Mar 21, 2014 at 03:54:37PM -0700, Darrick J. Wong wrote: > > On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote: > > > > > I'm inclined to agree with Zach on this item. Ultimately,

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-21 Thread Darrick J. Wong
On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote: > Hi folks, > > On Fri, Mar 21, 2014 at 11:23:32AM -0700, Zach Brown wrote: > > On Thu, Mar 20, 2014 at 09:30:41PM -0700, Darrick J. Wong wrote: > > > This RFC provides a rough implementation of a mechanism

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-21 Thread Darrick J. Wong
On Fri, Mar 21, 2014 at 11:23:32AM -0700, Zach Brown wrote: > On Thu, Mar 20, 2014 at 09:30:41PM -0700, Darrick J. Wong wrote: > > This RFC provides a rough implementation of a mechanism to allow > > userspace to attach protection information (e.g. T10 DIF) data to a > > disk

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-21 Thread Darrick J. Wong
On Fri, Mar 21, 2014 at 10:57:31AM -0400, Jeff Moyer wrote: > "Darrick J. Wong" writes: > > > This RFC provides a rough implementation of a mechanism to allow > > userspace to attach protection information (e.g. T10 DIF) data to a > > disk write and to receiv

[PATCH 3/5] aio/dio: allow user to ask kernel to fill in parts of the protection info

2014-03-20 Thread Darrick J. Wong
nt to provide. This is intended, for example, to satisfy programs that really only care to provide an app tag. Signed-off-by: Darrick J. Wong --- Documentation/block/data-integrity.txt | 11 block/blk-integrity.c |1 drivers/scsi/sd_dif.c |

[PATCH 4/5] aio/dio: advertise possible userspace flags

2014-03-20 Thread Darrick J. Wong
Expose possible userland flags to the new AIO/DIO PI interface so that userspace can discover what flags exist. Signed-off-by: Darrick J. Wong --- Documentation/ABI/testing/sysfs-block | 14 ++ Documentation/block/data-integrity.txt | 26 + block/blk

[PATCH 5/5] blk-integrity: refactor various routines

2014-03-20 Thread Darrick J. Wong
Refactor blk-integrity.c to avoid duplicating similar functions, and remove all users of pi_buf, since it's really only there to handle the (common) case where the kernel auto-generates all the PI data. Signed-off-by: Darrick J. Wong --- fs/bio-integrity.c |

[PATCH 1/5] fs/bio-integrity: remove duplicate code

2014-03-20 Thread Darrick J. Wong
Frøm: Gu Zheng Most code of function bio_integrity_verify and bio_integrity_generate is the same, so introduce a help function bio_integrity_generate_verify() to remove the duplicate code. Signed-off-by: Gu Zheng --- fs/bio-integrity.c | 83 +++

[PATCH 2/5] aio/dio: enable DIX passthrough

2014-03-20 Thread Darrick J. Wong
Provide a set of new AIO commands (IOCB_CMD_P{READ,WRITE}VM) that utilize the last iovec of the iovec array to convey protection information to and from userspace. Signed-off-by: Darrick J. Wong --- Documentation/block/data-integrity.txt | 11 ++ fs/aio.c | 22

[RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-20 Thread Darrick J. Wong
This RFC provides a rough implementation of a mechanism to allow userspace to attach protection information (e.g. T10 DIF) data to a disk write and to receive the information alongside a disk read. The interface is an extension to the AIO interface: two new commands (IOCB_CMD_P{READ,WRITE}VM) are

Re: status of block-integrity

2014-01-06 Thread Darrick J. Wong
On Fri, Jan 03, 2014 at 03:03:42PM -0500, Martin K. Petersen wrote: > > "Hannes" == Hannes Reinecke writes: > > Hannes> Personally, I doubt it's a good idea to kill it off, but a > Hannes> proper (userland) API for it has been a long time missing. > > Before we throw the baby out with the ba

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Darrick J. Wong
On Thu, Feb 07, 2013 at 02:09:17PM -0500, Martin K. Petersen wrote: > >>>>> "Darrick" == Darrick J Wong writes: > > Darrick> and more recently I've theorized that we could add a magic > Darrick> fcntl/ioctl to make the kernel recognize, say, the f

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Darrick J. Wong
On Thu, Feb 07, 2013 at 01:40:14AM -0800, Joel Becker wrote: > On Wed, Feb 06, 2013 at 03:34:49PM -0500, Chuck Lever wrote: > > > > On Feb 6, 2013, at 3:24 PM, "Darrick J. Wong" > > wrote: > > > > > On Wed, Feb 06, 2013 at 01:51:22PM -0600,

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-06 Thread Darrick J. Wong
On Wed, Feb 06, 2013 at 01:51:22PM -0600, Ben Myers wrote: > Hi, > > I'm interested in discussing how to pass protection information to and from > userspace. Maybe Martin could be enlisted for the discussion. > > I read that some work has already been done in this area but have not been > able

[PATCH] sd: Don't incorrectly "promote" DIF type0 into DIF type1 disks.

2012-11-27 Thread Darrick J. Wong
he rest of the DIF setup. Right now, the SCSI layer "promotes" a DIF type 0 disk into a DIF type 1 disk, which seems incorrect. Signed-off-by: Darrick J. Wong --- drivers/scsi/sd_dif.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-10 Thread Darrick J. Wong
On Mon, Jul 09, 2012 at 06:24:15PM -0400, Robert Trace wrote: > On 07/09/2012 04:45 PM, Darrick J. Wong wrote: > > > > I suspect that /sys/devices//manage_start_stop > > = 0 > > for the SATA devices hanging off the SAS controller. > > Yep, looks like you're

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-09 Thread Darrick J. Wong
On Mon, Jul 09, 2012 at 03:37:09PM -0400, Robert Trace wrote: > > I did some further research regarding my problem. > > It appears to me the fault does not lie with the mpt2sas driver (not > > that I can definitely exclude it), but with the md implementation. > > I'm actually discovering some of t

[PATCH 2/2] aic94xx: Use sas_request_addr() to provide SAS WWN if the adapter lacks one

2008-02-19 Thread Darrick J. Wong
If the aic94xx chip doesn't have a SAS address in the chip's flash memory, make libsas get one for us. Resend of 8 Oct 2007 patch, now based off 2.6.25-rc2 + scsi_misc. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx.h | 16 -

[PATCH 1/2] libsas: Provide a transport-level facility to request SAS addrs

2008-02-19 Thread Darrick J. Wong
Provide a facility to use the request_firmware() interface to get a SAS address from userspace. This can be used by SAS LLDDs that cannot obtain the address from the host adapter. Resend of 8 Oct. 2007 patch, now based off 2.6.25-rc2 + scsi_misc. Signed-off-by: Darrick J. Wong <[EMAIL PROTEC

[PATCH] aic94xx: Don't free ABORT_TASK SCBs that are timed out (Was: Re: aic94xx: failing on high load)

2008-02-19 Thread Darrick J. Wong
to fix this ... or at least > mitigate the problems it causes. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_tmf.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_tmf.c b/drivers/scsi

Re: [patch 03/13] mptbase: reset ioc initiator during PCI resume

2008-02-07 Thread Darrick J. Wong
On Thu, Feb 07, 2008 at 06:41:25PM -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 23:53 -0800, [EMAIL PROTECTED] wrote: > > From: "Darrick J. Wong" <[EMAIL PROTECTED]> > > > > It appears that the LSI SAS 1064E chip needs to be reset after a >

Re: aic94xx: failing on high load (another data point)

2008-01-30 Thread Darrick J. Wong
On Wed, Jan 30, 2008 at 06:59:34PM +0800, Keith Hopkins wrote: > > V28. My controller functions well with a single drive (low-medium load). > Unfortunately, all attempts to get the mirrors in sync fail and usually hang > the whole box. Adaptec posted a V30 sequencer on their website; does tha

Re: aic94xx: failing on high load

2008-01-14 Thread Darrick J. Wong
On Mon, Jan 14, 2008 at 03:49:16PM +0100, Jan Sembera wrote: > Hi, > > we have array of 16 SAS disks connected to Adaptec controllers > ... > this elsewhere and I was recommended to send it to linux-scsi. Hmm... I think Peter Bogdanovic was hitting this error recently (cc'd). There are a lo

Re: [PATCH] libsas: fix sense_buffer overrun

2008-01-14 Thread Darrick J. Wong
Looks sane to me; Acked-by: Darrick J. Wong <[EMAIL PROTECTED]> --D On Sun, Jan 13, 2008 at 02:20:18AM +0900, FUJITA Tomonori wrote: > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> > --- > drivers/scsi/libsas/sas_scsi_host.c |2 +- > 1 files changed, 1

Re: [PATCH] libsas: don't use made up error codes

2007-12-31 Thread Darrick J. Wong
> codes. > > The problem error code in question is ETASK. I've replaced this by > ECOMM (communications error on send) a network error code that seems to > most closely relay what ETASK meant. Yay, cleanups :) Acked-by: Darrick J. Wong <[EMAIL PROTECTED]> - To uns

Re: [PATCH] drivers/scsi/: Spelling fixes

2007-12-17 Thread Darrick J. Wong
On Mon, Dec 17, 2007 at 11:40:14AM -0800, Joe Perches wrote: > drivers/scsi/scsi_transport_sas.c |2 +- SAS bits are Acked-by: Darrick J. Wong <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EM

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Darrick J. Wong
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote: > As an aside, issues like this really really imply a need to move libsas > away from the old libata EH stuff (like brking did with ipr, in patches). Hm... does the new libata EH handle the case of "device was unplugged, don't bother t

[PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Darrick J. Wong
unplugged without warning. Change libsas to reject commands to domain devices that have already gone away. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_ata.c |4 drivers/scsi/libsas/sas_expander.c |3 +++ drivers/scsi/libsas/sas_po

Re: aic94xx or libsas crash on X7DB3 supermicro with enclosure and sata drives

2007-12-03 Thread Darrick J. Wong
On Mon, Dec 03, 2007 at 02:43:09PM -0500, Jeff Garzik wrote: > But what do you mean by "device removal code can get hung up"? That sounds > like a bug we should fix. At the moment, libsas' sas_rphy_remove function doesn't distinguish between removing a device before or after the disk has been d

Re: aic94xx or libsas crash on X7DB3 supermicro with enclosure and sata drives

2007-12-03 Thread Darrick J. Wong
On Mon, Dec 03, 2007 at 05:09:54PM +0100, Krzysztof B??aszkowski wrote: > > I noticed also another failure when i removed a drive. The event was not > notified by anything (ie the block device and corresponding sg were > registered) so i run dd on this truly "virtual" drive. > > dd reached D st

Re: aic94xx or libsas crash on X7DB3 supermicro with enclosure and sata drives

2007-11-30 Thread Darrick J. Wong
On Fri, Nov 30, 2007 at 10:22:07AM +0100, Krzysztof B??aszkowski wrote: > Hello all, > > I noticed this according to syslog. furthermore if aic94xx is connected to > single sata drive only then there is no crash but device is not recognized > too. (mysterious: "ERROR: Unidentified device type 5"

[PATCH 2/2] libsas: Use new ATA configuration mechanism

2007-11-12 Thread Darrick J. Wong
Update sas_ata to use the new ata_sas_rphy mechanisms as provided by Brian King, and simplify ATA device discovery... WARNING WARNING WARNING! This patch is experimental, use at your own risk. Comments-requested-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas

[PATCH 1/2] libsas: Convert ATA bridge to use new EH

2007-11-12 Thread Darrick J. Wong
. jgarzik: If an ATA command was in-progress at the time of a port freeze, can complete after thawing? (Does that even make sense?) Comments-requested-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_ata.c | 86 ++--- 1 files chang

[PATCH 2/2] libsas: Fix various sparse complaints

2007-11-05 Thread Darrick J. Wong
Annotate sas_queuecommand with locking details, and clean up a few more sparse warnings about static/non-static declarations. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_scsi_host.c |6 +- include/scsi/libsas.h |4 +--- 2

[PATCH 1/2] libsas: Convert sas_proto users to sas_protocol

2007-11-05 Thread Darrick J. Wong
sparse complains about the mixing of enums in libsas. Since the underlying numeric values of both enums are the same, combine them to get rid of the warning. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_dev.c |6 +++--- drivers/scsi/a

Re: [2.6 patch] scsi/aic94xx/: cleanups

2007-11-05 Thread Darrick J. Wong
On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote: > This patch contains the following cleanups: > - static functions in .c files shouldn't be marked inline > - make needlessly global code static > - #if 0 unused code asd_unpause_lseq can be removed; the other if 0'd functions are debug

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-09 Thread Darrick J. Wong
On Tue, Oct 09, 2007 at 09:41:47AM -0700, Andrew Vasquez wrote: > On Tue, 09 Oct 2007, James Smart wrote: > > > Why do you prefer request_firmware() vs something over sysfs ? > > > > Does environments like the kdump kernel also have access to data needed > > by request_firmware() ? Assuming t

[PATCH 2/2] aic94xx: Use sas_request_addr() to provide SAS addr if the adapter lacks one

2007-10-08 Thread Darrick J. Wong
If the aic94xx chip doesn't have a SAS address in the chip's flash memory, make libsas get one for us. Also clean out some old code that had been used to do this in the past. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94

[PATCH 1/2] libsas: Provide a transport-level facility to request SAS addrs

2007-10-08 Thread Darrick J. Wong
Use the request_firmware() interface to get a SAS address from userspace. This way, there's no debate as to who or how an address gets generated; it's up to the administrator to provide one if the driver can't find one on its own. Signed-off-by: Darrick J. Wong <[EMAIL PROTECT

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Darrick J. Wong
On Mon, Oct 08, 2007 at 03:48:32PM -0700, Andrew Vasquez wrote: > So how about factoring that out to a transport-level interface. How > about something along the lines of the following patch, whereby the > software driver upon detecting no valid WWPN, makes an upcall to each > interface's 'reques

[PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Darrick J. Wong
ard doesn't have one. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx.h |1 - drivers/scsi/aic94xx/aic94xx_hwi.c | 40 +-- drivers/scsi/aic94xx/aic94xx_init.c |2 -- 3 files changed, 29 insertions(+), 14 del

Re: [patch 16/17] mptbase: reset ioc initiator during PCI resume

2007-10-02 Thread Darrick J. Wong
On Tue, Oct 02, 2007 at 04:51:48PM -0600, Moore, Eric wrote: > I replied to this thread a couple times last week, and no response from > Darrick. I doubt this is required becase the MESSAGE_UNIT_RESET is > issued from inside mpt_do_ioc_recovery. I need some logs with debug > enabled. Darrick

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-30 Thread Darrick J. Wong
On Sat, Sep 29, 2007 at 02:25:33AM -0400, Jeff Garzik wrote: > Muli Ben-Yehuda wrote: >> On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote: >>> On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: >>>> Unless I'm missing something, the S

Re: [PATCH] aic94xx: fix SMP request DMA direction

2007-09-28 Thread Darrick J. Wong
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote: > > Unless I'm missing something, the SMP request goes /to/ the PCI device :) > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> ACK; builds ok and SMP commands seem to work ok (not that they didn't before). --Darrick > --- > driver

Re: [PATCH] mptbase: Reset ioc initiator during PCI resume

2007-09-24 Thread Darrick J. Wong
On Thu, Sep 20, 2007 at 07:06:35PM -0600, Moore, Eric wrote: > Darrick - MESSAGE_UNIT_RESET is already issued from inside > mpt_do_ioc_recovery(), so you don't need to send this in advance of > that.YOu will find that occuring from the function MakeIocReady. > Anyways... would it be possible fo

[PATCH] Clean up IOC reset code to obey coding style

2007-09-20 Thread Darrick J. Wong
Randy Dunlap scolded me for introducing poorly styled code. Since it was a copy-and-paste block from mpt_suspend(), fix both. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/message/fusion/mptbase.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff -

[PATCH] mptbase: Reset ioc initiator during PCI resume

2007-09-20 Thread Darrick J. Wong
IOC facts reply, msgLength=0 offsetof=6! So far it seems to fix suspend/resume on all the MPT Fusion cards I have (SAS and U320 SCSI) but since I don't know the internals of that chip I can't say for sure if this is a proper fix. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]&g

[PATCH] libsas: SMP request handler shouldn't crash when rphy is NULL

2007-07-24 Thread Darrick J. Wong
sas_smp_handler crashes when smp utils are used with an aic94xx host because certain devices (the sas_host itself, specifically) lack rphy structures. No rphy means no SMP target support, but we shouldn't crash here. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/

Re: [PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Darrick J. Wong
On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote: > @@ -244,7 +242,7 @@ > if (check_signature(base + > signatures[sig].offset, signatures[sig].string, > strlen(signatures[sig].string))) { > addr = > bases

Re: Patch added to scsi-pending-2.6: [SCSI] libsas: convert to use the data buffer accessors

2007-05-29 Thread Darrick J. Wong
On Sun, May 27, 2007 at 05:37:43PM +, James Bottomley wrote: > [SCSI] libsas: convert to use the data buffer accessors > This patch is pending because it requires ACKs from: > > Darrick J. Wong <[EMAIL PROTECTED]> ACK. --D - To unsubscribe from this list: send the

[PATCH] aic94xx: asd_clear_nexus should fail if the cleared task does not complete

2007-05-16 Thread Darrick J. Wong
freeing active tasks. I _think_ this will fix one of the SCB timeout crash problems (though I've not been able to reproduce it lately...) Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_tmf.c | 14 ++ 1 files changed, 10 insertion

Re: [PATCH] aacraid: superfluous adapter reset for IBM 8 series ServeRAID controllers

2007-05-02 Thread Darrick J. Wong
Darrick J. Wong wrote: > Salyzyn, Mark wrote: >> The kexec patch introduced a superfluous (and otherwise inert) reset of >> some adapters. The register can have a hardware default value that has >> zeros for the undefined interrupts. This patch refines the test of the >>

Re: [PATCH] aacraid: superfluous adapter reset for IBM 8 series ServeRAID controllers

2007-05-01 Thread Darrick J. Wong
on only the interrupts that affect > the driver in order to detect if an incomplete shutdown of the Adapter > had occurred (kdump). Tests out ok on the affected machines, so: Acked-by: Darrick J. Wong <[EMAIL PROTECTED]> --D - To unsubscribe from this list: send the line "unsubscribe

Re: Kernel crash with AIC94xx (one step forward, hope it's lucky)

2007-05-01 Thread Darrick J. Wong
Constantin Teodorescu wrote: > 03:02:15 kernel: [ cut here ] > 03:02:15 kernel: kernel BUG at drivers/scsi/aic94xx/aic94xx_hwi.h:354! On the odd chance you still have this controller (and have the time to test out patches), would you mind applying this patch: http://sweag

Re: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Darrick J. Wong
Salyzyn, Mark wrote: > As an option for a patch (later), what was the actual value of the > Munit.OIMR register (on the x3550 and the x3650 please, just in case)? 0xF. --D - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Darrick J. Wong
Salyzyn, Mark wrote: > In my unit tests of aacraid_kexec_5.patch, restart was not called for > normal operations. If you are just doing a normal boot, what conditions > are causing restart to be called in your case? Is it a warm restart? > Some kind of operation that leaves the Adapter in an initi

[PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-26 Thread Darrick J. Wong
crash at startup. Move the initializers (we need both rx_sync_cmd and enable_int pointers) further up to proceed the restart_adapter call. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/rx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -

Re: Kernel crash with AIC94xx (one step forward, hope it's lucky)

2007-04-26 Thread Darrick J. Wong
Constantin Teodorescu wrote: > So ... should I ask for other controller quotation ? > Could you recommend me a good SAS controller, with 8 internal ports, > supporting Linux , with 99.% reliability ? :-) > > I have the following options : Intel® RAID Controller SRCSAS18E > (Parowan) and LS

Re: aic94xx driver woes

2007-03-31 Thread Darrick J. Wong
Douglas Gilbert wrote: > So that is almost 12 months that I have been reporting > this driver as broken. Is it just me or my hardware? I seem to recall you saying that the LSI Fusion card was plugged into the same expander as the 48300? If so, does unplugging the Fusion card from the expander ma

[PATCH 2/2]: sas_ata: Don't reset the phy in post_internal_command

2007-02-22 Thread Darrick J. Wong
We don't need to reset the SAS phy in sas_ata_post_internal; all that is necessary is to clear out the task from the SAS HA. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_ata.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --gi

[PATCH 1/2] sas_ata: Rename ata_queued_cmd->lldd_task to driver_data

2007-02-22 Thread Darrick J. Wong
Per Tejun's request, rename the lldd_task field and add comments about it. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_ata.c |8 include/linux/libata.h|4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/d

Re: Please help if u can.

2007-02-21 Thread Darrick J. Wong
John Scarpa wrote: > First a very big thanks to all of u! I have been suffering a serious > lack of sleep problem lately.. i should have noticed that by whom has > been submitting the past 500 fixes and updates! > > Quick question, is the driver still consider experimental?? Very much so. The S

Re: Please help if u can.

2007-02-20 Thread Darrick J. Wong
Douglas Gilbert wrote: > It would be reasonable to assume that Luben is the maintainer > of this code although the MAINTAINERS file has no entry > for the aic94xx driver. > > This code was effectively removed from Luben's control > about 18 months ago and has passed through several sets > of hand

Re: BUG in libata from ata_sas_port_alloc

2007-02-15 Thread Darrick J. Wong
James Bottomley wrote: > The problem is that memory obtained by devm_kzalloc() cannot be returned > by kfree() ... they come from different allocation lists. The solution > is probably to have a corresponding ata_probe_ent_free(), I just don't > exactly see how to tell if the object came from the

Re: Any multipath SAS support in Linux?

2007-02-14 Thread Darrick J. Wong
Orion Poplawski wrote: > I'm thinking about trying to setup a two node HA storage cluster > connected to an external SAS box. Is such a thing possible at this time? I've had success with aic94xx + dm_multipath before. There has recently been a bug in the multipath tools wherein it fails to detec

  1   2   >