Re: Patch added to scsi-rc-fixes-2.6: [SCSI] arcmsr: fix message allocation

2008-02-25 Thread Daniel Drake
nickcheng wrote: Hi, I definitely agree it is in atomic context but why is the memory not for DMA? Would you please show me why? It would probably be easier if you could explain where you believe the memory IS used for DMA :) Anyway, looking at ARCMSR_MESSAGE_READ_RQBUFFER current code does

[PATCH] arcmsr: fix message allocation

2008-02-20 Thread Daniel Drake
. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- drivers/scsi/arcmsr/arcmsr_hba.c | 26 +++--- 1 files changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 4f9ff32..f91f79c 100644 --- a/d

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-16 Thread Daniel Drake
Daniel Drake wrote: Here is a patch to address your comments. Joshua, would you mind testing this before I submit it properly? It will apply cleanly to 2.6.24 on top of the previous patch you tested. I have compile-tested it. It would help to include the patch. >F

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-16 Thread Daniel Drake
James Bottomley wrote: On Sat, 2008-02-16 at 11:49 +, Daniel Drake wrote: I assume you're aware that this patch is just a subset of commit 76d78300a6eb8 which you've already pushed up to Linus. Adding Nick Cheng (commit author) to CC so that he can go over the feedback. Wel

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-16 Thread Daniel Drake
I assume you're aware that this patch is just a subset of commit 76d78300a6eb8 which you've already pushed up to Linus. Adding Nick Cheng (commit author) to CC so that he can go over the feedback. James Bottomley wrote: diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-13 Thread Daniel Drake
you report success. Daniel From: Nick Cheng <[EMAIL PROTECTED]> Partial backport of 76d78300 ("arcmsr: updates (1.20.00.15)") by Daniel Drake <[EMAIL PROTECTED]>. Removes pci_alloc_consistent usage, which should not be used when IRQs are disabled for portability reasons. Fi

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread Daniel Drake
James Bottomley wrote: However, I think you're right, the vanilla TUR does eat NOT_READY for removable media, which CDs are. Does this fix it? Works great, thanks! Daniel - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] sr: update to follow tray status correctly

2008-02-06 Thread Daniel Drake
Hi James, James Bottomley wrote: It's been a while with no status on this one, so I corrected the patch based on my original input. The attached is what I think is the best way of doing this (I've replaced the home grown test_unit_ready routine with the SCSI one and updated some of the sense ch

[PATCH] SCSI: Don't be so verbose if no disc is present

2005-09-09 Thread Daniel Drake
repeatedly poll the device for media change. This patch demotes the message to a quieter scsi-logging message only. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- linux/drivers/scsi/scsi_ioctl.c.orig 2005-09-09 23:10:07.0 +0100 +++ linux/drivers/scsi/scsi_ioctl.c 2005-09-09 23

[PATCH] Allow both megaraid drivers to be built

2005-08-29 Thread Daniel Drake
ages printed out via printk. I have left the procfs name as "megaraid" as presumably userspace tools rely on this. Remove hardware ID's from megaraid_legacy which overlap with the newgen megaraid drivers. Allow megaraid_legacy to be built alongside the newgen driver. Signed-off-b

[PATCH] Allow both megaraid drivers to be built

2005-08-29 Thread Daniel Drake
w one alongside it. I know that this solution is not ideal, but as LSIL are being uncooperative, I think this is the best compromise we can do for now. Please apply. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> diff -urNp linux-2.6.12/drivers/scsi-orig/megaraid/Kconfig.megaraid linux-2.6.

scsi/libata bootup sysfs oops with 2.6.12 + 2.6.13-rc3

2005-07-15 Thread Daniel Drake
Hi, After upgrading kernel, Edward (on CC) is having trouble booting up. The kernel hangs after reporting it can't mount root on /dev/sda3, which is supposed to be a partition on a SATA disk, connected to a sata_nv controller. As serial console is not available, we stripped down the kernel in