On 27/08/2019 20:27, Al Viro wrote:
<>
> If you want to express something like "data packet formed; now you can commit
> it and tell me if there'd been any errors", use something explicit. close()
> simply isn't suitable for that. writev() for datagram-like semantics might
> be; fsync() or fdatas
On 26/08/2019 22:32, Al Viro wrote:
<>
> D'oh... OK, that settles it; exclusion with st_write() would've been
> painful, but playing with the next st_write() on the same struct file
> rewinding the damn thing to overwrite what st_flush() had spewed is
> an obvious no-go.
>
So what are the kind o
port it myself, til now you guys
> been doing this for me ;-)"
>
> Now the last time this caused a bit of a stir, but still no actual users,
> not even for SG_IO passthrough commands. So here we go again, this time
> including removing everything in the scsi and block layer s
On 20/12/18 09:26, Christoph Hellwig wrote:
> On Wed, Dec 19, 2018 at 09:01:53PM -0500, Douglas Gilbert wrote:
>>> 1) reduce the size of every kernel with block layer support, and
>>> even more for every kernel with scsi support
>>
>> By proposing the removal of bidi support from the block l
On 19/12/18 16:43, Christoph Hellwig wrote:
> On Mon, Nov 26, 2018 at 07:11:10PM +0200, Boaz Harrosh wrote:
>> On 11/11/18 15:32, Christoph Hellwig wrote:
>>> The only real user of the T10 OSD protocol, the pNFS object layout
>>> driver never went to the point of havin
On 28/11/18 06:32, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
ACK-by: Boaz Harrosh
> ---
> drivers/scsi/osd/osd_initiator.c | 3 ++-
&g
On 11/11/18 15:32, Christoph Hellwig wrote:
> The only real user of the T10 OSD protocol, the pNFS object layout
> driver never went to the point of having shipping products, and we
> removed it 1.5 years ago. Exofs is just a simple example without
> real life users.
>
You have failed to say wha
drivers/scsi/osd/osd_initiator.c
> @@ -58,6 +58,8 @@
>
> enum { OSD_REQ_RETRIES = 1 };
>
> +static const struct osd_obj_id osd_root_object;
> +
> MODULE_AUTHOR("Boaz Harrosh ");
> MODULE_DESCRIPTION("open-osd initiator library libosd.ko");
> MODULE_L
On 26/10/18 20:54, Nick Desaulniers wrote:
<>
>
> It's hard to say without knowing the original intent of the code.
>>From the variable's identifier and fact that it's global, I *assume*
> that we want only 1 struct osd_obj_id which is the root, hence the
> identifier `osd_root_object`. It has 4
On 27/10/18 16:28, Martin K. Petersen wrote:
>
> Bart,
>
>> Removing kernel drivers that are not used helps to reduce the workload
>> of a maintainer and hence is a rational action. Additionally, if
>> anyone would ever complain about removal of a kernel driver, it can be
>> brought back by rever
On 31/10/18 23:10, Douglas Gilbert wrote:
> On 2018-10-31 4:57 p.m., Boaz Harrosh wrote:
>> On 30/10/18 09:45, Christoph Hellwig wrote:
>>> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
>>>> LGTM, for both:
>>>
>>> I also have this on
On 31/10/18 19:29, Bart Van Assche wrote:
> On Wed, 2018-10-31 at 18:34 +0200, Boaz Harrosh wrote:
>> On 27/10/18 11:20, Christoph Hellwig wrote:
>>> The only real user of the T10 OSD protocol, the pNFS object layout
>>> driver never went to the point of havin
On 27/10/18 11:20, Christoph Hellwig wrote:
> The only real user of the T10 OSD protocol, the pNFS object layout
> driver never went to the point of having shipping products, and we
> removed it 1.5 years ago. Exofs is just a simple example without
> real life users.
>
> The code has been mostly
On 30/10/18 09:45, Christoph Hellwig wrote:
> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
>> LGTM, for both:
>
> I also have this one on top as requested by Martin. The core block
> bidi support is unfortunately also used by bsg-lib, although it is
> not anywhere near as invasive.
On 02/10/18 17:56, Christoph Hellwig wrote:
> On Mon, Oct 01, 2018 at 06:16:32PM -0700, Bart Van Assche wrote:
>> Boaz, the most recent osd patch that is neither trivial nor treewide
>> refactoring is six years old (51976a8c85ce ("[SCSI] osd_uld: Add osdname &
>> systemid sysfs at scsi_osd class").
o avoid 80 character column limit.
>
> [1]
> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com
>
ACK-BY: Boaz Harrosh
> Signed-off-by: Kees Cook
> ---
> drivers/scsi/osd/osd_initiator.c | 16
> 1 file changed
; Signed-off-by: Christoph Hellwig
>> ---
>> MAINTAINERS | 4
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 1bb06c5f7716..28dd83a1d9e2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -9418,10
On 04/21/2017 05:00 PM, Trond Myklebust wrote:
> Maintenance is not development. It’s about doing all the followup
> _after_ the feature is declared to be developed. That’s been missing
> for quite some time in the case of the OSD pNFS code, which is why
> I’m not even bothering to consider staging
On 04/20/2017 11:18 PM, Trond Myklebust wrote:
<>
>
> OK. I'm applying this patch for the 4.12 merge window.
That is understandable this code was not tested for a long while
> If, as Boaz
> suggests, there is still an interest in exofs, then I suggest we put
> that to the test by moving it into
On 04/07/2017 10:50 PM, Bart Van Assche wrote:
> On Fri, 2017-04-07 at 13:29 -0600, Logan Gunthorpe wrote:
>> On 07/04/17 09:49 AM, Bart Van Assche wrote:
>>> Sorry that I had not yet noticed Logan's patch series. Should my two
>>> patches that conflict with Logan's patch series be dropped and rewo
On 04/12/2017 07:01 PM, Christoph Hellwig wrote:
> This was just a proof of concept user for the SCSI OSD library, and
> never had any real users.
>
> Signed-off-by: Christoph Hellwig
Yes please remove this driver
ACK-by Boaz Harrosh
> ---
> drivers/block/Kconfig | 16 -
On 04/12/2017 07:01 PM, Christoph Hellwig wrote:
Hi Sir Christoph
> The only real user of the T10 OSD protocol, the pNFS object layout
> driver never went to the point of having shipping products, and the
> other two users (osdblk and exofs) were simple example of it's usage.
>
I understand why
On 03/30/2017 08:17 PM, Bart Van Assche wrote:
> scsi_device_get() can fail. Hence check its return value.
>
> Signed-off-by: Bart Van Assche
> Cc: Boaz Harrosh
Cool thanks
ACK-by: Boaz Harrosh
> ---
> drivers/scsi/osd/osd_uld.c | 8 +---
> 1 file changed, 5 inser
On 03/23/2017 12:41 PM, Dan Carpenter wrote:
> We don't call the remove() function unless probe() succeeds so "oud"
> can't be NULL here. Plus, if it were NULL, we dereference it on the
> next line so it would crash anyway.
>
> Signed-off-by: Dan Carpenter
&
On 02/28/2017 03:11 AM, Jeff Layton wrote:
<>
>
> I'll probably have questions about the read side as well, but for now it
> looks like it's mostly used in an ad-hoc way to communicate errors
> across subsystems (block to fs layer, for instance).
If memory does not fail me it used to be checked l
On 02/24/2016 01:21 PM, Sudip Mukherjee wrote:
> The variable is_ver1 is always true and so OSD_CAP_LEN can never be
> used.
> Reported by Coverity.
>
> Signed-off-by: Sudip Mukherjee
ACK-by: Boaz harrosh
Thanks
> ---
>
> v2: Joe Perches asked to mention the too
would be to change the casts to (u8*) aka
> (unsigned char*), but it is much simpler (and generates smaller code)
> to use the %ph extension which was created for such short hexdumps.
>
Ha real cool, thanks I hated that crap
ACK-by: Boaz Harrosh
> Signed-off-by: Rasmus Vi
On 09/30/2015 12:28 PM, Hannes Reinecke wrote:
<>
> Pushing things into the background is typically not the best of
> ideas; actually I've been running into issues with udev not being
> complete by the time the next round is started. So more often than
> not I would be greeted with messages:
>
> '
detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
ACK-by: Boaz Harrosh
> ---
> drivers/scsi/osd/osd_uld.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
> i
On 05/27/2015 01:02 PM, Narsimhulu Musini (nmusini) wrote:
<>
>>> +ifeq ($(CONFIG_SCSI_SNIC_DEBUG_FS), y)
>>> +ccflags-y += -DSNIC_DEBUG_FS
>>
>> Why do you need an extra define here just use
>> CONFIG_SCSI_SNIC_DEBUG_FS in source code directly
> Agree, I just want to use a shorter macro in the sou
On 05/27/2015 10:19 AM, Narsimhulu Musini wrote:
> Kconfig for kbuild
> Makefile to build snic module
>
> Updated MAINTAINERS file
>
> Signed-off-by: Narsimhulu Musini
> Signed-off-by: Sesidhar Baddela
> ---
> * v3
> - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling
> debug
On 04/29/2015 05:15 AM, James Bottomley wrote:
>
> Perhaps the best thing to do is just fix target and call it quits?
>
Right! drivers write code for sg_chaining and on ARCHs that do not
support it the code just works.
Only the max_sg is smaller and the chaining code never kicks in
and is dead c
On 01/29/2015 04:41 PM, James Bottomley wrote:
> On Thu, 2015-01-29 at 15:00 +0200, Boaz Harrosh wrote:
>> On 01/23/2015 03:12 PM, Christoph Hellwig wrote:
>>> On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote:
>>>> There is some confusion in the SCSI co
On 01/29/2015 03:20 PM, Bart Van Assche wrote:
> On 01/29/15 14:07, Boaz Harrosh wrote:
>> On 01/26/2015 11:58 AM, Bart Van Assche wrote:
>>
>>> Hello Christoph,
>>>
>>> This makes sense to me. I will rework this patch series as you proposed.
>
On 01/26/2015 11:58 AM, Bart Van Assche wrote:
> Hello Christoph,
>
> This makes sense to me. I will rework this patch series as you proposed.
>
Do you have a bidi setup to test against?
Sending xor command to scsi_dbg is only half the test for me because, yes
there are two buffers, but they a
On 01/23/2015 03:12 PM, Christoph Hellwig wrote:
> On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote:
>> There is some confusion in the SCSI core and in SCSI LLDs around the
>> meaning of sc_data_direction and whether or not this member can have the
>> value DMA_BIDIRECTIONAL. Clear u
On 11/06/2014 05:53 PM, Alan Stern wrote:
>> But just the simple case of read-capacity failure should we then?
>
> That's a separate question. As far as I know, the case you are
> describing has not come up.
>
BTW: what we should do is when the partition parser at the block layer
see that the
On 11/06/2014 05:54 PM, James Bottomley wrote:
>
> We don't have a failure. This is the problem. Determining that a
> problem exists
>
OK Sorry. I assumed the bridge is smart enough to do nothing,
ie READ_CAPACITY_10 is passed as is via sata to the device that
actually supports READ_CAPACITY
On 11/06/2014 12:30 PM, James Bottomley wrote:
> On Wed, 2014-11-05 at 11:30 -0800, Christoph Hellwig wrote:
>> On Wed, Nov 05, 2014 at 11:34:11AM -0500, Alan Stern wrote:
Sorry, meant to. In principle I'm OK with this as the lever for the
hack (largely because it means we don't need to
On 11/05/2014 06:34 PM, Alan Stern wrote:
<>
>
> It's simpler than that: The drive is attached directly to the computer
> (i.e., via SATA rather than USB) when the partition table is created.
> With no USB-SATA bridge chip to mess things up, there's no problem
> determining the correct capacity.
On 10/22/2014 12:04 AM, James Bottomley wrote:
> On Tue, 2014-10-21 at 17:05 +0300, Boaz Harrosh wrote:
>> Hi Sir Linus
>>
>> A small administrative stuff, was on vacation and the old email bounced on
>> me.
>> I was hoping to still make the 3 weeks merge wind
commit [bfe01a5b] Linux 3.17
3 patches available in the git repository at:
git://git.open-osd.org/linux-open-osd.git for-linus
for you to fetch changes up to 1fa3a002b2546c42c343c77c144871285896ced5:
Boaz Harrosh - fix email in Documentation (2014-10-19 20:36:36 +0300
From: Boaz Harrosh
I forgot to update Documentation/*.txt
Signed-off-by: Boaz Harrosh
---
Documentation/scsi/osd.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/scsi/osd.txt b/Documentation/scsi/osd.txt
index da162f7..5a9879b 100644
--- a/Documentation
From: Boaz Harrosh
I no longer have access to the Panasas email.
So change to an email that can always reach me.
Signed-off-by: Boaz Harrosh
---
drivers/scsi/osd/Kbuild | 2 +-
drivers/scsi/osd/Kconfig| 2 +-
drivers/scsi/osd/osd_debug.h| 2 +-
drivers/scsi/osd
From: Boaz Harrosh
I have moved on, and do no longer have Panasas email access.
Update to an email that can reach me.
So change bharr...@panasas.com => o...@electrozaur.com
Explain of email address:
* electrozaur.com is a domain owned by me.
* ooo - Stands for Open Osd . Org
Another em
On 08/13/2014 04:09 PM, Sagi Grimberg wrote:
> On 8/6/2014 4:25 PM, Boaz Harrosh wrote:
>
> Hey Boaz,
>
> So in the current flow, I still don't think it is wrong/buggy, the
> transfer byte length related to scsi buffer length
(In iscsi for sure
> but I think that fo
On 08/06/2014 03:43 PM, Sagi Grimberg wrote:
> Hi Boaz,
>
<>
>>
>> I hate that you introduced this new transfer_length variable. It does
>> not exist. In BIDI supporting driver there is out_len and in_len just
>> as original code.
>
> Effectively, out_len and in_len are the same except for the bi
On 08/04/2014 02:30 PM, jgr...@suse.com wrote:
> From: Juergen Gross
>
> If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
> driver's
> private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
> scsi_alloc_host_cmd_pool() isn't saving the pool address in
On 07/30/2014 07:50 PM, Ross Zwisler wrote:
<>
>> + */
>> +printk(KERN_EROR "brd: brd_find unexpected device %d\n", i);
>
> s/KERN_EROR/KERN_ERR/
>
Yes thanks, sigh, code should compile
driver error. I used pr_err but last inspection I saw that printk is used
everywhere and, crapped ...
On 07/30/2014 06:34 PM, Matthew Wilcox wrote:
> On Wed, Jul 30, 2014 at 05:18:47PM +0300, Boaz Harrosh wrote:
>> When brd_direct_access() is called on a partition-bdev
>> it would access the wrong sector. And caller would then
>> corrupt the device's data.
>>
>&
cess that will do the
proper checks and translations before calling a driver
global member. (The way it is done at the rest of the
block stack)
CC: Matthew Wilcox
Signed-off-by: Boaz Harrosh
---
drivers/block/brd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
ere is one more partitions BUG regarding
brd_direct_access() which is fixed on the next patch.
Signed-off-by: Boaz Harrosh
---
drivers/block/brd.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index c7d138e.
On 07/29/2014 08:19 PM, Ross Zwisler wrote:
> On Tue, 2014-07-29 at 19:37 +0300, Boaz Harrosh wrote:
>> Hi folks
>>
>> I've been playing with yet unseen prd block device, and hit an issue with
>> partitioning
>> but since prd.c is a copy/paste of brd.c th
On 07/29/2014 07:56 PM, Matthew Wilcox wrote:
> On Tue, Jul 29, 2014 at 07:37:49PM +0300, Boaz Harrosh wrote:
>> But before we are running to fix this bug. Could we please do better and
>> just remove the support for partitions
>> all together.
>> Since it *never*
Hi folks
I've been playing with yet unseen prd block device, and hit an issue with
partitioning
but since prd.c is a copy/paste of brd.c the same exact issue exists with brd.
It does not support partitions!
An attempt to fdisk say a couple of partitions, then mkfs && mount an individual
partiti
On 06/11/2014 12:09 PM, Sagi Grimberg wrote:
> In case protection information exists over the wire
> iscsi header data length is required to include it.
> Use protection information aware scsi helpers to set
> the correct transfer length.
>
> In order to avoid breakage, remove iser transfer length
On 06/25/2014 01:32 PM, Sagi Grimberg wrote:
> On 6/25/2014 11:48 AM, Sagi Grimberg wrote:
>
>
>>
>>> I made the patch below which should fix both bidi
>>> support in iscsi and also WRITE_SAME (and similar commands) support.
>>
>> I'm a bit confused, for all commands (bidi or not) the iscsi heade
On 06/25/2014 04:17 AM, Vladislav Bolkhovitin wrote:
> Martin K. Petersen, on 06/23/2014 06:58 PM wrote:
>>> "Mike" == Mike Christie writes:
+ unsigned int xfer_len = blk_rq_bytes(scmd->request);
>>
>> Mike> Can you do bidi and dif/dix?
>>
>> Nope.
>
> Correction: at the moment.
>
> The
On 07/20/2014 04:27 PM, Christoph Hellwig wrote:
> On Sun, Jul 20, 2014 at 02:47:49PM +0300, Boaz Harrosh wrote:
>>
>> So two things here:
>> - hdr->cmd_len is char so can be MAX of 255. I understand that 4 bytes
>> alignment is a SCSI
>> thing so you fou
On 07/20/2014 01:23 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Hi Christoph I've quickly reviewed your code and have a few questions
> ---
> block/scsi_ioctl.c | 24 +---
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/block/scsi_ioc
On 06/05/2014 06:40 PM, Boaz Harrosh wrote:
> On 06/03/2014 08:18 PM, Douglas Gilbert wrote:
>> v4 of this patch was sent 20131201.
>>
>> ChangeLog:
>> - remove the 16 byte CDB (SCSI command) length limit
>>from the sg driver by handling longe
si-generic.txt
> + *
> + * For utility and test programs see: http://sg.danny.cz/sg/sg3_utils.html
> + */
>
> #ifdef __KERNEL__
> extern int sg_big_buff; /* for sysctl */
> #endif
>
> -/* New interface introduced in the 3.x SG drivers follows */
>
> typedef struct sg_iovec /* same structure as used by readv() Linux system */
> { /* call. It defines one scatter-gather element. */
> @@ -87,7 +44,7 @@ typedef struct sg_io_hdr
> {
> int interface_id; /* [i] 'S' for SCSI generic (required) */
> int dxfer_direction;/* [i] data transfer direction */
> -unsigned char cmd_len; /* [i] SCSI command length ( <= 16 bytes) */
> +unsigned char cmd_len; /* [i] SCSI command length */
> unsigned char mx_sb_len;/* [i] max length to write to sbp */
> unsigned short iovec_count; /* [i] 0 implies no scatter gather */
> unsigned int dxfer_len; /* [i] byte count of data transfer */
Reviewed-by: Boaz Harrosh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
eueing nor SATA
> NCQ). Summarizing:
>- SG_IO in the block layer: blk_exec*(at_head=false)
>- sg SG_IO: at_head=true
>- bsg SG_IO: at_head=true
>
> Some time ago Boaz Harrosh introduced a sg v4 flag called
> BSG_FLAG_Q_AT_TAIL to override the bsg driver default.
>
>
> Looks more like an ack than a hack :)
>
Oops so I do need that coffee ;0)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/02/2014 10:58 AM, Christoph Hellwig wrote:
> With Linus opening the merge window things should calm down now.
>
> I've pushed the mvsas pciid update, and a revert of the be2scsi patch
> that wasn't quite ready to the drivers-for-3.16 branch.
>
> I've also created a new drivers-for-3.16-2 br
On 06/01/2014 05:06 PM, Fabian Frederick wrote:
> __constant_cpu_to_be16 converted to cpu_to_be16
>
> This patch fixes checkpatch warnings:
>
> "WARNING: __constant_cpu_to_be16 should be cpu_to_be16"
>
> Cc: Boaz Harrosh
> Cc: Benny Halevy
> Signed-of
On 04/08/2014 11:42 PM, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
>
> Signed-off-by: Matei Oprea
> Cc: ROSEdu Kernel Community
> ---
> drivers/scsi/lpfc/lpfc_init.c | 14 --
> 1 file changed, 8 insertions(
On 03/18/2014 10:51 PM, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
>
> Signed-off-by: Matei Oprea
> Cc: ROSEdu Kernel Community
> ---
> drivers/scsi/lpfc/lpfc_init.c |4 ++--
> 1 file changed, 2 insertions(+), 2 de
;From 9809b82bbb9813370738ac00400c01d61b0c51b4 Mon Sep 17 00:00:00 2001
From: Boaz Harrosh
Date: Mon, 4 Jan 2010 10:45:56 +0200
Subject: [PATCH 1/4] scsi_lib: request_queue is only needed inside
scsi_requeue_command
This is a pure cleanup. Just starting the engines for things
to come.
Signe
te ? WRITE : READ, flags);
> - if (unlikely(!req))
> - return ERR_PTR(-ENOMEM);
> + if (unlikely(IS_ERR(req)))
Just a nit IS_ERR already has an unlikely so it can be dropped here. (No bigy)
ACK-by: Boaz Harrosh
> + retu
On 09/18/2013 05:07 PM, Douglas Gilbert wrote:
> On 13-09-18 03:58 AM, Jack Wang wrote:
>> On 09/18/2013 08:41 AM, Alireza Haghdoost wrote:
>>> Hi
>>>
>>> I am working on a high throughput and low latency application which
>>> does not tolerate block layer overhead to send IO request directly to
>>
ttomley"
> Cc: Bart Van Assche
> Cc: linux-scsi@vger.kernel.org
ACK-by: Boaz Harrosh
> ---
<>
> drivers/scsi/osd/osd_initiator.c| 4 ++--
<>
> diff --git a/drivers/scsi/osd/osd_initiator.c
> b/drivers/scsi/osd/osd_initiator.c
> index d8293f2
On 01/29/2013 10:14 AM, Hannes Reinecke wrote:
> Hi all,
>
> Thin-provisioned devices have the ability to set a 'soft threshold',
> which is triggered if the real free space for this device is beyond
> this mark.
>
> The intention behind this is to allow the system to induce some
> garbage col
On 02/07/2013 02:33 PM, Hannes Reinecke wrote:
> On 02/07/2013 01:16 PM, Boaz Harrosh wrote:
>> (Again libaio should be changed in concert with Kernel's new API, and we
>> can sacrifice old user-mode performance, with a COMPAT layer. Distro
>> maintainers should
On 02/07/2013 02:29 PM, Bart Van Assche wrote:
> On 02/07/13 13:08, Boaz Harrosh wrote:
>> (My addition is for support of sg_lists to bsg, in a way that makes Tomo
>> happy
>> I know that qemu was wanting this for a while as well as the multitude of
>> user-mode se
On 02/07/2013 02:08 PM, Boaz Harrosh wrote:
> On 02/07/2013 01:27 PM, Hannes Reinecke wrote:
>> On 02/07/2013 11:01 AM, Darrick J. Wong wrote:
>>> On Thu, Feb 07, 2013 at 01:40:14AM -0800, Joel Becker wrote:
>>>> On Wed, Feb 06, 2013 at 03:34:49PM -0500, Chuck Lev
On 02/07/2013 01:27 PM, Hannes Reinecke wrote:
> On 02/07/2013 11:01 AM, Darrick J. Wong wrote:
>> On Thu, Feb 07, 2013 at 01:40:14AM -0800, Joel Becker wrote:
>>> On Wed, Feb 06, 2013 at 03:34:49PM -0500, Chuck Lever wrote:
On Feb 6, 2013, at 3:24 PM, "Darrick J. Wong"
wrote:
On 01/30/2013 09:06 AM, Dan Carpenter wrote:
> There wasn't any error handling for this kzalloc().
>
ACK-by: Boaz Harrosh
James please queue for inclusion
> Signed-off-by: Dan Carpenter
Thanks Dan
>
> diff --git a/drivers/scsi/osd/osd_initiator.c
> b/drivers/s
On 01/30/2013 04:34 PM, walter harms wrote:
>
<>
> I start to see the complexity of the situation. Would you mind to add
> the comment "it can be anything. UTF-8 is more likely but not guaranteed
> either" ?
> For now using a pascal-string seems the best solution but it should be warned
> that g
On 12/18/2012 01:28 PM, James Bottomley wrote:
<>
>> Both these patches where in linux-next for a long time. So I believe
>> the merge will go just fine. Lets leave it like this, or I can rebase
>> and remove it?
>
> If it merges OK, I'd just leave it as is. It wouldn't be anywhere close
> to the
On 12/18/2012 12:58 PM, James Bottomley wrote:
> On Mon, 2012-12-17 at 18:53 +0200, Boaz Harrosh wrote:
>> Hi Linus.
>>
>> Please pull the following changes since commit [ddffeb8c] Linux 3.7-rc1
>> They are available in the git repository at:
>>
>> git://
s year, It is important for
some of the big installation cluster systems, who's been compiling their
own kernel just for that patch.
Thanks in advance
Boaz
--------
Boaz Harrosh (1):
exofs: don't leak io_state and pages on re
On 10/24/2012 02:55 PM, Boaz Harrosh wrote:
> On 10/24/2012 02:51 PM, Boaz Harrosh wrote:
>>
>> This patch adds the support for the following two read-only sysfs attributes
>> to scsi_osd class members : osdname & systemid
>>
>> These attributes will show
On 10/24/2012 02:51 PM, Boaz Harrosh wrote:
>
> This patch adds the support for the following two read-only sysfs attributes
> to scsi_osd class members : osdname & systemid
>
> These attributes will show up as below in sysfs class hierarchy:
> /sys/class/scsi_osd/osd
in the system and send a
attributes query for these, in order to access the user
requested device)
Signed-off-by: Sachin Bhamare
Signed-off-by: Boaz Harrosh
---
drivers/scsi/osd/osd_uld.c | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git
We should switch this topic to the scsi mailing list
On 08/17/2012 01:49 PM, Boaz Harrosh wrote:
> On 08/17/2012 01:12 AM, Nicholas A. Bellinger wrote:
>
>> On Thu, 2012-08-16 at 09:24 -0700, Roland Dreier wrote:
>>> Actually I'm not sure removing cmd_spdtl is the rig
On 07/30/2012 10:12 AM, Paolo Bonzini wrote:
> Il 30/07/2012 01:50, Rusty Russell ha scritto:
>>> Also, being the first user of chained scatterlist doesn't exactly give
>>> me warm fuzzies.
>>
>> We're far from the first user: they've been in the kernel for well over
>> 7 years. They were introdu
On 07/26/2012 10:23 AM, Paolo Bonzini wrote:
>
> In the meanwhile, we still have a bug to fix, and we need to choose
> between Sen Wang's v1 (sg_set_page) or v2 (value assignment). I'm still
> leaning more towards v2, if only because I already tested that one myself.
>
It's your call, you kno
On 07/25/2012 11:06 PM, Paolo Bonzini wrote:
> Il 25/07/2012 21:16, Boaz Harrosh ha scritto:
>> The picture confused me. It looked like the first element is the
>> virtio_scsi_cmd_req
>> not an sgilist-element that points to the struct's buffer.
>>
>> In th
On 07/25/2012 08:43 PM, Paolo Bonzini wrote:
> Il 25/07/2012 17:28, Boaz Harrosh ha scritto:
>>> 1) what I get is a scsi_cmnd which contains an N-element scatterlist.
>>>
>>> 2) virtio-scsi has to build the "packet" that is passed to the hardware
>
On 07/25/2012 05:17 PM, Paolo Bonzini wrote:
> Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
>>>> In SCSI land most LLDs should support chaining just by virtu of using the
>>>> for_each_sg macro. That all it takes. Your code above does support it.
>>>
>>&
On 07/25/2012 04:36 PM, Paolo Bonzini wrote:
> Il 25/07/2012 15:26, Boaz Harrosh ha scritto:
>> On 07/25/2012 03:49 PM, Paolo Bonzini wrote:
>>
>>>
>>> Except here the destination array has to be given to virtio, which
>>> doesn't (yet) understand
On 07/25/2012 03:49 PM, Paolo Bonzini wrote:
>
> Except here the destination array has to be given to virtio, which
> doesn't (yet) understand chaining. I'm using for_each_sg rather than a
> simple memcpy exactly because I want to flatten the input scatterlist
> onto consecutive scatterlist entr
e this
> paragraph with the following:
>
> "To fix this, we can simply copy the original scatterlist entries into
> virtio-scsi's; we need to copy the entries entirely, including the flag
> bits, so using sg_set_page is not correct".
>
> Please send v3 with this
On 07/25/2012 02:44 PM, Sen Wang wrote:
> 2012/7/25 Paolo Bonzini :
>> Il 25/07/2012 10:29, Wang Sen ha scritto:
>>> When using the commands below to write some data to a virtio-scsi LUN of the
>>> QEMU guest(32-bit) with 1G physical memory(qemu -m 1024), the qemu will
>>> crash.
>>>
>>> #
On 07/25/2012 12:41 PM, Paolo Bonzini wrote:
> Il 25/07/2012 11:22, Boaz Harrosh ha scritto:
>>>>>> for_each_sg(table->sgl, sg_elem, table->nents, i)
>>>>>> -sg_set_buf(&sg[idx++], sg_virt(sg_elem),
>>>>>
On 07/25/2012 11:44 AM, Paolo Bonzini wrote:
> Il 25/07/2012 10:29, Wang Sen ha scritto:
>> When using the commands below to write some data to a virtio-scsi LUN of the
>> QEMU guest(32-bit) with 1G physical memory(qemu -m 1024), the qemu will
>> crash.
>>
>> # sudo mkfs.ext4 /dev/sdb (/de
On Mon, Feb 18 2008 at 19:22 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2008-02-18 at 17:08 +0200, Boaz Harrosh wrote:
>> But ... James? is
>> there any chance these can go into scsi-rc-fixes for the 2.6.25
>> kernel? The reason they are so late was
On Tue, Feb 12 2008 at 22:17 +0200, Pete Wyckoff <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:12 -0500:
>> [EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 20:08 +0200:
>>> Cheers after 1.3 years these can go in.
>>>
>>> [PATCH 1/3] iscsi: extended cdb support
>>>The v
bidi support for iscsi_tcp
- access the right scsi_in() and/or scsi_out() side of things.
also for resid
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Reviewed-by: Pete Wyckoff <[EMAIL PROTECTED]>
Signed-off-by: Mike Christie <[EMAIL PROTECTED]>
---
drivers/scsi/
1 - 100 of 638 matches
Mail list logo
