Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14

2013-05-01 Thread Bhanu Prakash Gollapudi
On 05/01/2013 06:05 PM, James Bottomley wrote: On Fri, 2013-03-08 at 15:53 -0800, Bhanu Prakash Gollapudi wrote: On 03/08/2013 01:28 PM, Bhanu Prakash Gollapudi wrote: Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc

Re: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name

2013-05-01 Thread Bhanu Prakash Gollapudi
On 05/01/2013 05:39 PM, James Bottomley wrote: On Fri, 2013-03-08 at 13:28 -0800, Bhanu Prakash Gollapudi wrote: +#ifndef PCI_DEVICE_ID_NX2_57710 +#define PCI_DEVICE_ID_NX2_577100x164e +#endif +#ifndef PCI_DEVICE_ID_NX2_57711 +#define PCI_DEVICE_ID_NX2_57711

Re: [PATCH 0/5] bnx2fc version 1.0.14

2013-04-18 Thread Bhanu Prakash Gollapudi
On 03/08/2013 01:28 PM, Bhanu Prakash Gollapudi wrote: Hi James, Please consider including the following patches for 3.9+ merge window. Thanks, Bhanu Bhanu Prakash Gollapudi (5): bnx2fc: Enable cached tasks to improve performance bnx2fc: Include chip number in the symbolic name

Re: error handler scheduling

2013-04-02 Thread Bhanu Prakash Gollapudi
On 03/27/2013 07:35 AM, Hannes Reinecke wrote: On 03/27/2013 03:11 AM, James Smart wrote: In looking through the error handler, if a command times out and is added to the eh_cmd_q for the shost, the error handler is only awakened once shost->host_busy (total number of i/os posted to the shost) i

Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14

2013-03-08 Thread Bhanu Prakash Gollapudi
On 03/08/2013 01:28 PM, Bhanu Prakash Gollapudi wrote: Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers

[PATCH 0/5] bnx2fc version 1.0.14

2013-03-08 Thread Bhanu Prakash Gollapudi
Hi James, Please consider including the following patches for 3.9+ merge window. Thanks, Bhanu Bhanu Prakash Gollapudi (5): bnx2fc: Enable cached tasks to improve performance bnx2fc: Include chip number in the symbolic name bnx2fc: Fix race condition between IO completion and abort

[PATCH 1/5] bnx2fc: Enable cached tasks to improve performance

2013-03-08 Thread Bhanu Prakash Gollapudi
Set perf_config to 3 during firmware initialization to enable both cached connections as well as cached tasks. Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_hwi.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2fc

[PATCH 2/5] bnx2fc: Include chip number in the symbolic name

2013-03-08 Thread Bhanu Prakash Gollapudi
Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h | 53 + drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 51 +++ 2 files changed, 98 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b

[PATCH 3/5] bnx2fc: Fix race condition between IO completion and abort

2013-03-08 Thread Bhanu Prakash Gollapudi
Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_io.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 60798e8..539b95b 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/drivers/scsi/bnx2fc

[PATCH 5/5] bnx2fc: Bumped version to 1.0.14

2013-03-08 Thread Bhanu Prakash Gollapudi
Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 676dba3..1ece6e9 100644 --- a

[PATCH 4/5] bnx2fc: Update copyright information

2013-03-08 Thread Bhanu Prakash Gollapudi
Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc/bnx2fc_els.c |2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- drivers/scsi/bnx2fc/bnx2fc_hwi.c |2 +- drivers/scsi/bnx2fc/bnx2fc_io.c |2 +- drivers/scsi/bnx2fc

Re: [PATCH 5/15] drivers/scsi/bnx2fc/bnx2fc_io.c: adjust duplicate test

2013-01-21 Thread Bhanu Prakash Gollapudi
; bnx2fc_free_mp_resc(io_req); return FAILED; Acked-by: Bhanu Prakash Gollapudi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[v2 PATCH 3/8] bnx2fc: support software fcoe target

2013-01-10 Thread Bhanu Prakash Gollapudi
e FCoE target always advertises RETRY bit even when there are no tape LUNs behind the target. This causes the driver to enable FW support for sequence level error recovery and perform REC/SRR. This patch arrests the behavior by not enabling SLER feature for this target. Signed-off-by: Bha

[PATCH 5/8] bnx2fc: Map the doorbell register between offload and enable requests

2012-12-21 Thread Bhanu Prakash Gollapudi
resolve this, map the doorbell between offload and enable, so that driver is ready to receive the unsolicited packets and arm the CQ as soon as FW enable is performed. Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |3 +++ drivers/scsi/bnx2fc/bnx2fc_hwi.c | 25

[PATCH 8/8] bnx2fc: Bumped version to 1.0.13

2012-12-21 Thread Bhanu Prakash Gollapudi
Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 6bbc0c1..7ce1560 100644 --- a

[PATCH 4/8] bnx2fc: Move offload/upload wait logic into a function

2012-12-21 Thread Bhanu Prakash Gollapudi
Moved the 'waiting for upload/offload completion' logic to respective functions as it is called in multiple places. Also this is done in preperation for the next patch. Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 65 +-

[PATCH 7/8] bnx2fc: Support max IO size to 512KB

2012-12-21 Thread Bhanu Prakash Gollapudi
Increase max_sectors from 512 to 1024 in order to support max IO size of 512KB. Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc

[PATCH 6/8] bnx2fc: Tx/Rx byte counts reset to 0 when exceeding 32 bit values

2012-12-21 Thread Bhanu Prakash Gollapudi
Since the FW counters are 32-bit, accumulate the stats in the driver. Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h | 22 ++ drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 17 - 2 files changed, 34 insertions(+), 5 deletions(-) diff

[PATCH 1/8] bnx2fc: remove useless calls to memset().

2012-12-21 Thread Bhanu Prakash Gollapudi
From: Cyril Roelandt These calls are followed by calls to memcpy() on the same memory area, so they can be safely removed. Signed-off-by: Cyril Roelandt Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_hwi.c |4 1 files changed, 0 insertions(+), 4 deletions

[PATCH 2/8] bnx2fc: Remove potential NULL dereference

2012-12-21 Thread Bhanu Prakash Gollapudi
; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // Signed-off-by: Julia Lawall Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_io.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 3/8] bnx2fc: support software fcoe target

2012-12-21 Thread Bhanu Prakash Gollapudi
: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc_tgt.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c index b9d0d9c..4998b69 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c +++ b/drivers/scsi/bnx2fc

[PATCH 0/8] bnx2fc version 1.0.13

2012-12-21 Thread Bhanu Prakash Gollapudi
Hi James, Please consider including the following patches in 3.8+ merge window. Thanks, Bhanu Bhanu Prakash Gollapudi (6): bnx2fc: support software fcoe target bnx2fc: Move offload/upload wait logic into a function bnx2fc: Map the doorbell register between offload and enable requests

Re: [PATCH 00/16] libfc, libfcoe and fcoe updates for 3.8

2012-12-16 Thread Bhanu Prakash Gollapudi
except for the minor comment in patch 5. Reviewed-by: Bhanu Prakash Gollapudi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/16] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-12-16 Thread Bhanu Prakash Gollapudi
On 12/12/2012 03:22 PM, Robert Love wrote: +ssize_t fcoe_ctlr_create_store(struct bus_type *bus, + const char *buf, size_t count) +{ + struct net_device *netdev = NULL; + struct fcoe_transport *ft = NULL; + struct fcoe_ctlr_device *ctlr_dev = NULL; +

Re: [PATCH 3/6] scsi: bnx2fc: remove useless calls to memset().

2012-12-03 Thread Bhanu Prakash Gollapudi
et(&io_req->err_entry, 0, - sizeof(struct fcoe_err_report_entry)); memcpy(&io_req->err_entry, err_entry, sizeof(struct fcoe_err_report_entry)); Acked-by: Bhanu Prakash Gollapudi -- To unsubscribe from this list: send the line &qu

Re: [PATCH] [SCSI] bnx2fc: fix NULL checking in bnx2fc_initiate_tmf()

2012-11-05 Thread Bhanu Prakash Gollapudi
gain. Thanks! Acked-by: Bhanu Prakash Gollapudi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH v4 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

2012-10-10 Thread Bhanu Prakash Gollapudi
On 10/09/2012 03:18 PM, Robert Love wrote: v4: @Neil: Policy is now: 'mode' attribute: input: "Fabric" "VN2VN" (case insensitive) output: "Fabric" "VN2VN" 'enabled' attribute: input: "1" "0" output: "1" "0" @M

Re: [RFC PATCH v2 5/5] bnx2fc: Use the fcoe_sysfs control interface

2012-09-30 Thread Bhanu Prakash Gollapudi
On 09/26/2012 07:02 PM, Robert Love wrote: This patch adds support for the new fcoe_sysfs control interface to bnx2fc.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the

Re: [RFC PATCH 4/5] bnx2fc: Use new fcoe_sysfs control interface

2012-09-14 Thread Bhanu Prakash Gollapudi
On 09/10/2012 03:59 PM, Robert Love wrote: Convert bnx2fc to use the new fcoe_sysfs create, delete, enable, disable, start and mode. bnx2fc doesn't support VN2VN. bnx2fc will not initialize the set_fcoe_ctlr_mode routine and therefore its instances will always be in FABRIC mode. There was previo

Re: [RFC PATCH 2/5] libfcoe: Create new libfcoe control interfaces

2012-09-14 Thread Bhanu Prakash Gollapudi
On 9/10/2012 3:59 PM, Robert Love wrote: This patch is the first in a series that will remove libfcoe's create, destroy, enable and disable module parameters and replace them with interface files in the new /sys/bus/fcoe subsystem. Old layout: /sys/module/libfcoe/parameters/{create,destroy,enab

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Bhanu Prakash Gollapudi
On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No discovery or login # echo eth3.1

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Bhanu Prakash Gollapudi
On 9/10/2012 6:41 PM, Love, Robert W wrote: On Mon 10 Sep 2012 05:05:20 PM PDT, Bhanu Prakash Gollapudi wrote: On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Bhanu Prakash Gollapudi
On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that work. It moves the create, vn2vn_creat

Re: [PATCH 2/5] drivers/scsi/bnx2fc/bnx2fc_io.c: Remove potential NULL dereference

2012-09-07 Thread Bhanu Prakash Gollapudi
,7 @@ static int bnx2fc_initiate_tmf(struct scsi_cmnd *sc_cmd, u8 tm_flags) rc = FAILED; goto tmf_err; } + rp = rport->dd_data; rc = fc_block_scsi_eh(sc_cmd); if (rc) Thanks Julia. Acked-by: Bhanu Prakash Gollapudi -- To u

Re: [PATCH] Fix incorrect memset in bnx2fc_parse_fcp_rsp

2012-09-03 Thread Bhanu Prakash Gollapudi
0, SCSI_SENSE_BUFFERSIZE); if (fcp_sns_len) memcpy(sc_cmd->sense_buffer, rq_data, fcp_sns_len); Thanks Andi. Looks good to me. Acked-by: Bhanu Prakash Gollapudi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of