Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2018-01-03 Thread Bartlomiej Zolnierkiewicz
| 4 ++-- > lib/test_firmware.c | 14 +--- > lib/test_kmod.c | 14 +--- > sound/soc/omap/mcbsp.c | 4 ++-- > 15 files changed, 49 insertions(+), 80 deletions(-) For fbdev changes: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-20 Thread Bartlomiej Zolnierkiewicz
On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote: > > > au1100fb is using managed dma allocations, so it doesn't need t

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-19 Thread Bartlomiej Zolnierkiewicz
h Hellwig Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

2017-04-26 Thread Bartlomiej Zolnierkiewicz
On Wednesday, April 26, 2017 09:34:22 AM Christoph Hellwig wrote: > The caller only looks at the scsi_request result field anyway. > > Signed-off-by: Christoph Hellwig Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute P

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

2017-04-26 Thread Bartlomiej Zolnierkiewicz
> Signed-off-by: Christoph Hellwig Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

2017-03-22 Thread Bartlomiej Zolnierkiewicz
_clkscaling_supported(hba)) > - hba->clk_scaling.active_reqs--; > } > > /* clear corresponding bits of completed commands */ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: remove the cmd_type field from struct request

2017-02-01 Thread Bartlomiej Zolnierkiewicz
). > libata that would need to be added, before we can git rm drivers/ide/ ? I was trying to start the removal with [1] last year but it has been NAK-ed by DaveM who seems to want to keep drivers/ide/ forever [2]. [1] https://lkml.org/lkml/2016/2/4/409 [2] https://lkml.org/lkml/2016/

Re: [PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-13 Thread Bartlomiej Zolnierkiewicz
igned-off-by: Tuan Phan > Signed-off-by: Suman Tripathi Reviewed-by: Bartlomiej Zolnierkiewicz Thanks for fixing all the remaining issues. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "

Re: [PATCH v16 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-12 Thread Bartlomiej Zolnierkiewicz
simple and look like this: static void xgene_ahci_host_stop(struct ata_host *host) { struct ahci_host_priv *hpriv = host->private_data; ahci_platform_disable_resources(hpriv); } > + .driver = { > + .name = "xgene-ahci", > + .owner

Re: [PATCH v14 2/3] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-04 Thread Bartlomiej Zolnierkiewicz
form_[get,enable,disable]_resources() is not used instead? > + if (!hplat_data->phy) { > + dev_err(dev, "no PHY available\n"); > + rc = -ENODEV; > + goto disable_resources; > + } > + > + rc = phy_init(hplat_data->phy

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

2013-11-12 Thread Bartlomiej Zolnierkiewicz
Hi Sergei, On Tuesday, November 12, 2013 08:34:36 PM Sergei Shtylyov wrote: > Hello. > > On 12-11-2013 19:40, Bartlomiej Zolnierkiewicz wrote: > > > Please remember to include linux-...@vger.kernel.org on CC: for ATA patches. > > > Also from the quick look it seems

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

2013-11-12 Thread Bartlomiej Zolnierkiewicz
on the code in patch #4 - patch #5 ("Documentation: Add documentation for APM X-Gene SATA DTS binding") should come before patch #2 ("arm64: Add APM X-Gene DTS entry for SATA controllers") or (even better) just be merged into patch #2 Best regards, -- Bartlomiej Zolnierkiew

Re: [PATCH/RESEND 1/2] Hard disk S3 resume time optimization

2013-09-10 Thread Bartlomiej Zolnierkiewicz
On Friday, September 06, 2013 03:45:35 PM Todd E Brandt wrote: > On Fri, Sep 06, 2013 at 06:54:48PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Thursday, September 05, 2013 05:38:53 PM Todd E Brandt wrote: > > > This is the final draft

Re: [PATCH/RESEND 1/2] Hard disk S3 resume time optimization

2013-09-06 Thread Bartlomiej Zolnierkiewicz
me(struct device *dev) > > static const struct dev_pm_ops ata_port_pm_ops = { > .suspend = ata_port_suspend, > - .resume = ata_port_resume, > + .resume = ata_port_resume_async, ->resume will now return success even though it can later fail during the asy

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Bartlomiej Zolnierkiewicz
req->cmd_type = REQ_TYPE_BLOCK_PC; > + req->cmd_flags |= REQ_PM | REQ_QUIET | REQ_PREEMPT; > + > + req->end_io_data = sdkp; > + blk_execute_rq_nowait(req->q, NULL, req, 1, sd_resume_async_end); > + return 0; > + > + error_sense: > +

Re: "mount: could not find filesystem" - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday 14 February 2008, Kamalesh Babulal wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > On Tuesday 12 February 2008, Kamalesh Babulal wrote: >

"mount: could not find filesystem" - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 14 February 2008, Kamalesh Babulal wrote: > Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > On Tuesday 12 February 2008, Kamalesh Babulal wrote: > >> Bartlomiej Zolnierkiewicz wrote: > >>> Hi, > >>> > >>&g

Re: dmesg spam

2008-02-04 Thread Bartlomiej Zolnierkiewicz
On Sunday 03 February 2008, Andrew Morton wrote: > > With latest -mm, running fc8 I am getting this in the logs, ^^^ => SCSI/libata cc:ing Jeff > once per second. > > sr0: CDROM not ready. Make sure there is a disc in the drive. > sr0: CDROM not ready. Make sure the

Re: [PATCH 19/30] blk_end_request: changing ide-scsi (take 4)

2007-12-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 11 December 2007, Kiyoshi Ueda wrote: > This patch converts ide-scsi to use blk_end_request interfaces. > Related 'uptodate' arguments are converted to 'error'. > > Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > Signed-off-by: Kiyoshi

Re: [PATCH 20/28] blk_end_request: changing ide-scsi (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 December 2007, Kiyoshi Ueda wrote: > This patch converts ide-scsi to use blk_end_request(). > > Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> > Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTEC

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
On Tuesday 04 December 2007, Kiyoshi Ueda wrote: > Hi Bartlomiej, > > On Sat, 1 Dec 2007 23:53:05 +0100, Bartlomiej Zolnierkiewicz <[EMAIL > PROTECTED]> wrote: > > On Saturday 01 December 2007, Kiyoshi Ueda wrote: > > > This patch converts "norma

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
, > which just returns value '1', to tell blk_end_request_callback() > about that. > > Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> > Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> Looks good, thanks! Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECT

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 December 2007, Kiyoshi Ueda wrote: > This patch converts "normal" parts of ide to use blk_end_request(). > > Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> > Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> > --- > drivers/ide/ide-cd.c |6 +++--- > drivers/ide/ide-io.c | 1

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
Kiyoshi Ueda <[EMAIL PROTECTED] Cc: Jun'ichi Nomura <[EMAIL PROTECTED]> Cc: Tejun Heo <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- Kiyoshi: please rebase your patch on top of this one (I'll send it to Linus in the next IDE update),

Re: [PATCH 2/2] ide-scsi: use print_hex_dump from

2007-11-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 27 November 2007, Bartlomiej Zolnierkiewicz wrote: > On Tuesday 27 November 2007, Andrew Morton wrote: > > On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote: > > > > > these utilities implemented in lib/hexdump.c are more

Re: [PATCH 2/2] ide-scsi: use print_hex_dump from

2007-11-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 27 November 2007, Andrew Morton wrote: > On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote: > > > these utilities implemented in lib/hexdump.c are more handy, please use > > this. > > > > ... > > > > --- a/drivers/scsi/ide-scsi.c > > +++ b/drivers/scsi/ide-scsi.

Re: [git patches] libata update

2007-10-12 Thread Bartlomiej Zolnierkiewicz
On Friday 12 October 2007, Jeff Garzik wrote: > > [ I just sent this upstream to Andrew and Linus ] > > Now that I have nailed down the corruption problem, I can attend to > this... Fun stuff: > > * port multiplier support (like an ethernet hub, only dumber) Great to see this here. > * Async

[PATCH] MAINTAINERS: mark ide-scsi as Orphan

2007-09-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) Index: b/MAINTAINERS === --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1889,6 +1889,11 @@ M: Gadi

Re: [PATCH 24/24 ver3 ] ide-scsi.c: convert to data accessors and !use_sg cleanup

2007-09-19 Thread Bartlomiej Zolnierkiewicz
lly worth to fix it > As suggested by Christoph Hellwig I set > use_10_for_rw = 1; and use_10_for_ms = 1; > for this device and completely killed the translation. > > Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> anyway patch looks good Signed-off-by: Bartlomiej Zol

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 September 2007, James Bottomley wrote: > On Mon, 2007-09-17 at 12:46 +0200, Bartlomiej Zolnierkiewicz wrote: > > 0024 drivers/scsi/ide-scsi.c - Bartlomiej Zolnierkiewicz > > <[EMAIL PROTECTED]> > > > > This reminds me that ide-scsi needs a real Ma

Re: [PATCH 24/24] ide-scsi.c: convert to data accessors and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Wednesday 12 September 2007, Boaz Harrosh wrote: > > - Convert ide-scsi to the new data accessors and cleanup >the !use_sg code paths. > > Inspecting old code I can see places that still assume > scsi_cmnd->request_buffer is a linear char pointer. Though I > admit this assumption is

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday 11 September 2007, Boaz Harrosh wrote: > Here are more accessors patches. I have tried > to find Maintainers of drivers but please help me if > I missed any. [ ... ] > 0010 drivers/scsi/eata_pio.c - Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > ? not me, acco

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > On Saturday 15 September 2007, Adrian Bunk wrote: > >> On Sat, Sep 15, 2007 at 11:44:59AM -0400, Jeff Garzik wrote: > >>> Stefan Richter wrote: > >>>> Adrian Bunk

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Adrian Bunk wrote: > On Sat, Sep 15, 2007 at 11:44:59AM -0400, Jeff Garzik wrote: > > Stefan Richter wrote: > >> Adrian Bunk wrote: > >>> On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote: > Perfect is in the eye of the beholder. You would consequen

Re: [PATCH 31] drivers/scsi/ide-scsi.c: kmalloc + memset conversion to kzalloc

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Tuesday 31 July 2007, Mariusz Kozlowski wrote: > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/scsi/ide-scsi.c | 34642 -> 34536 (-106 bytes) > drivers/scsi/ide-scsi.o | 171728 -> 171524 (-204 bytes) > > drivers/scsi/ide-scsi.c | 10 -- > 1 file changed, 4 insert

Re: [PATCH 24/33] ide-scsi: sg chaining support

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Monday 16 July 2007, Jens Axboe wrote: > Cc: [EMAIL PROTECTED] > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messa

Re: [PATCH 33/33] IDE: sg chaining support

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Monday 16 July 2007, Jens Axboe wrote: > Cc: [EMAIL PROTECTED] > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messa

Re: block/bsg.c

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 July 2007, FUJITA Tomonori wrote: > They were fixed. Please check the latest code: > > git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git bsg > > We wait for Linus to pull from it. It has been merged. Thanks for fixing the mentioned issues. Thanks, Bart -

Re: block/bsg.c

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, James Bottomley wrote: > On Wed, 2007-07-18 at 02:43 +0200, Bartlomiej Zolnierkiewicz wrote: > > [ James, please remeber to cc: linux-ide on IDE patches, thanks. ] > > Blame Andrew ... I assumed he'd be reporting the problem to the relevant &g

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
[ James, please remeber to cc: linux-ide on IDE patches, thanks. ] On Wednesday 18 July 2007, Jeff Garzik wrote: > James Bottomley wrote: > > @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct > > file *file, struct block_device > > int err, (*setfunc)(ide_drive_t *, int

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday 17 July 2007, Andrew Morton wrote: > On Tue, 17 Jul 2007 22:52:25 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > ide-{disk,scsi,tape} don't support REQ_TYPE_BLOCK_PC requests et all > > (so attempts to use SG_IO, CDROM_SEND_PA

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
Hi, Some more bsg findings... block/Kconfig: endif # BLOCK Shouldn't BLK_DEV_BSG depend on BLOCK? config BLK_DEV_BSG bool "Block layer SG support" depends on (SCSI=y) && EXPERIMENTAL default y ---help--- Saying Y here will enable generic SG (SCSI gener

Re: [PATCH 05/33] Add chained sg support to linux/scatterlist.h

2007-07-16 Thread Bartlomiej Zolnierkiewicz
On Monday 16 July 2007, Jens Axboe wrote: > The core of the patch - allow the last sg element in a scatterlist > table to point to the start of a new table. We overload the LSB of > the page pointer to indicate whether this is a valid sg entry, or > merely a link to the next list. > > Signed-off-b

Re: [PATCH 03/33] block: convert to using sg helpers

2007-07-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 16 July 2007, Jens Axboe wrote: > Convert the main rq mapper (blk_rq_map_sg()) to the sg helper setup. > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > block/ll_rw_blk.c | 19 --- > 1 files changed, 12 insertions(+), 7 deletions(-) > > diff --git a/bloc

Re: [PATCH] IDE: Remove references to the non-existent CONFIG_SCSI_EATA_DMA variable.

2007-06-08 Thread Bartlomiej Zolnierkiewicz
On Sunday 03 June 2007, Robert P. J. Day wrote: > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Linux tape drivers

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 April 2007, Andrew Morton wrote: > On Wed, 4 Apr 2007 12:22:35 -0700 > "Willem Riede" <[EMAIL PROTECTED]> wrote: > > > On 4/4/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Wed, 4 Apr 2007 16:26:14 +0200 Kern Sibbald <[EMAIL PROTECTED]> wrote: > > > > > > > I'm all in favor