On 2019-10-21 23:28, Hannes Reinecke wrote:
> On 10/21/19 6:41 PM, Bart Van Assche wrote:
>> On 10/21/19 2:53 AM, Hannes Reinecke wrote:
>>> We should return the actual error code in st_scsi_execute(),
>>> avoiding the need to use DRIVER_ERROR.
>>>
On 10/21/19 2:53 AM, Hannes Reinecke wrote:
When failing to map the user buffer we should return the actual
error code, avoiding the usage of DRIVER_ERROR.
Signed-off-by: Hannes Reinecke
---
block/scsi_ioctl.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/s
On 10/21/19 2:53 AM, Hannes Reinecke wrote:
We should return the actual error code in st_scsi_execute(),
avoiding the need to use DRIVER_ERROR.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/st.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/st.c b/dri
On 10/21/19 2:53 AM, Hannes Reinecke wrote:
@@ -6021,43 +6015,28 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp,
ADV_SCSI_REQ_Q *scsiqp)
ASC_DBG(2, "SAM_STAT_CHECK_CONDITION\n");
ASC_DBG_PRT_SENSE(2, scp->sense_buffer,
On 2019-10-18 03:01, zhengbin wrote:
> @@ -1648,16 +1651,20 @@ static int sd_sync_cache(struct scsi_disk *sdkp,
> struct scsi_sense_hdr *sshdr)
> if (res) {
> sd_print_result(sdkp, "Synchronize Cache(10) failed", res);
>
> - if (driver_byte(res) == DRIVER_SENSE)
>
On 2019-10-11 20:25, zhengbin wrote:
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 5447738..d5e29c5 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -255,6 +255,13 @@ int __scsi_execute(struct scsi_device *sdev, const
> unsigned char *cmd,
>
ntribute the test case to the blktests project. Anyway:
Reviewed-by: Bart Van Assche
On 10/10/19 5:05 AM, zhengbin wrote:
+ /*
+* need to initial sshdr to avoid uninit-value access
+*/
+ if (sshdr)
+ memset(sshdr, 0, sizeof(struct scsi_sense_hdr));
+
I think the above comment is slightly confusing because it is correct
for some callers
On 10/10/19 8:07 PM, zhengbin (A) wrote:
Besides, scsi_sense_hdr is just 8 bytes, memset it to 0 will not affect
performance
That's true ...
Bart.
On 10/10/19 5:05 AM, zhengbin wrote:
kmsan report a warning in 5.1-rc4:
BUG: KMSAN: uninit-value in sr_get_events drivers/scsi/sr.c:207 [inline]
BUG: KMSAN: uninit-value in sr_check_events+0x2cf/0x1090 drivers/scsi/sr.c:243
CPU: 1 PID: 13858 Comm: syz-executor.0 Tainted: GB 5.1.0
Cc:
Fixes: 085e56766f74 ("scsi: ch: add refcounting")
Signed-off-by: Bart Van Assche
---
drivers/scsi/ch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index 5f8153c37f77..76751d6c7f0d 100644
--- a/drivers/scsi/ch.c
+++ b/drivers/scsi/ch.c
@@
ly and don't need to
evaluate the RTPG data (which we won't have anyway).
Reviewed-by: Bart Van Assche
On 10/9/19 2:32 AM, Ming Lei wrote:
Cc: Bart Van Assche
As one can see in the .mailmap file in the kernel tree I use my @acm.org
email address for kernel contributions. The above email address is no
longer valid since I left WDC more than a year ago.
Otherwise this patch looks fine to me
On 10/9/19 2:32 AM, Ming Lei wrote:
@@ -354,7 +354,8 @@ void scsi_device_unbusy(struct scsi_device *sdev, struct
scsi_cmnd *cmd)
if (starget->can_queue > 0)
atomic_dec(&starget->target_busy);
- atomic_dec(&sdev->device_busy);
+ if (!blk_queue_nonrot(sdev->reques
On 2019-10-06 00:44, Ming Lei wrote:
> +struct scsi_host_mq_in_flight {
> + int cnt;
> +};
Is this structure useful? Have you considered to use the 'int' datatype
directly and to leave out struct scsi_host_mq_in_flight?
> /**
> * scsi_host_busy - Return the host busy counter
> * @shost:
nown problems are fixed in your tree.
>
> v2: check loop condition only once (Bart van Assche)
>
> Commit message follows:
>
> Fix two issues with the previously submitted patch
> "qla2xxx: Optimize NPIV tear down process": a missing negation
> in a wait_eve
On 10/1/19 8:27 PM, Douglas Gilbert wrote:
- kt = ns_to_ktime((u64)delta_jiff * (NSEC_PER_SEC / HZ));
- } else
- kt = ndelay;
+ u64 ns = jiffies_to_nsecs(delta_jiff);
+
+ if (sdebug_random && ns
in scsi_eh_prep_cmnd() after saving the original
command value in struct scsi_eh_save.
Reviewed-by: Bart Van Assche
On 10/2/19 8:25 AM, Martin Wilck wrote:
> On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote:
>>
>> Both loops check the loop termination condition twice. Has it been
>> considered to write these loops such that the loop termination
>> condition
>> is
On 10/2/19 7:35 AM, Martin Wilck wrote:
> From: Martin Wilck
>
> Hello Martin,
>
> this patch fixes two issues in patch 02/14 in Himanshu's latest
> qla2xxx series ("qla2xxx: Bug fixes for the driver") from
> Sept. 12th, which you applied onto 5.4/scsi-fixes already.
> See https://marc.info/?l=l
On 9/12/19 11:09 AM, Himanshu Madhani wrote:
From: Quinn Tran
There are instances, though rare, where a LOGO request
cannot be sent out and the thread in free session done
can wait indefinitely. Fix this by putting an upper
bound to sleep.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Mad
On 9/27/19 7:04 AM, Douglas Gilbert wrote:
Add an option to use the given command delay (in nanoseconds)
as the upper limit for command durations. A pseudo random
number generator chooses each duration from the range:
[0..delay_in_ns)
Main benefit: allows testing with out-of-order respons
On 2019-09-26 09:22, Ryan Attard wrote:
> Add sysfs attributes for the ATA information page and
> Supported VPD Pages page.
Reviewed-by: Bart Van Assche
On 9/25/19 11:02 AM, Ryan Attard wrote:
static struct bin_attribute *scsi_sdev_bin_attrs[] = {
+ &dev_attr_vpd_pg0,
&dev_attr_vpd_pg83,
&dev_attr_vpd_pg80,
+ &dev_attr_vpd_pg89,
&dev_attr_inquiry,
NULL
};
diff --git a/include/scsi/scsi_device.h b/in
sable depth for disk events */
The "_on" part in the variable name "rpm_autosuspend_on" is probably
redundant and the comment could have been more elaborate. Anyway:
Reviewed-by: Bart Van Assche
On 9/12/19 7:35 AM, Stanley Chu wrote:
> Enable auto suspend capability in MediaTek UFS driver.
>
> Signed-off-by: Stanley Chu
> Reviewed-by: Avri Altman
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/dr
On 9/12/19 7:35 AM, Stanley Chu wrote:
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 64c96c7828ee..461aafadd208 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -1300,7 +1300,8 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
>
On 9/12/19 1:39 AM, Roman Bolshakov wrote:
> This series has a few bug fixes for the driver.
>
> Note, #1 only fixes the crash in the kernel. The complete fix for clean
> ACL deletion from initiator side is in works and requires a discussion.
>
> As of now initiator is not aware that target no lo
On 8/20/19 8:27 AM, Mike Christie wrote:
tcm loop does not take a reference to the scsi_device at creation/link
time then need to release at removal/unlink time. The above
scsi_device_put is for the successful scsi_device_lookup call. tcm loop
works like a scsi host driver that does its own scann
On 8/20/19 2:04 AM, Naohiro Aota wrote:
If there is no corresponding scsi_device for a LUN,
tcm_loop_port_unlink() complains that it "Unable to locate struct
scsi_device for " the device and keep %tl_tpg_port_count as is. However,
such situation is legal when we delete a SCSI device using
/sys/cl
Van Assche
---
drivers/scsi/qla2xxx/qla_isr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index cd39ac18c5fd..d81b5ecce24b 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2780,8 +2780,6
On 8/12/19 8:35 PM, zhengbin wrote:
KASAN reports a use-after-free in 4.19-stable,
which won't happen after commit 47cdee29ef9d
("block: move blk_exit_queue into __blk_release_queue").
This patch doesn't apply on top of kernel v4.19.67:
$ git am ~/\[PATCH\ v4\]\ SCSI\:\ fix\ queue\ cleanup\ ra
On 8/14/19 6:50 PM, zhengbin (A) wrote:
ping
Sending a "ping" after 46 hours is way too soon and only causes
irritation. What would help though is more information about how this
patch has been tested. Does it e.g. survive the srp tests in blktests?
Thanks,
Bart.
On 7/24/19 10:46 PM, Wang Xiayang wrote:
As commit a86028f8e3ee ("staging: most: sound: replace snprintf
with strscpy") suggested, using snprintf without a format specifier
is potentially risky if a0->vendor_name or a0->vendor_pn mistakenly
contain format specifiers. In addition, as compared in t
On 8/12/19 1:52 PM, Roman Bolshakov wrote:
On Thu, Aug 08, 2019 at 08:02:07PM -0700, Bart Van Assche wrote:
Avoid that this function crashes if mcmd == NULL.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1
On 8/11/19 7:06 PM, zhengbin wrote:
KASAN reports a use-after-free in 4.19-stable,
which won't happen after commit 47cdee29ef9d
("block: move blk_exit_queue into __blk_release_queue").
However, backport this patch to 4.19-stable will be a lot of work and
the risk is great. Moreover, we should mak
On 8/9/19 2:03 AM, zhengbin wrote:
> KASAN reports a use-after-free in 4.19-stable,
> which won't happen after commit 47cdee29ef9d
> ("block: move blk_exit_queue into __blk_release_queue").
> However, backport this patch to 4.19-stable will be a lot of work and
> the risk is great. Moreover, we sho
() function because it is never called.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 17 -
drivers/scsi/qla2xxx/qla_gbl.h | 6 +-
drivers/scsi/qla2xxx/qla_gs.c | 15 ++--
drivers/scsi/qla2xxx/qla_init.c | 131
This patch reduces code duplication.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 2 +-
drivers/scsi/qla2xxx/qla_gbl.h | 2 ++
drivers/scsi/qla2xxx/qla_gs.c | 12 +-
drivers/scsi/qla2xxx/qla_iocb.c | 40
E N2N handling into state
machine") # v4.19.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_iocb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 7021fbeb6d23..e9
mailbox interface") # v4.16.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index
Make the code easier to read by converting 'goto' statements into
'return' statements.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/
It is easy to mix up the QLA_* and the MBS_* status codes. Complain loudly
if that happens.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 5 +
drivers/scsi/qla2xxx/qla_init.c | 9 +
2 files changed, 14 insertions(+)
diff --git a/drivers
Make it clear to humans and also to the compiler that the string passed
as fourth argument is not modified.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gbl.h | 4 ++--
drivers/scsi/qla2xxx/qla_init.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions
Split srb_cmd.ctx into two pointers such that the compiler can check
the type of that pointer.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 4 ++--
drivers/scsi/qla2xxx/qla_iocb.c | 20 +---
drivers/scsi/qla2xxx/qla_nx.c | 2
This patch reduces code duplication.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gbl.h | 1 +
drivers/scsi/qla2xxx/qla_iocb.c | 128 +---
drivers/scsi/qla2xxx/qla_mr.c | 13 +---
drivers/scsi/qla2xxx/qla_nvme.c | 14
This patch fixes several gcc complaints about string truncation.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mr.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi
This patch does not change any functionality.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 5ec3c2b96f3f
This change makes it easier to detect qla24xx_read_flash_data() failures
and also to handle such failures. This change does not modify the behavior
of the driver since all callers ignore the qla24xx_read_flash_data()
return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers
Since struct sg_table is used in nvme-fc-driver.h, include
from that header file.
Since no definitions or declarations from are used in
the qla_nvme.h header file, do not include from that
header file.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nvme.h
This patch does not change any functionality but makes the next patch
easier to read.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_inline.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi
This was detected by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 37e24987c852..2ba06a84c501 100644
--- a
but improves source code readability and also allows the
compiler to verify the endianness of Fibre Channel IDs.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 71 ++--
drivers/scsi/qla2xxx/qla_gs.c | 62 --
drivers/scsi
This patch fixes several Coverity complaints about not always checking
the qla2x00_wait_for_hba_online() return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_attr.c | 3 ++-
drivers/scsi/qla2xxx/qla_target.c | 7 +--
2 files changed, 7 insertions
Pass the output buffer size to the code that generates a PCI info string
and check the output buffer size while generating a PCI info string.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_attr.c | 3 +-
drivers/scsi/qla2xxx/qla_def.h | 2 +-
drivers/scsi
Read the FC port state once instead of twice. This patch fixes the
following Coverity complaint:
Unchecked return value (CHECKED_RETURN)
check_return: Calling atomic_read without checking return value (as is
done elsewhere 80 out of 92 times).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
be equal to 0.
dead_error_condition: The condition req_data_len != rsp_data_len cannot be
true.
Cc: Himanshu Madhani
Fixes: a9b6f722f62d ("[SCSI] qla2xxx: Implementation of bidirectional.") # v3.7.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_bsg.c | 11 +--
1 fi
Not calling sp->done() from the command completion path is a severe bug.
Hence complain loudly if that happens.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 4
drivers/scsi/qla2xxx/qla_isr.c | 4
drivers/scsi/qla2xxx/qla_mr.c
expects an expression of type
uint64_t (64 bits, unsigned).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index
n issue between qla2xxx
and TCM") # v4.5.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 13 -
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xx
This patch fixes several Coverity complaints about reading data that
has not been initialized.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b
The C language supports implicit casting of void pointers to non-void
pointers. Remove explicit sts_entry_* casts that are not necessary.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_isr.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions
According to the firmware documentation the firmware expects all ELS
pass-through IOCB parameters in little endian format. Make this explicit.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_fw.h | 8
drivers/scsi/qla2xxx/qla_iocb.c | 7 ---
2
scsi_remove_host() is called before queue pairs are deleted
and scsi_remove_host() waits for all outstanding SCSI commands to finish.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 1 -
drivers/scsi/qla2xxx/qla_os.c | 45
Make sure that locking assumptions are verified at runtime if kernel
debugging is enabled.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi
Failure of a soft reset is a severe failure. Hence report such failures.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_tmpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
It is helpful when debugging this driver to have the firmware status
code available if a mailbox command fails. Hence report that firmware
status code.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mbx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
Avoid that this function crashes if mcmd == NULL.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_target.c
index
This patch makes it clear to humans and also to the compiler that
ql_dump_buffer() does not modify the memory the @buf argument points at.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_dbg.c | 3 ++-
drivers/scsi/qla2xxx/qla_gbl.h | 2 +-
2 files changed, 3
According to the firmware documentation responder mode must be set for
ELS pass-through IOCBs if a response is expected.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_iocb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi
The value returned by this function is not used. Hence change the
return type of this function into 'void' and remove the return
statement.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Pass the correct session ID to find_sess_by_s_id() instead of passing
an uninitialized variable.
Cc: Himanshu Madhani
Fixes: 2d70c103fd2a ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >=
24xx series") # v3.5.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla
Since sess == NULL before 'goto out_term2' is executed, the code under
'if (sess)' cannot be reached. Hence remove that code. This was detected
by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 3 ---
1 file changed,
Instead of explicitly checking whether a timeout has occurred, ignore
the del_timer() return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx
Since qlt_make_local_sess() is defined before it is called, remove the
forward declaration of that function.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b
.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_bsg.c| 8 ++-
drivers/scsi/qla2xxx/qla_def.h| 14 +--
drivers/scsi/qla2xxx/qla_gbl.h| 14 +--
drivers/scsi/qla2xxx/qla_gs.c | 21 ++--
drivers/scsi/qla2xxx
This patch fixes a Coverity complaint about not checking the sscanf()
return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_tmpl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi
Checking a pointer after it has been dereferenced is not useful. This was
detected by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers
This patch fixes the following Coverity complaint:
Unchecked return value (CHECKED_RETURN)
check_return: Calling wait_for_completion_timeout without checking return
value (as is done elsewhere 14 out of 17 times).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx
Use the same approach for encoding the destination ID as the approach
used by qlt_update_vp_map().
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx
ailed.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 3 ++-
drivers/scsi/qla2xxx/qla_nx.c | 4 +++-
drivers/scsi/qla2xxx/qla_os.c | 7 +--
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/sc
This patch makes the string manipulation code easier to verify.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 18 ++
drivers/scsi/qla2xxx/qla_mr.c | 6 --
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers
Simplify the implementation of this function by using the %phC format
specifier instead of using explicit for-loops.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a
Delete the PLOGIN ACK data structure from the vha->plogi_ack_list before
freeing that data structure to avoid that that list gets corrupted.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 8 ++--
drivers/scsi/qla2xxx/qla_target.c | 4 +++-
Make it clear that the CDB is not modified after processing of a SCSI
command has started.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.h
b/drivers
This patch makes the code that parses the GID list easier to read
without changing the behavior of the code.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_dfs.c| 9 +++--
drivers/scsi/qla2xxx/qla_init.c | 18 --
drivers/scsi/qla2xxx
This patch does not change any functionality but fixes a Coverity
complaint about using a scalar as an array.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h| 4 ++--
drivers/scsi/qla2xxx/qla_iocb.c | 4 ++--
drivers/scsi/qla2xxx/qla_target.c | 4
ull pointer &vha->vha_tgt.qla_tgt->tgt_list_entry
to list_del, which dereferences it.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b
This patch makes it clear that the tag, hwq and qpair variables are
only used in the mq path.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers
SCSI
command completion.
- Since qla2xxx_eh_abort() increments the sp reference count by calling
sp_get(), decrement the sp reference count before returning.
Cc: Himanshu Madhani
Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for
aborting SCSI commands")
Signed-o
Insert a space where required, surround complex expressions in macros
with parentheses, use the UL suffix instead of the (unsigned long) cast,
do not use line continuations when not necessary and do not explicitly
initialize static variables to zero.
Cc: Himanshu Madhani
Signed-off-by: Bart Van
Since qla2x00_abort_srb() starts with increasing the reference count of
@sp, decrease that same reference count before returning.
Cc: Himanshu Madhani
Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for
aborting SCSI commands") # v5.2.
Signed-off-by: Bart
function.
Bart Van Assche (58):
qla2xxx: Make qla2x00_abort_srb() again decrease the sp reference
count
qla2xxx: Really fix qla2xxx_eh_abort()
qla2xxx: Improve Linux kernel coding style conformance
qla2xxx: Use tabs instead of spaces for indentation
qla2xxx: Include the header file
This patch only modifies whitespace.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 78 +--
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
Since the put_unaligned_*() macros are used in this header file, include
the header file that defines these macros.
Cc: Himanshu Madhani
Fixes: 15b7a68c1d03 ("scsi: qla2xxx: Introduce the dsd32 and dsd64 data
structures") # v5.2-rc1.
Signed-off-by: Bart Van Assche
---
drivers/sc
There is no bsg code in the qla_mr.c source file. Hence do not include
the header file from qla_mr.c.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx
art Van Assche
BTW, these two patches fix several nvmeof-mp blktests regressions.
Bart.
If scsi_target_block() fails that can break the code that calls this
function. Hence complain loudly if scsi_target_block() fails.
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
Signed-off-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 7 ++-
1 file
() and moved the WARN_ONCE() statement into device_block().
Bart Van Assche (3):
Make scsi_internal_device_unblock_nowait() reject invalid new_state
values
Complain if scsi_target_block() fails
Reduce memory required for SCSI logging
drivers/scsi/scsi_lib.c | 15 +++-
drivers
("scsi: Implement per-cpu logging buffer") # v4.0.
Reported-by: Jan Palus
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
Cc: Jan Palus
Signed-off-by: Bart Van Assche
---
drivers/scsi/scsi_logging.c | 48 +++--
in
1 - 100 of 3375 matches
Mail list logo
