Re: [PATCH v2 26/79] docs: powerpc: convert docs to ReST and rename to *.rst

2019-04-23 Thread Andrew Donnellan
phan: while this is not linked to the main index.rst file, in order to avoid build warnings. Signed-off-by: Mauro Carvalho Chehab Acked-by: Andrew Donnellan # cxl Minor possible improvement below, otherwise compiled output looks very nice. diff --git a/Documentation/powerpc/cxl.txt b

Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption

2018-12-04 Thread Andrew Morton
On Tue, 4 Dec 2018 12:18:01 -0800 Matthew Wilcox wrote: > On Tue, Dec 04, 2018 at 12:14:43PM -0800, Andrew Morton wrote: > > On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby > > wrote: > > > > > On 11/13/18 1:36 AM, Matthew Wilcox wrote: > > > > On M

Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption

2018-12-04 Thread Andrew Morton
er corrupts DMA pool memory. > >> > >> Signed-off-by: Tony Battersby > > I like it! Also, here you're using blks_per_alloc in a way which isn't > > normally in the performance path, but might be with the right config > > options. With that, I withdraw my objection t

Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

2018-09-12 Thread Andrew Donnellan
other architectures, compat_ptr() does not do anything, but using the new generic_compat_ioctl_ptrarg helper makes it more correct in theory, and simplifies the code. Signed-off-by: Arnd Bergmann For cxl: Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel..

Re: simplify procfs code for seq_file instances

2018-04-24 Thread Andrew Morton
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote: > On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > > git://git.infradead.org/users/hch/misc.git proc_create > > > > > > I want to ask if it is time to start using poorman function overloading > > with _b_c_e().

Re: [PATCH v2 00/38] cxlflash: OCXL transport support

2018-03-08 Thread Andrew Donnellan
function independent of the existing core driver that communicates with the AFU. This one has been sitting for a week without any reviews. Andrew, when will you have time to take a look? > Being a pretty big chunk of code, I would like to merge it sooner rather than later. Or we can postpone until 4

Re: [PATCH v2 10/38] cxlflash: Setup AFU PASID

2018-03-08 Thread Andrew Donnellan
range is used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 09/38] cxlflash: Setup AFU acTag range

2018-03-08 Thread Andrew Donnellan
. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h index f6af247..9c675fa 100644 --- a/drivers/scsi/cxlflash/ocxl_hw.h +++ b/drivers/scsi/cxlflash/ocxl_hw.h @@ -22,4 +22,6

Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration

2018-03-08 Thread Andrew Donnellan
On 27/02/18 09:21, Uma Krishnan wrote: The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Andrew

Re: [PATCH v2 07/38] cxlflash: Setup function acTag range

2018-03-08 Thread Andrew Donnellan
. For cxlflash devices only a single function per host is expected and thus the entire range is assigned. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h index 658f420..190d71a

Re: [PATCH v2 06/38] cxlflash: Read host function configuration

2018-03-06 Thread Andrew Donnellan
Reviewed-by: Andrew Donnellan --- drivers/scsi/cxlflash/ocxl_hw.c | 41 + drivers/scsi/cxlflash/ocxl_hw.h | 2 ++ 2 files changed, 43 insertions(+) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index e3a0a9b..dc32a73

Re: [PATCH v2 05/38] cxlflash: Hardware AFU for OCXL

2018-03-06 Thread Andrew Donnellan
exit paths of the driver. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs One comment below Reviewed-by: Andrew Donnellan --- drivers/scsi/cxlflash/backend.h | 1 + drivers/scsi/cxlflash/cxl_hw.c | 6 ++ drivers/scsi/cxlflash/main.c| 9 +++-- drivers/scsi/cxlflash

Re: [PATCH v2 04/38] cxlflash: Introduce OCXL backend

2018-03-06 Thread Andrew Donnellan
my response to the first version of this series, at some point we might want to make this not depend on OCXL in all cases, but I don't feel strongly on that. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 04/38] cxlflash: Introduce OpenCXL backend

2018-02-22 Thread Andrew Donnellan
to depend on OCXL in all cases? IMHO it should be possible to build a cxl-only version without ocxl, though I don't feel very strongly on this. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 00/38] cxlflash: OpenCXL transport support

2018-02-22 Thread Andrew Donnellan
ch of the ocxl-specific stuff as I can get to, though I'm a bit busy with the OpenCAPI skiboot work and reviewing the libocxl userspace library at the moment. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Reply

2018-01-23 Thread Andrew
Dear Sir, I am Andrew Wetkas.Personal Assistant to a former Governor in Nigeria. We need your assistance to invest a huge sum in your country. I will give you further details once I hear from you. Regards Andrew

Re: [PATCH 1/6] cxlflash: Reset command ioasc

2018-01-03 Thread Andrew Donnellan
md->sa.ioasc = 0; cmd->rcb.ctx_id = hwq->ctx_hndl; cmd->rcb.msi = SISL_MSI_RRQ_UPDATED; cmd->rcb.port_sel = CHAN2PORTMASK(scp->device->channel); -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread Andrew Lunn
at the cas_alloc_rxds level, you also need a fix at the next level up: err = -ENOMEM; if (cas_tx_tiny_alloc(cp) < 0) goto err_unlock; /* alloc rx descriptors */ if (cas_alloc_rxds(cp) < 0) goto err_tx_tiny; again, the return value is discarded. Andrew

Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-13 Thread Andrew Lunn
by bond_open() with: if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) return -ENOMEM; So you might want to also modify this code, to return the return value, rather than use the hard coded ENOMEM. Since you code is OK as far as it goes: Reviewed-by: And

Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'

2017-08-15 Thread Andrew Donnellan
On 16/08/17 06:18, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'create_context()' fails, returns -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET ENOMEM seems right here. Reviewed-by: Andrew Donnellan --- d

Re: [PATCH 10/17] cxlflash: Fence EEH during probe

2017-04-12 Thread Andrew Donnellan
is flushed during device removal to avoid orphaned threads. Signed-off-by: Matthew R. Ochs Signed-off-by: Uma Krishnan The use of the term "fence" in the commit message might be a bit confusing given how the term is already used in the context of EEH :) Andrew -- Andrew Donnellan

Re: [PATCH 0/4] cxlflash: Enhancements, cleanup and fixes

2017-01-09 Thread Andrew Donnellan
On 10/01/17 16:00, Martin K. Petersen wrote: The first three patches in the series were submitted by you but do not carry your Signed-off-by:... hmm, over in linuxppc-land I don't think we particularly enforce this. Thanks for the reminder! -- Andrew Donnellan OzLabs

Re: [PATCH 3/4] cxlflash: Cleanup prints

2017-01-08 Thread Andrew Donnellan
strictly print-related. :) Signed-off-by: Matthew R. Ochs An impressive cleanup! Nothing bad which stands out to me. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited -- To unsubscribe from this list

Re: [PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

2016-09-05 Thread Andrew Donnellan
lash_remove, - .shutdown = cxlflash_shutdown, + .shutdown = cxlflash_remove, What's the justification for using cxlflash_remove() as the shutdown hook, rather than just not having a shutdown hook at all? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ib

Re: [PATCH 1/2] wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE

2016-09-02 Thread Andrew Morton
On Fri, 02 Sep 2016 06:36:05 -0400 "Martin K. Petersen" wrote: > > "Joe" == Joe Perches writes: > > Joe> Convert it to the preferred const struct pci_device_id instead. > > Applied to 4.9/scsi-queue. That creates an ordering dependency between the scsi tree and -mm's "treewide: remove re

Re: Dirty/Writeback fields in /proc/meminfo affected by 20d74bf29c

2016-08-04 Thread Andrew Morton
On Mon, 1 Aug 2016 04:36:28 +0200 Tomas Vondra wrote: > Hi, > > While investigating a strange OOM issue on the 3.18.x branch (which > turned out to be already fixed by 52c84a95), I've noticed a strange > difference in Dirty/Writeback fields in /proc/meminfo depending on > kernel version. I'm

Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown

2016-07-21 Thread Andrew Donnellan
ed. Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") Signed-off-by: Uma Krishnan Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited -- To unsubscribe from this list: send t

Re: [PATCH v2] cxl: remove dead Kconfig options

2016-07-17 Thread Andrew Donnellan
On 18/07/16 14:52, Andrew Donnellan wrote: Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn&#

[PATCH v2] cxl: remove dead Kconfig options

2016-07-17 Thread Andrew Donnellan
unsie Signed-off-by: Andrew Donnellan Acked-by: Ian Munsie Acked-by: Matthew R. Ochs --- Applies on top of powerpc#next, now that the Mellanox CX-4 patches have been applied. --- drivers/misc/cxl/Kconfig | 10 -- drivers/scsi/cxlflash/main.h | 4 2 files changed, 14 dele

Re: [PATCH] cxl: remove dead Kconfig options

2016-07-13 Thread Andrew Donnellan
On 14/07/16 12:05, Andrew Donnellan wrote: Sorry for not stating explicitly - I'd like this taken through powerpc as the cxlflash change is incidental to the cxl changes. I'll also be submitting a v2 that applies on top of another cxl series that hasn't been merged yet. -- A

Re: [PATCH] cxl: remove dead Kconfig options

2016-07-13 Thread Andrew Donnellan
On 14/07/16 12:02, Martin K. Petersen wrote: "Andrew" == Andrew Donnellan writes: Andrew> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they Andrew> were only needed to coordinate the merging of the cxlflash Andrew> driver. Also remove the stub imple

Re: [PATCH] cxl: remove dead Kconfig options

2016-07-08 Thread Andrew Donnellan
On 04/07/16 17:12, Andrew Donnellan wrote: Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn&#

[PATCH] cxl: remove dead Kconfig options

2016-07-04 Thread Andrew Donnellan
unsie Signed-off-by: Andrew Donnellan --- Applies on top of powerpc#next --- drivers/misc/cxl/Kconfig | 10 -- drivers/scsi/cxlflash/main.h | 4 2 files changed, 14 deletions(-) diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kconfig index 560412c..0cb10cf 100644

Re: [PATCH] sd: Fix rw_max for devices that report an optimal xfer size

2016-06-01 Thread Andrew Patterson
ttp://vger.kernel.org/majordomo-info.html > I tested this patch on a 3Par array (32K optimal transfer length) that has issues without this patch. After applying this patch on a linux-stable kernel, optimal_io_size is correctly reported as 32K. Tested-by: Andrew Patterson -- Andrew Patterso

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > This is another attempt to avoid a regression in wwn_to_u64() after > > > that

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > This is another attempt to avoid a regression in wwn_to_u64() after > that started using get_unaligned_be64(), which in turn ran into a > bug on gcc-4.9 through 6.1. I'm still getting a couple screenfuls of things like net/tipc/name_dist

bnx2x: bnx2fc: FC-NPIV table with bad length

2016-03-14 Thread Andrew Patterson
bfc,bnx2fc,scsi_dh_emc,sd_mod The CNA is running 2.16.20 firmware and is in an HP Proliant bl460gen9 blade. -- Andrew Patterson Hewlett-Packard Enterprise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Andrew Morton
On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" wrote: > Let's mark the VMA as VM_IO to indicate to mm core that the VMA is > migratable. > > ... > > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -1261,7 +1261,7 @@ sg_mmap(struct file *filp, struct vm_area_struct *vma) >

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Andrew Morton
On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" wrote: > The patch below fixes the issue for me, but this bug makes me wounder how > many bugs like this we have in kernel... :-/ > > Looks like we are too permissive about which VMA is migratable: > vma_migratable() filters out VMA by VM_

Re: [PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-14 Thread Andrew Donnellan
e of later code changes, all looks good. Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list: send the li

Re: [PATCH v2 4/6] cxlflash: Fix to resolve cmd leak after host reset

2015-12-14 Thread Andrew Donnellan
onable. Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

2015-12-14 Thread Andrew Donnellan
On 15/12/15 08:06, Uma Krishnan wrote: Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by: Uma Krishnan Reviewed-by: Andrew Donnellan -- Andrew Donnellan

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-13 Thread Andrew Donnellan
Without the card-specific code, how does the driver behave if the new card is plugged in? Andrew -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from

Re: [PATCH v6 35/37] cxlflash: Fix to avoid corrupting port selection mask

2015-10-22 Thread Andrew Donnellan
On 22/10/15 07:16, Matthew R. Ochs wrote: The port selection mask of a LUN can be corrupted when the manage LUN ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device. > ... Signed-off-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan -- Andrew Donnel

Re: [PATCH v6 16/37] cxlflash: Fix async interrupt bypass logic

2015-10-22 Thread Andrew Donnellan
evaluation for an unset bit. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work

Re: [PATCH v6 36/37] cxlflash: Fix to avoid lock instrumentation rejection

2015-10-22 Thread Andrew Donnellan
tmf_slock during probe. Signed-off-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list

Re: [PATCH v6 37/37] cxlflash: Fix to avoid bypassing context cleanup

2015-10-21 Thread Andrew Donnellan
ff-by: Matthew R. Ochs Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v5 33/34] cxlflash: Fix to avoid leaving dangling interrupt resources

2015-10-05 Thread Andrew Donnellan
error gates at the bottom of the function and the appropriate goto is added to each error path. As a mini side fix while refactoring in this routine, the else statement following the AFU version evaluation is eliminated as it is not needed. Signed-off-by: Matthew R. Ochs Reviewed-by: Andrew

Re: [PATCH v4 02/32] cxlflash: Replace magic numbers with literals

2015-09-28 Thread Andrew Donnellan
-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list: send the

Re: [PATCH v4 12/32] cxlflash: Fix to avoid spamming the kernel log

2015-09-28 Thread Andrew Donnellan
changes were made: - pr_debug to pr_devel - pr_debug to pr_debug_ratelimited - pr_err to dev_err - pr_debug to dev_dbg Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan Changes mostly look fine, further comments below

Re: [PATCH v4 23/32] cxlflash: Fix function prolog parameters and return codes

2015-09-28 Thread Andrew Donnellan
and return codes. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan See further comments below. --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -401,8 +401,7 @@ static void wait_resp(struct afu *afu

Re: [PATCH v4 11/32] cxlflash: Refine host/device attributes

2015-09-28 Thread Andrew Donnellan
Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King The commit message could explain the patch a bit better. Andrew -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited

Re: [PATCH v4 24/32] cxlflash: Fix MMIO and endianness errors

2015-09-28 Thread Andrew Donnellan
clean. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia

Re: [PATCH v4 31/32] cxlflash: Correct trace string

2015-09-28 Thread Andrew Donnellan
Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this

Re: [PATCH v4 29/32] cxlflash: Fix to double the delay each time

2015-09-28 Thread Andrew Donnellan
Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Limited -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v4 26/32] cxlflash: Correct spelling, grammar, and alignment mistakes

2015-09-28 Thread Andrew Donnellan
issues. Update some comments for clarity and consistency. Remove extra lines and a few unneeded variables/statements. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs

Re: [PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-28 Thread Andrew Donnellan
s not require an embedded fops. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work)IBM Australia Li

Re: [PATCH v3 29/32] MAINTAINERS: Add cxlflash driver

2015-09-24 Thread Andrew Donnellan
On 25/09/15 05:44, Matthew R. Ochs wrote: Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b

Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Andrew Cooper
avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http:

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-20 Thread Andrew Morton
On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann wrote: > The recent change to mark the input argument of sg_pcopy_from_buffer > had the unfortunate side-effect to cause a new warning in the > scsi_debug code: > > drivers/scsi/scsi_debug.c: In function 'do_device_access': > drivers/scsi/scsi_deb

Re: [PATCH] scatterlist: enable sg chaining for all architectures

2015-04-28 Thread Andrew Morton
On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita wrote: > Some architectures enable sg chaining option while others do not. > > The requirement to enable sg chaining is that pages must be aligned > at a 32-bit boundary in order to overload the LSB of the pointer. > Regardless of whether ARCH_HAS_

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-13 Thread Andrew Morton
On Fri, 13 Feb 2015 16:05:54 -0800 James Bottomley wrote: > @@ -42,31 +44,60 @@ void string_get_size(u64 size, const enum > string_size_units units, > [STRING_UNITS_2] = 1024, > }; > int i, j; > - u32 remainder = 0, sf_cap; > + u32 remainder = 0, sf_cap, exp; >

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-12 Thread Andrew Morton
On Thu, 12 Feb 2015 15:45:29 -0800 James Bottomley wrote: > ... > > > I don't get it. As the man says, this is presently dead code and > > string_get_size() will need to be changed to work for disks larger than > > 2^64 bytes. That change may be to take a u128 or it may be as you > > suggest:

Re: [patch 069/104] lib/string_helpers.c:string_get_size(): remove redundant prefixes

2015-02-12 Thread Andrew Morton
On Thu, 12 Feb 2015 15:25:08 -0800 James Bottomley wrote: > On Thu, 2015-02-12 at 15:01 -0800, a...@linux-foundation.org wrote: > > From: Rasmus Villemoes > > Subject: lib/string_helpers.c:string_get_size(): remove redundant prefixes > > > > While 3c9f3681d0b4 "[SCSI] lib: add generic helper t

Re: Tagged overlapped commands

2014-12-17 Thread Andrew Brooks
On 1 December 2014 at 12:22, Andrew Brooks wrote: > I'm having trouble writing to an LTO-5 tape drive connected via Adaptec 1405 > Writing aborts with this in syslog: > > st0: Sense Key : Aborted Command [current] > st0: Add. Sense: Tagged overlapped commands (task tag 0) &g

Re: Tagged overlapped commands

2014-12-16 Thread Andrew Brooks
On 8 December 2014 at 07:02, James Bottomley wrote: > > The error message likely means that the tape device had more than one > command outstanding at once (i.e. one command was sent while the current > command was still pending). It could also mean that a tag got re-used > (same tag issued while

Re: Tagged overlapped commands

2014-12-04 Thread Andrew Brooks
On 1 December 2014 at 12:24, Andrew Brooks wrote: > > I'm having trouble writing to an LTO-5 tape drive connected via Adaptec 1405 > Writing aborts with this in syslog: > > st0: Sense Key : Aborted Command [current] > st0: Add. Sense: Tagged overlapped commands (task tag 0)

Tagged overlapped commands

2014-12-01 Thread Andrew Brooks
untu 12.04 (3.2.0-70) and the latest fedora 20.1. Does anyone have any ideas on how to troubleshoot and fix this? Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Fwd: Adaptec 71605H HBA randomly failing to detect any drives at init

2014-09-01 Thread Andrew Robertson
Hi, I have an Adaptec 71605H HBA that's randomly failing to detect any drives at boot. I have two systems with this HBA, and both are showing the exact same behavior. I can reproduce this randomly about 3 out of 4 times, where most of the time it comes up where "lsscsi" shows no drives attached

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-22 Thread Andrew Morton
On Wed, 22 Jan 2014 11:30:19 -0800 James Bottomley wrote: > But this, I think, is the fundamental point for debate. If we can pull > alignment and other tricks to solve 99% of the problem is there a need > for radical VM surgery? Is there anything coming down the pipe in the > future that may

Re: [PATCH 1/1] remove cpqarray from mainline kernel

2013-10-17 Thread Andrew Morton
On Thu, 17 Oct 2013 12:52:26 -0500 Mike Miller wrote: > cpqarray hasn't been used in over 12 years. It's doubtful that anyone still > uses the board. It's time the driver was removed from the mainline kernel. > The only updates these days are minor and mostly done by people outside of HP. It's a

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Andrew Morton
On Mon, 01 Jul 2013 15:24:11 -0700 James Bottomley wrote: > > --- a/block/blk-core.c~block-fix-possible-sleep-in-invalid-context-fix > > +++ a/block/blk-core.c > > @@ -3159,15 +3159,14 @@ EXPORT_SYMBOL(blk_pre_runtime_resume); > > */ > > void blk_post_runtime_resume(struct request_queue *q, i

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Andrew Morton
On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma wrote: > When block runtime PM is enabled following warning is seen > while resuming the device. > > BUG: sleeping function called from invalid context at > .../drivers/base/power/runtime.c:923 > in_atomic(): 1, irqs_disabled(): 128, pid: 12

Re: [PATCH 1/1] cciss: add cciss_allow_hpsa module parameter

2013-04-22 Thread Andrew Morton
On Thu, 18 Apr 2013 13:49:37 -0500 Mike Miller wrote: > Add the cciss_allow_hpsa modules parameter. This allows users to use the hpsa > driver instead of cciss for older controllers. > Tested with 3.9.0-rc7 in combination with the bug fix submitted Tuesday. My > apologies for not testing that pat

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-17 Thread Andrew Morton
On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > Patch 1/1 > > If hpsa is selected as the Smart Array driver cciss may try to load in the > kdump kernel. When this happens kdump fails and a core file cannot be created. > This patch prevents cciss from trying to load in this scenario. This

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-16 Thread Andrew Morton
On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > Patch 1/1 > > If hpsa is selected as the Smart Array driver cciss may try to load in the > kdump kernel. When this happens kdump fails and a core file cannot be created. > This patch prevents cciss from trying to load in this scenario. This

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread Andrew Vasquez
On Sun, 10 Mar 2013, James Bottomley wrote: > On Sun, 2013-03-10 at 00:57 -0800, Andrew Morton wrote: > > On Sun, 10 Mar 2013 08:22:47 + James Bottomley > > wrote: > > > > > [missing SCSI cc added] > > > On Sun, 2013-03-10 at 17:09 +0900, Akinobu M

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread Andrew Morton
> > > Signed-off-by: Akinobu Mita > > Cc: "James E.J. Bottomley" > > Cc: Andrew Vasquez > > --- > > drivers/scsi/qla2xxx/qla_attr.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/ql

Re: [PATCH][SCSI] hptiop: Support HighPoint RR4520/RR4522 HBA

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 11:28:54 +0800 HighPoint Linux Team wrote: > Support HighPoint RR4520/RR4522 HBAs which are based on Marvell Frey. > > Signed-off-by: HighPoint Linux Team > > Documentation/scsi/hptiop.txt | 69 ++- > drivers/scsi/hptiop.c | 413 >

Re: next-20120925: BUG at drivers/scsi/scsi_lib.c:640!

2012-09-25 Thread Andrew Morton
(cc's added) On Tue, 25 Sep 2012 22:06:37 +0400 Dmitry Monakhov wrote: > > Seems like barriers are broken again > > kernel BUG at drivers/scsi/scsi_lib.c:1180! > invalid opcode: [#1] SMP > Modules linked in: coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel > microcode sg xhci_

Re: [PATCH] fcoe: Remove redundant 'less than zero' check

2012-07-09 Thread Andrew Morton
On Thu, 05 Jul 2012 07:52:25 -0700 Robert Love wrote: > strtoul returns an 'unsigned long' so there is no > reason to check if the value is less than zero. > > strtoul already checks for the '-' character deep > in its bowels. It will return an error if the user > has provided a negative value a

Re: arcmsr & areca-1660 - strange behaviour under heavy load

2008-02-26 Thread Andrew Morton
On Tue, 26 Feb 2008 10:35:31 +0100 (CET) Nikola Ciprich <[EMAIL PROTECTED]> wrote: > Hi > > On Sun, 24 Feb 2008, Andrew Morton wrote: > > Hi Andrew, > thanks a lot for reply, I'm attaching requested information. > please let me know if You need more informat

Re: arcmsr & areca-1660 - strange behaviour under heavy load

2008-02-24 Thread Andrew Morton
On Sat, 23 Feb 2008 12:20:12 +0100 (CET) Nikola Ciprich <[EMAIL PROTECTED]> wrote: > Hi, > > I've found strange problem either in arcmsr driver, or maybe in > areca-1660 card... > When system on SAS discs RAID connected to areca-1660 card > gets under heavy I/O load, it gets unusable after som

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-23 Thread Andrew Morton
On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Sat, 23 Feb 2008, Jeff Garzik wrote: > > > > I know I am probably shooting myself in the foot here, since I am the > > original > > author of mvsas, but... > > > > Should we be adding new drivers duri

Re: LSI Logic MegaRAID SATA 150-4 / LSI Logic New Generation RAID Device Drivers (MEGARAID_NEWGEN) problems (megaraid abort: scsi cmd:14600, do now own)

2008-02-22 Thread Andrew Morton
(cc's added) On Mon, 18 Feb 2008 21:09:22 -0500 "David M. Strang" <[EMAIL PROTECTED]> wrote: > Greetings - > > A couple months back I purchased a LSI Logic MegaRAID ATA 150-4 > controller, as well as 3 Seagate 500GB SATA-II hard drives to use in my > system. Previously, I was using a pair of W

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-21 Thread Andrew Buehler
On 2/21/2008 12:17 PM, Greg KH wrote: On Thu, Feb 21, 2008 at 11:36:23AM -0500, Alan Stern wrote: On Thu, 21 Feb 2008, Andrew Buehler wrote: [Greg KH] I know he's in the CC:, but I'm not sure he's reading this thread, and I'm hesitant to bother people about things out

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-21 Thread Andrew Buehler
On 2/20/2008 2:29 PM, Alan Stern wrote: On Wed, 20 Feb 2008, Andrew Buehler wrote: In other words: I don't think that's likely to be practical in the present instance. If you have reason to believe otherwise (past positive experience with Novell, for instance), I'd be glad to

Re: [Bugme-new] [Bug 10057] New: gdth: unable to handle kernel NULL pointer dereference at virtual address 0000000c

2008-02-21 Thread Andrew Morton
On Thu, 21 Feb 2008 00:44:45 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10057 > >Summary: gdth: unable to handle kernel NULL pointer dereference > at virtual address 000c >Product: Drivers >Version

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-20 Thread Andrew Buehler
On 2/20/2008 12:15 PM, Alan Stern wrote: On Wed, 20 Feb 2008, Andrew Buehler wrote: Hmm. One thing which just sprang to mind, in the stab-in-the-dark category: in 2.6.24.2, launching the program on some machines gave warnings along the lines of "this program is using a deprecated

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-20 Thread Andrew Buehler
On Tue, 19 Feb 2008, Andrew Buehler wrote: With those two problems out of the way, what is left is the hard-drive issue, and that is also halfway fixed by enabling ACPI. Specifically, it is "fixed" in that the kernel sees the hard drive and I can mount it, but it is not fixed in that

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > > On Tue, 19 Feb 2008, James Bottomley wrote: > > > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > > This patch removes dead

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > This patch removes dead code spotted by the Coverity checker. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +--

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-19 Thread Andrew Buehler
On 2/16/2008 10:35 PM, Alan Stern wrote: On Sat, 16 Feb 2008, Andrew Buehler wrote: Until this thread, I was not even aware that ACPI was related to USB; I had largely conflated it with a similar acronym which I think is related to power management and which I can suddenly not even find in

Re: [PATCH 1/1] cciss: procfs updates to display info about many volumes

2008-02-19 Thread Andrew Morton
On Tue, 19 Feb 2008 11:48:18 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11 2008, Mike Miller wrote: > > Patch 1 of 1 > > > > This patch allows us to display information about all of the logical volumes > > configured on a particular without stepping on memory even when there are >

Re: gdth new set of patches for 2.6.24 stable

2008-02-18 Thread Andrew Morton
On Sun, 17 Feb 2008 18:46:03 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > ... > > All my testers have reported back that with these 5 patches applied they can > now run with a 2.6.24 kernel the same way they ran before. However there is > that reported issue, with the dma_free_coherent WARN_

Re: [PATCH] qla2xxx: fix compilation compile

2008-02-17 Thread Andrew Vasquez
gned-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Acked-by: Andrew Vasquez <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Andrew Buehler
On 2/16/2008 10:35 PM, Alan Stern wrote: On Sat, 16 Feb 2008, Andrew Buehler wrote: Messages sent to my address directly are explicitly not filtered into the folders I have set up for various mailing lists, so that if someone does send me a "heads up" reply for a specific topic on

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Andrew Buehler
On 2/17/2008 2:20 AM, Paul Jackson wrote: Andrew wrote: (Since there are multiple Andrews on just the LKML, and at least two - one of whom is much more prominent than I am - in the direct address list for this discussion, I'm not sure whether or not this is a sufficient attribution.

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-16 Thread Andrew Buehler
On 2/16/2008 6:11 PM, Alan Stern wrote: On Sat, 16 Feb 2008, Andrew Buehler wrote: For another, getting two copies of a message is no big deal -- I disagree. Everyone has his own taste. Obviously there's no world-wide consensus, possibly because different people have different wor

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-16 Thread Andrew Buehler
to avoid it and still make sure all relevant people receive the message.) On 2/16/2008 10:20 AM, Alan Stern wrote: On Sat, 16 Feb 2008, Oliver Pinter wrote: On 2/15/08, Andrew Buehler <[EMAIL PROTECTED]> wrote: In my workplace, I use a customized version of Novell's ZENworks imag

  1   2   3   4   5   6   7   8   >