[PATCH] aic94xx: don't return zero on failure paths in aic94xx_init()

2018-05-18 Thread Alexey Khoroshilov
-by: Alexey Khoroshilov --- drivers/scsi/aic94xx/aic94xx_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 6c838865ac5a..4a4746cc6745 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b

[PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case

2017-04-23 Thread Alexey Khoroshilov
(). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/mvumi.c | 85 1 file changed, 26 insertions(+), 59 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 247df5e79b71..fe97401ad192 100644 --- a/drivers/scsi/mvumi.c +++ b

[PATCH] scsi: mvumi: add check for dma mapping errors

2017-04-21 Thread Alexey Khoroshilov
Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/mvumi.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 247df5e79b71..49f8b20f5d91 100644 --- a/drivers/scsi/mvumi.c +++ b

[PATCH] wd719x: add check for dma mapping errors

2017-01-27 Thread Alexey Khoroshilov
wd719x_queuecommand() doesn't check if mapping dma memory succeed. The patch adds the check and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/wd719x.c | 6 ++ 1 file changed, 6 insertions(+) diff --

[PATCH] megaraid: fix error code check of register_chrdev()

2016-05-13 Thread Alexey Khoroshilov
Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/megaraid.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 9d05302a3bcd..ded082942ca0 100644 --- a/drivers

[PATCH] mptsas: fix checks for dma mapping errors

2016-04-15 Thread Alexey Khoroshilov
mptsas_smp_handler() checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/message/fusion/mptsas.c | 4 ++-- 1 file

[PATCH v3] mptlan: add checks for dma mapping errors

2016-01-25 Thread Alexey Khoroshilov
mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. v3: Fix resource deallocation (reported by Tomas Henzl). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey

Re: [PATCH v2] mptlan: add checks for dma mapping errors

2016-01-25 Thread Alexey Khoroshilov
On 25.01.2016 16:36, Tomas Henzl wrote: > On 23.1.2016 01:41, Alexey Khoroshilov wrote: >> mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check >> if mapping dma memory succeed. >> The patch adds the checks and failure handling. >> >> Found by

[PATCH v2] mptlan: add checks for dma mapping errors

2016-01-22 Thread Alexey Khoroshilov
mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/message/fusion/mptlan.c | 14

[PATCH] mptlan: add checks for dma mapping errors

2016-01-22 Thread Alexey Khoroshilov
mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/message/fusion/mptlan.c | 14

[PATCH] bfa: fix leak of bfad_im_port_index on module unload

2015-06-11 Thread Alexey Khoroshilov
Resources allocated within bfad_im_port_index idr are not deallocated on module unload. The patch adds idr_destroy() in exit function. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/bfa/bfad_im.c | 2 ++ 1 file changed, 2

[PATCH v2] [SCSI] bfa: allocate memory with GFP_ATOMIC in spinlock context

2014-04-18 Thread Alexey Khoroshilov
(linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/bfa/bfad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index cc0fbcdc5192..7593b7c1d336 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -507,7

Re: [PATCH] [SCSI] bfa: allocate memory with GFP_ATOMIC in spinlock context

2014-04-18 Thread Alexey Khoroshilov
Please ignore this patch, it will resend a correct version of it. On 18.04.2014 00:25, Alexey Khoroshilov wrote: > bfa_fcb_pbc_vport_create() is called only from bfa_fcs_pbc_vport_init(), > that is called only from bfad_drv_start() with bfad_lock spinlock held. > So the patch replaces G

[PATCH] [SCSI] bfa: allocate memory with GFP_ATOMIC in spinlock context

2014-04-18 Thread Alexey Khoroshilov
(linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/bfa/bfad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index cc0fbcdc5192..8f46d1b72fb8 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -652,7

[PATCH] [SCSI] scsi_dh_hp_sw: return -ENOMEM if kzalloc() failed

2013-02-22 Thread Alexey Khoroshilov
If kzalloc() failed, hp_sw_bus_attach() breaks off initialization, but returns zero. The patch adds -ENOMEM as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/scsi/device_handler/scsi_dh_hp_sw.c |2

[PATCH v2] [SCSI] mpt2sas: fix double mutex lock in NON_BLOCKING state

2012-08-28 Thread Alexey Khoroshilov
: Alexey Khoroshilov --- drivers/scsi/mpt2sas/mpt2sas_ctl.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_ctl.c b/drivers/scsi/mpt2sas/mpt2sas_ctl.c index 49bdd2d..d29ea56 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_ctl.c +++ b/drivers

[RESEND PATCH] [SCSI] mpt2sas: fix double mutex lock in NON_BLOCKING state

2012-08-24 Thread Alexey Khoroshilov
If state is NON_BLOCKING and mutex_trylock is succeed, the control flow goes to mutex_lock_interruptible() that is a deadlock. Found by Linux Driver Verification project (linuxtesting.org). Acked-by: "Nandigama, Nagalakshmi" Signed-off-by: Alexey Khoroshilov --- drivers/sc